)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add vmtp ansible role to kolla."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Larry Rensing \u003clr699s@att.com\u003e"},{"line_number":12,"context_line":"Co-Authored-By: Tin Lam \u003ctinlam@gmail.com\u003e"},{"line_number":13,"context_line":"Partially implements: bp vmtp-container"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib3945e0a94cca9f3a8c4f55953b40674c88ac8e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_b02294a1","line":12,"updated":"2016-09-12 20:58:08.000000000","message":"Tin, you are already listed as author.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7339037c72ea30d215403a515a47e54c519b896b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Larry Rensing \u003clr699s@att.com\u003e"},{"line_number":12,"context_line":"Co-Authored-By: Tin Lam \u003ctinlam@gmail.com\u003e"},{"line_number":13,"context_line":"Partially implements: bp vmtp-container"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib3945e0a94cca9f3a8c4f55953b40674c88ac8e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_d0fab8bc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2016-09-12 20:59:39.000000000","message":"This should be implements. And it looks like the wrong blueprint? Is there no vmtp-ansible?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c1dd4cd7cbcb83b9124debba789b79fc9b7bd3cc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Larry Rensing \u003clr699s@att.com\u003e"},{"line_number":12,"context_line":"Co-Authored-By: Tin Lam \u003ctinlam@gmail.com\u003e"},{"line_number":13,"context_line":"Partially implements: bp vmtp-container"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib3945e0a94cca9f3a8c4f55953b40674c88ac8e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a89bdaa_5096a8f0","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"9a89bdaa_d0fab8bc","updated":"2016-09-12 21:10:17.000000000","message":"The container portion was merged in: https://review.openstack.org/#/c/354362/ - this patchset for the ansible role part is just another work item for this bp.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"}],"ansible/roles/vmtp/defaults/main.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"283970265cbab7574e16b3a6077f165af990145d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Database (mongodb)"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":"vmtp_database_port: 27017"},{"line_number":8,"context_line":"vmtp_database_name: \"client_db\""},{"line_number":9,"context_line":"vmtp_database_collection: \"pns_web_entry\""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_f44b9957","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":18},"updated":"2016-08-26 13:09:17.000000000","message":"none of the other roles have a service specific database port","commit_id":"92f4dbe71a2cf08482dfbcdaef534017297d3ef0"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"058911a311b208992ef6ed3742e6f5874879a5d2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Database (mongodb)"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":"vmtp_database_port: 27017"},{"line_number":8,"context_line":"vmtp_database_name: \"client_db\""},{"line_number":9,"context_line":"vmtp_database_collection: \"pns_web_entry\""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_698fa423","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":18},"in_reply_to":"fa7ab95a_2f376ab1","updated":"2016-08-26 15:43:52.000000000","message":"Nice catch.  I will change this in the next patch set to use the group_vars one.  Thanks.","commit_id":"92f4dbe71a2cf08482dfbcdaef534017297d3ef0"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"3828f9d4b831c00e630f66a87598647e596dffe1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Database (mongodb)"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":"vmtp_database_port: 27017"},{"line_number":8,"context_line":"vmtp_database_name: \"client_db\""},{"line_number":9,"context_line":"vmtp_database_collection: \"pns_web_entry\""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_2f376ab1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":18},"in_reply_to":"fa7ab95a_f44b9957","updated":"2016-08-26 13:20:23.000000000","message":"That\u0027s a good point Paul.  The ports are exposed in all.yml.\n\nhttps://github.com/openstack/kolla/blob/master/ansible/group_vars/all.yml#L117","commit_id":"92f4dbe71a2cf08482dfbcdaef534017297d3ef0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"vmtp_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-vmtp\""},{"line_number":14,"context_line":"vmtp_tag: \"{{ openstack_release }}\""},{"line_number":15,"context_line":"vmtp_image_full: \"{{ vmtp_image }}:{{ vmtp_tag }}\""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_6327b812","line":16,"updated":"2016-08-26 18:34:02.000000000","message":"Please, remove empty line","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b5419326e90d6c98f8fcfe52e105c848587cc561","unresolved":false,"context_lines":[{"line_number":13,"context_line":"vmtp_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-vmtp\""},{"line_number":14,"context_line":"vmtp_tag: \"{{ openstack_release }}\""},{"line_number":15,"context_line":"vmtp_image_full: \"{{ vmtp_image }}:{{ vmtp_tag }}\""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_c42167fd","line":16,"in_reply_to":"fa7ab95a_6327b812","updated":"2016-08-26 20:38:35.000000000","message":"Done","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#########################"},{"line_number":12,"context_line":"# VMTP Specific resources"},{"line_number":13,"context_line":"#########################"},{"line_number":14,"context_line":"vmtp_vm_image_name: \"Ubuntu Server 14.04\""},{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_10498060","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":40},"updated":"2016-09-12 20:58:08.000000000","message":"Can we use 16.04 here? This is the latest available release of Ubuntu.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#########################"},{"line_number":12,"context_line":"# VMTP Specific resources"},{"line_number":13,"context_line":"#########################"},{"line_number":14,"context_line":"vmtp_vm_image_name: \"Ubuntu Server 14.04\""},{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_50bdc866","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":40},"in_reply_to":"9a89bdaa_10498060","updated":"2016-09-12 21:28:51.000000000","message":"Will fix in the next patch set.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":14,"context_line":"vmtp_vm_image_name: \"Ubuntu Server 14.04\""},{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_103260f2","line":17,"updated":"2016-09-12 20:58:08.000000000","message":"Does it makes sense to use at lease 2 name servers?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":14,"context_line":"vmtp_vm_image_name: \"Ubuntu Server 14.04\""},{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_1056e029","line":17,"in_reply_to":"9a89bdaa_103260f2","updated":"2016-09-12 21:28:51.000000000","message":"I can add another one - is there one aside from 8.8.8.8 that\u0027s preferred?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e4b1a650142e0084d9e3b04d9970b1dfda82262d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"vmtp_vm_image_name: \"Ubuntu Server 14.04\""},{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_3be02596","line":17,"in_reply_to":"9a89bdaa_1056e029","updated":"2016-09-12 21:37:00.000000000","message":"8.8.4.4, this is the other one provided by Google.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_b070d4a5","line":18,"updated":"2016-09-12 20:58:08.000000000","message":"Why not using the ubuntu cloud archive url here?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e4b1a650142e0084d9e3b04d9970b1dfda82262d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_1bfa8143","line":18,"in_reply_to":"9a89bdaa_b014544d","updated":"2016-09-12 21:37:00.000000000","message":"I do not know the behaviour of VMTP. I think it will download this image when it is not yet available.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vmtp_vm_ssh_username: \"ubuntu\""},{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_b014544d","line":18,"in_reply_to":"9a89bdaa_b070d4a5","updated":"2016-09-12 21:28:51.000000000","message":"I can change that - but it was the default value provided by VMTP.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_7053ac17","line":19,"range":{"start_line":19,"start_character":30,"end_line":19,"end_character":38},"updated":"2016-09-12 20:58:08.000000000","message":"I would prefer \"vmtp...\" here.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_7b2c6d99","line":19,"range":{"start_line":19,"start_character":30,"end_line":19,"end_character":38},"in_reply_to":"9a89bdaa_7053ac17","updated":"2016-09-12 21:28:51.000000000","message":"These values were picked because the net and subnet were created using those names: https://github.com/openstack/kolla/blob/master/tools/init-runonce#L56-L57","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e4b1a650142e0084d9e3b04d9970b1dfda82262d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"vmtp_vm_flavor_type: \"m1.small\""},{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_db8ad9be","line":19,"range":{"start_line":19,"start_character":30,"end_line":19,"end_character":38},"in_reply_to":"9a89bdaa_7b2c6d99","updated":"2016-09-12 21:37:00.000000000","message":"When setting internal_cidr address I think vmtp will create the network if it does not exist. Have you checked this?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"},{"line_number":23,"context_line":"vmtp_internal_cidr_v6: [\u00272001:45::/64\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_b059b437","line":20,"range":{"start_line":20,"start_character":29,"end_line":20,"end_character":40},"updated":"2016-09-12 20:58:08.000000000","message":"dito","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":17,"context_line":"vmtp_vm_nameservers: [\u00278.8.8.8\u0027]"},{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"},{"line_number":23,"context_line":"vmtp_internal_cidr_v6: [\u00272001:45::/64\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_db3bb9cf","line":20,"range":{"start_line":20,"start_character":29,"end_line":20,"end_character":40},"in_reply_to":"9a89bdaa_b059b437","updated":"2016-09-12 21:28:51.000000000","message":"see above","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"},{"line_number":23,"context_line":"vmtp_internal_cidr_v6: [\u00272001:45::/64\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_d042b83d","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":48},"updated":"2016-09-12 20:58:08.000000000","message":"dito","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":18,"context_line":"vmtp_vm_image_url: \"\""},{"line_number":19,"context_line":"vmtp_internal_network_name: [\u0027demo-net\u0027]"},{"line_number":20,"context_line":"vmtp_internal_subnet_name: [\u0027demo-subnet\u0027]"},{"line_number":21,"context_line":"vmtp_internal_subnet_name_ipv6: [\u0027demo-v6-subnet\u0027]"},{"line_number":22,"context_line":"vmtp_internal_cidr: [\u002710.0.0.0/24\u0027]"},{"line_number":23,"context_line":"vmtp_internal_cidr_v6: [\u00272001:45::/64\u0027]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_1b3281f2","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":48},"in_reply_to":"9a89bdaa_d042b83d","updated":"2016-09-12 21:28:51.000000000","message":"There\u0027s no v6-subnet created, but named so according to the previous format.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"}],"ansible/roles/vmtp/tasks/config.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: Copying over configuration file for vmtp"},{"line_number":9,"context_line":"  template:"},{"line_number":10,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":11,"context_line":"    dest: \" {{ node_config_directory }}/vmtp/{{ item }}\""},{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - \"cfg.default.yaml\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_8ee30305","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":55},"updated":"2016-08-26 18:34:02.000000000","message":"This item isn\u0027t vmtp.cfg?\nhttp://vmtp.readthedocs.io/en/latest/quickstart_git.html#create-your-vmtp-config-file","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b5419326e90d6c98f8fcfe52e105c848587cc561","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: Copying over configuration file for vmtp"},{"line_number":9,"context_line":"  template:"},{"line_number":10,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":11,"context_line":"    dest: \" {{ node_config_directory }}/vmtp/{{ item }}\""},{"line_number":12,"context_line":"  with_items:"},{"line_number":13,"context_line":"    - \"cfg.default.yaml\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_f7d0df55","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":55},"in_reply_to":"fa7ab95a_8ee30305","updated":"2016-08-26 20:38:35.000000000","message":"VMTP by default places a cfg.default.yaml into the system, and it appears that file should not be modified:  https://github.com/openstack/vmtp/blob/master/vmtp/cfg.default.yaml#L4-L7\n\nUsers who wish to execute a different configurations (however it is named) can specify that using the \"-c\" or \"--config\" option.","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"ac99f2de2c25cfb17f1ef6726cc61ebd50b92c93","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Copying over configuration file for vmtp"},{"line_number":9,"context_line":"  template:"},{"line_number":10,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":11,"context_line":"    dest: \" {{ node_config_directory }}/vmtp/{{ item }}\""},{"line_number":12,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a89bdaa_e0fe6004","line":9,"updated":"2016-09-09 20:59:35.000000000","message":"did you try if merge_ini will work here? Without configuration override we\u0027ll have problem overriding this one, especially for CIRDs. https://github.com/openstack/kolla/blob/master/ansible/roles/horizon/tasks/config.yml#L30 this is another option for it, worse but better than nothing","commit_id":"62fbe777d788866c2d1b6e3583d9b08c19307253"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  merge_yaml:"},{"line_number":20,"context_line":"    sources:"},{"line_number":21,"context_line":"      - \"{{ role_path }}/templates/{{ item }}.yaml.j2\""},{"line_number":22,"context_line":"      - \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":23,"context_line":"    dest: \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - \"cfg.default\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_d0c5588e","line":22,"updated":"2016-09-12 20:58:08.000000000","message":"Overlay configuration files are missing here.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  merge_yaml:"},{"line_number":20,"context_line":"    sources:"},{"line_number":21,"context_line":"      - \"{{ role_path }}/templates/{{ item }}.yaml.j2\""},{"line_number":22,"context_line":"      - \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":23,"context_line":"    dest: \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - \"cfg.default\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_7b954d31","line":22,"in_reply_to":"9a89bdaa_d0c5588e","updated":"2016-09-12 21:28:51.000000000","message":"Will look into this in the next patchset.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    sources:"},{"line_number":21,"context_line":"      - \"{{ role_path }}/templates/{{ item }}.yaml.j2\""},{"line_number":22,"context_line":"      - \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":23,"context_line":"    dest: \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - \"cfg.default\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_90c75097","line":23,"updated":"2016-09-12 20:58:08.000000000","message":"Is it not possible to place the configuration files in /etc/...? This looks wrong to me.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    sources:"},{"line_number":21,"context_line":"      - \"{{ role_path }}/templates/{{ item }}.yaml.j2\""},{"line_number":22,"context_line":"      - \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":23,"context_line":"    dest: \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - \"cfg.default\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_1b744134","line":23,"in_reply_to":"9a89bdaa_90c75097","updated":"2016-09-12 21:28:51.000000000","message":"If a user runs `pip install vmtp`, it automatically places a default cfg file in the python site-packages/vmtp folder, that can be override by the -c option.  If we target the file under /etc/ there will be 2 different configuration files, one of which won\u0027t take effect.  I am not sure if there is a better way to deal with this.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      - \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":23,"context_line":"    dest: \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - \"cfg.default\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_105340e3","line":25,"updated":"2016-09-12 20:58:08.000000000","message":"you could add yaml here to avoid the duplications in line 21...23","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      - \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":23,"context_line":"    dest: \"{{ python_path }}/vmtp/{{ item }}.yaml\""},{"line_number":24,"context_line":"  with_items:"},{"line_number":25,"context_line":"    - \"cfg.default\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_7b7aad89","line":25,"in_reply_to":"9a89bdaa_105340e3","updated":"2016-09-12 21:28:51.000000000","message":"Will fix in the next patchset.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"}],"ansible/roles/vmtp/tasks/deploy.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"a74bda43ce9808a413e71e52f7a1cdf8633ed34a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_c32312a6","line":3,"updated":"2016-08-25 16:05:47.000000000","message":"This should only run on vmtp hosts.  Can you also add a new line between the includes.\n\nwhen: inventory_hostname in groups[\u0027vmtp\u0027]","commit_id":"4629d710ef00c077088214a7c88de31d8e278a77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e43cfe5da0b7f65174a561a7cdf480f50296050a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_3c4b512d","line":3,"in_reply_to":"1ac06dbe_c32312a6","updated":"2016-08-25 21:51:02.000000000","message":"Done.  Also, added this to a few other places.","commit_id":"4629d710ef00c077088214a7c88de31d8e278a77"}],"ansible/roles/vmtp/tasks/do_reconfigure.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- include: config.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Check configuration"},{"line_number":13,"context_line":"  command: docker exec {{}} /usr/local/bin/kolla_set_configs --check"},{"line_number":14,"context_line":"  changed_when: false"},{"line_number":15,"context_line":"  failed_when: false"},{"line_number":16,"context_line":"  register: check_results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_03c0acdf","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":27},"updated":"2016-08-26 18:34:02.000000000","message":"Missing vmtp or item.name, along with_items in the task","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b5419326e90d6c98f8fcfe52e105c848587cc561","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- include: config.yml"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Check configuration"},{"line_number":13,"context_line":"  command: docker exec {{}} /usr/local/bin/kolla_set_configs --check"},{"line_number":14,"context_line":"  changed_when: false"},{"line_number":15,"context_line":"  failed_when: false"},{"line_number":16,"context_line":"  register: check_results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_c4e6c7b3","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":27},"in_reply_to":"fa7ab95a_03c0acdf","updated":"2016-08-26 20:38:35.000000000","message":"Done","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    - item[1][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":37,"context_line":"    - inventory_hostname in groups[\u0027vmtp\u0027]"},{"line_number":38,"context_line":"  with_together:"},{"line_number":39,"context_line":"    - container_envs.results"},{"line_number":40,"context_line":"    - check_results.results"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- include: start.yml"},{"line_number":43,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_e3ee688a","line":40,"range":{"start_line":39,"start_character":6,"end_line":40,"end_character":27},"updated":"2016-08-26 18:34:02.000000000","message":"Please use ansible2 syntax \"{{ container_envs.results }}\"","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b5419326e90d6c98f8fcfe52e105c848587cc561","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    - item[1][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":37,"context_line":"    - inventory_hostname in groups[\u0027vmtp\u0027]"},{"line_number":38,"context_line":"  with_together:"},{"line_number":39,"context_line":"    - container_envs.results"},{"line_number":40,"context_line":"    - check_results.results"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- include: start.yml"},{"line_number":43,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_2464d347","line":40,"range":{"start_line":39,"start_character":6,"end_line":40,"end_character":27},"in_reply_to":"fa7ab95a_e3ee688a","updated":"2016-08-26 20:38:35.000000000","message":"Done","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    - item[1][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":53,"context_line":"    - inventory_hostname in groups[\u0027vmtp\u0027]"},{"line_number":54,"context_line":"  with_together:"},{"line_number":55,"context_line":"    - container_envs.results"},{"line_number":56,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_2313f067","line":56,"range":{"start_line":55,"start_character":1,"end_line":56,"end_character":27},"updated":"2016-08-26 18:34:02.000000000","message":"Ditto","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b5419326e90d6c98f8fcfe52e105c848587cc561","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    - item[1][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":53,"context_line":"    - inventory_hostname in groups[\u0027vmtp\u0027]"},{"line_number":54,"context_line":"  with_together:"},{"line_number":55,"context_line":"    - container_envs.results"},{"line_number":56,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_645edb77","line":56,"range":{"start_line":55,"start_character":1,"end_line":56,"end_character":27},"in_reply_to":"fa7ab95a_2313f067","updated":"2016-08-26 20:38:35.000000000","message":"Done","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"}],"ansible/roles/vmtp/tasks/pull.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    image: \"{{ vmtp_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_ee9bafc7","line":6,"updated":"2016-08-26 18:34:02.000000000","message":"Is common add a when: inventory_hostname in groups[\u0027vmtp\u0027] here","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b5419326e90d6c98f8fcfe52e105c848587cc561","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    image: \"{{ vmtp_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_e473cb13","line":6,"in_reply_to":"fa7ab95a_ee9bafc7","updated":"2016-08-26 20:38:35.000000000","message":"Done","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"}],"ansible/roles/vmtp/tasks/reconfigure.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"73211652f1025f778f8df42d78a6625b32792b9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: do_reconfigure.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027mongodb\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_77aa521b","line":3,"updated":"2016-08-25 22:49:51.000000000","message":"leave serial: \"30%\" in there.   Also I think you want the reconfigure to occur on vmtp hosts not mongodb hosts.","commit_id":"e0d519ce448534e82554084a4557ce2f025791c0"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"87b3f83bdb4ea06620d374a4cd053a76eb60ce7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: do_reconfigure.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027mongodb\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_135af383","line":3,"in_reply_to":"fa7ab95a_77aa521b","updated":"2016-08-26 03:22:17.000000000","message":"Done.","commit_id":"e0d519ce448534e82554084a4557ce2f025791c0"}],"ansible/roles/vmtp/templates/cfg.default.yaml.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"a74bda43ce9808a413e71e52f7a1cdf8633ed34a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"flavor_type: {{ vmtp_vm_flavor_type }}"},{"line_number":4,"context_line":"availability_zone: {{ vmtp_vm_availability_zone }}"},{"line_number":5,"context_line":"dns_nameservers: {{ vmtp_vm_nameservers }}"},{"line_number":6,"context_line":"vm_image_url: {{ vmtp_vm_image_url }}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# -----------------------------------------------------------------------------"},{"line_number":9,"context_line":"# These variables are not likely to be changed"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_be126907","line":6,"updated":"2016-08-25 16:05:47.000000000","message":"How much does the user care about these values?  Seems like it doesn\u0027t matter, but I wanted to make sure.","commit_id":"4629d710ef00c077088214a7c88de31d8e278a77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e43cfe5da0b7f65174a561a7cdf480f50296050a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"flavor_type: {{ vmtp_vm_flavor_type }}"},{"line_number":4,"context_line":"availability_zone: {{ vmtp_vm_availability_zone }}"},{"line_number":5,"context_line":"dns_nameservers: {{ vmtp_vm_nameservers }}"},{"line_number":6,"context_line":"vm_image_url: {{ vmtp_vm_image_url }}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# -----------------------------------------------------------------------------"},{"line_number":9,"context_line":"# These variables are not likely to be changed"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_bcd20133","line":6,"in_reply_to":"1ac06dbe_be126907","updated":"2016-08-25 21:51:02.000000000","message":"The user can always pass in their configuration file through --config or -c.  For now, I will put in the default values from VMTP.  We may be able to remove this template all together.","commit_id":"4629d710ef00c077088214a7c88de31d8e278a77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e43cfe5da0b7f65174a561a7cdf480f50296050a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"dns_nameservers: {{ vmtp_vm_nameservers }}"},{"line_number":6,"context_line":"vm_image_url: {{ vmtp_vm_image_url }}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# -----------------------------------------------------------------------------"},{"line_number":9,"context_line":"# These variables are not likely to be changed"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"reuse_network_name:"},{"line_number":12,"context_line":"floating_ip: True"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_bc8e8125","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":46},"updated":"2016-08-25 21:51:02.000000000","message":"Will be removing these comments as well.","commit_id":"4629d710ef00c077088214a7c88de31d8e278a77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e43cfe5da0b7f65174a561a7cdf480f50296050a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"vm_bandwidth: 0"},{"line_number":44,"context_line":"os_dataplane_network: \u0027physnet1\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# -----------------------------------------------------------------------------"},{"line_number":47,"context_line":"# MongoDB variables"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"vmtp_mongod_port: {{ vmtp_database_port }}"},{"line_number":50,"context_line":"vmtp_db: {{ vmtp_database_name }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_1c9e8d56","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":19},"updated":"2016-08-25 21:51:02.000000000","message":"Ditto. See above.","commit_id":"4629d710ef00c077088214a7c88de31d8e278a77"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"73211652f1025f778f8df42d78a6625b32792b9c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"vmtp_mongod_port: {{ vmtp_database_port }}"},{"line_number":44,"context_line":"vmtp_db: {{ vmtp_database_name }}"},{"line_number":45,"context_line":"vmtp_collection: {{ vmtp_database_collection }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_0c573803","line":43,"updated":"2016-08-25 22:49:51.000000000","message":"Do you want to use mongodb as a default? If so it needs to be enabled when vmtp is enabled","commit_id":"e0d519ce448534e82554084a4557ce2f025791c0"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"87b3f83bdb4ea06620d374a4cd053a76eb60ce7b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"vmtp_mongod_port: {{ vmtp_database_port }}"},{"line_number":44,"context_line":"vmtp_db: {{ vmtp_database_name }}"},{"line_number":45,"context_line":"vmtp_collection: {{ vmtp_database_collection }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_4e72107e","line":43,"in_reply_to":"fa7ab95a_0c573803","updated":"2016-08-26 03:22:17.000000000","message":"Done","commit_id":"e0d519ce448534e82554084a4557ce2f025791c0"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"283970265cbab7574e16b3a6077f165af990145d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{% if enable_mongodb | bool %}"},{"line_number":44,"context_line":"vmtp_mongod_port: {{ vmtp_database_port }}"},{"line_number":45,"context_line":"vmtp_db: {{ vmtp_database_name }}"},{"line_number":46,"context_line":"vmtp_collection: {{ vmtp_database_collection }}"},{"line_number":47,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa7ab95a_5431a5a1","line":44,"range":{"start_line":44,"start_character":21,"end_line":44,"end_character":39},"updated":"2016-08-26 13:09:17.000000000","message":"mongodb_port","commit_id":"92f4dbe71a2cf08482dfbcdaef534017297d3ef0"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"84a7d4ec162a5aff03e5968b17b2e0a6e0c8badb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"image_name: \u0027Ubuntu Server 14.04\u0027"},{"line_number":2,"context_line":"ssh_vm_username: \u0027ubuntu\u0027"},{"line_number":3,"context_line":"flavor_type: \u0027m1.small\u0027"},{"line_number":4,"context_line":"availability_zone:"},{"line_number":5,"context_line":"dns_nameservers: [ \u00278.8.8.8\u0027 ]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa7ab95a_8e47831c","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":25},"updated":"2016-08-26 18:34:02.000000000","message":"Is there any other options?","commit_id":"3305bf071a58d374b01dd4670a58ebe53e3b2344"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"9d04861e880ccdcade53c23e118855a248151010","unresolved":false,"context_lines":[{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{% if enable_mongodb | bool %}"},{"line_number":44,"context_line":"vmtp_mongod_port: {{ mongodb_port }}"},{"line_number":45,"context_line":"vmtp_db: {{ vmtp_database_name }}"},{"line_number":46,"context_line":"vmtp_collection: {{ vmtp_database_collection }}"},{"line_number":47,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"fa7ab95a_94ed78b9","line":47,"range":{"start_line":43,"start_character":0,"end_line":47,"end_character":11},"updated":"2016-08-29 18:06:47.000000000","message":"If enable_mongodb option is added I understand that the user wants to use mongo deployed with kolla, maybe is interesting bootstrap the database on it. Also, I can\u0027t find any info about which user vmtp uses to store data in mongo or any cmd option to specify.","commit_id":"4a9313bc74f3c947c6e7516cbafc6b8af00d205f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3a4d75ef2cccfe09a41e0937e2f2051312f75f61","unresolved":false,"context_lines":[{"line_number":44,"context_line":"vmtp_mongod_port: {{ mongodb_port }}"},{"line_number":45,"context_line":"vmtp_db: {{ vmtp_database_name }}"},{"line_number":46,"context_line":"vmtp_collection: {{ vmtp_database_collection }}"},{"line_number":47,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a89bdaa_0d6a34b3","line":47,"updated":"2016-09-07 14:04:30.000000000","message":"agreed","commit_id":"4a9313bc74f3c947c6e7516cbafc6b8af00d205f"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"ac0dad2182c670b697cea738edcdd9138bbc09b0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"vmtp_mongod_port: {{ mongodb_port }}"},{"line_number":45,"context_line":"vmtp_db: {{ vmtp_database_name }}"},{"line_number":46,"context_line":"vmtp_collection: {{ vmtp_database_collection }}"},{"line_number":47,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a89bdaa_bdbf1fa9","line":47,"in_reply_to":"9a89bdaa_0d6a34b3","updated":"2016-09-09 20:46:53.000000000","message":"the decision was made to remove mongodb, because vmtp uses mongodb with no credentials (security issues).   it will still be usable, but it will not be able to store results until vmtp fixes their implementation","commit_id":"4a9313bc74f3c947c6e7516cbafc6b8af00d205f"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"ac99f2de2c25cfb17f1ef6726cc61ebd50b92c93","unresolved":false,"context_lines":[{"line_number":16,"context_line":"internal_network_name: [\u0027pns-internal-net\u0027, \u0027pns-internal-net2\u0027]"},{"line_number":17,"context_line":"internal_subnet_name: [\u0027pns-internal-subnet\u0027, \u0027pns-internal-subnet2\u0027]"},{"line_number":18,"context_line":"internal_subnet_name_ipv6: [\u0027pns-internal-v6-subnet\u0027,\u0027pns-internal-v6-subnet2\u0027]"},{"line_number":19,"context_line":"internal_cidr: [\u0027192.168.1.0/24\u0027 , \u0027192.168.2.0/24\u0027]"},{"line_number":20,"context_line":"internal_cidr_v6: [\u00272001:45::/64\u0027,\u00272001:46::/64\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"public_key_file:"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9a89bdaa_400c6c3b","line":19,"updated":"2016-09-09 20:59:35.000000000","message":"use cidrs as in https://github.com/openstack/kolla/blob/master/tools/init-runonce#L57 please.","commit_id":"62fbe777d788866c2d1b6e3583d9b08c19307253"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":11,"context_line":"config_drive:"},{"line_number":12,"context_line":"user_data_file:"},{"line_number":13,"context_line":"ipv6_mode:"},{"line_number":14,"context_line":"router_name: \u0027pns-router\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"internal_network_name: {{ vmtp_internal_network_name }}"},{"line_number":17,"context_line":"internal_subnet_name: {{ vmtp_internal_subnet_name }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_f0adfce9","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":14},"updated":"2016-09-12 20:58:08.000000000","message":"Are the \u0027 necessary?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":11,"context_line":"config_drive:"},{"line_number":12,"context_line":"user_data_file:"},{"line_number":13,"context_line":"ipv6_mode:"},{"line_number":14,"context_line":"router_name: \u0027pns-router\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"internal_network_name: {{ vmtp_internal_network_name }}"},{"line_number":17,"context_line":"internal_subnet_name: {{ vmtp_internal_subnet_name }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_fbe5dd08","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":14},"in_reply_to":"9a89bdaa_f0adfce9","updated":"2016-09-12 21:28:51.000000000","message":"I will make this configuration as well next patchset.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":32,"context_line":"generic_retry_count: 50"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tcp_tp_loop_count: 3"},{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_30b4c433","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":16},"updated":"2016-09-12 20:58:08.000000000","message":"I would prefer to use\n\ntcp...:\n  - 65536","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":32,"context_line":"generic_retry_count: 50"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tcp_tp_loop_count: 3"},{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_bb28b534","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":16},"in_reply_to":"9a89bdaa_30b4c433","updated":"2016-09-12 21:28:51.000000000","message":"Can fix in the next patchset. It is done to be consistent with the default cfg provided by vmtp: https://github.com/openstack/vmtp/blob/master/vmtp/cfg.default.yaml#L148","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tcp_tp_loop_count: 3"},{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_70880c72","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":16},"updated":"2016-09-12 20:58:08.000000000","message":"dito","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tcp_tp_loop_count: 3"},{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_5bd4091f","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":16},"in_reply_to":"9a89bdaa_70880c72","updated":"2016-09-12 21:28:51.000000000","message":"ditto","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":34,"context_line":"tcp_tp_loop_count: 3"},{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"vm_bandwidth: 0"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_b07e1468","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":17},"updated":"2016-09-12 20:58:08.000000000","message":"dito","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":34,"context_line":"tcp_tp_loop_count: 3"},{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"vm_bandwidth: 0"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_7bd9cd56","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":17},"in_reply_to":"9a89bdaa_b07e1468","updated":"2016-09-12 21:28:51.000000000","message":"ditto","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_f0941c8c","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":22},"updated":"2016-09-12 20:58:08.000000000","message":"dito","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":35,"context_line":"tcp_pkt_sizes: [65536]"},{"line_number":36,"context_line":"udp_pkt_sizes: [128, 1024, 8192]"},{"line_number":37,"context_line":"icmp_pkt_sizes: [64, 391, 1500]"},{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_9bda114a","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":22},"in_reply_to":"9a89bdaa_f0941c8c","updated":"2016-09-12 21:28:51.000000000","message":"ditto","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"adb1dbdffa2c349735cecee1f15e189ea2035918","unresolved":false,"context_lines":[{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_50ea2810","line":41,"range":{"start_line":41,"start_character":23,"end_line":41,"end_character":31},"updated":"2016-09-12 20:58:08.000000000","message":"I think this should be configurable?","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"32d62be771ffd377f7983556b8ad192dc2df0e38","unresolved":false,"context_lines":[{"line_number":38,"context_line":"udp_loss_rate_range: [2, 5]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"vm_bandwidth: 0"},{"line_number":41,"context_line":"os_dataplane_network: \u0027physnet1\u0027"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_db4c9944","line":41,"range":{"start_line":41,"start_character":23,"end_line":41,"end_character":31},"in_reply_to":"9a89bdaa_50ea2810","updated":"2016-09-12 21:28:51.000000000","message":"Will fix in the next patch set.","commit_id":"f69f718849f49418bbe1ce207b4ba96bccd9cf9a"}]}