)]}'
{"ansible/roles/prechecks/tasks/user_checks.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"079c6b9eae6b05acd87dec0f4c22faf4da915d54","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# (duonghq) # Cannot add user to docker group in bootstrap task"},{"line_number":7,"context_line":"# because of the check docker\u0027s version task will fail"},{"line_number":8,"context_line":"- fail: msg\u003d\"User is not in docker group\""},{"line_number":9,"context_line":"  when: (\"docker\" not in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":10,"context_line":"      and (\"{{ ansible_user }}\" !\u003d \"root\")"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_fc1e495e","line":8,"updated":"2016-08-31 02:10:16.000000000","message":"how about \"Linux user cannot connect to docker daemon or docker daemon not running.\"","commit_id":"84cb8d1e7f9105abcf344bf74e172bc6e567067b"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"4d7beee5f5d8704f44a3d35f8c2b725ebfbd359c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# (duonghq) # Cannot add user to docker group in bootstrap task"},{"line_number":7,"context_line":"# because of the check docker\u0027s version task will fail"},{"line_number":8,"context_line":"- fail: msg\u003d\"User is not in docker group\""},{"line_number":9,"context_line":"  when: (\"docker\" not in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":10,"context_line":"      and (\"{{ ansible_user }}\" !\u003d \"root\")"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_573d4eba","line":8,"in_reply_to":"fa7ab95a_fc1e495e","updated":"2016-08-31 02:53:29.000000000","message":"This message belongs to docker command, but I check user\u0027s group directly. But it\u0027s not sufficient due to user which is in \u0027root\u0027 group can control docker, too.\n\nI am not sure if only \u0027root\u0027 and \u0027docker\u0027 group can control docker.\n\nThe intent of this patchset is provided more detail over general docker\u0027s message (cannot connect to docker daemon)","commit_id":"84cb8d1e7f9105abcf344bf74e172bc6e567067b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c2dd0fd509e96c9101232462448472977159d06c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# because of the check docker\u0027s version task will fail"},{"line_number":8,"context_line":"- fail: msg\u003d\"User is not in docker group\""},{"line_number":9,"context_line":"  when: (\"docker\" not in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":10,"context_line":"      and (\"{{ ansible_user }}\" !\u003d \"root\")"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_143e22da","line":10,"updated":"2016-08-25 08:24:25.000000000","message":"This is not correct.\n\nHow about a user in root group?\n\nthe correct logical is: the current use can touch the /etc/docker.sock file. \n\ncheck this by using run `docker info` without error.","commit_id":"84cb8d1e7f9105abcf344bf74e172bc6e567067b"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"600a1e6c21371ad87796ae53cf3ac505aa002ade","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# because of the check docker\u0027s version task will fail"},{"line_number":8,"context_line":"- fail: msg\u003d\"User is not in docker group\""},{"line_number":9,"context_line":"  when: (\"docker\" not in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":10,"context_line":"      and (\"{{ ansible_user }}\" !\u003d \"root\")"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_1febdb79","line":10,"in_reply_to":"1ac06dbe_143e22da","updated":"2016-08-25 08:36:22.000000000","message":"As you explain, I think checking if user can read the file is more suitable, due to docker info can fail if user cannot touch this file or docker is not running.","commit_id":"84cb8d1e7f9105abcf344bf74e172bc6e567067b"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"afcd88427d4a0182e9e928f610ead7305a73b682","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# because of the check docker\u0027s version task will fail"},{"line_number":8,"context_line":"- fail: msg\u003d\"User is not in docker group\""},{"line_number":9,"context_line":"  when: (\"docker\" not in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":10,"context_line":"      and (\"{{ ansible_user }}\" !\u003d \"root\")"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_0cb3b80b","line":10,"in_reply_to":"1ac06dbe_143e22da","updated":"2016-08-31 04:20:15.000000000","message":"I just tested. User is in root group cannot connect to docker deamon. Only root or user in docker group can.","commit_id":"84cb8d1e7f9105abcf344bf74e172bc6e567067b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5a296f4a71367685d54f8c24f64e3d5178ac174e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# this test does not cover custom socket but Kolla does not support it too"},{"line_number":14,"context_line":"- fail: msg\u003d\"User is not root or in docker socket owner group\""},{"line_number":15,"context_line":"  when: not ((\"{{ docker_sock.stat.gr_name }}\" in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":16,"context_line":"      or (\"{{ ansible_user_id }}\" \u003d\u003d \"root\"))"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_b2bc3807","line":16,"updated":"2016-09-07 16:59:47.000000000","message":"for example? when the `docker info` fail?","commit_id":"3aa2066afa9b1c09207660f4407db0335d4acb2a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"8f5405d6b21912f00a36f70018a46dce77f2033e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# this test does not cover custom socket but Kolla does not support it too"},{"line_number":14,"context_line":"- fail: msg\u003d\"User is not root or in docker socket owner group\""},{"line_number":15,"context_line":"  when: not ((\"{{ docker_sock.stat.gr_name }}\" in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":16,"context_line":"      or (\"{{ ansible_user_id }}\" \u003d\u003d \"root\"))"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_8e290e3a","line":16,"updated":"2016-09-01 14:40:06.000000000","message":"still do not think this is right direction.\n\nHow about the user already set the docker.sock to 777?\n\nthe right direction i think is: you can run `docker info` without any error. like:\n\n- name: Check the docker.sock access\n  command: docker info","commit_id":"3aa2066afa9b1c09207660f4407db0335d4acb2a"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"a21fe941dff8469abc84782247b2a71f06587473","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# this test does not cover custom socket but Kolla does not support it too"},{"line_number":14,"context_line":"- fail: msg\u003d\"User is not root or in docker socket owner group\""},{"line_number":15,"context_line":"  when: not ((\"{{ docker_sock.stat.gr_name }}\" in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":16,"context_line":"      or (\"{{ ansible_user_id }}\" \u003d\u003d \"root\"))"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_b31fcb59","line":16,"in_reply_to":"9a89bdaa_b2bc3807","updated":"2016-09-08 01:20:03.000000000","message":"docker info can fail for many reason, I want to clarify the reason.","commit_id":"3aa2066afa9b1c09207660f4407db0335d4acb2a"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"2b877dd5640c3e2236ccfda6052c9bc7edc3041c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# this test does not cover custom socket but Kolla does not support it too"},{"line_number":14,"context_line":"- fail: msg\u003d\"User is not root or in docker socket owner group\""},{"line_number":15,"context_line":"  when: not ((\"{{ docker_sock.stat.gr_name }}\" in user_groups.stdout.split(\u0027 \u0027))"},{"line_number":16,"context_line":"      or (\"{{ ansible_user_id }}\" \u003d\u003d \"root\"))"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_5f88ece7","line":16,"in_reply_to":"fa7ab95a_8e290e3a","updated":"2016-09-05 04:54:12.000000000","message":"Seems that many edge cases here, but there are many cases with very different reasons for `docker info` fail.\n\nDo you have any other suggestion?","commit_id":"3aa2066afa9b1c09207660f4407db0335d4acb2a"}]}