)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f248dc55084675711f135a894be535c6c25bf6a2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Prithiv \u003cprithiv.mohan@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-22 21:48:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dockerfiles for collectd-ceilometer-plugin Container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Collectd-ceilometer-plugin is essential for further"},{"line_number":10,"context_line":"more detailed metrics collection, smarter scheduling and service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_b47a5c75","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":42},"updated":"2016-08-23 03:20:03.000000000","message":"delete","commit_id":"1d4112c3e7164f72d414e88fa33f97494a4a8446"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f248dc55084675711f135a894be535c6c25bf6a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dockerfiles for collectd-ceilometer-plugin Container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Collectd-ceilometer-plugin is essential for further"},{"line_number":10,"context_line":"more detailed metrics collection, smarter scheduling and service"},{"line_number":11,"context_line":"assurance."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_14ba500a","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":26},"updated":"2016-08-23 03:20:03.000000000","message":"delete","commit_id":"1d4112c3e7164f72d414e88fa33f97494a4a8446"}],"docker/collectd-ceilometer-plugin/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN useradd -r -m --user-group collectd \\"},{"line_number":5,"context_line":"    \u0026\u0026 usermod -a -G kolla collectd"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_23092fde","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":35},"updated":"2016-08-22 17:01:17.000000000","message":"Move this after collectd installation, also probably when collectd package is installed will create the user/group.","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_e31c37c3","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":31},"updated":"2016-08-22 17:01:17.000000000","message":"I would use collectd_ceilometer_plugin_packages because container name is that.","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN {{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_237dafe7","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":31},"updated":"2016-08-22 17:01:17.000000000","message":"Ditto","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN {{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD collectd-ceilometer-plugin-archive /collectd-ceilometer-plugin-source"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_63e167fe","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"updated":"2016-08-22 17:01:17.000000000","message":"Remove the RUN before macro install, the RUN has been included in macro itself","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RUN {{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD collectd-ceilometer-plugin-archive /collectd-ceilometer-plugin-source"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_0350735c","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":53},"updated":"2016-08-22 17:01:17.000000000","message":"Same as package definition, collectd_ceilometer_plugin_packages","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"RUN {{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD collectd-ceilometer-plugin-archive /collectd-ceilometer-plugin-source"},{"line_number":20,"context_line":"RUN ln -s collectd-ceilometer-plugin-source/* collectd-ceilometer-plugin"},{"line_number":21,"context_line":"COPY collectd_sudoers /etc/sudoers.d/kolla_collectd_sudoers"},{"line_number":22,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_83e8e3b5","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":73},"updated":"2016-08-22 17:01:17.000000000","message":"This use to be for source installations, add  source logic to install it","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block collectd_ceilometer_plugin_footer %}{% endblock %}"},{"line_number":29,"context_line":"{% block footer %}{% endblock %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ include_footer }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"USER collectd"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_e3d717eb","line":30,"updated":"2016-08-22 17:01:17.000000000","message":"Please, remove empty line","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f248dc55084675711f135a894be535c6c25bf6a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ac06dbe_14fff0aa","updated":"2016-08-23 03:20:03.000000000","message":"file should be \nkolla/docker/collectd/Dockerfile","commit_id":"1d4112c3e7164f72d414e88fa33f97494a4a8446"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f248dc55084675711f135a894be535c6c25bf6a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD collectd-ceilometer-plugin-archive /collectd-ceilometer-plugin-source"},{"line_number":20,"context_line":"RUN ln -s collectd-ceilometer-plugin-source/* collectd-ceilometer-plugin"},{"line_number":21,"context_line":"COPY collectd_sudoers /etc/sudoers.d/kolla_collectd_sudoers"},{"line_number":22,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":23,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_d471d877","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":72},"updated":"2016-08-23 03:20:03.000000000","message":"this should be done via a custimisation script hosted in \nhttps://github.com/openstack/collectd-ceilometer-plugin","commit_id":"1d4112c3e7164f72d414e88fa33f97494a4a8446"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f248dc55084675711f135a894be535c6c25bf6a2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_collectd_sudoers \\"},{"line_number":26,"context_line":"    \u0026\u0026 usermod -a -G kolla collectd"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block collectd_ceilometer_plugin_footer %}{% endblock %}"},{"line_number":29,"context_line":"{% block footer %}{% endblock %}"},{"line_number":30,"context_line":"{{ include_footer }}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_948640d9","line":28,"range":{"start_line":28,"start_character":17,"end_line":28,"end_character":35},"updated":"2016-08-23 03:20:03.000000000","message":"delete","commit_id":"1d4112c3e7164f72d414e88fa33f97494a4a8446"}],"docker/collectd-ceilometer-plugin/collectd_sudoers":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4318ba258416a8fab784998db34dcabb3c4ae7dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown collectd\\: /var/lib/collectd/data, /usr/bin/chown collectd\\: /var/lib/collectd/data"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1ac06dbe_f9ba2422","line":1,"range":{"start_line":1,"start_character":74,"end_line":1,"end_character":118},"updated":"2016-08-22 17:01:17.000000000","message":"Duplicated?","commit_id":"581a3e919365fcf7fb4f8e570bfe4b0c34371c3f"}],"docker/collectd/Dockerfile.j2":[{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"e26c1583bb5df719a72023b9e108dfefffd81130","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":13,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_caaf437b","line":10,"updated":"2016-08-23 15:46:23.000000000","message":"see below","commit_id":"da9b96ab9196cb3047fbb11064d417e23a400a43"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"e26c1583bb5df719a72023b9e108dfefffd81130","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"  {% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":"{{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_0ace7b62","line":12,"updated":"2016-08-23 15:46:23.000000000","message":"should this line be duplicated?","commit_id":"da9b96ab9196cb3047fbb11064d417e23a400a43"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"343903b60669b036633b7b93c1f4e2240f584cdd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN useradd -r -m --user-group collectd \\"},{"line_number":5,"context_line":"    \u0026\u0026 usermod -a -G kolla collectd"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":8,"context_line":"{% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1ac06dbe_ad24970c","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":35},"updated":"2016-08-23 18:16:10.000000000","message":"Probably collectd package creates the user, adding collectd user to kolla group is also done at the end of the file.\nI think this code block has to be removed unless collectd user is not created while installing, in this case i would move it in the same run as usermod","commit_id":"4a5594fc08e72768a29bbc57dd9c53d963c52326"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"343903b60669b036633b7b93c1f4e2240f584cdd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_collectd_sudoers \\"},{"line_number":18,"context_line":"    \u0026\u0026 usermod -a -G kolla collectd"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block collectd_ceilometer_plugin_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1ac06dbe_4d4d2399","line":20,"range":{"start_line":20,"start_character":9,"end_line":20,"end_character":34},"updated":"2016-08-23 18:16:10.000000000","message":"s/collectd_ceilometer_plugin_footer/collectd_base_footer/g","commit_id":"4a5594fc08e72768a29bbc57dd9c53d963c52326"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6158f2df044d1bdd0d1ef1188efcd50a26b89d84","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":"{% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1ac06dbe_3fdedcdc","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":29},"updated":"2016-08-24 11:48:50.000000000","message":"Same as Paul\u0027s comment, only collectd_packages.","commit_id":"aebfaf612f41dfb89a9b464fbad8b052aaa2eb2e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"619e7a8223a60ce7a311c0e6391dd6829998f322","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":"{% set collectd_base_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{{ macros.install_packages(collectd_base_packages | customizable(\"packages\")) }}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"COPY collectd_sudoers /etc/sudoers.d/kolla_collectd_sudoers"},{"line_number":10,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1ac06dbe_3f99bcc4","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":40},"updated":"2016-08-24 11:37:38.000000000","message":"The image name is just \u0027collectd\u0027 so this should really be \u0027collectd_packages\u0027","commit_id":"aebfaf612f41dfb89a9b464fbad8b052aaa2eb2e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a9d6b3c4707758c4ed3d0a2bc5516112e441a428","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa7ab95a_6c26d2bb","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":53},"updated":"2016-08-26 15:53:08.000000000","message":"does this need openstack-base or can it just inherit from base","commit_id":"ff7fc6afc9124a9429b928f3c9b6973858dfec13"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a9d6b3c4707758c4ed3d0a2bc5516112e441a428","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":"{% set collectd_packages \u003d [\u0027collectd\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{{ macros.install_packages(collectd_packages | customizable(\"packages\")) }}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa7ab95a_0c38e6d2","line":5,"updated":"2016-08-26 15:53:08.000000000","message":"please add line above this","commit_id":"ff7fc6afc9124a9429b928f3c9b6973858dfec13"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"ee3e074f7694e8d20465af82b00a10067e046795","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0026\u0026 usermod -a -G kolla collectd"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block collectd_footer %}{% endblock %}"},{"line_number":19,"context_line":"{% block footer %}{% endblock %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ include_footer }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa7ab95a_4db713d8","line":19,"range":{"start_line":19,"start_character":1,"end_line":19,"end_character":32},"updated":"2016-08-29 05:41:01.000000000","message":"remove this footer block","commit_id":"ff7fc6afc9124a9429b928f3c9b6973858dfec13"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50ba5411dbf5f944c8ca98dfcae63d4776d9cd2","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block collectd_footer %}{% endblock %}"},{"line_number":19,"context_line":"{% block footer %}{% endblock %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ include_footer }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"USER collectd"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa7ab95a_fe81c590","line":20,"updated":"2016-08-26 10:00:53.000000000","message":"Remove empty line","commit_id":"ff7fc6afc9124a9429b928f3c9b6973858dfec13"}],"docker/collectd/collectd_sudoers":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"343903b60669b036633b7b93c1f4e2240f584cdd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R collectd\\: /var/lib/collectd/, /bin/chown -R collectd\\: /var/lib/collectd/"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ac06dbe_ed296f9c","line":1,"range":{"start_line":1,"start_character":75,"end_line":1,"end_character":120},"updated":"2016-08-23 18:16:10.000000000","message":"This is duplicated","commit_id":"4a5594fc08e72768a29bbc57dd9c53d963c52326"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"31bebeec7035387226ffd34b608296ef6e5277f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R collectd\\: /var/lib/collectd/"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1ac06dbe_ff17df51","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":42},"updated":"2016-08-25 08:38:41.000000000","message":"sudoers files in other containers list /bin/chown and /usr/bin/chown here, probably because different distributions use different locations.","commit_id":"f78f8a6ac5dc4bf642b8f038a8bca32544bf1438"}],"docker/collectd/extend_start.sh":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"619e7a8223a60ce7a311c0e6391dd6829998f322","unresolved":false,"context_lines":[{"line_number":1,"context_line":"sudo chown collectd: /var/run/collectd"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_1fdb207d","line":1,"updated":"2016-08-24 11:37:38.000000000","message":"Please add #!/bin/bash to top of tile","commit_id":"aebfaf612f41dfb89a9b464fbad8b052aaa2eb2e"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"31bebeec7035387226ffd34b608296ef6e5277f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"sudo chown collectd: /var/run/collectd"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1ac06dbe_3fd177ce","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":38},"updated":"2016-08-25 08:38:41.000000000","message":"sync this with the entry in the sudoers file (or vice versa)","commit_id":"f78f8a6ac5dc4bf642b8f038a8bca32544bf1438"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"31bebeec7035387226ffd34b608296ef6e5277f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1ac06dbe_9f8eabce","line":3,"updated":"2016-08-25 08:38:41.000000000","message":"In other containers with check first if it is necessary to adjust the permissions.","commit_id":"f78f8a6ac5dc4bf642b8f038a8bca32544bf1438"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"16bd51f763564cb0fa37049b0227a5f270dd5422","unresolved":false,"context_lines":[{"line_number":1,"context_line":"sudo chown collectd: /var/lib/collectd"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1ac06dbe_17c73f13","line":1,"updated":"2016-08-25 09:56:47.000000000","message":"Please have a look at the scripts used in other containers and do it the same way.","commit_id":"2aa9d1dca147a2ad7974d5317e0bff47198d6611"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50ba5411dbf5f944c8ca98dfcae63d4776d9cd2","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":4,"context_line":"if [[ $(stat -c %U:%G /var/lib/collectd) !\u003d \"collectd:collectd\" ]]; then"},{"line_number":5,"context_line":"sudo chown collectd: /var/lib/collectd"},{"line_number":6,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":10,"id":"fa7ab95a_3e632d1c","line":5,"updated":"2016-08-26 10:00:53.000000000","message":"Please, indent this line","commit_id":"ff7fc6afc9124a9429b928f3c9b6973858dfec13"}]}