)]}'
{"docker/nova/nova-serialproxy/Dockerfile.j2":[{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"b677383847610251ba197bf980f2c4881a31d027","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block nova_serialproxy_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER nova"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_e3019cb0","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"updated":"2016-08-23 13:28:14.000000000","message":"please remove unnamed footer","commit_id":"c62210903b2b3160c5513ce8b6eff1dd6074b61b"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6e31aaf9a2d509d99799d98da4cad79c7a532ec8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block nova_serialproxy_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER nova"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa7ab95a_ed78e72d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"in_reply_to":"1ac06dbe_4cbcfcba","updated":"2016-08-29 05:39:24.000000000","message":"Eduardo, we have the named footer block for customization and existing footer block as below. This unnamed footer block is not required","commit_id":"c62210903b2b3160c5513ce8b6eff1dd6074b61b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b754fd3c95235ec77978ffbcb27a8f0969fc8e8e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block nova_serialproxy_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER nova"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_4cbcfcba","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"in_reply_to":"1ac06dbe_e3019cb0","updated":"2016-08-23 21:07:14.000000000","message":"ATM there is not really clear if block footer should be removed from non *-base images.","commit_id":"c62210903b2b3160c5513ce8b6eff1dd6074b61b"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"1bc46ee6cdf3a0b7fc744d629efee11d74d87378","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block nova_serialproxy_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER nova"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9a89bdaa_f411fe5e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"in_reply_to":"fa7ab95a_52e4f9df","updated":"2016-09-03 00:57:28.000000000","message":"about {block footer}, it have what role, who can tell me or to renferce","commit_id":"c62210903b2b3160c5513ce8b6eff1dd6074b61b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"76023ad31fdd62bb39159ef9f8b8976653cac870","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block nova_serialproxy_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER nova"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa7ab95a_52e4f9df","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"in_reply_to":"fa7ab95a_ed78e72d","updated":"2016-08-29 13:08:05.000000000","message":"As described https://review.openstack.org/#/c/361253/4/doc/CONTRIBUTING.rst\n\n\"{{ include_footer }} is legacy and should not be included in new services, it is superseded by {% block footer %}{% endblock %}\"\n\n{% block footer %}{% endblock %} shouldn\u0027t be included at base images, nova-serialproxy is not a base image, depends from nova-base.\nJust want to be sure if remove or leave there unnamed block footers. Don\u0027t want to remove now and put it again in the next PS.","commit_id":"c62210903b2b3160c5513ce8b6eff1dd6074b61b"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"9d4749e1a9e72c8ad1e9bc12be2998e5b984524a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}nova-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":6,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_75af9ce3","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":47},"updated":"2016-09-14 02:06:38.000000000","message":"Add {% block nova_serialproxy_header %}{% endblock %}","commit_id":"596f7e839ce3de681ad923e6e7f6167be8504693"}]}