)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"94cd3708a81936dec358870856a4afecacafeee0","unresolved":false,"context_lines":[{"line_number":381,"context_line":"#######################"},{"line_number":382,"context_line":"nova_backend_ceph: \"{{ enable_ceph }}\""},{"line_number":383,"context_line":"nova_backend: \"{{ \u0027rbd\u0027 if nova_backend_ceph | bool else \u0027default\u0027 }}\""},{"line_number":384,"context_line":"nova_serial_console: \"no\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_4f2aea7f","line":384,"updated":"2016-11-06 04:27:23.000000000","message":"hmm, how about use `enable_nova_serialconsole_proxy?\n1. use the service name direct is easy to remember.\n2. this is a switch, add enable_ prefix.","commit_id":"e40f0a008a8e5024e2bf3f9a7248ca91c595eb48"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"275eecc91f3da850a7e0a2826524e45401fb5668","unresolved":false,"context_lines":[{"line_number":381,"context_line":"#######################"},{"line_number":382,"context_line":"nova_backend_ceph: \"{{ enable_ceph }}\""},{"line_number":383,"context_line":"nova_backend: \"{{ \u0027rbd\u0027 if nova_backend_ceph | bool else \u0027default\u0027 }}\""},{"line_number":384,"context_line":"nova_serial_console: \"no\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_30a44e07","line":384,"range":{"start_line":384,"start_character":12,"end_line":384,"end_character":19},"updated":"2016-11-04 14:40:29.000000000","message":"why \"console\" rather than \"proxy\"? Also regardless I think it should be prefixed with \"enable_\"","commit_id":"e40f0a008a8e5024e2bf3f9a7248ca91c595eb48"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ef9aa692398ab6d24b4d3450a3e10bb9377f44d2","unresolved":false,"context_lines":[{"line_number":381,"context_line":"#######################"},{"line_number":382,"context_line":"nova_backend_ceph: \"{{ enable_ceph }}\""},{"line_number":383,"context_line":"nova_backend: \"{{ \u0027rbd\u0027 if nova_backend_ceph | bool else \u0027default\u0027 }}\""},{"line_number":384,"context_line":"nova_serial_console: \"no\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"#######################"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_8725db0b","line":384,"range":{"start_line":384,"start_character":12,"end_line":384,"end_character":19},"in_reply_to":"ba5da102_30a44e07","updated":"2016-11-04 17:48:02.000000000","message":"@pbourke, nova serial proxy is the API which provides nova serial console services.\nThe service enabled is nova console, the API listening and Docker image is serial proxy.\nShould I unify all to nova console or to serial proxy? What you prefer?","commit_id":"e40f0a008a8e5024e2bf3f9a7248ca91c595eb48"}],"ansible/roles/nova/tasks/deploy.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"94cd3708a81936dec358870856a4afecacafeee0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        inventory_hostname in groups[\u0027nova-consoleauth\u0027] or"},{"line_number":10,"context_line":"        inventory_hostname in groups[\u0027nova-novncproxy\u0027] or"},{"line_number":11,"context_line":"        inventory_hostname in groups[\u0027nova-scheduler\u0027] or"},{"line_number":12,"context_line":"        inventory_hostname in groups[\u0027nova-serialproxy\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: external-ceph.yml"},{"line_number":15,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba5da102_6f1fae5b","line":12,"updated":"2016-11-06 04:27:23.000000000","message":"nova-serial do not need ceph info.","commit_id":"e40f0a008a8e5024e2bf3f9a7248ca91c595eb48"}],"ansible/roles/nova/tasks/reload.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"b3cd5494e4c74802ba7875c40ead068bcb1a31fb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027nova-serialproxy\u0027]"},{"line_number":23,"context_line":"    - nova_serial_console | bool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Sighup nova-spicehtml5proxy"},{"line_number":26,"context_line":"  command: docker exec -t nova_spicehtml5proxy kill -1 1"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - inventory_hostname in groups[\u0027nova-spicehtml5proxy\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_a2c5463d","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":35},"updated":"2016-10-12 03:03:18.000000000","message":"why is this done?  can you explain?","commit_id":"cef1dd59df535d8433f2e3b08043a2674bcd40d7"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"050935d7634107c9f678759cc093ac6fa6f9cb76","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027nova-serialproxy\u0027]"},{"line_number":23,"context_line":"    - nova_serial_console | bool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Sighup nova-spicehtml5proxy"},{"line_number":26,"context_line":"  command: docker exec -t nova_spicehtml5proxy kill -1 1"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - inventory_hostname in groups[\u0027nova-spicehtml5proxy\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_38615ea9","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":35},"in_reply_to":"fa6399be_7c66ee2a","updated":"2016-10-19 04:56:12.000000000","message":"Yes, as long as the two containers do not communicate, having this should be ok.","commit_id":"cef1dd59df535d8433f2e3b08043a2674bcd40d7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4fd9a29907cf590bcc1487f2830120651fa14fe7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027nova-serialproxy\u0027]"},{"line_number":23,"context_line":"    - nova_serial_console | bool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Sighup nova-spicehtml5proxy"},{"line_number":26,"context_line":"  command: docker exec -t nova_spicehtml5proxy kill -1 1"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - inventory_hostname in groups[\u0027nova-spicehtml5proxy\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_7c66ee2a","line":25,"range":{"start_line":25,"start_character":15,"end_line":25,"end_character":35},"in_reply_to":"fa6399be_a2c5463d","updated":"2016-10-14 16:18:30.000000000","message":"good catch, is not needed at all. Sigterm is made to refresh upgrade levels, but these two containers does not communicate with rabbitmq, so no need of upgrade level. I think having this config will not harm. What do you think?","commit_id":"cef1dd59df535d8433f2e3b08043a2674bcd40d7"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7f32d05d6e0985842c20ea2cb9140a0e5d164b0d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"[serial_console]"},{"line_number":93,"context_line":"enabled \u003d true"},{"line_number":94,"context_line":"base_url \u003d ws://{{ kolla_external_fqdn }}:{{ nova_serialproxy_port }}/"},{"line_number":95,"context_line":"serialproxy_host \u003d 0.0.0.0"},{"line_number":96,"context_line":"serialproxy_port \u003d {{ nova_serialproxy_port }}"},{"line_number":97,"context_line":"proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":98,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_0950a95d","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":26},"updated":"2016-08-25 16:35:25.000000000","message":"I have a security concern on binding at 0.0.0.0, ATM if the same IP address is not used in base_url and serialproxy_host, need to be bind at 0.0.0.0. [0]\n\nIMHO, this is not correct from the security point of view.\n\nTried changing values from different IP addresses/hostnames, but the only running combiantion is all the same or bind to 0.0.0.0.\n\nIf someone have some advise or idea, tell me.\n\n[0] http://docs.openstack.org/mitaka/config-reference/compute/config-options.html","commit_id":"65593d6a03575be4637ae5cae2b9fd46304d84b2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"047e419f754ee05f6768b7351c3e324e0fe2f940","unresolved":false,"context_lines":[{"line_number":92,"context_line":"[serial_console]"},{"line_number":93,"context_line":"enabled \u003d true"},{"line_number":94,"context_line":"base_url \u003d ws://{{ kolla_external_fqdn }}:{{ nova_serialproxy_port }}/"},{"line_number":95,"context_line":"serialproxy_host \u003d 0.0.0.0"},{"line_number":96,"context_line":"serialproxy_port \u003d {{ nova_serialproxy_port }}"},{"line_number":97,"context_line":"proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":98,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_6020b84a","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":26},"in_reply_to":"1ac06dbe_0950a95d","updated":"2016-09-14 02:58:20.000000000","message":"yup this can\u0027t merge as is.  wildcard binds are a huge problem.","commit_id":"65593d6a03575be4637ae5cae2b9fd46304d84b2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"98cc322308e536bf127a6e38c4346f62cdc316e3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"[serial_console]"},{"line_number":93,"context_line":"enabled \u003d true"},{"line_number":94,"context_line":"base_url \u003d ws://{{ kolla_external_fqdn }}:{{ nova_serialproxy_port }}/"},{"line_number":95,"context_line":"serialproxy_host \u003d 0.0.0.0"},{"line_number":96,"context_line":"serialproxy_port \u003d {{ nova_serialproxy_port }}"},{"line_number":97,"context_line":"proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":98,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_606d1832","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":26},"in_reply_to":"7a8ec9b2_6020b84a","updated":"2016-09-14 03:12:37.000000000","message":"@Eduardo,\n\ncould u explain more? what issue did u meet when using a specified ip address? any logs will be helpful.\n\nI think {{ api_interface_address }} should work.","commit_id":"65593d6a03575be4637ae5cae2b9fd46304d84b2"}]}