)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"9b20308c1d6d79f07eb69cee37e10f326743a05b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yao Lu \u003clu.yao135@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-23 04:23:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"delete virtual bridge artifacts when cleaning hosts"},{"line_number":8,"context_line":"After cleaning hosts by using tools/cleanup_host, some of the ovs bridge"},{"line_number":9,"context_line":"devices such as ovs-system still exist. This will result in"},{"line_number":10,"context_line":"{{neutron_external_interface}} not working properly because it had been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_662751ca","line":7,"updated":"2016-08-30 03:16:04.000000000","message":"Update the commit message [1] \n\n[1] http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"d3ce7c6937fd3c9884d822adeb5bfb6983ce6bd8"},{"author":{"_account_id":21103,"name":"Zhijiang Hu","email":"hu.zhijiang@zte.com.cn","username":"huzhj"},"change_message_id":"3a08e649c0ce616d8198456754754d87e12499d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After cleaning hosts by using tools/cleanup_host, some of the ovs bridge"},{"line_number":10,"context_line":"devices such as ovs-system still exist. This will result in"},{"line_number":11,"context_line":"{{neutron_external_interface}} not working properly because it had been"},{"line_number":12,"context_line":"added to the ovs-system bridge. The solution is removing the openvswitch"},{"line_number":13,"context_line":"kernel module."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib3b096d842f2210b8bd223892a3492ef2fcf7c52"},{"line_number":16,"context_line":"Signed-off-by: luyao \u003clu.yao135@zte.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_165a9050","line":13,"range":{"start_line":12,"start_character":48,"end_line":13,"end_character":14},"updated":"2016-09-01 09:03:31.000000000","message":"As your latest patchset this should be changed into some thing like this: calling neutron-ovs-cleanup script in neutron_openvswitch_agent container before removing it.","commit_id":"6b96183e8e4f973a9ed82b522f0a941bd20db2f1"}],"tools/cleanup-containers":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"711e3e1dc47fb3de818d2e4b396e9434f5997bb2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"echo \"Removing ovs bridge...\""},{"line_number":20,"context_line":"(docker exec -u root neutron_openvswitch_agent neutron-ovs-cleanup --ovs_all_ports 2\u003e\u00261) \u003e/dev/null"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"echo \"Stopping containers...\""},{"line_number":23,"context_line":"(docker stop -t 2 ${containers_to_kill} 2\u003e\u00261) \u003e /dev/null"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa7ab95a_e7aac6d1","line":20,"updated":"2016-09-01 12:58:00.000000000","message":"1. ignore all error is bad\n2. when using neutron-ovs-cleanup, you need point the config file like:\n\nneutron-ovs-cleanup --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini --ovs_all_ports","commit_id":"1958364e6c7889dc9b627ced81b387a1f1bf8824"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0f728389fb4a3c82a85f85b49a6c0b4ea273fdd7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"echo \"Removing ovs bridge...\""},{"line_number":20,"context_line":"(docker exec -u root neutron_openvswitch_agent neutron-ovs-cleanup \\"},{"line_number":21,"context_line":"    --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":22,"context_line":"    --ovs_all_ports) \u003e /dev/null"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a89bdaa_a03b7dea","line":20,"updated":"2016-09-05 15:51:45.000000000","message":"i do not think the root is needed.","commit_id":"cf9134ddfe5040c6b75ef276d1944e99dedebd5c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b55c27032c8d4535780bea0d33fcb80b96dffcf5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"echo \"Removing ovs bridge...\""},{"line_number":20,"context_line":"(docker exec -u root neutron_openvswitch_agent neutron-ovs-cleanup \\"},{"line_number":21,"context_line":"    --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":22,"context_line":"    --ovs_all_ports) \u003e /dev/null"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a89bdaa_e93b9fe9","line":20,"updated":"2016-09-06 07:49:37.000000000","message":"now, the neutron_opevswitch_agent connect the openvswitch_db through tcp port by using idl. So it is OK.\n\nBut, this is cleanup-container which destroy the all containers. So i think it is fine to use root.\n\nThanks","commit_id":"cf9134ddfe5040c6b75ef276d1944e99dedebd5c"},{"author":{"_account_id":21288,"name":"Yao Lu","email":"lu.yao135@zte.com.cn","username":"luyao"},"change_message_id":"db253d25a62c6e65db521ba408d1f648ff6a6156","unresolved":false,"context_lines":[{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"echo \"Removing ovs bridge...\""},{"line_number":20,"context_line":"(docker exec -u root neutron_openvswitch_agent neutron-ovs-cleanup \\"},{"line_number":21,"context_line":"    --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":22,"context_line":"    --ovs_all_ports) \u003e /dev/null"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a89bdaa_635c15ee","line":20,"in_reply_to":"9a89bdaa_a03b7dea","updated":"2016-09-06 02:30:23.000000000","message":"Thanks!But after my test, if not the root, ovs-vsclt command can\u0027t exec and rasie Permission denied error in neutron_openvswitch_agent container. So I think the root is needed.","commit_id":"cf9134ddfe5040c6b75ef276d1944e99dedebd5c"}],"tools/cleanup-host":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"735d0d84a0956ddb5f7ed36d39dc397fa7924e5c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Removing bridges...\""},{"line_number":31,"context_line":"rmmod openvswitch"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"Creating a fstab backup...\""},{"line_number":34,"context_line":"sudo cp /etc/fstab /etc/fstab_backup"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1ac06dbe_801eebb8","line":31,"updated":"2016-08-23 10:10:37.000000000","message":"This seems quite destructive. Can we be a little more selective about the bridges we remove without tearing out the entire kmod?","commit_id":"d3ce7c6937fd3c9884d822adeb5bfb6983ce6bd8"},{"author":{"_account_id":21288,"name":"Yao Lu","email":"lu.yao135@zte.com.cn","username":"luyao"},"change_message_id":"301bafbd8793e32819034e6d256e0108ce5884f7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Removing bridges...\""},{"line_number":31,"context_line":"rmmod openvswitch"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"Creating a fstab backup...\""},{"line_number":34,"context_line":"sudo cp /etc/fstab /etc/fstab_backup"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1ac06dbe_658e59d1","line":31,"in_reply_to":"1ac06dbe_801eebb8","updated":"2016-08-23 11:54:33.000000000","message":"thanks for your suggestion！I will use other command to just remove ovs-system birdge","commit_id":"d3ce7c6937fd3c9884d822adeb5bfb6983ce6bd8"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"12c68205cdaa937c699fa887ddab392172178e1e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Removing bridges...\""},{"line_number":31,"context_line":"rmmod openvswitch"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"Creating a fstab backup...\""},{"line_number":34,"context_line":"sudo cp /etc/fstab /etc/fstab_backup"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa7ab95a_be85d9cf","line":31,"updated":"2016-08-30 08:11:10.000000000","message":"this will raise error because the bridge use it and can not remove it directly.\n\nthe right solution should be remove all the ovs bridge when using ovs agent.","commit_id":"96ee551a0277a6bb7c72a27d3324ca8af5dbc15d"},{"author":{"_account_id":21288,"name":"Yao Lu","email":"lu.yao135@zte.com.cn","username":"luyao"},"change_message_id":"7e797bc28b5879e82f4488166e8fa827f08e65c4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"done"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Removing bridges...\""},{"line_number":31,"context_line":"rmmod openvswitch"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"echo \"Creating a fstab backup...\""},{"line_number":34,"context_line":"sudo cp /etc/fstab /etc/fstab_backup"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa7ab95a_e7d18d24","line":31,"in_reply_to":"fa7ab95a_be85d9cf","updated":"2016-09-01 07:51:57.000000000","message":"I think when we use cleanup-host ,","commit_id":"96ee551a0277a6bb7c72a27d3324ca8af5dbc15d"}]}