)]}'
{"docker/mariadb/extend_start.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2afc7116387d844fbb24d3aa7fec04efed575f95","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            exit 1"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    done"},{"line_number":15,"context_line":"    sleep 5"},{"line_number":16,"context_line":"    sudo -E kolla_security_reset"},{"line_number":17,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027localhost\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""},{"line_number":18,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027%\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_b4774e01","line":15,"updated":"2016-08-25 08:20:20.000000000","message":"could u use a better solution?  use magic number is bad.","commit_id":"ff14762ed591d314c43d14850e7572c8e94ef1f6"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"91d8fb0b6ebf70d6e0bb7c21b9f20f77116347e5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            exit 1"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    done"},{"line_number":15,"context_line":"    sleep 5"},{"line_number":16,"context_line":"    sudo -E kolla_security_reset"},{"line_number":17,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027localhost\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""},{"line_number":18,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027%\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa7ab95a_6f54abfe","line":15,"in_reply_to":"1ac06dbe_3f5857fa","updated":"2016-08-29 15:09:08.000000000","message":"+1","commit_id":"ff14762ed591d314c43d14850e7572c8e94ef1f6"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"2a24186f530081e2b30c4ec05199a2b9bb72fec3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            exit 1"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    done"},{"line_number":15,"context_line":"    sleep 5"},{"line_number":16,"context_line":"    sudo -E kolla_security_reset"},{"line_number":17,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027localhost\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""},{"line_number":18,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027%\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa7ab95a_9753a1e1","line":15,"in_reply_to":"1ac06dbe_3f5857fa","updated":"2016-08-30 04:32:01.000000000","message":"Done","commit_id":"ff14762ed591d314c43d14850e7572c8e94ef1f6"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"433a36f634e13b064d0b87f69cf554e3d5ddfcd7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            exit 1"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    done"},{"line_number":15,"context_line":"    sleep 5"},{"line_number":16,"context_line":"    sudo -E kolla_security_reset"},{"line_number":17,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027localhost\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""},{"line_number":18,"context_line":"    mysql -u root --password\u003d\"${DB_ROOT_PASSWORD}\" -e \"GRANT ALL PRIVILEGES ON *.* TO \u0027root\u0027@\u0027%\u0027 IDENTIFIED BY \u0027${DB_ROOT_PASSWORD}\u0027 WITH GRANT OPTION;\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_3f5857fa","line":15,"in_reply_to":"1ac06dbe_b4774e01","updated":"2016-08-25 08:30:28.000000000","message":"Yes, please do not use sleep. What about analysing the results of SHOW STATUS LIKE \u0027wsrep%\u0027 ?","commit_id":"ff14762ed591d314c43d14850e7572c8e94ef1f6"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b920873036e1a672985cd3539a23ddab3f184121","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o xtrace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"function bootstrap_db {"},{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa7ab95a_4a357cf5","line":2,"updated":"2016-08-31 14:47:01.000000000","message":"remove this debug line","commit_id":"9dd3774f9e0cbf5fb7207bf130aa4adadc244189"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"e733293667dd8911eb52693bf75e7309ff842900","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o xtrace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"function bootstrap_db {"},{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a89bdaa_3a0c2394","line":2,"in_reply_to":"fa7ab95a_4a357cf5","updated":"2016-09-04 00:43:55.000000000","message":"will do","commit_id":"9dd3774f9e0cbf5fb7207bf130aa4adadc244189"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b920873036e1a672985cd3539a23ddab3f184121","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        fi"},{"line_number":15,"context_line":"    done"},{"line_number":16,"context_line":"    sleep 2"},{"line_number":17,"context_line":"    cluster_ready\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_cluster_status\u0027\" | grep Primary)"},{"line_number":18,"context_line":"    while [[ ! -f /var/lib/mysql/mariadb.pid ]] || [ -z \"${cluster_ready}\" ]; do"},{"line_number":19,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":20,"context_line":"            let TIMEOUT-\u003d1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa7ab95a_6a3a40e9","line":17,"updated":"2016-08-31 14:47:01.000000000","message":"so we expect the cluster is ready like this. Do we still need wait for the pid file?","commit_id":"9dd3774f9e0cbf5fb7207bf130aa4adadc244189"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"e733293667dd8911eb52693bf75e7309ff842900","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        fi"},{"line_number":15,"context_line":"    done"},{"line_number":16,"context_line":"    sleep 2"},{"line_number":17,"context_line":"    cluster_ready\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_cluster_status\u0027\" | grep Primary)"},{"line_number":18,"context_line":"    while [[ ! -f /var/lib/mysql/mariadb.pid ]] || [ -z \"${cluster_ready}\" ]; do"},{"line_number":19,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":20,"context_line":"            let TIMEOUT-\u003d1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a89bdaa_5a11e7ab","line":17,"in_reply_to":"fa7ab95a_6a3a40e9","updated":"2016-09-04 00:43:55.000000000","message":"If cluster_ready is true, I do not think we need to check the pid file.","commit_id":"9dd3774f9e0cbf5fb7207bf130aa4adadc244189"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ab4d8034e97ae321011029cc12e23e83118ea5bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o xtrace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"function bootstrap_db {"},{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a89bdaa_03cda5b6","line":2,"updated":"2016-09-07 14:31:37.000000000","message":"remote the xtrace","commit_id":"e1703b7a652acd3787710bb36f8c345fe929b70a"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"68342aaceb31439f8424983b481643bdacbd962b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o xtrace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"function bootstrap_db {"},{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a89bdaa_30fc913d","line":2,"in_reply_to":"9a89bdaa_03cda5b6","updated":"2016-09-08 01:04:37.000000000","message":"Hi, Jeffrey, it is for debugging the script on gate. I will remove this line once you agree on the other changes. Thanks.","commit_id":"e1703b7a652acd3787710bb36f8c345fe929b70a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"a47fd534a0757b927d07b8dc383469dcf6de953b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"},{"line_number":6,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":7,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":8,"context_line":"    while [[ ! -S /var/lib/mysql/mysql.sock ]] \u0026\u0026 [[ ! -S /var/run/mysqld/mysqld.sock ]]; do"},{"line_number":9,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":10,"context_line":"            let TIMEOUT-\u003d1"},{"line_number":11,"context_line":"            sleep 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a89bdaa_b398ab6b","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":9},"updated":"2016-09-08 01:40:01.000000000","message":"Dear huikang, I think the 3 while cycle can be combined together, if you can trouble you to change","commit_id":"e1703b7a652acd3787710bb36f8c345fe929b70a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ab4d8034e97ae321011029cc12e23e83118ea5bd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"},{"line_number":6,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":7,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":8,"context_line":"    while [[ ! -S /var/lib/mysql/mysql.sock ]] \u0026\u0026 [[ ! -S /var/run/mysqld/mysqld.sock ]]; do"},{"line_number":9,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":10,"context_line":"            let TIMEOUT-\u003d1"},{"line_number":11,"context_line":"            sleep 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a89bdaa_23c6299a","line":8,"updated":"2016-09-07 14:31:37.000000000","message":"why check the mysql.sock in two places? if this is must, please add some NOTE to explain this.","commit_id":"e1703b7a652acd3787710bb36f8c345fe929b70a"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"0faf39a11a098b2b3d273a4873786465c9437fe9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"},{"line_number":6,"context_line":"    # Wait for the mariadb server to be \"Ready\" before starting the security reset with a max timeout"},{"line_number":7,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":8,"context_line":"    while [[ ! -S /var/lib/mysql/mysql.sock ]] \u0026\u0026 [[ ! -S /var/run/mysqld/mysqld.sock ]]; do"},{"line_number":9,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":10,"context_line":"            let TIMEOUT-\u003d1"},{"line_number":11,"context_line":"            sleep 1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a89bdaa_09d048f5","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":9},"in_reply_to":"9a89bdaa_b398ab6b","updated":"2016-09-08 03:15:46.000000000","message":"Hi, Bingbing thanks for your comment. In the latest PS, I have consolidated the 3 while loop to 2. Could you take a look at the current one? -Hui","commit_id":"e1703b7a652acd3787710bb36f8c345fe929b70a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ab4d8034e97ae321011029cc12e23e83118ea5bd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        fi"},{"line_number":15,"context_line":"    done"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":18,"context_line":"    while [[ ! -f /var/lib/mysql/mariadb.pid ]]; do"},{"line_number":19,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":20,"context_line":"            let TIMEOUT-\u003d1"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a89bdaa_43c32d89","line":17,"updated":"2016-09-07 14:31:37.000000000","message":"we are waiting for the mysql.sock for 60 seconds. and wait for the mariadb.pid file for another 60 seconds. it is really needed?","commit_id":"e1703b7a652acd3787710bb36f8c345fe929b70a"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"0c94dca6d20e62b8277454f77f6ebc278ee49c22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o xtrace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"function bootstrap_db {"},{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a89bdaa_2ce97eb7","line":2,"updated":"2016-09-08 13:30:39.000000000","message":"Remove please","commit_id":"739cab2121bb7a85172a99a76675efb3d9d130fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d68f29376db4423251b7f288b1ab13160b3ddb9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -o xtrace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"function bootstrap_db {"},{"line_number":5,"context_line":"    mysqld_safe --wsrep-new-cluster \u0026"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a89bdaa_57d194fa","line":2,"in_reply_to":"9a89bdaa_2ce97eb7","updated":"2016-09-09 19:58:29.000000000","message":"Done","commit_id":"739cab2121bb7a85172a99a76675efb3d9d130fc"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"0c94dca6d20e62b8277454f77f6ebc278ee49c22","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":8,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."},{"line_number":9,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":10,"context_line":"    while [[ ! -S /var/lib/mysql/mysql.sock ]] \u0026\u0026 [[ ! -S /var/run/mysqld/mysqld.sock ]] || [[ ! -f /var/lib/mysql/mariadb.pid ]]; do"},{"line_number":11,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":12,"context_line":"            let TIMEOUT-\u003d1"},{"line_number":13,"context_line":"            sleep 1"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a89bdaa_0c34ba47","line":10,"updated":"2016-09-08 13:30:39.000000000","message":"Can you break this if up so it fits into 80 chars?","commit_id":"739cab2121bb7a85172a99a76675efb3d9d130fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d68f29376db4423251b7f288b1ab13160b3ddb9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":8,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."},{"line_number":9,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":10,"context_line":"    while [[ ! -S /var/lib/mysql/mysql.sock ]] \u0026\u0026 [[ ! -S /var/run/mysqld/mysqld.sock ]] || [[ ! -f /var/lib/mysql/mariadb.pid ]]; do"},{"line_number":11,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"},{"line_number":12,"context_line":"            let TIMEOUT-\u003d1"},{"line_number":13,"context_line":"            sleep 1"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a89bdaa_97db1c1b","line":10,"in_reply_to":"9a89bdaa_0c34ba47","updated":"2016-09-09 19:58:29.000000000","message":"Done","commit_id":"739cab2121bb7a85172a99a76675efb3d9d130fc"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"0c94dca6d20e62b8277454f77f6ebc278ee49c22","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            exit 1"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":"    done"},{"line_number":18,"context_line":"    cluster_ready\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_cluster_status\u0027\" | grep Primary)"},{"line_number":19,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":20,"context_line":"    while [[ -z \"${cluster_ready}\" ]]; do"},{"line_number":21,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a89bdaa_acdf4ed4","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":17},"updated":"2016-09-08 13:30:39.000000000","message":"Is there a reason this var is not in caps?","commit_id":"739cab2121bb7a85172a99a76675efb3d9d130fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d68f29376db4423251b7f288b1ab13160b3ddb9d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            exit 1"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":"    done"},{"line_number":18,"context_line":"    cluster_ready\u003d$(mysql -u root --exec\u003d\"SHOW STATUS LIKE \u0027wsrep_cluster_status\u0027\" | grep Primary)"},{"line_number":19,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":20,"context_line":"    while [[ -z \"${cluster_ready}\" ]]; do"},{"line_number":21,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a89bdaa_f7062884","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":17},"in_reply_to":"9a89bdaa_acdf4ed4","updated":"2016-09-09 19:58:29.000000000","message":"Done","commit_id":"739cab2121bb7a85172a99a76675efb3d9d130fc"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4923a83357cac86d877996b3827a3fbfefce477d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # NOTE(huikang): the location of mysql\u0027s socket file varies depending on the OS distributions."},{"line_number":7,"context_line":"    # Querying the cluster status has to be executed after the existence of mysql.sock and mariadb.pid."},{"line_number":8,"context_line":"    TIMEOUT\u003d${DB_MAX_TIMEOUT:-60}"},{"line_number":9,"context_line":"    while [[ ! -S /var/lib/mysql/mysql.sock ]] \u0026\u0026 \\"},{"line_number":10,"context_line":"          [[ ! -S /var/run/mysqld/mysqld.sock ]] || \\"},{"line_number":11,"context_line":"          [[ ! -f /var/lib/mysql/mariadb.pid ]]; do"},{"line_number":12,"context_line":"        if [[ ${TIMEOUT} -gt 0 ]]; then"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9a89bdaa_43524d68","line":9,"updated":"2016-09-13 09:26:43.000000000","message":"should this be ( [[ ! -S ... ]] || [[ ! -S ... ]] ) \u0026\u0026 [[ -f ... ]] ?","commit_id":"c7c879095fffee711479c40f0bc95b1829a2b069"}]}