)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"42b43550018e94db18cd8efd3cd663143a6c951f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"http://docs.openstack.org/developer/ceilometer/install/dbreco.html for"},{"line_number":13,"context_line":"more info on Ceilometer database backends."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TrivialFix"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iaf84f9efe0537f42797f4bb7ba2a3611835cc84e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_7c4d7971","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2016-09-12 06:22:43.000000000","message":"I would rather use a blueprint because is the support for a new feature.","commit_id":"27fabbd212afa2edbe500e53eba3f7505200b93d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4fab464fa60dba2aebd8a1af3e1a25189b646d4e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"http://docs.openstack.org/developer/ceilometer/install/dbreco.html for"},{"line_number":13,"context_line":"more info on Ceilometer database backends."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 1622532"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iaf84f9efe0537f42797f4bb7ba2a3611835cc84e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a89bdaa_2b82c094","line":15,"updated":"2016-09-12 09:57:30.000000000","message":"Closes-Bug: #1622532","commit_id":"504f008b5e9a4ce351942a0b8bbd68bd391cf317"}],"ansible/roles/ceilometer/tasks/bootstrap.yml":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"60cab86d3a570de9cf74437d6a8d6922e52cc4db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking mongodb backend for ceilometer"},{"line_number":3,"context_line":"  local_action: fail msg\u003d\"ceilometer_database_type set to \u0027mongodb\u0027 but mongodb is not enabled\""},{"line_number":4,"context_line":"  changed_when: false"},{"line_number":5,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_5efd1739","line":2,"updated":"2016-09-06 09:38:14.000000000","message":"this is in prechecks already","commit_id":"a908dbd1ae0c34ac915bb3a69cc83d956fafaeab"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d4c3e523cb9d75304d402c368b70c9c932bb3e9e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking mongodb backend for ceilometer"},{"line_number":3,"context_line":"  local_action: fail msg\u003d\"ceilometer_database_type set to \u0027mongodb\u0027 but mongodb is not enabled\""},{"line_number":4,"context_line":"  changed_when: false"},{"line_number":5,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_c3438aad","line":2,"in_reply_to":"9a89bdaa_5efd1739","updated":"2016-09-08 11:42:53.000000000","message":"I agree tbh, someone mentioned that our precheck model needs improving as prechecks only run pre-deploy, and this ideally will be checked every time.\n\nWill remove this here though until that discussion happens again, it\u0027s not consistent to have a precheck here but not in other roles.","commit_id":"a908dbd1ae0c34ac915bb3a69cc83d956fafaeab"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"5d34ecb1df6c1e699f8c190af2ff6a9e8cea73ef","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":40,"context_line":"    -m mysql_user"},{"line_number":41,"context_line":"    -a \"login_host\u003d\u0027{{ database_address }}\u0027"},{"line_number":42,"context_line":"        login_port\u003d\u0027{{ database_port }}\u0027"},{"line_number":43,"context_line":"        login_user\u003d\u0027{{ database_user }}\u0027"},{"line_number":44,"context_line":"        login_password\u003d\u0027{{ database_password }}\u0027"},{"line_number":45,"context_line":"        name\u003d\u0027{{ ceilometer_database_name }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_526eeb2f","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":40},"updated":"2016-09-06 09:50:43.000000000","message":"add port to line 18 of \"ceilometer.conf.j2\"","commit_id":"a908dbd1ae0c34ac915bb3a69cc83d956fafaeab"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4fab464fa60dba2aebd8a1af3e1a25189b646d4e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Checking backend for ceilometer"},{"line_number":3,"context_line":"  local_action: fail msg\u003d\"No backend enabled for ceilometer. Mongodb is the only supported one for now\""},{"line_number":4,"context_line":"  changed_when: false"},{"line_number":5,"context_line":"  when: enable_ceilometer | bool and not enable_mongodb | bool"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Creating Ceilometer database"},{"line_number":8,"context_line":"  command: docker exec -t mongodb mongo --host {{ ceilometer_database_address }} --eval \u0027db \u003d db.getSiblingDB(\"{{ ceilometer_database_name }}\"); db.addUser({user\u0027:\u0027 \"{{ ceilometer_database_user }}\", pwd\u0027:\u0027 \"{{ ceilometer_database_password}}\", roles\u0027:\u0027 [ \"readWrite\", \"dbAdmin\" ]})\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a89bdaa_0b733ce8","side":"PARENT","line":5,"updated":"2016-09-12 09:57:30.000000000","message":"could u keep this task?","commit_id":"b10e29281ad81a16e340641cf144a9540e94b9d2"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"501e0537d6f3adffaa6fc4e2ecf091a984a674e5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Checking backend for ceilometer"},{"line_number":3,"context_line":"  local_action: fail msg\u003d\"No backend enabled for ceilometer. Mongodb is the only supported one for now\""},{"line_number":4,"context_line":"  changed_when: false"},{"line_number":5,"context_line":"  when: enable_ceilometer | bool and not enable_mongodb | bool"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Creating Ceilometer database"},{"line_number":8,"context_line":"  command: docker exec -t mongodb mongo --host {{ ceilometer_database_address }} --eval \u0027db \u003d db.getSiblingDB(\"{{ ceilometer_database_name }}\"); db.addUser({user\u0027:\u0027 \"{{ ceilometer_database_user }}\", pwd\u0027:\u0027 \"{{ ceilometer_database_password}}\", roles\u0027:\u0027 [ \"readWrite\", \"dbAdmin\" ]})\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a89bdaa_f976e93c","side":"PARENT","line":5,"in_reply_to":"9a89bdaa_0b733ce8","updated":"2016-09-12 11:41:13.000000000","message":"@Jeffrey, I understand there are issues around prechecks that you highlighted previously. Though I think we should discuss these separately instead of deviating in this commit and duplicating prechecks.","commit_id":"b10e29281ad81a16e340641cf144a9540e94b9d2"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"a995cc9ee664e6354f7488464de330380bd11288","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Checking backend for ceilometer"},{"line_number":3,"context_line":"  local_action: fail msg\u003d\"No backend enabled for ceilometer. Mongodb is the only supported one for now\""},{"line_number":4,"context_line":"  changed_when: false"},{"line_number":5,"context_line":"  when: enable_ceilometer | bool and not enable_mongodb | bool"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Creating Ceilometer database"},{"line_number":8,"context_line":"  command: docker exec -t mongodb mongo --host {{ ceilometer_database_address }} --eval \u0027db \u003d db.getSiblingDB(\"{{ ceilometer_database_name }}\"); db.addUser({user\u0027:\u0027 \"{{ ceilometer_database_user }}\", pwd\u0027:\u0027 \"{{ ceilometer_database_password}}\", roles\u0027:\u0027 [ \"readWrite\", \"dbAdmin\" ]})\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a89bdaa_a609a72e","side":"PARENT","line":5,"in_reply_to":"9a89bdaa_0b733ce8","updated":"2016-09-12 10:00:42.000000000","message":"what would be the reason to keep this instead of prechecks?","commit_id":"b10e29281ad81a16e340641cf144a9540e94b9d2"}],"ansible/roles/ceilometer/templates/ceilometer.conf.j2":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"470dcc554fb152cd047882990a032269c210c6a7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% if ceilometer_database_type \u003d\u003d \"mongodb\" %}"},{"line_number":16,"context_line":"connection \u003d mongodb://{{ ceilometer_database_user }}:{{ ceilometer_database_password }}@{{ ceilometer_database_address }}:{{ mongodb_port }}/{{ ceilometer_database_name }}"},{"line_number":17,"context_line":"{% elif ceilometer_database_type \u003d\u003d \"mysql\" %}"},{"line_number":18,"context_line":"connection \u003d mysql+pymysql://{{ ceilometer_database_user }}:{{ ceilometer_database_password }}@{{ ceilometer_database_address }}/{{ ceilometer_database_name }}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[keystone_authtoken]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_1221c39f","line":18,"range":{"start_line":18,"start_character":126,"end_line":18,"end_character":130},"updated":"2016-09-06 09:46:50.000000000","message":"need to add \"port\" to keep consistent with “mongodb”？or remove the \"mongodb_port\" in line 16","commit_id":"a908dbd1ae0c34ac915bb3a69cc83d956fafaeab"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d4c3e523cb9d75304d402c368b70c9c932bb3e9e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% if ceilometer_database_type \u003d\u003d \"mongodb\" %}"},{"line_number":16,"context_line":"connection \u003d mongodb://{{ ceilometer_database_user }}:{{ ceilometer_database_password }}@{{ ceilometer_database_address }}:{{ mongodb_port }}/{{ ceilometer_database_name }}"},{"line_number":17,"context_line":"{% elif ceilometer_database_type \u003d\u003d \"mysql\" %}"},{"line_number":18,"context_line":"connection \u003d mysql+pymysql://{{ ceilometer_database_user }}:{{ ceilometer_database_password }}@{{ ceilometer_database_address }}/{{ ceilometer_database_name }}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[keystone_authtoken]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_e3332e12","line":18,"range":{"start_line":18,"start_character":126,"end_line":18,"end_character":130},"in_reply_to":"9a89bdaa_1221c39f","updated":"2016-09-08 11:42:53.000000000","message":"This form is consistent with the rest of the codebase. Id rather not deviate here.","commit_id":"a908dbd1ae0c34ac915bb3a69cc83d956fafaeab"}],"etc/kolla/globals.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"5a5e085ff709ea09961dfd6126faa69d3453b878","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# Ceilometer options"},{"line_number":153,"context_line":"#######################"},{"line_number":154,"context_line":"# Valid options are [ mongodb, mysql ]"},{"line_number":155,"context_line":"ceilometer_database_type: \"mongodb\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"#######################"},{"line_number":158,"context_line":"# Cinder options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa7ab95a_16ca856d","line":155,"updated":"2016-08-28 17:24:40.000000000","message":"this should be commented out","commit_id":"d1a4f73f472a228414a49a1bd5f8e9a2d14488fd"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d5b2598b4f7331d425d93e3f5ea871bf38f88899","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# Ceilometer options"},{"line_number":153,"context_line":"#######################"},{"line_number":154,"context_line":"# Valid options are [ mongodb, mysql ]"},{"line_number":155,"context_line":"ceilometer_database_type: \"mongodb\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"#######################"},{"line_number":158,"context_line":"# Cinder options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa7ab95a_4f2d27fd","line":155,"in_reply_to":"fa7ab95a_16ca856d","updated":"2016-08-29 15:17:43.000000000","message":"Done","commit_id":"d1a4f73f472a228414a49a1bd5f8e9a2d14488fd"}]}