)]}'
{"ansible/roles/destroy/tasks/cleanup_host.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9439c15e86e5c11e7216129478c360f16113f9bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Destroying Kolla host configuration"},{"line_number":3,"context_line":"  command: env CONFIG_DIR\u003d{{ CONFIG_DIR }} enable_haproxy\u003d{{ enable_haproxy }} /tmp/kolla-cleanup/tools/cleanup-host"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Destroying kolla-cleanup folder"},{"line_number":6,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_89ff73a9","line":3,"updated":"2016-09-06 07:36:58.000000000","message":"You can get the kolla_internal_vip_address and interface and kolla_external_vip_address directly here. no need to parse the globals.yml file by using bash","commit_id":"3a9b05d9e260e05159a0df71ccfaf9d4dc50254b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"6a0856313706484bb55a16254eea7afac0ffe6a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Destroying Kolla host configuration"},{"line_number":3,"context_line":"  command: env CONFIG_DIR\u003d{{ CONFIG_DIR }} enable_haproxy\u003d{{ enable_haproxy }} /tmp/kolla-cleanup/tools/cleanup-host"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Destroying kolla-cleanup folder"},{"line_number":6,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_2aa57ab4","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":78},"updated":"2016-09-06 06:47:02.000000000","message":"why not using \"environment\" of ansible tasks here?","commit_id":"3a9b05d9e260e05159a0df71ccfaf9d4dc50254b"}],"tools/cleanup-host":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0243809607a9a335b23c8ae628b99c3a2c5c7b33","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Keepalived leaves VIP on the host in case of accidental removal."},{"line_number":31,"context_line":"# This snippet removes VIPs."},{"line_number":32,"context_line":"ip -o addr show | awk -F\u0027 \u0027 \u0027/eth/{print $2,$4}\u0027 | while read -r ifname_addr ; do"},{"line_number":33,"context_line":"    if echo \"$ifname_addr\" | grep \"/32\" \u003e /dev/null; then"},{"line_number":34,"context_line":"      echo \"Removing VIP $ifname_addr on the host\""},{"line_number":35,"context_line":"      ip addr delete dev $ifname_addr"},{"line_number":36,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_6507a71d","line":33,"updated":"2016-09-01 07:24:26.000000000","message":"this is not correct.\nnot all the \u0027/32\u0027 ip are vip.\n\nYou can use the ansible variable from globals.yml file. like {{ kolla_internal_vip_address }} and {{ kolla_external_vip_address }}","commit_id":"2e3e6dfdfaa9524523dea3a63a919b9da823e7eb"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"af2aa14ae6e8d82b84980e4bc3bdbe29f5069ddd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Keepalived leaves VIP on the host in case of accidental removal."},{"line_number":31,"context_line":"# This snippet removes VIPs."},{"line_number":32,"context_line":"ip -o addr show | awk -F\u0027 \u0027 \u0027/eth/{print $2,$4}\u0027 | while read -r ifname_addr ; do"},{"line_number":33,"context_line":"    if echo \"$ifname_addr\" | grep \"/32\" \u003e /dev/null; then"},{"line_number":34,"context_line":"      echo \"Removing VIP $ifname_addr on the host\""},{"line_number":35,"context_line":"      ip addr delete dev $ifname_addr"},{"line_number":36,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_0a606a00","line":33,"in_reply_to":"fa7ab95a_6507a71d","updated":"2016-09-02 04:18:12.000000000","message":"Agree with Jeffrey, you should use globals.yml file to get actual VIP address","commit_id":"2e3e6dfdfaa9524523dea3a63a919b9da823e7eb"}]}