)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"7d5ebfdffa5ca7c8050d02c5375836fe15cca4bc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch changes version of ceph from hammer to jewel. Also removed"},{"line_number":10,"context_line":"versionlock as it seems we don\u0027t use it in ubuntu, and actually might be"},{"line_number":11,"context_line":"risky if we miss security patch on ceph."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8f88c2f914a4b635e59a509fa0194605eb73165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_bb8b62c2","line":12,"updated":"2016-09-07 03:25:15.000000000","message":"how about a blueprint to go with it since we need to sort out upgrades prior to rc1 as well.","commit_id":"d8bcaabe8959b118b8a203bb61d6464331b6d930"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"37dcff801843c07b003011233d7081b99e29b1f7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch changes version of ceph from hammer to jewel. Also removed"},{"line_number":10,"context_line":"versionlock as it seems we don\u0027t use it in ubuntu, and actually might be"},{"line_number":11,"context_line":"risky if we miss security patch on ceph."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8f88c2f914a4b635e59a509fa0194605eb73165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_8e5ade28","line":12,"in_reply_to":"9a89bdaa_bb8b62c2","updated":"2016-09-07 03:36:33.000000000","message":"Done","commit_id":"d8bcaabe8959b118b8a203bb61d6464331b6d930"}],"ansible/roles/ceph/templates/ceph.conf.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"68b9fe7ee4fd7b7e41633ae30eb41cf45a94c6d6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"auth client required \u003d cephx"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(inc0): This line will mean that if ceph was upgraded, it will run as root"},{"line_number":18,"context_line":"              until contents of /var/lib/ceph will not be chowned to ceph user."},{"line_number":19,"context_line":"              This change was introduced in Jewel version and we should include"},{"line_number":20,"context_line":"              chown operation in upgrade procedure later on. Bug id 1620702"},{"line_number":21,"context_line":"setuser match path \u003d /var/lib/ceph/$type/$cluster-$id"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a89bdaa_d45539c2","line":18,"range":{"start_line":18,"start_character":46,"end_line":18,"end_character":65},"updated":"2016-09-07 13:29:44.000000000","message":"do you mean \"until the contents of /var/lib/ceph *are chowned* to the ceph user?","commit_id":"99a1a6a0f019f721e8d832d9bd9dfe01de5b9652"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3c3fb214252c94df792a753a84ba2a9cc5a1f9e4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# NOTE(inc0): This line will mean that if ceph was upgraded, it will run as root"},{"line_number":18,"context_line":"              until contents of /var/lib/ceph are chowned to ceph user."},{"line_number":19,"context_line":"              This change was introduced in Jewel version and we should include"},{"line_number":20,"context_line":"              chown operation in upgrade procedure later on. Bug id 1620702"},{"line_number":21,"context_line":"setuser match path \u003d /var/lib/ceph/$type/$cluster-$id"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[mon]"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9a89bdaa_dee506dc","line":20,"updated":"2016-09-08 17:26:58.000000000","message":"add # for each line here.\n\nin mitaka, the ceph is run as root. so should we still need add this?\n\nPlease change the `Bug id xxx` more specifiable. like https://bugs.launchpad.net/kolla/+bug/1620702 . for the first glance, i thought it is a bug no in ceph.","commit_id":"24a9048e56fc9c05a7e97b78774980ac96afc5ec"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8ece3431543f7fd265bbb34f5e256b5857bac65b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# NOTE(inc0): This line will mean that if ceph was upgraded, it will run as root"},{"line_number":18,"context_line":"              until contents of /var/lib/ceph are chowned to ceph user."},{"line_number":19,"context_line":"              This change was introduced in Jewel version and we should include"},{"line_number":20,"context_line":"              chown operation in upgrade procedure later on. Bug id 1620702"},{"line_number":21,"context_line":"setuser match path \u003d /var/lib/ceph/$type/$cluster-$id"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[mon]"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9a89bdaa_89af9493","line":20,"in_reply_to":"9a89bdaa_dee506dc","updated":"2016-09-09 14:31:03.000000000","message":"done, and no, Mitaka uses root but mitaka will stay Hammer. This is change introduced in Jewel","commit_id":"24a9048e56fc9c05a7e97b78774980ac96afc5ec"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"7d5ebfdffa5ca7c8050d02c5375836fe15cca4bc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \u0027yum-plugin-priorities\u0027,"},{"line_number":88,"context_line":"    \u0027centos-release-ceph-jewel\u0027,"},{"line_number":89,"context_line":"    \u0027centos-release-qemu-ev\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"] %}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"{{ macros.install_packages(base_centos_yum_repo_packages | customizable(\"yum_centos_repo_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a89bdaa_7b9d5a09","line":90,"updated":"2016-09-07 03:25:15.000000000","message":"unneeded whitespace","commit_id":"d8bcaabe8959b118b8a203bb61d6464331b6d930"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"37dcff801843c07b003011233d7081b99e29b1f7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    \u0027yum-plugin-priorities\u0027,"},{"line_number":88,"context_line":"    \u0027centos-release-ceph-jewel\u0027,"},{"line_number":89,"context_line":"    \u0027centos-release-qemu-ev\u0027"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"] %}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"{{ macros.install_packages(base_centos_yum_repo_packages | customizable(\"yum_centos_repo_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a89bdaa_6e559af8","line":90,"in_reply_to":"9a89bdaa_7b9d5a09","updated":"2016-09-07 03:36:33.000000000","message":"Done","commit_id":"d8bcaabe8959b118b8a203bb61d6464331b6d930"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3c3fb214252c94df792a753a84ba2a9cc5a1f9e4","unresolved":false,"context_lines":[{"line_number":157,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":158,"context_line":"    if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] #}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"{% block base_redhat_binary_versionlock %}"},{"line_number":161,"context_line":"RUN yum -y update \\"},{"line_number":162,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":163,"context_line":"           yum-plugin-versionlock \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9a89bdaa_fed2cacf","side":"PARENT","line":160,"updated":"2016-09-08 17:26:58.000000000","message":"could u still leave the block here?","commit_id":"682025c9e2fe834c697e96d219c54b70e641cbf8"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8ece3431543f7fd265bbb34f5e256b5857bac65b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":158,"context_line":"    if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] #}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"{% block base_redhat_binary_versionlock %}"},{"line_number":161,"context_line":"RUN yum -y update \\"},{"line_number":162,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":163,"context_line":"           yum-plugin-versionlock \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9a89bdaa_09aaa470","side":"PARENT","line":160,"in_reply_to":"9a89bdaa_fed2cacf","updated":"2016-09-09 14:31:03.000000000","message":"Done","commit_id":"682025c9e2fe834c697e96d219c54b70e641cbf8"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"038468403eb19a2d3ead1c20c0b07be2f8f41027","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":158,"context_line":"    if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] #}"},{"line_number":159,"context_line":"{% block base_redhat_binary_versionlock %}{% endblock %}"},{"line_number":160,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":161,"context_line":"{% set base_centos_binary_packages \u003d ["},{"line_number":162,"context_line":"        \u0027sudo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_49358cf5","line":159,"updated":"2016-09-09 14:36:53.000000000","message":"I disagree this block is still needed tbh. It was added so users could change or disable the functionality we provided. Now it\u0027s gone if users want to do this they can use the header block or elsewhere, there\u0027s no need for a specific empty block for this. Not a big deal though.","commit_id":"0a50cb8889f245bc89b49fbb2dacb9c02ded5f88"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"57515f13c831390548f9776b0afddf864f67f3ea","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":158,"context_line":"    if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] #}"},{"line_number":159,"context_line":"{% block base_redhat_binary_versionlock %}{% endblock %}"},{"line_number":160,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":161,"context_line":"{% set base_centos_binary_packages \u003d ["},{"line_number":162,"context_line":"        \u0027sudo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_90817450","line":159,"in_reply_to":"9a89bdaa_49358cf5","updated":"2016-09-09 14:51:08.000000000","message":"ok. make sense.\nAnd yes. this  is not a big deal. I am OK to remain it or remove it.","commit_id":"0a50cb8889f245bc89b49fbb2dacb9c02ded5f88"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"15d47c54ede988d4fbf72a21c6062e852bb2ab35","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"{# We are back to the basic if conditional here which is:"},{"line_number":158,"context_line":"    if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] #}"},{"line_number":159,"context_line":"{% block base_redhat_binary_versionlock %}{% endblock %}"},{"line_number":160,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":161,"context_line":"{% set base_centos_binary_packages \u003d ["},{"line_number":162,"context_line":"        \u0027sudo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a89bdaa_b03bd89b","line":159,"in_reply_to":"9a89bdaa_90817450","updated":"2016-09-09 14:52:15.000000000","message":"There is no hurt in keeping it, and actually if makes sense if someone would like to lock some versions right?:) We can safely keep it imho, may actually be useful for someone.","commit_id":"0a50cb8889f245bc89b49fbb2dacb9c02ded5f88"}],"tools/setup_gate.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3c3fb214252c94df792a753a84ba2a9cc5a1f9e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # Optimize the repos to take advantage of the Infra provided mirrors for Ubuntu"},{"line_number":49,"context_line":"        sed -i \u0027s|^#apt_sources_list.*|apt_sources_list \u003d /etc/kolla/sources.list|\u0027 /etc/kolla/kolla-build.conf"},{"line_number":50,"context_line":"        sudo cp /etc/apt/sources.list /etc/kolla/sources.list"},{"line_number":51,"context_line":"        sudo cat /etc/apt/sources.list.available.d/ceph-deb-jewel.list | sudo tee -a /etc/kolla/sources.list"},{"line_number":52,"context_line":"        sudo cat /etc/apt/sources.list.available.d/ubuntu-cloud-archive.list | sudo tee -a /etc/kolla/sources.list"},{"line_number":53,"context_line":"        # Append non-infra provided repos to list"},{"line_number":54,"context_line":"        cat \u003c\u003c EOF | sudo tee -a /etc/kolla/sources.list"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9a89bdaa_41703b72","line":51,"updated":"2016-09-08 17:26:58.000000000","message":"This file do not exist.\n\nhttps://github.com/openstack-infra/project-config/blob/master/nodepool/scripts/configure_mirror.sh","commit_id":"24a9048e56fc9c05a7e97b78774980ac96afc5ec"}]}