)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"030448f9575338ffec93e1f2fa59955f08fd2ca5","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_74c25b54","line":363,"updated":"2016-09-08 17:51:12.000000000","message":"how the end-user know the valid value?\nwhat\u0027s the possible value? why not use boolean value?\n\n{% if manila_dhss \u003d\u003d \"True\" %}\ndriver_handles_share_servers \u003d True\n{% elif manila_dhss \u003d\u003d \"False\" %}\ndriver_handles_share_servers \u003d False\n{% endif %}\n\n\nthis is redundancy.\n\nwhy not try to use \n\ndriver_handles_share_servers \u003d {% \u0027True\u0027 if xxx|bool elese \u0027False %}","commit_id":"dab13c4442efdff6c19423fed27a7239b53c3055"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b2911bc1f2fbeac778cc78034f6b2ff323407e73","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_29eb9114","line":363,"updated":"2016-09-07 00:57:28.000000000","message":"why the old config do not work? if you config the manila_enable_dhss to yes, the manila_dhss is \u0027True\u0027.","commit_id":"dab13c4442efdff6c19423fed27a7239b53c3055"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"32b531f293204169cfecf20da636a1c365e8d371","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_e6c97c27","line":363,"in_reply_to":"9a89bdaa_29eb9114","updated":"2016-09-08 11:53:44.000000000","message":"Hi Jeffrey, I did it, but after deploy i get this error.\nManilaException: Config opt \u0027driver_handles_share_servers\u0027 has improper value - \u0027None\u0027","commit_id":"dab13c4442efdff6c19423fed27a7239b53c3055"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b225e06c1080a9e1561db294d13eaf43718e9d89","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_fd8b2c66","line":363,"in_reply_to":"9a89bdaa_4a9ae7c6","updated":"2016-09-12 13:43:53.000000000","message":"Jeffrey is right, you can use {{ \u0027True\u0027 if xxx|bool else \u0027False\u0027 }}, but with double {{ instead of {%","commit_id":"dab13c4442efdff6c19423fed27a7239b53c3055"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"b96aa0bded4b3cf644e13e4483151259647a4bec","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_4a9ae7c6","line":363,"in_reply_to":"9a89bdaa_74c25b54","updated":"2016-09-09 11:48:41.000000000","message":"how the end-user know the valid value?\n-\u003e https://review.openstack.org/#/c/366247/2/etc/kolla/globals.yml\n\nwhy not use boolean value?\n-\u003e Because I get this error\n\"ManilaException: Config opt \u0027driver_handles_share_servers\u0027 has improper value - \u0027None\u0027\"\n\nwhy not try to use \ndriver_handles_share_servers \u003d {% \u0027True\u0027 if xxx|bool elese \u0027False %}\n\n-\u003e Because I get this error\n\"ManilaException: Config opt \u0027driver_handles_share_servers\u0027 has improper value - \u0027None\u0027\"","commit_id":"dab13c4442efdff6c19423fed27a7239b53c3055"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"16a3e97e4df743b469c88ad4dc40c0609cfdc982","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_581d0161","line":363,"in_reply_to":"9a89bdaa_fd8b2c66","updated":"2016-09-12 14:58:32.000000000","message":"No, it doesn\u0027t work.","commit_id":"dab13c4442efdff6c19423fed27a7239b53c3055"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"1ea2e89d44eea95de51983084b0786706fb346fb","unresolved":false,"context_lines":[{"line_number":360,"context_line":"#######################################"},{"line_number":361,"context_line":"# Manila - Shared File Systems Options"},{"line_number":362,"context_line":"#######################################"},{"line_number":363,"context_line":"manila_dhss: \"True\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a89bdaa_ecd9b2f4","line":363,"updated":"2016-09-12 17:36:31.000000000","message":"To follow the variable names used for neutron i think it makes sense to use enable_manila_dhss as variable name.","commit_id":"82347c0c730609e3e7d9a87ca2262b3bd4df6c7f"}]}