)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15492,"name":"Robin Naundorf","email":"r.naundorf@fh-muenster.de","username":"senk"},"change_message_id":"8f78d145d55e9d383a1dc08c25ea99626489114a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dupengfei \u003c58750307@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-14 14:15:05 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make common paras graceful and modify some writen bugs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Define database_address_port instead of *_database_address,"},{"line_number":10,"context_line":"define memcached_servers at all.yml."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_0b21c9fb","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":17},"updated":"2016-09-14 09:38:37.000000000","message":"paras? please write it out","commit_id":"bc112825d020e408ec3f23305537b6eee5100169"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"_transport_url_ansible \u003d \"rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":388,"context_line":"_transport_url_k8s \u003d \"rabbit://{{ rabbitmq_user }}:{{ rabbitmq_password }}@rabbitmq:{{ rabbitmq_port }}\""},{"line_number":389,"context_line":"transport_url \u003d \"{{ _transport_url_ansible if orchestration_engine \u003d\u003d \u0027ANSIBLE\u0027 else _transport_url_k8s }}\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"_auth_uri_ansible \u003d \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}\""},{"line_number":392,"context_line":"_auth_uri_k8s \u003d \"{{ keystone_internal_url }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_c9b9b430","line":389,"updated":"2016-09-14 07:10:56.000000000","message":"For the same rationale as flexibility for overridding multiple databases, we want the same flexibility for overridding multiple transports.  I understand the objective, but it doesn\u0027t fit in with our scalability plans.","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"_auth_uri_ansible \u003d \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}\""},{"line_number":392,"context_line":"_auth_uri_k8s \u003d \"{{ keystone_internal_url }}\""},{"line_number":393,"context_line":"auth_uri \u003d \"{{ _auth_uri_ansible if orchestration_engine \u003d\u003d \u0027ANSIBLE\u0027 else _auth_uri_k8s }}\""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"_auth_url_ansible \u003d \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}\""},{"line_number":396,"context_line":"_auth_url_k8s \u003d \"{{ keystone_admin_url }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_c96294d8","line":393,"updated":"2016-09-14 07:10:56.000000000","message":"I\u0027ll have to think more deeply about this one.  We may need per service auth overrides, or we may not.  Paul, any feedback?\n\nMy main concern is the elimination of the option for achieving multi-region.  I know authentication is involved there in a special way and I\u0027m just not sure either way if a global would eliminate the ability to execute multi-region.","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"_memcached_servers_ansible \u003d \"{% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":400,"context_line":"_memcache_servers_k8s \u003d \"memcached\""},{"line_number":401,"context_line":"memcache_servers \u003d \"{{ _memcached_servers_ansible if orchestration_engine \u003d\u003d \u0027ANSIBLE\u0027 else _memcache_servers_k8s }}\""},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"_database_address_port_ansible: \"{{ kolla_internal_fqdn }}:{{ database_port }}\""},{"line_number":404,"context_line":"_database_address_port_k8s: \"mariadb:{{ database_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_a9c1c882","line":401,"updated":"2016-09-14 07:10:56.000000000","message":"this part seems like a no-brainer to accept to me.  Paul thoughts?\n\nAlso we need to abstract this nonsense:\nhostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] to enable IPV6.  That is probably orthogonal to what your after with getting kubernetes going in your environment, but it needs to be done and would get my +2.","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"_database_address_port_ansible: \"{{ kolla_internal_fqdn }}:{{ database_port }}\""},{"line_number":404,"context_line":"_database_address_port_k8s: \"mariadb:{{ database_port }}\""},{"line_number":405,"context_line":"database_address_port \u003d \"{{ _database_address_port_ansible if orchestration_engine \u003d\u003d \u0027ANSIBLE\u0027 else _database_address_port_k8s }}\""},{"line_number":406,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_c990d498","line":405,"updated":"2016-09-14 07:10:56.000000000","message":"see note on database overrides in different part of the review.","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"}],"ansible/roles/horizon/templates/local_settings.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":147,"context_line":"CACHES \u003d {"},{"line_number":148,"context_line":"    \u0027default\u0027: {"},{"line_number":149,"context_line":"        \u0027BACKEND\u0027: \u0027django.core.cache.backends.memcached.MemcachedCache\u0027,"},{"line_number":150,"context_line":"        \u0027LOCATION\u0027: \u0027{{ memcache_servers }}\u0027"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"}"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_c91d3468","line":150,"updated":"2016-09-14 07:10:56.000000000","message":"I like the concept of a memcache_servers global rather then copying it all over the codebase as we do today","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":71,"context_line":"root_helper \u003d sudo neutron-rootwrap /etc/neutron/rootwrap.conf"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"[database]"},{"line_number":74,"context_line":"connection \u003d mysql+pymysql://{{ neutron_database_user }}:{{ neutron_database_password }}@{{ database_address_port }}/{{ neutron_database_name }}"},{"line_number":75,"context_line":"max_retries \u003d -1"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"[keystone_authtoken]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_f67e4fad","line":74,"updated":"2016-09-14 07:10:56.000000000","message":"we want to keep the flexibility to enable per-service databases, and this particular change eliminates that flexibility by changing neutron_database_address to database_address_port.  This locks us into one database server, which is not suitable for our future roadmap.","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a235efc526f1fe7917dc5372c00edd62df1ad7ef","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":88,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":89,"context_line":"memcached_servers \u003d {{ memcache_servers }}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[oslo_messaging_notifications]"},{"line_number":92,"context_line":"{% if enable_ceilometer | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_76d6bfc6","line":89,"updated":"2016-09-14 07:10:56.000000000","message":"memcache servers seems like something that can be global and doesn\u0027t need specific overriding","commit_id":"9f21a23da38e3a9ded9b49896236e1fee7feea66"}]}
