)]}'
{"docker/ironic/ironic-inspector/Dockerfile.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"b2c08e66799cd13f59ceb9d3d2dbffe578578082","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"        RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":11,"context_line":"        ironic-inspector"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_44579725","line":10,"updated":"2016-09-13 16:12:57.000000000","message":"This wont work indented","commit_id":"5a3275df1c3fabcd0d21282dec1e65ad43cfaa29"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"b2c08e66799cd13f59ceb9d3d2dbffe578578082","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":"    RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":17,"context_line":"    ironic-inspector"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_6452db36","line":16,"updated":"2016-09-13 16:12:57.000000000","message":"same","commit_id":"5a3275df1c3fabcd0d21282dec1e65ad43cfaa29"},{"author":{"_account_id":14287,"name":"Waldemar Znoinski","email":"wznoinsk@redhat.com","username":"wznoinsk"},"change_message_id":"fd457fea99926f0747e303695aac9ce7501a8cec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":"    RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":17,"context_line":"    ironic-inspector"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_fa220051","line":16,"in_reply_to":"9a89bdaa_6452db36","updated":"2016-09-13 16:37:21.000000000","message":"this one was run and tested fine but I\u0027ll change these","commit_id":"5a3275df1c3fabcd0d21282dec1e65ad43cfaa29"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"42cfd6209d4f361d92f1ea3dee083b2f70c26b5b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":11,"context_line":"    ironic-inspector"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7a8ec9b2_53cba672","line":10,"updated":"2016-09-13 19:52:19.000000000","message":"if ubuntu binary doesn\u0027t have packages, then it doesn\u0027t support this feature.  If ubuntu packages ironic-inspector, we can always add this prior to newton.\n\nFor now can you remove it?  Mixing source with binary dependencies doesn\u0027t work properly (although) it may appear so).\n\nThanks\n-steve","commit_id":"8953ae3a412223759bbf2d5427a257443fd0e7b0"},{"author":{"_account_id":14287,"name":"Waldemar Znoinski","email":"wznoinsk@redhat.com","username":"wznoinsk"},"change_message_id":"8fbf000fc7e04217c44470bf8377645603789798","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":11,"context_line":"    ironic-inspector"},{"line_number":12,"context_line":"    {% endif %}"},{"line_number":13,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7a8ec9b2_059458e0","line":10,"in_reply_to":"7a8ec9b2_53cba672","updated":"2016-09-14 09:10:14.000000000","message":"Done","commit_id":"8953ae3a412223759bbf2d5427a257443fd0e7b0"},{"author":{"_account_id":14287,"name":"Waldemar Znoinski","email":"wznoinsk@redhat.com","username":"wznoinsk"},"change_message_id":"1d0d14a8d6f4d806bbd78ac4da20f3980506b65b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7a8ec9b2_6fd3a704","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"updated":"2016-09-16 13:55:38.000000000","message":"looks like it\u0027s now available\nhttp://packages.ubuntu.com/search?keywords\u003dironic-inspector\u0026searchon\u003dnames","commit_id":"17ffbfed3f1387e5dac32f1957bd9ef1fe3c2f16"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"3a7ece6c3356b7b4811ade6bbf22b67e787d99cc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":14,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":15,"context_line":"    ironic-inspector"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7a8ec9b2_c457c000","line":14,"updated":"2016-09-14 13:31:39.000000000","message":"Sorry I should have mentioned this the first time but - this seems non standard. Does the ironic source install in ironic-base not provide ironic-inspector?","commit_id":"17ffbfed3f1387e5dac32f1957bd9ef1fe3c2f16"},{"author":{"_account_id":14287,"name":"Waldemar Znoinski","email":"wznoinsk@redhat.com","username":"wznoinsk"},"change_message_id":"1d0d14a8d6f4d806bbd78ac4da20f3980506b65b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":14,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":15,"context_line":"    ironic-inspector"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7a8ec9b2_ad5efbe6","line":14,"in_reply_to":"7a8ec9b2_c457c000","updated":"2016-09-16 13:55:38.000000000","message":"it does not hence it\u0027s only installed in ironic-inspector image (this file), see line 8 above\n\nironic-base container, when installed binary, provides \u0027openstack-ironic-common\u0027 package on centos/fedora/oreaclelinux/rhel: https://www.rpmfind.net/linux/RPM/fedora/updates/23/armhfp/o/openstack-ironic-common-2015.1.3-1.fc23.noarch.html\n\nwhich depends on many python-utils and modules and installs ironic api, conductor, db and command line clients for the above (not inspector)\n\nand \u0027ironic-common\u0027 package on ubuntu\nhttp://packages.ubuntu.com/xenial/all/ironic-common/filelist\n\nwhich provides only a few configuration/sudoers/filters files (no daemons or service whatsoever) and does _not_ have inspector as one of its dependencies\n\nAnd in source type of installation (on any distro) pip installing requirements for ironic (https://github.com/openstack/ironic/blob/master/requirements.txt) does not include inspector either","commit_id":"17ffbfed3f1387e5dac32f1957bd9ef1fe3c2f16"}]}