)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"950936ac95f122a355919a7a30a99696a0ee16e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use \"type\" to take place of \"which\" and update the output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When run tools/init-runonce without opoenstackclient installed,it"},{"line_number":10,"context_line":"will retrun \"openstack not installed\", which not friendly and confuse"},{"line_number":11,"context_line":"people，this patch update it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a8ec9b2_22c14de5","line":9,"updated":"2016-09-14 08:12:02.000000000","message":"nit: missing space","commit_id":"0f4d21c7e1d5f56d7eb4f7706a64be391cd94bd6"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"950936ac95f122a355919a7a30a99696a0ee16e7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use \"type\" to take place of \"which\" and update the output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When run tools/init-runonce without opoenstackclient installed,it"},{"line_number":10,"context_line":"will retrun \"openstack not installed\", which not friendly and confuse"},{"line_number":11,"context_line":"people，this patch update it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Use \"type\" command to avoid \"which\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a8ec9b2_42b6598b","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":11},"updated":"2016-09-14 08:12:02.000000000","message":"nit: typo","commit_id":"0f4d21c7e1d5f56d7eb4f7706a64be391cd94bd6"}],"tools/init-runonce":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d51e03edd844a73dc86586b1a822cc7938ba6ea3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"LC_ALL\u003dC"},{"line_number":13,"context_line":"export LC_ALL"},{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(which $i) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_bf55cafa","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":19},"updated":"2016-09-13 16:16:53.000000000","message":"Please avoid use of \u0027which\u0027 (http://stackoverflow.com/a/677212/663370)","commit_id":"a0687aeb6eef568ed0084540350410b85e82449a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8a084699d04bb7057a6c18f2c2d7cdef4ae1f72f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"export LC_ALL"},{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a8ec9b2_0c63aa1b","line":16,"updated":"2016-09-14 07:33:04.000000000","message":"Why is it necessary to check for openstack here?","commit_id":"45b786f6f306d425f7a54722654b80e156fc60e8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8a084699d04bb7057a6c18f2c2d7cdef4ae1f72f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"},{"line_number":20,"context_line":"            echo \"$i not installed. Please install $i before proceeding\""},{"line_number":21,"context_line":"            exit 1"},{"line_number":22,"context_line":"        fi"},{"line_number":23,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a8ec9b2_4c6db203","line":20,"updated":"2016-09-14 07:33:04.000000000","message":"This output should be sufficient.","commit_id":"45b786f6f306d425f7a54722654b80e156fc60e8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"fa2447ac3adf4982c7857c4871b0b687d2d49f09","unresolved":false,"context_lines":[{"line_number":13,"context_line":"export LC_ALL"},{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a8ec9b2_387c2072","line":16,"updated":"2016-09-14 08:31:03.000000000","message":"Why is this necessary?","commit_id":"203515aa3647485623fafb049e7cc97000420bb1"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"1f7555131de4bc23ac2bcfe65faa751e5091cc1e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"export LC_ALL"},{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a8ec9b2_5371a3df","line":16,"updated":"2016-09-14 18:27:58.000000000","message":"exactly same thing is with nova:) python-novaclient is correct package and so on. In fact pip install nova will install nova service so it\u0027s wrong","commit_id":"203515aa3647485623fafb049e7cc97000420bb1"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d5d7e9f5f960d6415bc712bdd077ff55e6aec508","unresolved":false,"context_lines":[{"line_number":13,"context_line":"export LC_ALL"},{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a8ec9b2_39adf1e9","line":16,"in_reply_to":"7a8ec9b2_387c2072","updated":"2016-09-14 13:18:11.000000000","message":"I think it\u0027s because without it will echo \"Please install openstack ...\" where it needs to say \"Please install python-openstack ...\"","commit_id":"203515aa3647485623fafb049e7cc97000420bb1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d3789d9b8d90f87414f7d9ce2679928a09068d65","unresolved":false,"context_lines":[{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"},{"line_number":20,"context_line":"            echo \"$i not installed. Please install $i before proceeding\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a8ec9b2_44dc69e4","line":17,"updated":"2016-09-15 02:32:00.000000000","message":"nova and neutron has the same issue\n\nnova not installed\nneutron not installed.","commit_id":"cf2484e88bd861286d8324845bc60174154a6c35"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"1d74459390fbc4db19d0049a5f16e57e74d7a7dc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ $i \u003d\u003d openstack ]; then"},{"line_number":17,"context_line":"            echo \"python-openstackclient not installed. Please install python-openstackclient before proceeding\""},{"line_number":18,"context_line":"            exit 1"},{"line_number":19,"context_line":"        else:"},{"line_number":20,"context_line":"            echo \"$i not installed. Please install $i before proceeding\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a8ec9b2_a1cb51a4","line":17,"in_reply_to":"7a8ec9b2_44dc69e4","updated":"2016-09-15 09:43:41.000000000","message":"Yes, I think it is fine to output: python-${i}client no install. Please install python-${i}client before proceeding.","commit_id":"cf2484e88bd861286d8324845bc60174154a6c35"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"5698c58427a5cc74810eafd12b8ac4c2dec0d027","unresolved":false,"context_lines":[{"line_number":11,"context_line":"unset LANGUAGE"},{"line_number":12,"context_line":"LC_ALL\u003dC"},{"line_number":13,"context_line":"export LC_ALL"},{"line_number":14,"context_line":"for i in curl nova neutron openstack; do"},{"line_number":15,"context_line":"    if [[ ! $(type $i 2\u003e/dev/null) ]]; then"},{"line_number":16,"context_line":"        if [ \"$i\" \u003d\u003d \u0027curl\u0027 ]; then"},{"line_number":17,"context_line":"            echo \"$i not installed. Please install $i before proceeding\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7a8ec9b2_b980baf8","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":18},"updated":"2016-09-16 04:11:20.000000000","message":"do we need novaclient and neutronclient installed separately if we are installing openstackclient?","commit_id":"d48cc50e9e56fac2d6cad6cf13cf37746014441a"}]}