)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"2a3a796dd2f81983c9fa013a12609dce5f8d453c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When run tools/init-runonce without Keystone credentials specified,"},{"line_number":10,"context_line":"it will source the openrc file automatic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I940e3c531a10b7b7e39ad857a6489c46f65549b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_55858e57","line":11,"updated":"2016-09-16 18:47:10.000000000","message":"Add bug id or TrivialFix","commit_id":"3472830583f94a02e7e16a121e22f02a3eea8a41"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f10a1a0d658c52f4b23ef37927955607a94cee1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     caoyuan \u003ccao.yuan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-17 07:02:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source the openrc file automatic when run tools/init-runonce"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When run tools/init-runonce without Keystone credentials specified,"},{"line_number":10,"context_line":"it will source the openrc file automatic."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_e76329af","line":7,"updated":"2016-09-19 04:19:21.000000000","message":"run -\u003e running","commit_id":"b3c8f1e4fd08bb888e3a8197a4e6cf174e5eb2e6"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f10a1a0d658c52f4b23ef37927955607a94cee1d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Source the openrc file automatic when run tools/init-runonce"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When run tools/init-runonce without Keystone credentials specified,"},{"line_number":10,"context_line":"it will source the openrc file automatic."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_6770f972","line":10,"updated":"2016-09-19 04:19:21.000000000","message":"automatically","commit_id":"b3c8f1e4fd08bb888e3a8197a4e6cf174e5eb2e6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"e3d4f037a4296f262d6ccf4297234e6f122ef056","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     caoyuan \u003ccao.yuan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-19 12:55:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source the openrc file automatically when running tools/init-runonce"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When run tools/init-runonce without Keystone credentials specified,"},{"line_number":10,"context_line":"it will source the openrc file automatically."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8ec9b2_25e6e9e7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":68},"updated":"2016-09-19 06:48:03.000000000","message":"good commit，please add bug.\nclose #bug","commit_id":"914f515fda0fa11bcecf47626ddffd322e7139ad"}],"tools/init-runonce":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f10a1a0d658c52f4b23ef37927955607a94cee1d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Test for credentials set, if no Keystone credentials specified. source it."},{"line_number":31,"context_line":"if [[ \"${OS_USERNAME}\" \u003d\u003d \"\" ]]; then"},{"line_number":32,"context_line":"    echo \"No Keystone credentials specified. running source openrc now\""},{"line_number":33,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":34,"context_line":"    echo \"source openrc complete\""},{"line_number":35,"context_line":"fi"},{"line_number":36,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a8ec9b2_6749d930","line":33,"updated":"2016-09-19 04:19:21.000000000","message":"what if /etc/kolla/admin-openrc.sh does not exist? The error message may include \"run post-run.yml\".","commit_id":"b3c8f1e4fd08bb888e3a8197a4e6cf174e5eb2e6"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e981f1843ca555761eefb72811d48225e667a892","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Test for credentials set, if no Keystone credentials specified. source it."},{"line_number":31,"context_line":"if [[ \"${OS_USERNAME}\" \u003d\u003d \"\" ]]; then"},{"line_number":32,"context_line":"    echo \"No Keystone credentials specified. running source openrc now\""},{"line_number":33,"context_line":"    if [ ! -f \"/etc/kolla/admin-openrc.sh\" ];then"},{"line_number":34,"context_line":"        echo \"Admin openrc file does not exist, creating it automatically\""},{"line_number":35,"context_line":"        kolla-ansible post-deploy"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a8ec9b2_b8285f87","line":32,"range":{"start_line":32,"start_character":45,"end_line":32,"end_character":46},"updated":"2016-09-19 08:25:31.000000000","message":"nit: R","commit_id":"914f515fda0fa11bcecf47626ddffd322e7139ad"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e981f1843ca555761eefb72811d48225e667a892","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Test for credentials set, if no Keystone credentials specified. source it."},{"line_number":31,"context_line":"if [[ \"${OS_USERNAME}\" \u003d\u003d \"\" ]]; then"},{"line_number":32,"context_line":"    echo \"No Keystone credentials specified. running source openrc now\""},{"line_number":33,"context_line":"    if [ ! -f \"/etc/kolla/admin-openrc.sh\" ];then"},{"line_number":34,"context_line":"        echo \"Admin openrc file does not exist, creating it automatically\""},{"line_number":35,"context_line":"        kolla-ansible post-deploy"},{"line_number":36,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a8ec9b2_781c176a","line":33,"updated":"2016-09-19 08:25:31.000000000","message":"nit: missing space","commit_id":"914f515fda0fa11bcecf47626ddffd322e7139ad"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e981f1843ca555761eefb72811d48225e667a892","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    echo \"No Keystone credentials specified. running source openrc now\""},{"line_number":33,"context_line":"    if [ ! -f \"/etc/kolla/admin-openrc.sh\" ];then"},{"line_number":34,"context_line":"        echo \"Admin openrc file does not exist, creating it automatically\""},{"line_number":35,"context_line":"        kolla-ansible post-deploy"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":38,"context_line":"    echo \"Source openrc complete\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a8ec9b2_98b3a34c","line":35,"updated":"2016-09-19 08:25:31.000000000","message":"This is not future safe. At the moment post-deploy only generates the admin openrc. In the future maybe we will add more post deploy tasks. I think it would be better to add a tag to the admin openrc task and to use this tag here.","commit_id":"914f515fda0fa11bcecf47626ddffd322e7139ad"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"11852a96b8cb1c86cc4d94e2e5a02b4202c6fd39","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    echo \"No Keystone credentials specified. Running source openrc now\""},{"line_number":33,"context_line":"    if [ ! -f \"/etc/kolla/admin-openrc.sh\" ]; then"},{"line_number":34,"context_line":"        echo \"Admin openrc file does not exist, creating it automatically\""},{"line_number":35,"context_line":"        kolla-ansible post-deploy"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":38,"context_line":"    echo \"Source openrc complete\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a8ec9b2_c599a9d2","line":35,"updated":"2016-09-19 14:10:49.000000000","message":"This wont work if using the development flow where \u0027pip install kolla\u0027 has not being run. It will also fail badly if a user happens to run without a successful deploy. I would suggest not running automatically.","commit_id":"e138488213e5d591d6e302b23e11be748537c047"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"253f4d34062e497c02c48ebcbc6589106afb8435","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    if [ ! -f \"/etc/kolla/admin-openrc.sh\" ]; then"},{"line_number":34,"context_line":"        echo \"Admin openrc file does not exist, creating it automatically\""},{"line_number":35,"context_line":"        kolla-ansible post-deploy"},{"line_number":36,"context_line":"    fi"},{"line_number":37,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":38,"context_line":"    echo \"Source openrc complete\""},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a8ec9b2_2c57ad58","line":36,"updated":"2016-09-19 09:36:35.000000000","message":"we should double check  if [ ! -f \"/etc/kolla/admin-openrc.sh\" ] to cross check if kolla-ansible post-deploy command is successfully executed, other wise in fail condition also, the last echo will print echo \"Source openrc complete\", which can create confusion to the end user.","commit_id":"e138488213e5d591d6e302b23e11be748537c047"}]}