)]}'
{"docker/freezer/freezer-api/Dockerfile.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"c7ad6ffdd54a5f0a7378c0b5de7119c979ff1f51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":18,"context_line":"            \u0027httpd\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"{{ macros.install_packages(freezer_api_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":22,"context_line":"        {% set freezer_api_packages \u003d ["},{"line_number":23,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5a8bc5a2_ea6ad719","line":20,"updated":"2016-09-22 15:30:18.000000000","message":"You should be able to remove this line and move the one below down to line 28","commit_id":"beea5bbd49fcfecb591ca386c4f8633269288cdc"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd24b3c91c2f346499385c2ad8b1526d6a71fbef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":18,"context_line":"            \u0027httpd\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"{{ macros.install_packages(freezer_api_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":22,"context_line":"        {% set freezer_api_packages \u003d ["},{"line_number":23,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5a8bc5a2_d5f940ca","line":20,"in_reply_to":"5a8bc5a2_ea6ad719","updated":"2016-09-22 15:39:30.000000000","message":"Agree. Both macros install can be moved to line 28","commit_id":"beea5bbd49fcfecb591ca386c4f8633269288cdc"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"c7ad6ffdd54a5f0a7378c0b5de7119c979ff1f51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a8bc5a2_aabb6f71","line":41,"updated":"2016-09-22 15:30:18.000000000","message":"Can freezer run as non root? If so please look at adding USER entries to these files","commit_id":"beea5bbd49fcfecb591ca386c4f8633269288cdc"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"        {% set freezer_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":18,"context_line":"            \u0027httpd\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_9b7b6829","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":44},"updated":"2016-11-05 17:48:07.000000000","message":"Fedora support has been removed.","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":18,"context_line":"            \u0027httpd\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"{{ macros.install_packages(freezer_api_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":"RUN sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":22,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":23,"context_line":"        {% set freezer_api_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_bb782c2d","line":20,"updated":"2016-11-05 17:48:07.000000000","message":"Please, add a line between.","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027httpd\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"{{ macros.install_packages(freezer_api_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":"RUN sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":22,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":23,"context_line":"        {% set freezer_api_packages \u003d ["},{"line_number":24,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_1b875813","line":21,"updated":"2016-11-05 17:48:07.000000000","message":"ditto","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"{{ macros.install_packages(freezer_api_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":"RUN sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":22,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":23,"context_line":"        {% set freezer_api_packages \u003d ["},{"line_number":24,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"},{"line_number":25,"context_line":"            \u0027apache2\u0027"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_3b8c1c35","line":22,"updated":"2016-11-05 17:48:07.000000000","message":"ditto","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"},{"line_number":25,"context_line":"            \u0027apache2\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":"{{ macros.install_packages(freezer_api_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_5b81d0fa","line":27,"updated":"2016-11-05 17:48:07.000000000","message":"Ditto","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"RUN chmod 755 /usr/local/bin/kolla_freezer_extend_start"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{% block freezer_api_footer %}{% endblock %}"},{"line_number":42,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_1bb598cf","line":42,"updated":"2016-11-05 17:48:07.000000000","message":"Missing include footer","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba5da102_3bba5cc1","line":43,"updated":"2016-11-05 17:48:07.000000000","message":"Which user will run freezer? usually here RUN freezer","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3943cff4cd0810d51ef10823e5054abd0d338c13","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% block freezer_api_footer %}{% endblock %}"},{"line_number":46,"context_line":"{% block footer %}{% endblock %}"},{"line_number":47,"context_line":"{{ include_footer }}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"USER freezer"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ba5da102_0c3ab9cd","line":47,"updated":"2016-11-06 21:05:24.000000000","message":"looks good - glad folks finally starting to pick up on this hard part :).  We ought to make this whole block a macro to make the programming model easier.","commit_id":"51663a7c310a6d793fd943096c32f0b73130a11d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3943cff4cd0810d51ef10823e5054abd0d338c13","unresolved":false,"context_lines":[{"line_number":46,"context_line":"{% block footer %}{% endblock %}"},{"line_number":47,"context_line":"{{ include_footer }}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"USER freezer"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ba5da102_4c34b1dd","line":49,"updated":"2016-11-06 21:05:24.000000000","message":"you don\u0027t need USER in apache applications.  Apache drops root instead.  That said, I don\u0027t know a whole lot about freezer, so I\u0027ll leave it as is and it can be addressed in a follow-on review if it needs to be removed.","commit_id":"51663a7c310a6d793fd943096c32f0b73130a11d"}],"docker/freezer/freezer-api/extend_start.sh":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bd24b3c91c2f346499385c2ad8b1526d6a71fbef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    freezer-manage db update"},{"line_number":7,"context_line":"    freezer-manage db show"},{"line_number":8,"context_line":"    exit 0"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a8bc5a2_d57ce022","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":26},"updated":"2016-09-22 15:39:30.000000000","message":"Show is necessary or do any other action that showing?","commit_id":"beea5bbd49fcfecb591ca386c4f8633269288cdc"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"0c352d853d00fac4182d0d1388a3f542132d303d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    freezer-manage db update"},{"line_number":7,"context_line":"    freezer-manage db show"},{"line_number":8,"context_line":"    exit 0"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba5da102_5e7348e7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":26},"updated":"2016-10-31 11:45:41.000000000","message":"why you use db show?","commit_id":"ade9de357143a53690b7ee10b184633358959da6"}],"docker/freezer/freezer-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_freezer_extend_start \\"},{"line_number":32,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_freezer_extend_start"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block freezer_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5da102_3b933c51","line":34,"updated":"2016-11-05 17:48:07.000000000","message":"block footer missing","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"}],"docker/freezer/freezer-base/extend_start.sh":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"c7ad6ffdd54a5f0a7378c0b5de7119c979ff1f51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Create log dir for Barbican logs"},{"line_number":4,"context_line":"LOG_DIR\u003d\"/var/log/kolla/freezer\""},{"line_number":5,"context_line":"if [[ ! -d \"${LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p ${LOG_DIR}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a8bc5a2_8a123361","line":3,"range":{"start_line":3,"start_character":21,"end_line":3,"end_character":29},"updated":"2016-09-22 15:30:18.000000000","message":"freezer","commit_id":"beea5bbd49fcfecb591ca386c4f8633269288cdc"}],"docker/freezer/freezer-base/freezer_sudoers":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"32fe94b16ecccf7fde6bee0585f9965c39909111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba5da102_139f54b5","updated":"2016-11-04 14:52:49.000000000","message":"Please add a \"kolla_\" prefix to this file, see https://review.openstack.org/#/c/393603/","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"}],"tests/test_build.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                       \"congress-base\","},{"line_number":76,"context_line":"                       \"bifrost-base\","},{"line_number":77,"context_line":"                       \"cloudkitty-base\","},{"line_number":78,"context_line":"                       \"freezer\"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def setUp(self):"},{"line_number":81,"context_line":"        super(BuildTestCentosBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_7b9db458","line":78,"range":{"start_line":78,"start_character":24,"end_line":78,"end_character":31},"updated":"2016-11-05 17:48:07.000000000","message":"freezer-base","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                       \"congress-base\","},{"line_number":104,"context_line":"                       \"bifrost-base\","},{"line_number":105,"context_line":"                       \"cloudkitty-base\","},{"line_number":106,"context_line":"                       \"freezer\"]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def setUp(self):"},{"line_number":109,"context_line":"        super(BuildTestUbuntuBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_9ba28899","line":106,"range":{"start_line":106,"start_character":24,"end_line":106,"end_character":31},"updated":"2016-11-05 17:48:07.000000000","message":"ditto","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2a4c149b362d6398edfe92978b0b8c15b0496bf9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                       \"congress-base\","},{"line_number":132,"context_line":"                       \"bifrost-base\","},{"line_number":133,"context_line":"                       \"cloudkitty-base\","},{"line_number":134,"context_line":"                       \"freezer\"]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def setUp(self):"},{"line_number":137,"context_line":"        super(BuildTestOracleLinuxBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_bb9f4c4f","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":31},"updated":"2016-11-05 17:48:07.000000000","message":"ditto","commit_id":"cc21d1cf3eab2a62e748ec4ef9bf1c3906237229"}]}