)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"b87219433f3b0eb3699a938ed2451168c3c0b2ba","unresolved":false,"context_lines":[{"line_number":13,"context_line":"services."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I719661d75f5044239a1fd52080d322c77490ecae"},{"line_number":16,"context_line":"Partially-Implements: bluentprint centralized-logging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a8bc5a2_76cb121f","line":16,"updated":"2016-09-28 10:42:26.000000000","message":"Correct blueprint spelling\ns/bluentprint/blueprint/g","commit_id":"80cd8bd4a6129b77a1529805f85fab25e7b8e7cb"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4b909e1051bd6f8af951b2714bc3ea6865a12a10","unresolved":false,"context_lines":[{"line_number":13,"context_line":"services."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I719661d75f5044239a1fd52080d322c77490ecae"},{"line_number":16,"context_line":"Partially-Implements: bluentprint centralized-logging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a98d1f4_1431faa2","line":16,"range":{"start_line":16,"start_character":34,"end_line":16,"end_character":53},"updated":"2016-09-28 16:43:20.000000000","message":"This blueprint does not exists...","commit_id":"80cd8bd4a6129b77a1529805f85fab25e7b8e7cb"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Monitoring options are specified here"},{"line_number":294,"context_line":"enable_collectd: \"no\""},{"line_number":295,"context_line":"enable_kube_logger: \"no\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"####################"},{"line_number":298,"context_line":"# Logging options"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_0a4f07be","line":295,"updated":"2016-10-11 13:47:46.000000000","message":"how is this related to the docker image?","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Monitoring options are specified here"},{"line_number":294,"context_line":"enable_collectd: \"no\""},{"line_number":295,"context_line":"enable_kube_logger: \"no\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"####################"},{"line_number":298,"context_line":"# Logging options"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_a5880ce9","line":295,"in_reply_to":"fa6399be_0a4f07be","updated":"2016-10-11 14:08:24.000000000","message":"Done","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"}],"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN ulimit -n 65536"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_a50e4c32","line":8,"updated":"2016-10-11 13:47:46.000000000","message":"why is this necessary?","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN ulimit -n 65536"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_c5542056","line":8,"in_reply_to":"fa6399be_a50e4c32","updated":"2016-10-11 14:08:24.000000000","message":"It is required due to a nature of application. It must stay here.","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN  rpm --import https://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY td.repo /etc/yum.repos.d/td.repo "},{"line_number":15,"context_line":"    "}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_856ea8c7","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":5},"updated":"2016-10-11 13:47:46.000000000","message":"nit: 1 space is enough","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN  rpm --import https://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY td.repo /etc/yum.repos.d/td.repo "},{"line_number":15,"context_line":"    "}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_054ff8bd","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":5},"in_reply_to":"fa6399be_856ea8c7","updated":"2016-10-11 14:08:24.000000000","message":"Done","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"RUN  rpm --import https://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY td.repo /etc/yum.repos.d/td.repo "},{"line_number":15,"context_line":"    "},{"line_number":16,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":17,"context_line":"        \u0027td-agent\u0027,"},{"line_number":18,"context_line":"        \u0027gcc-c++\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_0a78e7f1","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":4},"updated":"2016-10-11 13:47:46.000000000","message":"remove whitespace","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN  curl https://packages.treasuredata.com/GPG-KEY-td-agent | apt-key add -"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"RUN  echo \"deb http://packages.treasuredata.com/2/ubuntu/trusty/ trusty contrib\" \u003e /etc/apt/sources.list.d/treasure-data.list"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_aa40db57","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":71},"updated":"2016-10-11 13:47:46.000000000","message":"we use xenial and not trusty","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"},{"line_number":30,"context_line":"        \u0027curl\u0027,"},{"line_number":31,"context_line":"        \u0027make\u0027,"},{"line_number":32,"context_line":"        \u0027g++\u0027"},{"line_number":33,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_4a31ff0a","line":30,"range":{"start_line":30,"start_character":9,"end_line":30,"end_character":13},"updated":"2016-10-11 13:47:46.000000000","message":"this should be already part of our base image, please check, also you already use curl in line 24, this means it has to be already installed inside the image","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"},{"line_number":30,"context_line":"        \u0027curl\u0027,"},{"line_number":31,"context_line":"        \u0027make\u0027,"},{"line_number":32,"context_line":"        \u0027g++\u0027"},{"line_number":33,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_659a7416","line":30,"range":{"start_line":30,"start_character":9,"end_line":30,"end_character":13},"in_reply_to":"fa6399be_4a31ff0a","updated":"2016-10-11 14:08:24.000000000","message":"Done","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"},{"line_number":30,"context_line":"        \u0027curl\u0027,"},{"line_number":31,"context_line":"        \u0027make\u0027,"},{"line_number":32,"context_line":"        \u0027g++\u0027"},{"line_number":33,"context_line":"    ] %}"},{"line_number":34,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_cab0af8e","line":31,"updated":"2016-10-11 13:47:46.000000000","message":"is it required to install development tools inside the image? this could be a security problem.","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"},{"line_number":30,"context_line":"        \u0027curl\u0027,"},{"line_number":31,"context_line":"        \u0027make\u0027,"},{"line_number":32,"context_line":"        \u0027g++\u0027"},{"line_number":33,"context_line":"    ] %}"},{"line_number":34,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa6399be_25a87c1f","line":31,"in_reply_to":"fa6399be_cab0af8e","updated":"2016-10-11 14:08:24.000000000","message":"During agent installation, they use make and gcc, without them installation fails.","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"83f0859a767032cdf33b6699917fcf65221711a4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN curl https://packages.treasuredata.com/GPG-KEY-td-agent | apt-key add -"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"RUN echo \"deb http://packages.treasuredata.com/2/ubuntu/xenial/ xenial contrib\" \u003e /etc/apt/sources.list.d/treasure-data.list"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa6399be_dd55d8c6","line":26,"updated":"2016-10-11 14:38:05.000000000","message":"Same here, merge with line 24.","commit_id":"8e685c565ccec319f81b166772ee00fbc542ebc1"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"8b15ec8622669f142e2caffba36f23c891836e5e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"RUN sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent"},{"line_number":38,"context_line":"RUN td-agent-gem install fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep"},{"line_number":39,"context_line":"RUN rm -f /etc/td-agent/td-agent.conf"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":42,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa6399be_eb3e55b7","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":37},"updated":"2016-10-11 14:21:05.000000000","message":"I think it would be better\nRUN xxx \\\n      \u0026 xxx \\\n      \u0026 xxx","commit_id":"8e685c565ccec319f81b166772ee00fbc542ebc1"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fbe71a96663519ce35fd5e21961188b6cd9a19d8","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"RUN sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent"},{"line_number":38,"context_line":"RUN td-agent-gem install fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep"},{"line_number":39,"context_line":"RUN rm -f /etc/td-agent/td-agent.conf"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":42,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa6399be_dd2078fa","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":37},"in_reply_to":"fa6399be_9d4b602b","updated":"2016-10-11 17:12:36.000000000","message":"Could you elaborate why 2 + 3 is better than 3 + 2?","commit_id":"8e685c565ccec319f81b166772ee00fbc542ebc1"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"83f0859a767032cdf33b6699917fcf65221711a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"RUN sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent"},{"line_number":38,"context_line":"RUN td-agent-gem install fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch fluent-plugin-grep"},{"line_number":39,"context_line":"RUN rm -f /etc/td-agent/td-agent.conf"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":42,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa6399be_9d4b602b","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":37},"in_reply_to":"fa6399be_eb3e55b7","updated":"2016-10-11 14:38:05.000000000","message":"I think it is better to move line 41/42 before line 37 and to merge all RUN commands.","commit_id":"8e685c565ccec319f81b166772ee00fbc542ebc1"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4a8e8df158022bf25af0ce74ac1d47c2f67c03ac","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN ulimit -n 65536"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_b0f8174b","line":8,"updated":"2016-10-12 14:52:22.000000000","message":"Please compress this line into one of the RUN statements below to save on layers","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7433c8997e090df8807768557e8fc592ca81dc3","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN ulimit -n 65536"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_8761103c","line":8,"in_reply_to":"fa6399be_81f2e3d0","updated":"2016-10-12 17:30:21.000000000","message":"done","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"51f85cee24aa33e393ae14a82e3cd017b46adf05","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN ulimit -n 65536"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_81f2e3d0","line":8,"in_reply_to":"fa6399be_ab8c2880","updated":"2016-10-12 15:36:21.000000000","message":"Because it is required by the application. It is in their installation instructions.","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"46f4b8ee2821c88849d47b8a1ce684840d9d9313","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN ulimit -n 65536"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_ab8c2880","line":8,"in_reply_to":"fa6399be_b0f8174b","updated":"2016-10-12 14:56:46.000000000","message":"Why is this ulimit required at all?\n\n@pbourke: Merge with line 37...?","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4a8e8df158022bf25af0ce74ac1d47c2f67c03ac","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rpm --import https://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY td.repo /etc/yum.repos.d/td.repo"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_d0310b0d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":67},"updated":"2016-10-12 14:52:22.000000000","message":"Repo setup is currently being done in base (see kibana + others). I know the thinking is probably not to carry unnecessary stuff in every image, but we should be consistent either way. Having it in base has some advantages such as making it easier to consistently change to internal repos.","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e286aa802d28f09928e67b16b7b4cdeaf412ecaf","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rpm --import https://packages.treasuredata.com/GPG-KEY-td-agent"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY td.repo /etc/yum.repos.d/td.repo"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_a86ee0fe","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":67},"in_reply_to":"fa6399be_d0310b0d","updated":"2016-10-12 20:10:18.000000000","message":"Paul, I do not mind to move it to base, it is just this image is not used in kolla at all, so the only reason for it to exist at least for now is to bring it to kubernetes. If after my explanation you still think it is better to have it in the base please let me know and I will move it.","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4a8e8df158022bf25af0ce74ac1d47c2f67c03ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN curl https://packages.treasuredata.com/GPG-KEY-td-agent | apt-key add - \\"},{"line_number":25,"context_line":"    \u0026\u0026 echo \"deb http://packages.treasuredata.com/2/ubuntu/xenial/ xenial contrib\" \u003e /etc/apt/sources.list.d/treasure-data.list \\"},{"line_number":26,"context_line":"    \u0026\u0026 apt-get update "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_90e6b3b2","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":22},"updated":"2016-10-12 14:52:22.000000000","message":"whitespace","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7433c8997e090df8807768557e8fc592ca81dc3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN curl https://packages.treasuredata.com/GPG-KEY-td-agent | apt-key add - \\"},{"line_number":25,"context_line":"    \u0026\u0026 echo \"deb http://packages.treasuredata.com/2/ubuntu/xenial/ xenial contrib\" \u003e /etc/apt/sources.list.d/treasure-data.list \\"},{"line_number":26,"context_line":"    \u0026\u0026 apt-get update "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_4779b8f5","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":22},"in_reply_to":"fa6399be_6b47701d","updated":"2016-10-12 17:30:21.000000000","message":"done","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"46f4b8ee2821c88849d47b8a1ce684840d9d9313","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN curl https://packages.treasuredata.com/GPG-KEY-td-agent | apt-key add - \\"},{"line_number":25,"context_line":"    \u0026\u0026 echo \"deb http://packages.treasuredata.com/2/ubuntu/xenial/ xenial contrib\" \u003e /etc/apt/sources.list.d/treasure-data.list \\"},{"line_number":26,"context_line":"    \u0026\u0026 apt-get update "},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":29,"context_line":"        \u0027td-agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"fa6399be_6b47701d","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":22},"in_reply_to":"fa6399be_90e6b3b2","updated":"2016-10-12 14:56:46.000000000","message":"Same comment like for line 12 here? Repo setup should be moved to base container?","commit_id":"a31778cabec3b7b54eea3c170a551ed40df43270"}],"docker/fluentd/extend_start.sh":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"td-agent:kolla\" ]]; then"},{"line_number":9,"context_line":"    sudo chown td-agent:kolla /var/log/kolla"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":12,"context_line":"    sudo chmod 2775 /var/log/kolla"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":"if [[ $(stat -c %U:%G /var/lib/td-agent) !\u003d \"td-agent:kolla\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"fa6399be_a5aaccd2","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":43},"updated":"2016-10-11 13:47:46.000000000","message":"why 2775 and not 755?","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"td-agent:kolla\" ]]; then"},{"line_number":9,"context_line":"    sudo chown td-agent:kolla /var/log/kolla"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":"if [[ $(stat -c %a /var/log/kolla) !\u003d \"2775\" ]]; then"},{"line_number":12,"context_line":"    sudo chmod 2775 /var/log/kolla"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":"if [[ $(stat -c %U:%G /var/lib/td-agent) !\u003d \"td-agent:kolla\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"fa6399be_703cf493","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":43},"in_reply_to":"fa6399be_a5aaccd2","updated":"2016-10-11 14:08:24.000000000","message":"Excellent question, I guess because of this:\nhttps://github.com/openstack/kolla/blob/master/docker/heka/extend_start.sh#L11","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"}],"etc/kolla/globals.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ff8ca37e48f26f06102e25f75074d5173d84adaa","unresolved":false,"context_lines":[{"line_number":125,"context_line":"#enable_congress: \"no\""},{"line_number":126,"context_line":"#enable_elasticsearch: \"no\""},{"line_number":127,"context_line":"#enable_etcd: \"no\""},{"line_number":128,"context_line":"#enable_kube_logger: \"no\""},{"line_number":129,"context_line":"#enable_gnocchi: \"no\""},{"line_number":130,"context_line":"#enable_grafana: \"no\""},{"line_number":131,"context_line":"#enable_heat: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_6acc0336","line":128,"updated":"2016-10-11 13:47:46.000000000","message":"dito","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"89804026092b964596f4c902b272eed99fe3a9a4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"#enable_congress: \"no\""},{"line_number":126,"context_line":"#enable_elasticsearch: \"no\""},{"line_number":127,"context_line":"#enable_etcd: \"no\""},{"line_number":128,"context_line":"#enable_kube_logger: \"no\""},{"line_number":129,"context_line":"#enable_gnocchi: \"no\""},{"line_number":130,"context_line":"#enable_grafana: \"no\""},{"line_number":131,"context_line":"#enable_heat: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_252ddca7","line":128,"in_reply_to":"fa6399be_6acc0336","updated":"2016-10-11 14:08:24.000000000","message":"Done","commit_id":"737f81ac3d99be1e448e2eaf28c99a76a341135a"}]}