)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"################"},{"line_number":60,"context_line":"# Chrony options"},{"line_number":61,"context_line":"################"},{"line_number":62,"context_line":"# a list contains ntp servers"},{"line_number":63,"context_line":"external_ntp_servers: []"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_d3181c21","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":3},"updated":"2016-09-24 21:31:03.000000000","message":"Uppercase","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":253,"context_line":"enable_central_logging: \"no\""},{"line_number":254,"context_line":"enable_ceph: \"no\""},{"line_number":255,"context_line":"enable_ceph_rgw: \"no\""},{"line_number":256,"context_line":"enable_chrony: \"yes\""},{"line_number":257,"context_line":"enable_cinder: \"no\""},{"line_number":258,"context_line":"enable_cinder_backend_iscsi: \"no\""},{"line_number":259,"context_line":"enable_cinder_backend_lvm: \"no\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_33da204d","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":19},"updated":"2016-09-24 21:31:03.000000000","message":"Enabled by default?","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"}],"ansible/roles/chrony/tasks/upgrade.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- set_fact: secondary_addresses\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface].get(\u0027ipv4_secondaries\u0027, []) | map(attribute\u003d\u0027address\u0027) | list }}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Stopping all slave keepalived containers"},{"line_number":7,"context_line":"  kolla_docker:"},{"line_number":8,"context_line":"    action: \"stop_container\""},{"line_number":9,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":10,"context_line":"    name: \"keepalived\""},{"line_number":11,"context_line":"  when: kolla_internal_vip_address not in secondary_addresses"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Upgrading master keepalived and haproxy"},{"line_number":14,"context_line":"- include: start.yml"},{"line_number":15,"context_line":"  when: kolla_internal_vip_address in secondary_addresses"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Upgrading slave keepalived and haproxy"},{"line_number":18,"context_line":"- include: start.yml"},{"line_number":19,"context_line":"  when: kolla_internal_vip_address not in secondary_addresses"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_d3c65c67","line":19,"range":{"start_line":6,"start_character":0,"end_line":19,"end_character":61},"updated":"2016-09-24 21:31:03.000000000","message":"Don\u0027t know if i\u0027m missing something, but why is required to upgrade keepalived containers? Could you explain?\nI guess is a copy paste issue from haproxy role","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"}],"ansible/roles/chrony/templates/chrony.conf.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% for ntp_server in external_ntp_servers %}"},{"line_number":2,"context_line":"server {{ ntp_server }} iburst"},{"line_number":3,"context_line":"{% endfor %}"},{"line_number":4,"context_line":"{% for host in groups[\u0027chrony-server\u0027] %}"},{"line_number":5,"context_line":"server {{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }} iburst"},{"line_number":6,"context_line":"{% endfor %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a8bc5a2_33a8608d","line":4,"range":{"start_line":4,"start_character":30,"end_line":4,"end_character":36},"updated":"2016-09-24 21:31:03.000000000","message":"This should be clients servers","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"server {{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }} iburst"},{"line_number":6,"context_line":"{% endfor %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Look here for the admin password needed for chronyc.  The initial"},{"line_number":9,"context_line":"# password is generated by a random process at install time.  You may"},{"line_number":10,"context_line":"# change it if you wish."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"keyfile /etc/chrony/chrony.keys"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a8bc5a2_53a96c8f","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":24},"updated":"2016-09-24 21:31:03.000000000","message":"Comments in the file not necessary","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"}],"ansible/roles/chrony/templates/chrony.json.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/chrony.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/chrony/chrony.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0644\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/chrony.keys\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a8bc5a2_93977447","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":25},"updated":"2016-09-24 21:31:03.000000000","message":"644 permissions are mandatory or 600 is enough?","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/chrony.keys\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/chrony/chrony.keys\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0644\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"},{"line_number":17,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a8bc5a2_b3947043","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":25},"updated":"2016-09-24 21:31:03.000000000","message":"Ditto","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"}],"docker/chrony/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6ffee7600fac3b8e47e247b74d4e191315423c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":14,"context_line":"        \u0027chrony\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"# Ubuntu use _chrony username to use unified running user with RHEL system"},{"line_number":17,"context_line":"RUN useradd --user-group --create-home --home-dir /var/lib/chrony chrony"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5a8bc5a2_f39a786d","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":17},"updated":"2016-09-24 21:31:03.000000000","message":"Remove comma","commit_id":"46df2b18f1bfc2d93457902828fe30c1773c5f06"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"e7993d8610dedf8f6483a39bcc9f552bb9ecc7bb","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":10,"context_line":"        \u0027chrony\u0027"},{"line_number":11,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da6895a0_c5d21000","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":55},"updated":"2016-10-26 04:34:45.000000000","message":"the \"if\" condition seems unnecessary","commit_id":"fb592d2785ec3369f94e478f78589ad19aef435f"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"e7993d8610dedf8f6483a39bcc9f552bb9ecc7bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":10,"context_line":"        \u0027chrony\u0027"},{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set chrony_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da6895a0_e5cd545e","line":10,"range":{"start_line":9,"start_character":6,"end_line":10,"end_character":16},"updated":"2016-10-26 04:34:45.000000000","message":"the package is same","commit_id":"fb592d2785ec3369f94e478f78589ad19aef435f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"67ad3587db085d25cdacc9f45b44b2026eabd460","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":10,"context_line":"        \u0027chrony\u0027"},{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":14,"context_line":"        \u0027chrony\u0027,"},{"line_number":15,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da6895a0_e33f22d4","line":12,"updated":"2016-10-25 09:41:57.000000000","message":"i think bot blocks can be merged, the package name is the same on all distros","commit_id":"fb592d2785ec3369f94e478f78589ad19aef435f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"74892ee3fcde4fa7f5479060280091a42ad78aee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":10,"context_line":"        \u0027chrony\u0027"},{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":14,"context_line":"        \u0027chrony\u0027,"},{"line_number":15,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da6895a0_86090fe0","line":12,"in_reply_to":"da6895a0_e33f22d4","updated":"2016-10-25 13:15:30.000000000","message":"agree","commit_id":"fb592d2785ec3369f94e478f78589ad19aef435f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"67ad3587db085d25cdacc9f45b44b2026eabd460","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set chrony_packages \u003d ["},{"line_number":14,"context_line":"        \u0027chrony\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"# Ubuntu use _chrony username to use unified running user with RHEL system"},{"line_number":17,"context_line":"RUN useradd --user-group --create-home --home-dir /var/lib/chrony chrony"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da6895a0_c33cdee4","line":14,"updated":"2016-10-25 09:41:57.000000000","message":", at the end of line can be removed","commit_id":"fb592d2785ec3369f94e478f78589ad19aef435f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"67ad3587db085d25cdacc9f45b44b2026eabd460","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{% block chrony_footer %}{% endblock %}"},{"line_number":27,"context_line":"{% block footer %}{% endblock %}"},{"line_number":28,"context_line":"{{ include_footer }}"},{"line_number":29,"context_line":"# NOTE(Jeffrey4l): chrony running user is controlled by chronyd -u parameter"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da6895a0_2322fab9","line":29,"updated":"2016-10-25 09:41:57.000000000","message":"This note makes no sense to me.","commit_id":"fb592d2785ec3369f94e478f78589ad19aef435f"}]}