)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dc26484b18f965834f04133a02745f34ffd2391a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     caoyuan \u003ccao.yuan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-25 19:46:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the action when create Glance service endpoints"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_c0d03322","line":7,"updated":"2016-09-26 03:01:44.000000000","message":"action? description?","commit_id":"d602b88c5a7466875a4fa40d11a0f334dc37f41d"}],"ansible/roles/glance/tasks/register.yml":[{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"44b248c5511c3d04c6157f63ec168cf3a161042a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Creating the Glance service and endpoint"},{"line_number":3,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":4,"context_line":"    -m kolla_keystone_service"},{"line_number":5,"context_line":"    -a \"service_name\u003d{{ item.name }}"},{"line_number":6,"context_line":"        service_type\u003d{{ item.service_type }}"},{"line_number":7,"context_line":"        description\u003d\u0027{{ item.description }}\u0027"},{"line_number":8,"context_line":"        endpoint_region\u003d{{ openstack_region_name }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_1b028db4","line":5,"updated":"2016-09-26 04:50:44.000000000","message":"Thanks for working on it. However i am not getting the use of this change. can you please explain why we need this change?\n\nIt will be use full when it is called by different value in \"with_item\", however i see you have passes same value for each with_items. So it is not of much use.","commit_id":"d602b88c5a7466875a4fa40d11a0f334dc37f41d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3684302e50b6f9e340d48fd6706c3a2cae70b2db","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Creating the Glance service and endpoint"},{"line_number":3,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":4,"context_line":"    -m kolla_keystone_service"},{"line_number":5,"context_line":"    -a \"service_name\u003d{{ item.name }}"},{"line_number":6,"context_line":"        service_type\u003d{{ item.service_type }}"},{"line_number":7,"context_line":"        description\u003d\u0027{{ item.description }}\u0027"},{"line_number":8,"context_line":"        endpoint_region\u003d{{ openstack_region_name }}"},{"line_number":9,"context_line":"        url\u003d\u0027{{ item.url }}\u0027"},{"line_number":10,"context_line":"        interface\u003d\u0027{{ item.interface }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a8bc5a2_2fd7ffed","line":7,"range":{"start_line":5,"start_character":7,"end_line":7,"end_character":44},"updated":"2016-09-26 07:27:42.000000000","message":"I can\u0027t see a reason for changing this in a with_items. \nUsing with_items we have duplicated name, service_type and description with the endpoints. IMHO duplicating code is useless when the only change in the items is the endpoint url.","commit_id":"d17b9df30fd1203f8c84c158995941c5812e5a91"}]}