)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7ff0e6b232826f7def2a0940d31e7abc55e14935","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     prameswar \u003cengg.pram1@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-28 19:19:14 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"moved changes to precheck"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1627782"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98d1f4_f6aae084","line":7,"updated":"2016-09-28 14:03:31.000000000","message":"Be more descriptive.","commit_id":"a4f9a0c1f1d804bb9bce69c4b47bd652f4bd51d7"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7ff0e6b232826f7def2a0940d31e7abc55e14935","unresolved":false,"context_lines":[{"line_number":180,"context_line":"rbd_secret_uuid \u003d {{ rbd_secret_uuid }}"},{"line_number":181,"context_line":"{% endif %}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"[upgrade_levels]"},{"line_number":186,"context_line":"compute \u003d auto"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a98d1f4_d6bec4d3","side":"PARENT","line":183,"updated":"2016-09-28 14:03:31.000000000","message":"This is not related to the change.","commit_id":"3a54a2cb542fd16a18e5ce81e266322fd181d39d"}],"ansible/roles/prechecks/tasks/service_checks.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7ff0e6b232826f7def2a0940d31e7abc55e14935","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: checking hardware acceleration support"},{"line_number":9,"context_line":"  shell: egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo"},{"line_number":10,"context_line":"  register: result"},{"line_number":11,"context_line":"  failed_when: result | failed"},{"line_number":12,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Checking Docker version"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a98d1f4_96c19c31","line":11,"updated":"2016-09-28 14:03:31.000000000","message":"Why? It makes sense to make to print out a warning the hardware acceleration support is not enabled. But I think the pre checks should not fail when it is not enabled. E.g. when I run an AIO environment it could be correct to have no hardware acceleration enabled.","commit_id":"a4f9a0c1f1d804bb9bce69c4b47bd652f4bd51d7"},{"author":{"_account_id":20858,"name":"prameswar","email":"engg.pram1@gmail.com","username":"prameswar"},"change_message_id":"f08b887d62718246a130864a007cdd09550187e1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: checking hardware acceleration support"},{"line_number":9,"context_line":"  shell: egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo"},{"line_number":10,"context_line":"  register: result"},{"line_number":11,"context_line":"  failed_when: result | failed"},{"line_number":12,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Checking Docker version"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a98d1f4_915fe60d","line":11,"in_reply_to":"3a98d1f4_96c19c31","updated":"2016-09-28 14:11:40.000000000","message":"if we run command :egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo\n\nthis will return zero because of that it is failing.\n\nwill is be ok if i remove fail_when part and add ignore_errors: yes. that will print in red color.","commit_id":"a4f9a0c1f1d804bb9bce69c4b47bd652f4bd51d7"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"69749934f82c711c9e5ecb6814031648b893acf4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  failed_when: result.stat.exists"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: checking hardware acceleration support enabled"},{"line_number":9,"context_line":"  shell: egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo"},{"line_number":10,"context_line":"  ignore_errors: yes"},{"line_number":11,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a98d1f4_e0a64f52","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":16},"updated":"2016-09-29 15:19:12.000000000","message":"Checking","commit_id":"d12ca9e52f85059cda68711706173cd13a4cc7fd"}]}