)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"5ddeba0d3d16919bb6838486990d8da27d1b5e4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-30 00:22:57 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix rabbitmq bustage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8de9a553b506a15f4d96cc6b55f21e3a27887a1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a98d1f4_dfd749bd","line":7,"updated":"2016-09-30 08:40:26.000000000","message":"Please improve the commit message.","commit_id":"8e3804fc3be77a3d80a6f874df5560e8e4ee3851"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d7375600effd8d00f98a1af84bb735cb6f12b62c","unresolved":false,"context_lines":[{"line_number":306,"context_line":"# RabbitMQ options"},{"line_number":307,"context_line":"####################"},{"line_number":308,"context_line":"rabbitmq_user: \"openstack\""},{"line_number":309,"context_line":"rabbitmq_version: \"rabbitmq_server-3.6.2/plugins/rabbitmq_clusterer-3.6.2.ez/rabbitmq_clusterer-3.6.x-667f92b0/ebin\""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"####################"},{"line_number":312,"context_line":"# HAProxy options"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_c2e00d99","side":"PARENT","line":309,"updated":"2016-10-02 17:08:22.000000000","message":"this variable was added because (IIRC) generating the kubernetes config doesn\u0027t work properly without this change.  I think this change will break kubernetes.","commit_id":"789f50b2f3bc733015d11287054b63db7c01c03a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"deda5786c68d36cd6054411944558374297dd265","unresolved":false,"context_lines":[{"line_number":306,"context_line":"# RabbitMQ options"},{"line_number":307,"context_line":"####################"},{"line_number":308,"context_line":"rabbitmq_user: \"openstack\""},{"line_number":309,"context_line":"rabbitmq_version: \"rabbitmq_server-3.6.2/plugins/rabbitmq_clusterer-3.6.2.ez/rabbitmq_clusterer-3.6.x-667f92b0/ebin\""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"####################"},{"line_number":312,"context_line":"# HAProxy options"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_ce7af6f0","side":"PARENT","line":309,"in_reply_to":"3a98d1f4_c2e00d99","updated":"2016-10-03 00:40:42.000000000","message":"see the comments in https://review.openstack.org/#/c/379960/8/ansible/roles/rabbitmq/templates/rabbitmq-env.conf.j2","commit_id":"789f50b2f3bc733015d11287054b63db7c01c03a"}],"ansible/roles/rabbitmq/templates/rabbitmq-env.conf.j2":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"337de7b50e39d5d993e5a91ad5382d22828524d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"RABBITMQ_NODENAME\u003drabbit"},{"line_number":2,"context_line":"{% if orchestration_engine \u003d\u003d \u0027ANSIBLE\u0027 %}"},{"line_number":3,"context_line":"RABBITMQ_BOOT_MODULE\u003drabbit_clusterer"},{"line_number":4,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"-pa /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.5/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez/rabbitmq_clusterer-3.6.x-667f92b0/ebin\""},{"line_number":5,"context_line":"{%- endif %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RABBITMQ_LOG_BASE\u003d/var/log/kolla/rabbitmq"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3a98d1f4_d8bb9ce3","line":4,"updated":"2016-10-02 21:33:01.000000000","message":"If you assign new value of rabbitmq version to the variable, why do you needed to get rid of a variable?\nLike this:\nrabbitmq_version: \"rabbitmq_server-3.6.5/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez/rabbitmq_clusterer-3.6.x-667f92b0/ebin\"\n\nrabbitmq-env.conf.j2:RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"-pa /usr/lib/rabbitmq/lib/{{ rabbitmq_version }}\"","commit_id":"409fa4643b8cef8efb5443d1b44d08af702b1882"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"deda5786c68d36cd6054411944558374297dd265","unresolved":false,"context_lines":[{"line_number":1,"context_line":"RABBITMQ_NODENAME\u003drabbit"},{"line_number":2,"context_line":"{% if orchestration_engine \u003d\u003d \u0027ANSIBLE\u0027 %}"},{"line_number":3,"context_line":"RABBITMQ_BOOT_MODULE\u003drabbit_clusterer"},{"line_number":4,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"-pa /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.5/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez/rabbitmq_clusterer-3.6.x-667f92b0/ebin\""},{"line_number":5,"context_line":"{%- endif %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RABBITMQ_LOG_BASE\u003d/var/log/kolla/rabbitmq"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3a98d1f4_2e86fada","line":4,"in_reply_to":"3a98d1f4_d8bb9ce3","updated":"2016-10-03 00:40:42.000000000","message":"could you explain why rabbitmq_version matter?\n\nthis variable is only used when orchestration_engine \u003d\u003d ANSIBLE. \n\nWhy k8s will use this variable?","commit_id":"409fa4643b8cef8efb5443d1b44d08af702b1882"}],"docker/rabbitmq/Dockerfile.j2":[{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"641d48ca9f7b4616bcb6d719ec179d1641a3c5c3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#              process."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"RUN rm -rf /var/lib/rabbitmq/* \\"},{"line_number":43,"context_line":"    \u0026\u0026 curl -o $(echo /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.*/plugins)/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \\"},{"line_number":44,"context_line":"    \u0026\u0026 /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \\"},{"line_number":45,"context_line":"       rabbitmq_management \\"},{"line_number":46,"context_line":"       rabbitmq_clusterer \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a98d1f4_72c3aeed","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":65},"updated":"2016-09-30 15:29:24.000000000","message":"This is not good enough for a final solution as we would be in the same troubles when bumping to 3.7. Just few weeks ago it was on 3.5.","commit_id":"ea7b7b5c17f9fdda16591ebc0892d879e71dd7e3"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"7118b390e24b948117418f86b437a823d7f4326d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#              process."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"RUN rm -rf /var/lib/rabbitmq/* \\"},{"line_number":43,"context_line":"    \u0026\u0026 curl -o $(echo /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.*/plugins)/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \\"},{"line_number":44,"context_line":"    \u0026\u0026 /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \\"},{"line_number":45,"context_line":"       rabbitmq_management \\"},{"line_number":46,"context_line":"       rabbitmq_clusterer \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a98d1f4_0df08fc8","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":65},"in_reply_to":"3a98d1f4_521a327e","updated":"2016-09-30 15:38:56.000000000","message":"The difference is not between * and ?, * would not work as well in curl. That wildcards are bash extglob feature and this modified PS uses it inside bash\u0027s internal echo.","commit_id":"ea7b7b5c17f9fdda16591ebc0892d879e71dd7e3"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"272ecc176656359a6c40498850633b9ddec03cfa","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#              process."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"RUN rm -rf /var/lib/rabbitmq/* \\"},{"line_number":43,"context_line":"    \u0026\u0026 curl -o $(echo /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.*/plugins)/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \\"},{"line_number":44,"context_line":"    \u0026\u0026 /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \\"},{"line_number":45,"context_line":"       rabbitmq_management \\"},{"line_number":46,"context_line":"       rabbitmq_clusterer \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3a98d1f4_521a327e","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":65},"in_reply_to":"3a98d1f4_72c3aeed","updated":"2016-09-30 15:32:16.000000000","message":"Martin,\n\nI\u0027m surprised * works, 3.6.?  didn\u0027t.  Anyway lets get er merged as is because the plugins need to change if the y version changes, and the only way we find that out is if the build fails :)","commit_id":"ea7b7b5c17f9fdda16591ebc0892d879e71dd7e3"}]}