)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ec45c31e5f0402457be67ad141497f6eb85a6bb4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[1] http://docs.ansible.com/ansible/ping_module.html"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I228a720545a4507b9a483e4ff525d08db8077e20"},{"line_number":21,"context_line":"ClosesBug: #1630165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_dd16dea6","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":9},"updated":"2016-10-04 16:45:30.000000000","message":"Closes-Bug","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"39213ba1249c5fc3aef4cea7556b5b0d9e33528e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[1] http://docs.ansible.com/ansible/ping_module.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I228a720545a4507b9a483e4ff525d08db8077e20"},{"line_number":22,"context_line":"ClosesBug: #1630165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_07ba7ec0","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":19},"updated":"2016-10-05 16:46:45.000000000","message":"Per OpenStack\u0027s best practices for git commit messages, could you change this to \nCloses-Bug: #1630165.\n\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1ca793ef60bf759eeb1ba297ac62255d0562215a"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"0c837f12e8a1401134c6abcbbeb2d44102aab939","unresolved":false,"context_lines":[{"line_number":19,"context_line":"[1] http://docs.ansible.com/ansible/ping_module.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I228a720545a4507b9a483e4ff525d08db8077e20"},{"line_number":22,"context_line":"ClosesBug: #1630165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_b9f1dd6c","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":19},"in_reply_to":"1a95cdbc_07ba7ec0","updated":"2016-10-06 00:52:48.000000000","message":"Done","commit_id":"1ca793ef60bf759eeb1ba297ac62255d0562215a"}],"ansible/roles/prechecks/tasks/port_checks.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ec45c31e5f0402457be67ad141497f6eb85a6bb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# duonghq: Assume target ssh is at port 22"},{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_9daa966f","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":10},"updated":"2016-10-04 16:45:30.000000000","message":"Correct format here would be\n  TODO(duonghq): ...","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"9807ea74d431e8b5b182316cf8f6ca24006a0e58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# duonghq: Assume target ssh is at port 22"},{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_60cfd1b0","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":10},"in_reply_to":"1a95cdbc_9daa966f","updated":"2016-10-05 00:56:59.000000000","message":"Done","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ec45c31e5f0402457be67ad141497f6eb85a6bb4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"},{"line_number":6,"context_line":"# I put the check before all other port checks because"},{"line_number":7,"context_line":"# if the VIP is reachable, the Kolla cannot run properly"},{"line_number":8,"context_line":"# so other check is meaningless"},{"line_number":9,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not reachable"},{"line_number":10,"context_line":"  wait_for:"},{"line_number":11,"context_line":"    host: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_dd933e4e","line":8,"range":{"start_line":6,"start_character":1,"end_line":8,"end_character":31},"updated":"2016-10-04 16:45:30.000000000","message":"This would be better noted in the commit message","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"9807ea74d431e8b5b182316cf8f6ca24006a0e58","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"},{"line_number":6,"context_line":"# I put the check before all other port checks because"},{"line_number":7,"context_line":"# if the VIP is reachable, the Kolla cannot run properly"},{"line_number":8,"context_line":"# so other check is meaningless"},{"line_number":9,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not reachable"},{"line_number":10,"context_line":"  wait_for:"},{"line_number":11,"context_line":"    host: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_e0bbe10c","line":8,"range":{"start_line":6,"start_character":1,"end_line":8,"end_character":31},"in_reply_to":"1a95cdbc_dd933e4e","updated":"2016-10-05 00:56:59.000000000","message":"It\u0027s already in the commit message, but I rephrased the msg to make it more clear.\n\nThank you","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"b91c498b11d7d816172d389d99344dc61a2d79b7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  with_items:"},{"line_number":16,"context_line":"    - \"{{ kolla_internal_vip_address }}\""},{"line_number":17,"context_line":"    - \"{{ kolla_external_vip_address }}\""},{"line_number":18,"context_line":"  when: enable_haproxy | bool"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Checking free port for Aodh API"},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_4da4db56","line":18,"updated":"2016-10-04 18:31:14.000000000","message":"Is a failure condition missing above?","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"1ebcccfb4269c1d585acd8e8dc4ff32896cb5f32","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  with_items:"},{"line_number":16,"context_line":"    - \"{{ kolla_internal_vip_address }}\""},{"line_number":17,"context_line":"    - \"{{ kolla_external_vip_address }}\""},{"line_number":18,"context_line":"  when: enable_haproxy | bool"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Checking free port for Aodh API"},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_4020159c","line":18,"in_reply_to":"1a95cdbc_4da4db56","updated":"2016-10-05 00:47:00.000000000","message":"Can you explain it clearer?","commit_id":"962ed1df152080df37f31fd2d66b3661e2e988d5"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1cb512076028aa6af732e7cc3c00dc5077ec5abc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(duonghq): Assume target ssh is at port 22"},{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"},{"line_number":6,"context_line":"# I put the check before all other port checks because"},{"line_number":7,"context_line":"# if the VIP is reachable, the Kolla cannot run properly"},{"line_number":8,"context_line":"# so other check is meaningless"},{"line_number":9,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not reachable"},{"line_number":10,"context_line":"  wait_for:"},{"line_number":11,"context_line":"    host: \"{{ item }}\""},{"line_number":12,"context_line":"    port: \"22\""},{"line_number":13,"context_line":"    connect_timeout: 1"},{"line_number":14,"context_line":"    state: stopped"},{"line_number":15,"context_line":"  with_items:"},{"line_number":16,"context_line":"    - \"{{ kolla_internal_vip_address }}\""},{"line_number":17,"context_line":"    - \"{{ kolla_external_vip_address }}\""},{"line_number":18,"context_line":"  when: enable_haproxy | bool"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Checking free port for Aodh API"},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a95cdbc_11a538a1","line":18,"range":{"start_line":2,"start_character":0,"end_line":18,"end_character":29},"updated":"2016-10-06 11:37:10.000000000","message":"I don\u0027t understand why move this check to the top was need. My suggestion is to leave as it was and make changes there.","commit_id":"8d87b4bf1467714502868f130629e74e000e3249"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"2192ea1297817aab5b09274495726df075a7dded","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(duonghq): Assume target ssh is at port 22"},{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"},{"line_number":6,"context_line":"# I put the check before all other port checks because"},{"line_number":7,"context_line":"# if the VIP is reachable, the Kolla cannot run properly"},{"line_number":8,"context_line":"# so other check is meaningless"},{"line_number":9,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not reachable"},{"line_number":10,"context_line":"  wait_for:"},{"line_number":11,"context_line":"    host: \"{{ item }}\""},{"line_number":12,"context_line":"    port: \"22\""},{"line_number":13,"context_line":"    connect_timeout: 1"},{"line_number":14,"context_line":"    state: stopped"},{"line_number":15,"context_line":"  with_items:"},{"line_number":16,"context_line":"    - \"{{ kolla_internal_vip_address }}\""},{"line_number":17,"context_line":"    - \"{{ kolla_external_vip_address }}\""},{"line_number":18,"context_line":"  when: enable_haproxy | bool"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Checking free port for Aodh API"},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_c98c5d38","line":18,"range":{"start_line":2,"start_character":0,"end_line":18,"end_character":29},"in_reply_to":"1a95cdbc_11a538a1","updated":"2016-10-10 21:26:31.000000000","message":"Agreed, why not update the code in its existing place?","commit_id":"8d87b4bf1467714502868f130629e74e000e3249"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"6aeeb1d558f512cb18955ae7290fd4a38e4d4ba8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# TODO(duonghq): Assume target ssh is at port 22"},{"line_number":3,"context_line":"# need better way to determine if the ip(s) is reachable"},{"line_number":4,"context_line":"# but check by ssh is still better then ping check due to"},{"line_number":5,"context_line":"# many operator block ICMP"},{"line_number":6,"context_line":"# I put the check before all other port checks because"},{"line_number":7,"context_line":"# if the VIP is reachable, the Kolla cannot run properly"},{"line_number":8,"context_line":"# so other check is meaningless"},{"line_number":9,"context_line":"- name: Checking if kolla_internal_vip_address and kolla_external_vip_address are not reachable"},{"line_number":10,"context_line":"  wait_for:"},{"line_number":11,"context_line":"    host: \"{{ item }}\""},{"line_number":12,"context_line":"    port: \"22\""},{"line_number":13,"context_line":"    connect_timeout: 1"},{"line_number":14,"context_line":"    state: stopped"},{"line_number":15,"context_line":"  with_items:"},{"line_number":16,"context_line":"    - \"{{ kolla_internal_vip_address }}\""},{"line_number":17,"context_line":"    - \"{{ kolla_external_vip_address }}\""},{"line_number":18,"context_line":"  when: enable_haproxy | bool"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Checking free port for Aodh API"},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_97699b8e","line":18,"range":{"start_line":2,"start_character":0,"end_line":18,"end_character":29},"in_reply_to":"fa6399be_c98c5d38","updated":"2016-10-11 01:08:51.000000000","message":"I\u0027m very sorry for late reply.\n\nThe IP check should be done first due to it\u0027s meaningless to do other checks if this check fail. I think it\u0027s logical?\n\nIn other word, it\u0027s very time consuming to check other service port on every related-host than VIP check, I think in general, we should move low cost check to top if possible?","commit_id":"8d87b4bf1467714502868f130629e74e000e3249"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"53f0afcaf51bdda900edb6c0ec65f12446f5892a","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    state: stopped"},{"line_number":588,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"- name: Checking if kolla_internal_vip_address is in the same network as network_interface on all nodes"},{"line_number":591,"context_line":"  command: ip -4 -o addr show dev {{ network_interface }}"},{"line_number":592,"context_line":"  register: ip_addr_output"},{"line_number":593,"context_line":"  changed_when: false"},{"line_number":594,"context_line":"  failed_when: \"\u0027169.254.\u0027 not in kolla_internal_vip_address and \\"},{"line_number":595,"context_line":"                kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3]) is none\""},{"line_number":596,"context_line":"  when: enable_haproxy | bool"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"- name: Checking the network_interface is present"},{"line_number":599,"context_line":"  fail: \"msg\u003d\u0027Please check the network_interface property - interface {{ network_interface }} not found\u0027\""},{"line_number":600,"context_line":"  when: network_interface not in ansible_interfaces"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"- name: Checking the network_interface is active"},{"line_number":603,"context_line":"  fail: \"msg\u003d\u0027Please check the network_interface settings - interface {{ network_interface }} is not active\u0027\""},{"line_number":604,"context_line":"  when: hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027active\u0027] !\u003d True"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"- name: Checking the network_interface configuration"},{"line_number":607,"context_line":"  fail: \"msg\u003d\u0027Please check the network_interface settings - interface {{ network_interface }} configuration missing\u0027\""},{"line_number":608,"context_line":"  when: hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027] is not defined"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"- name: Checking the network_interface ip address configuration"},{"line_number":611,"context_line":"  fail: \"msg\u003d\u0027Please check the network_interface settings - interface {{ network_interface }} ip address problem\u0027\""},{"line_number":612,"context_line":"  when: hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] is not defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_cdda064b","line":612,"range":{"start_line":590,"start_character":0,"end_line":612,"end_character":102},"updated":"2016-10-13 23:14:59.000000000","message":"Hi Duong,thanks for your commit\nand if you move vip to top ,you should move those together, \nbut  I don\u0027t think move vip to top is necessary,  we need all port ok,  it no need to think about the relevance","commit_id":"8d87b4bf1467714502868f130629e74e000e3249"}]}