)]}'
{"kolla/common/config.py":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e5c318703e404ead145800a5cbe98ff048a564b4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# DELOREAN \u003d (\"http://buildlogs.centos.org/centos/7/cloud/x86_64/\""},{"line_number":32,"context_line":"#            \"rdo-trunk-master-tested/delorean.repo\")"},{"line_number":33,"context_line":"# TODO(pbourke): update to buildlogs.centos.org once this moves"},{"line_number":34,"context_line":"# DELOREAN_DEPS \u003d \"http://trunk.rdoproject.org/centos7/delorean-deps.repo\""},{"line_number":35,"context_line":"INSTALL_TYPE_CHOICES \u003d [\u0027binary\u0027, \u0027source\u0027, \u0027rdo\u0027, \u0027rhos\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_PROFILE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_51c95225","line":34,"updated":"2016-10-07 06:12:28.000000000","message":"I think this can be removed... (29 - 34)","commit_id":"959c8712caba44650cc5afe94ecb95d3958894d9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ac0aa1b6fd33c4dc7a1dddc53c61875d12ba3f3b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# DELOREAN \u003d (\"http://buildlogs.centos.org/centos/7/cloud/x86_64/\""},{"line_number":32,"context_line":"#            \"rdo-trunk-master-tested/delorean.repo\")"},{"line_number":33,"context_line":"# TODO(pbourke): update to buildlogs.centos.org once this moves"},{"line_number":34,"context_line":"# DELOREAN_DEPS \u003d \"http://trunk.rdoproject.org/centos7/delorean-deps.repo\""},{"line_number":35,"context_line":"INSTALL_TYPE_CHOICES \u003d [\u0027binary\u0027, \u0027source\u0027, \u0027rdo\u0027, \u0027rhos\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_PROFILE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_11926af6","line":34,"updated":"2016-10-07 06:15:01.000000000","message":"no need touch this. just remove the default value in the rpm_set_config","commit_id":"959c8712caba44650cc5afe94ecb95d3958894d9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"86bf2971ae59041f5b584630182d15235b244da6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# DELOREAN \u003d (\"http://buildlogs.centos.org/centos/7/cloud/x86_64/\""},{"line_number":32,"context_line":"#            \"rdo-trunk-master-tested/delorean.repo\")"},{"line_number":33,"context_line":"# TODO(pbourke): update to buildlogs.centos.org once this moves"},{"line_number":34,"context_line":"# DELOREAN_DEPS \u003d \"http://trunk.rdoproject.org/centos7/delorean-deps.repo\""},{"line_number":35,"context_line":"INSTALL_TYPE_CHOICES \u003d [\u0027binary\u0027, \u0027source\u0027, \u0027rdo\u0027, \u0027rhos\u0027]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_PROFILE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_51331214","line":34,"in_reply_to":"1a95cdbc_51c95225","updated":"2016-10-07 06:21:01.000000000","message":"Yes, agree. This will be branched as stable/newton and don\u0027t need delorean config. As an easy step for next maaster we can leave it commented. But from newton branch not makes sense","commit_id":"959c8712caba44650cc5afe94ecb95d3958894d9"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e5c318703e404ead145800a5cbe98ff048a564b4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"},{"line_number":147,"context_line":"               default\u003d\u0027Kolla Project (https://launchpad.net/kolla)\u0027,"},{"line_number":148,"context_line":"               help\u003d\u0027The MAINTAINER field\u0027),"},{"line_number":149,"context_line":"    cfg.ListOpt(\u0027rpm_setup_config\u0027, default\u003d[DELOREAN, DELOREAN_DEPS],"},{"line_number":150,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":151,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":152,"context_line":"    cfg.StrOpt(\u0027apt_sources_list\u0027, help\u003d(\u0027Path to custom sources.list\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_31e1269b","line":149,"range":{"start_line":149,"start_character":45,"end_line":149,"end_character":68},"updated":"2016-10-07 06:12:28.000000000","message":"this as well","commit_id":"959c8712caba44650cc5afe94ecb95d3958894d9"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"f4ba07b56b2e7242ccbe5d0afdfd677c251e707a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"},{"line_number":145,"context_line":"               default\u003d\u0027Kolla Project (https://launchpad.net/kolla)\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027The MAINTAINER field\u0027),"},{"line_number":147,"context_line":"    cfg.ListOpt(\u0027rpm_setup_config\u0027, default\u003d[DELOREAN, DELOREAN_DEPS],"},{"line_number":148,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":149,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":150,"context_line":"    cfg.StrOpt(\u0027apt_sources_list\u0027, help\u003d(\u0027Path to custom sources.list\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_06422dae","side":"PARENT","line":147,"range":{"start_line":147,"start_character":36,"end_line":147,"end_character":70},"updated":"2016-10-07 08:57:34.000000000","message":"What\u0027s happening here exactly?","commit_id":"b58147bcc0a98f694075b9593bffced1ab63bec0"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ff8c5721d248999f0cf4abc2c4f26e659fdd62cf","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"},{"line_number":145,"context_line":"               default\u003d\u0027Kolla Project (https://launchpad.net/kolla)\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027The MAINTAINER field\u0027),"},{"line_number":147,"context_line":"    cfg.ListOpt(\u0027rpm_setup_config\u0027, default\u003d[DELOREAN, DELOREAN_DEPS],"},{"line_number":148,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":149,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":150,"context_line":"    cfg.StrOpt(\u0027apt_sources_list\u0027, help\u003d(\u0027Path to custom sources.list\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_beded10e","side":"PARENT","line":147,"updated":"2016-10-07 13:52:31.000000000","message":"no need add delorean repo in stable branch. \nThis PS will be revert after newton branch is created.","commit_id":"b58147bcc0a98f694075b9593bffced1ab63bec0"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"bfb36a6ea49d0ab0f4e16d4f312d554ee69dd81e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"},{"line_number":145,"context_line":"               default\u003d\u0027Kolla Project (https://launchpad.net/kolla)\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027The MAINTAINER field\u0027),"},{"line_number":147,"context_line":"    cfg.ListOpt(\u0027rpm_setup_config\u0027, default\u003d[DELOREAN, DELOREAN_DEPS],"},{"line_number":148,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":149,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":150,"context_line":"    cfg.StrOpt(\u0027apt_sources_list\u0027, help\u003d(\u0027Path to custom sources.list\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_2ae50cdb","side":"PARENT","line":147,"in_reply_to":"1a95cdbc_beded10e","updated":"2016-10-07 21:24:14.000000000","message":"Paul,\n\nAt present we are *still* testing master (which is broken upstream) instead of Newton, which is what we should be testing.  This patch as Jeffrey said will be reverted in t-1 week when the branch is created on the 12th.","commit_id":"b58147bcc0a98f694075b9593bffced1ab63bec0"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ff8c5721d248999f0cf4abc2c4f26e659fdd62cf","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"},{"line_number":145,"context_line":"               default\u003d\u0027Kolla Project (https://launchpad.net/kolla)\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027The MAINTAINER field\u0027),"},{"line_number":147,"context_line":"    cfg.ListOpt(\u0027rpm_setup_config\u0027,"},{"line_number":148,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":149,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":150,"context_line":"    cfg.StrOpt(\u0027apt_sources_list\u0027, help\u003d(\u0027Path to custom sources.list\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_dee39dd7","line":147,"updated":"2016-10-07 13:52:31.000000000","message":"default \u003d []\n\nwill be better. :)","commit_id":"aeb86de6fc644a514d060b4ac869cab364266f03"}],"kolla/image/build.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ff8c5721d248999f0cf4abc2c4f26e659fdd62cf","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        self.install_type \u003d conf.install_type"},{"line_number":515,"context_line":"        self.tag \u003d conf.tag"},{"line_number":516,"context_line":"        self.images \u003d list()"},{"line_number":517,"context_line":"        rpm_setup_config \u003d filter(None, conf.rpm_setup_config)"},{"line_number":518,"context_line":"        self.rpm_setup \u003d self.build_rpm_setup(rpm_setup_config)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        rh_base \u003d [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_fee4d9e0","side":"PARENT","line":517,"updated":"2016-10-07 13:52:31.000000000","message":"btw, why we need call filter here?","commit_id":"b58147bcc0a98f694075b9593bffced1ab63bec0"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"bfb36a6ea49d0ab0f4e16d4f312d554ee69dd81e","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        self.install_type \u003d conf.install_type"},{"line_number":515,"context_line":"        self.tag \u003d conf.tag"},{"line_number":516,"context_line":"        self.images \u003d list()"},{"line_number":517,"context_line":"        rpm_setup_config \u003d filter(None, conf.rpm_setup_config)"},{"line_number":518,"context_line":"        self.rpm_setup \u003d self.build_rpm_setup(rpm_setup_config)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        rh_base \u003d [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_0abdb0b6","side":"PARENT","line":517,"in_reply_to":"1a95cdbc_fee4d9e0","updated":"2016-10-07 21:24:14.000000000","message":"Jeffrey,\n\nI have no idea why filter is there - but obviously if conf.rpm_setup_config is Null the iterator will fail.  Hence the hack on the right.","commit_id":"b58147bcc0a98f694075b9593bffced1ab63bec0"}]}