)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"7df10c41d109e51736da06f50673f24fd7b46faa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"roles. Leave galera.cnf for back compatible. Add mariadb.cnf for better"},{"line_number":11,"context_line":"use."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TrivialFix"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I39efef6c3702118b7373a7e8e32d35e52861acbb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_ba869163","line":13,"updated":"2016-10-10 18:59:39.000000000","message":"Is this really a Trivial Fix?  Shouldn\u0027t this patch set need a bug ID here?","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5412493e40a54eb9cba4425dbec119517e21190a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"roles. Leave galera.cnf for back compatible. Add mariadb.cnf for better"},{"line_number":11,"context_line":"use."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TrivialFix"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I39efef6c3702118b7373a7e8e32d35e52861acbb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_8b77b201","line":13,"updated":"2016-10-11 03:59:43.000000000","message":"will file a bug.","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"}],"ansible/roles/mariadb/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5412493e40a54eb9cba4425dbec119517e21190a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(Jeffrey4l): mariadb.cnf file is expected custom filename. galera.cnf"},{"line_number":18,"context_line":"# file is for backward compatible."},{"line_number":19,"context_line":"- name: Copying over galera.cnf"},{"line_number":20,"context_line":"  merge_configs:"},{"line_number":21,"context_line":"    vars:"},{"line_number":22,"context_line":"      service_name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_ab7476fd","line":19,"updated":"2016-10-11 03:59:43.000000000","message":"I perfer to use \"Copying over mariadb.cnf\". This PS trying to remove the word \"galera\" for less confusion.","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"7df10c41d109e51736da06f50673f24fd7b46faa","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(Jeffrey4l): mariadb.cnf file is expected custom filename. galera.cnf"},{"line_number":18,"context_line":"# file is for backward compatible."},{"line_number":19,"context_line":"- name: Copying over galera.cnf"},{"line_number":20,"context_line":"  merge_configs:"},{"line_number":21,"context_line":"    vars:"},{"line_number":22,"context_line":"      service_name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_5ae73540","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":31},"updated":"2016-10-10 18:59:39.000000000","message":"This should be:\n\n\n  Copying over galera.cnf and mariadb.cnf","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"d4363e39c26f7764bd6fd88091f3c50a4e160e5d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# NOTE(Jeffrey4l): mariadb.cnf file is expected custom filename. galera.cnf"},{"line_number":18,"context_line":"# file is for backward compatible."},{"line_number":19,"context_line":"- name: Copying over galera.cnf"},{"line_number":20,"context_line":"  merge_configs:"},{"line_number":21,"context_line":"    vars:"},{"line_number":22,"context_line":"      service_name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_c6035f75","line":19,"in_reply_to":"fa6399be_ab7476fd","updated":"2016-10-11 04:48:01.000000000","message":"In deprecation period, I prefer to put both name here with some note about galera, due to you still merge galera file.\n\nGalera and Mariadb is different to each other, the Galera name make user confuse but leave it in config and put one more name still does not better.","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"7df10c41d109e51736da06f50673f24fd7b46faa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      - \"{{ role_path }}/templates/galera.cnf.j2\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/galera.cnf\""},{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/mariadb/{{ inventory_hostname }}/galera.cnf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/mariadb.cnf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/mariadb/{{ inventory_hostname }}/mariadb.cnf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/galera.cnf\""},{"line_number":30,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_7a69598b","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":45},"updated":"2016-10-10 18:59:39.000000000","message":"Where is the jinja2 template for mariadb.cnf?\n\n\nShouldn\u0027t it be added in:\n\n\n  ansible/roles/mariadb/templates/mariadb.cnf.j2","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5412493e40a54eb9cba4425dbec119517e21190a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      - \"{{ role_path }}/templates/galera.cnf.j2\""},{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/galera.cnf\""},{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/mariadb/{{ inventory_hostname }}/galera.cnf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/mariadb.cnf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/mariadb/{{ inventory_hostname }}/mariadb.cnf\""},{"line_number":29,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/galera.cnf\""},{"line_number":30,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_cb5fea73","line":27,"updated":"2016-10-11 03:59:43.000000000","message":"this is custome config file. i.e. /etc/kolla/config file. we never add .j2 suffix for it. So no need add .j2","commit_id":"e2b4be5792e67b0d9a5095c2fecf59092db4c955"}]}