)]}'
{"docker/base/set_configs.py":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"7b34aa5fee393c95313ccf725fcfc7363ba0508b","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    with open(\u0027/run_command\u0027, \u0027w+\u0027) as f:"},{"line_number":195,"context_line":"        f.write(config[\u0027command\u0027])"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def set_permissions(config):"},{"line_number":198,"context_line":"    for permission in config.get(\u0027permissions\u0027, list()):"},{"line_number":199,"context_line":"        path \u003d permission.get(\u0027path\u0027)"},{"line_number":200,"context_line":"        owner \u003d permission.get(\u0027owner\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_ba085193","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":28},"updated":"2016-10-10 19:10:32.000000000","message":"This caused pep8 failure in gate.  Could you check?\n\n\nhttp://logs.openstack.org/98/384598/1/check/gate-kolla-pep8-ubuntu-xenial/f14b58d/console.html#_2016-10-10_15_33_15_435900","commit_id":"35d43acbdb41072592a199a36035bdb36344bb82"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"32c2806bd8d7faab044559a2cc369e6e42f6d96f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    LOG.info(\u0027The config files are in the expected state\u0027)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"def main():"},{"line_number":288,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":289,"context_line":"    parser.add_argument(\u0027--check\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_1c594335","line":286,"updated":"2016-10-10 15:59:00.000000000","message":"too many empty lines","commit_id":"35d43acbdb41072592a199a36035bdb36344bb82"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"32c2806bd8d7faab044559a2cc369e6e42f6d96f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":303,"context_line":"    try:"},{"line_number":304,"context_line":"        exit_code \u003d main()"},{"line_number":305,"context_line":"    except:"},{"line_number":306,"context_line":"        exit_code \u003d 1"},{"line_number":307,"context_line":"        LOG.exception(\u0027Unexpected error:\u0027)"},{"line_number":308,"context_line":"    finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_fc6c97d1","line":305,"updated":"2016-10-10 15:59:00.000000000","message":"please, log actual exception. We need to see this trace;)","commit_id":"35d43acbdb41072592a199a36035bdb36344bb82"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"50968d9b4f375e5959bbf97a12c9ff4488a5c66e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            if not group:"},{"line_number":207,"context_line":"                group \u003d user"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            user, group \u003d owner, owner"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        uid \u003d pwd.getpwnam(user).pw_uid"},{"line_number":212,"context_line":"        gid \u003d grp.getgrnam(group).gr_gid"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_5e6c05d0","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":38},"updated":"2016-10-13 10:34:41.000000000","message":"Better logic would be to not touch group in this case","commit_id":"4c207bc0399f024f24c05446a6924875c0f7aaef"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"deb20f590612963998a496fe1b04ede6d3155965","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            if not group:"},{"line_number":207,"context_line":"                group \u003d user"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            user, group \u003d owner, owner"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        uid \u003d pwd.getpwnam(user).pw_uid"},{"line_number":212,"context_line":"        gid \u003d grp.getgrnam(group).gr_gid"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_7f5d4378","line":209,"updated":"2016-10-13 11:24:51.000000000","message":"it is not common case to just user without group. and we use this pattern in config_files.","commit_id":"4c207bc0399f024f24c05446a6924875c0f7aaef"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"0b64c44938e4f8fd90dfeb5fb5835956c894325b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            if not group:"},{"line_number":207,"context_line":"                group \u003d user"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            user, group \u003d owner, owner"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        uid \u003d pwd.getpwnam(user).pw_uid"},{"line_number":212,"context_line":"        gid \u003d grp.getgrnam(group).gr_gid"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_312dbffe","line":209,"in_reply_to":"fa6399be_7f5d4378","updated":"2016-10-13 11:41:06.000000000","message":"Maybe not common but differs from standard expected chown behaviour","commit_id":"4c207bc0399f024f24c05446a6924875c0f7aaef"}]}