)]}'
{"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"fb4bead39018118b9be724d94426bfcb55582a33","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027libxslt-devel\u0027,"},{"line_number":201,"context_line":"            \u0027libyaml-devel\u0027,"},{"line_number":202,"context_line":"            \u0027MariaDB-devel\u0027,"},{"line_number":203,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":204,"context_line":"            \u0027openldap-devel\u0027,"},{"line_number":205,"context_line":"            \u0027openssl-devel\u0027,"},{"line_number":206,"context_line":"            \u0027postgresql\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa6399be_7d0e8c35","line":203,"updated":"2016-10-11 14:33:09.000000000","message":"this has to be removed because we install it using pip","commit_id":"6a57d1d4188ffd1830c4f79a309d5fe74675d9db"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"90be7a00cc528f7e3d8d64380939025a4b807f9d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        \u0027jsonpatch\u0027,"},{"line_number":269,"context_line":"        \u0027jsonpointer\u0027,"},{"line_number":270,"context_line":"        \u0027jsonschema\u0027,"},{"line_number":271,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":272,"context_line":"        \u0027keystoneauth1\u0027,"},{"line_number":273,"context_line":"        \u0027keystonemiddleware\u0027,"},{"line_number":274,"context_line":"        \u0027kombu\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa6399be_bd6ae418","line":271,"range":{"start_line":271,"start_character":8,"end_line":271,"end_character":22},"updated":"2016-10-11 14:46:08.000000000","message":"Not sure if it is a good idea to polute all images with MySQL python bits, could you explain why it is needed everywhere? If only Horizon needs why not to add just to Horizon?","commit_id":"93abc292fcbb1604c48718279002992d6fefa79c"},{"author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"change_message_id":"3e6619a825cfe6381cb0b078d6376e81cb3a61e1","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        \u0027jsonpatch\u0027,"},{"line_number":269,"context_line":"        \u0027jsonpointer\u0027,"},{"line_number":270,"context_line":"        \u0027jsonschema\u0027,"},{"line_number":271,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":272,"context_line":"        \u0027keystoneauth1\u0027,"},{"line_number":273,"context_line":"        \u0027keystonemiddleware\u0027,"},{"line_number":274,"context_line":"        \u0027kombu\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa6399be_7d03ec73","line":271,"updated":"2016-10-11 14:45:39.000000000","message":"move this under msgpack-python to keep the packages in order","commit_id":"93abc292fcbb1604c48718279002992d6fefa79c"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"71054edeeca608bad99f5344f87f3186bf186c75","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        \u0027jsonpatch\u0027,"},{"line_number":269,"context_line":"        \u0027jsonpointer\u0027,"},{"line_number":270,"context_line":"        \u0027jsonschema\u0027,"},{"line_number":271,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":272,"context_line":"        \u0027keystoneauth1\u0027,"},{"line_number":273,"context_line":"        \u0027keystonemiddleware\u0027,"},{"line_number":274,"context_line":"        \u0027kombu\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa6399be_808853e9","line":271,"range":{"start_line":271,"start_character":8,"end_line":271,"end_character":22},"in_reply_to":"fa6399be_bd6ae418","updated":"2016-10-11 15:02:20.000000000","message":"I\u0027m pretty sure other services require this package, adding it here is reasonable.","commit_id":"93abc292fcbb1604c48718279002992d6fefa79c"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"372efc02bb11512e2a0c7ee8d4a3d910c3c431b0","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027libxslt-devel\u0027,"},{"line_number":201,"context_line":"            \u0027libyaml-devel\u0027,"},{"line_number":202,"context_line":"            \u0027MariaDB-devel\u0027,"},{"line_number":203,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":204,"context_line":"            \u0027openldap-devel\u0027,"},{"line_number":205,"context_line":"            \u0027openssl-devel\u0027,"},{"line_number":206,"context_line":"            \u0027postgresql\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_654c0271","side":"PARENT","line":203,"updated":"2016-10-12 13:37:53.000000000","message":"why remove from centos?\n\nReading through the history on this review, you mentioned previously this is installed via pip for binary packaging.  Where precisely?  If you are speaking of the toolbox container, that is based upon base- not openstack-base.","commit_id":"24ec175f95ed38d8e3b85e1fe10ed1f1f3af987b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c2dd120af1856afedb4b4cc8d10db5cd83faa911","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027libxslt-devel\u0027,"},{"line_number":201,"context_line":"            \u0027libyaml-devel\u0027,"},{"line_number":202,"context_line":"            \u0027MariaDB-devel\u0027,"},{"line_number":203,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":204,"context_line":"            \u0027openldap-devel\u0027,"},{"line_number":205,"context_line":"            \u0027openssl-devel\u0027,"},{"line_number":206,"context_line":"            \u0027postgresql\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_b0549721","side":"PARENT","line":203,"in_reply_to":"fa6399be_654c0271","updated":"2016-10-12 14:51:38.000000000","message":"python package installed with yum/dnf in source container, python packages should be installed with pip. because of that i removed MySQL-python package here.","commit_id":"24ec175f95ed38d8e3b85e1fe10ed1f1f3af987b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"9a6f6c2bd6a18df8caff5a91a2c45a29c3c88be6","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027libxslt-devel\u0027,"},{"line_number":201,"context_line":"            \u0027libyaml-devel\u0027,"},{"line_number":202,"context_line":"            \u0027MariaDB-devel\u0027,"},{"line_number":203,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":204,"context_line":"            \u0027openldap-devel\u0027,"},{"line_number":205,"context_line":"            \u0027openssl-devel\u0027,"},{"line_number":206,"context_line":"            \u0027postgresql\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_21108da8","side":"PARENT","line":203,"in_reply_to":"fa6399be_b0549721","updated":"2016-10-17 16:40:11.000000000","message":"right - missed line 193.","commit_id":"24ec175f95ed38d8e3b85e1fe10ed1f1f3af987b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"6fe869b42f5860e006c9ca6c94d24e95bade0aa5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            \u0027libXi\u0027,"},{"line_number":40,"context_line":"            \u0027libxslt\u0027,"},{"line_number":41,"context_line":"            \u0027libyaml\u0027,"},{"line_number":42,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":43,"context_line":"            \u0027Percona-Server-shared-56\u0027,"},{"line_number":44,"context_line":"            \u0027pyOpenSSL\u0027,"},{"line_number":45,"context_line":"            \u0027pyparsing\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_6b3690e8","line":42,"updated":"2016-10-12 14:52:59.000000000","message":"binary installation","commit_id":"579dc84e053490459b8641eef3f984c34e5ebe67"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"6fe869b42f5860e006c9ca6c94d24e95bade0aa5","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            \u0027python-memcache\u0027,"},{"line_number":174,"context_line":"            \u0027python-mistralclient\u0027,"},{"line_number":175,"context_line":"            \u0027python-muranoclient\u0027,"},{"line_number":176,"context_line":"            \u0027python-mysqldb\u0027,"},{"line_number":177,"context_line":"            \u0027python-pip\u0027,"},{"line_number":178,"context_line":"            \u0027python-saharaclient\u0027,"},{"line_number":179,"context_line":"            \u0027python-swiftclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_8b1e8461","line":176,"updated":"2016-10-12 14:52:59.000000000","message":"binary installation","commit_id":"579dc84e053490459b8641eef3f984c34e5ebe67"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c2dd120af1856afedb4b4cc8d10db5cd83faa911","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    \u0026\u0026 rm get-pip.py"},{"line_number":235,"context_line":"{% endblock %}"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"{% set openstack_base_pip_packages \u003d ["},{"line_number":238,"context_line":"        \u0027Babel\u0027,"},{"line_number":239,"context_line":"        \u0027Mako\u0027,"},{"line_number":240,"context_line":"        \u0027MarkupSafe\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_103c63e1","line":237,"updated":"2016-10-12 14:51:38.000000000","message":"This is the list of pip packages, installed for all distros.","commit_id":"579dc84e053490459b8641eef3f984c34e5ebe67"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"372efc02bb11512e2a0c7ee8d4a3d910c3c431b0","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        \u0027kombu\u0027,"},{"line_number":274,"context_line":"        \u0027monotonic\u0027,"},{"line_number":275,"context_line":"        \u0027msgpack-python\u0027,"},{"line_number":276,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":277,"context_line":"        \u0027netaddr\u0027,"},{"line_number":278,"context_line":"        \u0027netifaces\u0027,"},{"line_number":279,"context_line":"        \u0027os-client-config\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_855e7610","line":276,"updated":"2016-10-12 13:37:53.000000000","message":"and then add to ubuntu?  Shouldn\u0027t it be in both?","commit_id":"579dc84e053490459b8641eef3f984c34e5ebe67"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c2dd120af1856afedb4b4cc8d10db5cd83faa911","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        \u0027kombu\u0027,"},{"line_number":274,"context_line":"        \u0027monotonic\u0027,"},{"line_number":275,"context_line":"        \u0027msgpack-python\u0027,"},{"line_number":276,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":277,"context_line":"        \u0027netaddr\u0027,"},{"line_number":278,"context_line":"        \u0027netifaces\u0027,"},{"line_number":279,"context_line":"        \u0027os-client-config\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa6399be_90307303","line":276,"in_reply_to":"fa6399be_855e7610","updated":"2016-10-12 14:51:38.000000000","message":"see my comment in line 237","commit_id":"579dc84e053490459b8641eef3f984c34e5ebe67"}]}