)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ac0386400d5b12fe3f8273dd0207f22365e72db9","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I17b2a47b95ed7dea391f1427a41c92b15c97986d"},{"line_number":13,"context_line":"Partially-Implements: blueprint kubernetes-toolbox"},{"line_number":14,"context_line":"(cherry picked from commit 78c981dc70e110c3d09039d14a5845cb46246399)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa6399be_ffab5ed4","line":14,"updated":"2016-10-18 17:45:23.000000000","message":"you are push PS on master, why it has cherry pick?","commit_id":"acae9075af058e09ef51f05b169aef8853fccb6b"}],"ansible/roles/common/defaults/main.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ac0386400d5b12fe3f8273dd0207f22365e72db9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"kubetoolbox_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-kubetoolbox\""},{"line_number":26,"context_line":"kubetoolbox_tag: \"{{ openstack_release }}\""},{"line_number":27,"context_line":"kubetoolbox_image_full: \"{{ kubetoolbox_image }}:{{ kubetoolbox_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_1fb9f22e","line":27,"updated":"2016-10-18 17:45:23.000000000","message":"no need add such.","commit_id":"acae9075af058e09ef51f05b169aef8853fccb6b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a99d7a08ca9b3624b6f7a6cc69b19b6b48ca7972","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"kubetoolbox_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-kubetoolbox\""},{"line_number":26,"context_line":"kubetoolbox_tag: \"{{ openstack_release }}\""},{"line_number":27,"context_line":"kubetoolbox_image_full: \"{{ kubetoolbox_image }}:{{ kubetoolbox_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_bf480689","line":27,"in_reply_to":"fa6399be_1fb9f22e","updated":"2016-10-18 18:01:24.000000000","message":"jeffrey can you expand here please?","commit_id":"acae9075af058e09ef51f05b169aef8853fccb6b"}],"docker/kubetoolbox/Dockerfile.j2":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"96b1f62d0a8e18fec6a6facca9f92f4d32fed4e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{{ macros.install_packages(kubetoolbox_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN wget -O /usr/bin/kubectl http://storage.googleapis.com/kubernetes-release/release/v1.4.0/bin/linux/amd64/kubectl"},{"line_number":30,"context_line":"RUN chmod uog+x /usr/bin/kubectl"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% block kubetoolbox_footer %}{% endblock %}"},{"line_number":33,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa6399be_301efcba","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":13},"updated":"2016-10-11 14:15:46.000000000","message":"uog？what\u0027s mean?","commit_id":"812f741ac51e487dde0ea2207915b37710310b86"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e397cb87307a02fa43a952ecbe2ee88f0b43054d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{{ macros.install_packages(kubetoolbox_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN wget -O /usr/bin/kubectl http://storage.googleapis.com/kubernetes-release/release/v1.4.0/bin/linux/amd64/kubectl"},{"line_number":30,"context_line":"RUN chmod uog+x /usr/bin/kubectl"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% block kubetoolbox_footer %}{% endblock %}"},{"line_number":33,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa6399be_b0a4cc57","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":13},"in_reply_to":"fa6399be_301efcba","updated":"2016-10-11 14:17:46.000000000","message":"it adds execute bit to User, Other, Group.","commit_id":"812f741ac51e487dde0ea2207915b37710310b86"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"045f87d38b57113d7b5eded79a2beeab1d84e9ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% set kubetoolbox_packages \u003d ["},{"line_number":11,"context_line":"     \u0027wget\u0027,"},{"line_number":12,"context_line":"     \u0027jq\u0027,"},{"line_number":13,"context_line":"     \u0027ceph-common\u0027,"},{"line_number":14,"context_line":"     \u0027ipmitool\u0027"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% set kubetoolbox_packages \u003d ["},{"line_number":20,"context_line":"     \u0027wget\u0027,"},{"line_number":21,"context_line":"     \u0027jq\u0027,"},{"line_number":22,"context_line":"     \u0027ceph-common\u0027,"},{"line_number":23,"context_line":"     \u0027ipmitool\u0027"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{ macros.install_packages(kubetoolbox_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa6399be_3d7ed4e4","line":24,"range":{"start_line":10,"start_character":0,"end_line":24,"end_character":8},"updated":"2016-10-11 14:44:26.000000000","message":"the package list here seems to be the same so distro specific blocks aren\u0027t needed.\n\nAlso given the small amount of tools being added would we get away with just adding them to the existing toolbox image?","commit_id":"288cebb9970c691de55d4330a6d4b718f1a6d01b"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7b41c7f8b908f2ab1368ab0f9d58cad42452c7c0","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% set kubetoolbox_packages \u003d ["},{"line_number":11,"context_line":"     \u0027wget\u0027,"},{"line_number":12,"context_line":"     \u0027jq\u0027,"},{"line_number":13,"context_line":"     \u0027ceph-common\u0027,"},{"line_number":14,"context_line":"     \u0027ipmitool\u0027"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% set kubetoolbox_packages \u003d ["},{"line_number":20,"context_line":"     \u0027wget\u0027,"},{"line_number":21,"context_line":"     \u0027jq\u0027,"},{"line_number":22,"context_line":"     \u0027ceph-common\u0027,"},{"line_number":23,"context_line":"     \u0027ipmitool\u0027"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{ macros.install_packages(kubetoolbox_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa6399be_205ea7e9","line":24,"range":{"start_line":10,"start_character":0,"end_line":24,"end_character":8},"in_reply_to":"fa6399be_3d7ed4e4","updated":"2016-10-11 14:51:39.000000000","message":"kolla tool box has tons of things which we do not really need, so I am not sure if there is an advantage in extending current toolbox with kuberenetes binary over a new toolbox image with kubernetes required tools.\nAs per the same set of images for both distros, it was done for future when packge names will not match.","commit_id":"288cebb9970c691de55d4330a6d4b718f1a6d01b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4cb25a63e330af5af3a74f2cfd8d7a1e7ba15f20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_840c8a3c","line":33,"updated":"2016-10-13 10:52:42.000000000","message":"missing drop root","commit_id":"78c981dc70e110c3d09039d14a5845cb46246399"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e32315d59b92b51f556cbf5f86cd3dd085f85a00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa6399be_a7a50da3","line":33,"in_reply_to":"fa6399be_840c8a3c","updated":"2016-10-13 12:15:07.000000000","message":"@Paul, one of the functions in kubernetes for this container is to deal with external ceph cluster we need to kolla-kubernetes. So bunch of ceph commands are executed in this context. I also checked kolla ceph implementation and it also runs with root as a user..","commit_id":"78c981dc70e110c3d09039d14a5845cb46246399"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ac0386400d5b12fe3f8273dd0207f22365e72db9","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block kubetoolbox_footer %}{% endblock %}"},{"line_number":31,"context_line":"{% block footer %}{% endblock %}"},{"line_number":32,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa6399be_3fb6b63d","line":32,"updated":"2016-10-18 17:45:23.000000000","message":"USER?","commit_id":"acae9075af058e09ef51f05b169aef8853fccb6b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a99d7a08ca9b3624b6f7a6cc69b19b6b48ca7972","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block kubetoolbox_footer %}{% endblock %}"},{"line_number":31,"context_line":"{% block footer %}{% endblock %}"},{"line_number":32,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa6399be_7f358ef5","line":32,"in_reply_to":"fa6399be_3fb6b63d","updated":"2016-10-18 18:01:24.000000000","message":"not needed at this time.","commit_id":"acae9075af058e09ef51f05b169aef8853fccb6b"}]}