)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"17fdccc9046eee313f50eda4f562e5606f8d47df","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"read kolla-build.conf by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change makes kolla-build read is config file"},{"line_number":10,"context_line":"  correctly by default."},{"line_number":11,"context_line":"- This change corrects the file name of the apt_sources_list"},{"line_number":12,"context_line":"  and apt_preferences to include the distro."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_2cf9fd4d","line":9,"updated":"2016-10-12 23:24:27.000000000","message":"Should this be 2 changes?","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"489fbad521ee056c24c61a36e3d3e58946c2d2cb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"read kolla-build.conf by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change makes kolla-build read is config file"},{"line_number":10,"context_line":"  correctly by default."},{"line_number":11,"context_line":"- This change corrects the file name of the apt_sources_list"},{"line_number":12,"context_line":"  and apt_preferences to include the distro."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_33322a60","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":22},"updated":"2016-10-13 10:12:29.000000000","message":"What is it currently doing that\u0027s not correct?","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"68c6575f932160ba022f639385b06e83d61ade67","unresolved":false,"context_lines":[{"line_number":7,"context_line":"read kolla-build.conf by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change makes kolla-build read is config file"},{"line_number":10,"context_line":"  correctly by default."},{"line_number":11,"context_line":"- This change corrects the file name of the apt_sources_list"},{"line_number":12,"context_line":"  and apt_preferences to include the distro."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_cd4db73f","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":22},"in_reply_to":"fa6399be_33322a60","updated":"2016-10-13 15:57:33.000000000","message":"currently it is not reading part of the config.\n\ni actully dont see how the current code reads any of the kolla build from /etc/kolla/kolla-build.conf but it is picking up the build types and distro somehow.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"489fbad521ee056c24c61a36e3d3e58946c2d2cb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change makes kolla-build read is config file"},{"line_number":10,"context_line":"  correctly by default."},{"line_number":11,"context_line":"- This change corrects the file name of the apt_sources_list"},{"line_number":12,"context_line":"  and apt_preferences to include the distro."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"trivial_fix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_d3d9ee23","line":12,"range":{"start_line":11,"start_character":2,"end_line":12,"end_character":44},"updated":"2016-10-13 10:12:29.000000000","message":"This should be a separate patch","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"68c6575f932160ba022f639385b06e83d61ade67","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change makes kolla-build read is config file"},{"line_number":10,"context_line":"  correctly by default."},{"line_number":11,"context_line":"- This change corrects the file name of the apt_sources_list"},{"line_number":12,"context_line":"  and apt_preferences to include the distro."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"trivial_fix"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_8d3f3f86","line":12,"range":{"start_line":11,"start_character":2,"end_line":12,"end_character":44},"in_reply_to":"fa6399be_d3d9ee23","updated":"2016-10-13 15:57:33.000000000","message":"yes this was what i was originally trying to fix then i discovered that the config was not beeing read.\ni will split these.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"489fbad521ee056c24c61a36e3d3e58946c2d2cb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- This change corrects the file name of the apt_sources_list"},{"line_number":12,"context_line":"  and apt_preferences to include the distro."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"trivial_fix"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4d8d677e878a90477e3517f779fe4afe3310df45"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_d3f00e94","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":11},"updated":"2016-10-13 10:12:29.000000000","message":"TrivialFix (though needs a bug really)","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"}],"kolla/image/build.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"2a28b84446ca6e59a06634c50d53d51bae20ae07","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from kolla.template import filters as jinja_filters"},{"line_number":54,"context_line":"from kolla.template import methods as jinja_methods"},{"line_number":55,"context_line":"from kolla import version"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_os_type():"},{"line_number":58,"context_line":"     return platform.linux_distribution()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_15dd1c0e","line":56,"updated":"2016-10-13 01:27:09.000000000","message":"pep8 will complain unless you have two blank lines here and between the functions.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"2a28b84446ca6e59a06634c50d53d51bae20ae07","unresolved":false,"context_lines":[{"line_number":55,"context_line":"from kolla import version"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_os_type():"},{"line_number":58,"context_line":"     return platform.linux_distribution()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def find_base_dir():"},{"line_number":61,"context_line":"     script_path \u003d os.path.dirname(os.path.realpath(sys.argv[0]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_95e84cb6","line":58,"updated":"2016-10-13 01:27:09.000000000","message":"Need to import platform. Also this is indented one space too far.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"17fdccc9046eee313f50eda4f562e5606f8d47df","unresolved":false,"context_lines":[{"line_number":58,"context_line":"     return platform.linux_distribution()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def find_base_dir():"},{"line_number":61,"context_line":"     script_path \u003d os.path.dirname(os.path.realpath(sys.argv[0]))"},{"line_number":62,"context_line":"     if os.path.basename(script_path) \u003d\u003d \u0027cmd\u0027:"},{"line_number":63,"context_line":"         return os.path.realpath(os.path.join(script_path, \u0027..\u0027, \u0027..\u0027))"},{"line_number":64,"context_line":"     if os.path.basename(script_path) \u003d\u003d \u0027bin\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_cc032141","line":61,"updated":"2016-10-12 23:24:27.000000000","message":"Might just be useful to add commentst as to say why checking for \u0027cmd\u0027 or why checking for \u0027tests\u0027 cause its not really obvious (though I think I know).","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"17fdccc9046eee313f50eda4f562e5606f8d47df","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def find_base_dir():"},{"line_number":61,"context_line":"     script_path \u003d os.path.dirname(os.path.realpath(sys.argv[0]))"},{"line_number":62,"context_line":"     if os.path.basename(script_path) \u003d\u003d \u0027cmd\u0027:"},{"line_number":63,"context_line":"         return os.path.realpath(os.path.join(script_path, \u0027..\u0027, \u0027..\u0027))"},{"line_number":64,"context_line":"     if os.path.basename(script_path) \u003d\u003d \u0027bin\u0027:"},{"line_number":65,"context_line":"         if find_os_type()[0] in [\u0027Ubuntu\u0027, \u0027debian\u0027]:"},{"line_number":66,"context_line":"             return \u0027/usr/local/share/kolla\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_4cef1187","line":63,"updated":"2016-10-12 23:24:27.000000000","message":"Nit; use os.path.pardir","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d2244dff2c3ecf29256d22c3c3e0ae7eb856124c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"     if os.path.exists(os.path.join(script_path, \u0027tests\u0027)):"},{"line_number":70,"context_line":"         return script_path"},{"line_number":71,"context_line":"     raise KollaDirNotFoundException("},{"line_number":72,"context_line":"         \u0027I do not know where your Kolla directory is\u0027"},{"line_number":73,"context_line":"     )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def find_config_file(filename):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_cf4073a8","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":53},"updated":"2016-10-12 23:55:51.000000000","message":"Don\u0027t use pronouns in code pls :)  I know nitpicky - but you have another rev after this to fix up the pep8 errors.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"2a28b84446ca6e59a06634c50d53d51bae20ae07","unresolved":false,"context_lines":[{"line_number":70,"context_line":"         return script_path"},{"line_number":71,"context_line":"     raise KollaDirNotFoundException("},{"line_number":72,"context_line":"         \u0027I do not know where your Kolla directory is\u0027"},{"line_number":73,"context_line":"     )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def find_config_file(filename):"},{"line_number":76,"context_line":"    global_conf_path \u003d os.path.join(\u0027/etc/kolla\u0027, filename)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b502b06d","line":73,"updated":"2016-10-13 01:27:09.000000000","message":"This whole function is also indented one space too far.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"2a28b84446ca6e59a06634c50d53d51bae20ae07","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def find_config_file(filename):"},{"line_number":76,"context_line":"    global_conf_path \u003d os.path.join(\u0027/etc/kolla\u0027, filename)"},{"line_number":77,"context_line":"    local_conf_path \u003d os.path.join(find_base_dir(), \u0027etc\u0027, \u0027kolla\u0027, filename)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if os.access(global_conf_path, os.R_OK):"},{"line_number":80,"context_line":"        return global_conf_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_35ef80b1","line":77,"updated":"2016-10-13 01:27:09.000000000","message":"Needs to be wrapped to fit under 79 chars.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ff682d907b1960a07f1528af170029e58a2fc0e8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        raise KollaDirNotFoundException("},{"line_number":85,"context_line":"            \u0027Cant find kolla config. Searched at: %s and %s\u0027 %"},{"line_number":86,"context_line":"            (global_conf_path, local_conf_path)"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def make_a_logger(conf\u003dNone, image_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_a106b9cb","line":87,"updated":"2016-10-14 02:21:17.000000000","message":"i do not think we need this. check oslo_config\u0027s code[0]. it load config files from follwing place\n\n   If a project is specified, following directories are returned::\n      ~/.${project}/\n      ~/\n      /etc/${project}/\n      /etc/\n\n[0] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L605,L629","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"68c6575f932160ba022f639385b06e83d61ade67","unresolved":false,"context_lines":[{"line_number":54,"context_line":"from kolla.template import methods as jinja_methods"},{"line_number":55,"context_line":"from kolla import version"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def find_os_type():"},{"line_number":58,"context_line":"     return platform.linux_distribution()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def find_base_dir():"},{"line_number":61,"context_line":"     script_path \u003d os.path.dirname(os.path.realpath(sys.argv[0]))"},{"line_number":62,"context_line":"     if os.path.basename(script_path) \u003d\u003d \u0027cmd\u0027:"},{"line_number":63,"context_line":"         return os.path.realpath(os.path.join(script_path, \u0027..\u0027, \u0027..\u0027))"},{"line_number":64,"context_line":"     if os.path.basename(script_path) \u003d\u003d \u0027bin\u0027:"},{"line_number":65,"context_line":"         if find_os_type()[0] in [\u0027Ubuntu\u0027, \u0027debian\u0027]:"},{"line_number":66,"context_line":"             return \u0027/usr/local/share/kolla\u0027"},{"line_number":67,"context_line":"         else:"},{"line_number":68,"context_line":"             return \u0027/usr/share/kolla\u0027"},{"line_number":69,"context_line":"     if os.path.exists(os.path.join(script_path, \u0027tests\u0027)):"},{"line_number":70,"context_line":"         return script_path"},{"line_number":71,"context_line":"     raise KollaDirNotFoundException("},{"line_number":72,"context_line":"         \u0027I do not know where your Kolla directory is\u0027"},{"line_number":73,"context_line":"     )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def find_config_file(filename):"},{"line_number":76,"context_line":"    global_conf_path \u003d os.path.join(\u0027/etc/kolla\u0027, filename)"},{"line_number":77,"context_line":"    local_conf_path \u003d os.path.join(find_base_dir(), \u0027etc\u0027, \u0027kolla\u0027, filename)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if os.access(global_conf_path, os.R_OK):"},{"line_number":80,"context_line":"        return global_conf_path"},{"line_number":81,"context_line":"    elif os.access(local_conf_path, os.R_OK):"},{"line_number":82,"context_line":"        return local_conf_path"},{"line_number":83,"context_line":"    else:"},{"line_number":84,"context_line":"        raise KollaDirNotFoundException("},{"line_number":85,"context_line":"            \u0027Cant find kolla config. Searched at: %s and %s\u0027 %"},{"line_number":86,"context_line":"            (global_conf_path, local_conf_path)"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def make_a_logger(conf\u003dNone, image_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_6df02bff","line":87,"range":{"start_line":57,"start_character":0,"end_line":87,"end_character":9},"updated":"2016-10-13 15:57:33.000000000","message":"thanks this is a direct port of the code that was originally in kolla \nhttps://github.com/openstack/kolla/blob/d1b0a8b3c22a368e1639d54a5a36e47222a00520/kolla/cmd/build.py#L290-L323\n\nbut i will respin with the changes that have been pointed out.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b3fb5c9c99f9c94930dbbb2eee01876c62154caf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        raise KollaDirNotFoundException("},{"line_number":85,"context_line":"            \u0027Cant find kolla config. Searched at: %s and %s\u0027 %"},{"line_number":86,"context_line":"            (global_conf_path, local_conf_path)"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def make_a_logger(conf\u003dNone, image_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_a0edc1b8","line":87,"in_reply_to":"fa6399be_a106b9cb","updated":"2016-10-14 12:29:27.000000000","message":"im currently seperating the changes into too and ill test if this is actully needed. when i was fixing the name of the sources list i was observing that self.conf.apt_sources_list was none regradless of the fact that it was set in the config.\n\nwith this change it picked up the config value.\nfrom reading https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L649-L673 it looks like the same effect could be acived by setting project to kolla on line 980 and allow oslo.config to find the directory.","commit_id":"64c35569c2a31abd5c341be18d221fab6c08e63f"}]}