)]}'
{"ansible/roles/mariadb/templates/galera.cnf.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"a3de37e3bf1763d337869356b7cc1e1fdbd1f636","unresolved":false,"context_lines":[{"line_number":47,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ hostvars[inventory_name][\u0027ansible_memory_mb\u0027][\u0027real\u0027][\u0027total\u0027] * 0.4 | round }}M\u0027"},{"line_number":48,"context_line":"max_heap_table_size \u003d \u002764M\u0027"},{"line_number":49,"context_line":"tmp_table_size \u003d \u002764M\u0027"},{"line_number":50,"context_line":"performance_schema \u003d on"},{"line_number":51,"context_line":"skip-name-resolve"},{"line_number":52,"context_line":"general-log \u003d 0"},{"line_number":53,"context_line":"log-output \u003d table"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa6399be_89c1ec56","line":50,"updated":"2016-10-13 18:42:49.000000000","message":"this affects performance (in a bad way) it is disabled by default and should not be enabled here","commit_id":"32a401ae8a89888c10678e1bd76d06fd14aba931"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"a3de37e3bf1763d337869356b7cc1e1fdbd1f636","unresolved":false,"context_lines":[{"line_number":48,"context_line":"max_heap_table_size \u003d \u002764M\u0027"},{"line_number":49,"context_line":"tmp_table_size \u003d \u002764M\u0027"},{"line_number":50,"context_line":"performance_schema \u003d on"},{"line_number":51,"context_line":"skip-name-resolve"},{"line_number":52,"context_line":"general-log \u003d 0"},{"line_number":53,"context_line":"log-output \u003d table"},{"line_number":54,"context_line":"slow_query_log \u003d 1"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa6399be_89dacc4a","line":51,"updated":"2016-10-13 18:42:49.000000000","message":"this only affects hosts with broken dns, dns is required for 90% of kolla to work, I would argue this shouldnt be set. though it probably doesnt hurt anything. It might result in performance increase in improperly configured environments","commit_id":"32a401ae8a89888c10678e1bd76d06fd14aba931"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"a3de37e3bf1763d337869356b7cc1e1fdbd1f636","unresolved":false,"context_lines":[{"line_number":49,"context_line":"tmp_table_size \u003d \u002764M\u0027"},{"line_number":50,"context_line":"performance_schema \u003d on"},{"line_number":51,"context_line":"skip-name-resolve"},{"line_number":52,"context_line":"general-log \u003d 0"},{"line_number":53,"context_line":"log-output \u003d table"},{"line_number":54,"context_line":"slow_query_log \u003d 1"},{"line_number":55,"context_line":"long_query_time \u003d 5"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa6399be_690738ca","line":52,"updated":"2016-10-13 18:42:49.000000000","message":"logging of each query should not be on by default, this line and the three below should be removed","commit_id":"32a401ae8a89888c10678e1bd76d06fd14aba931"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0c8b409b79d7d8557d62e33882e61bd68c766a9e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"key_buffer_size \u003d \u002764M\u0027"},{"line_number":47,"context_line":"max_heap_table_size \u003d \u002764M\u0027"},{"line_number":48,"context_line":"tmp_table_size \u003d \u002764M\u0027"},{"line_number":49,"context_line":"{% dynamic_pool_size_mb \u003d hostvars[inventory_name][\u0027ansible_memory_mb\u0027][\u0027real\u0027][\u0027total\u0027] * 0.4 | round %}"},{"line_number":50,"context_line":"{% if dynamic_pool_size_mb \u003c 8192 %}"},{"line_number":51,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ dynamic_pool_size_mb }}M\u0027"},{"line_number":52,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa6399be_811535e6","line":49,"updated":"2016-10-14 02:22:55.000000000","message":"you left out set \n\n{% set  xxx\u003dyyy %}","commit_id":"d34c4a1db867d79d7c5c47bbe462992ef1ba1e1e"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"774b7de75d17afc76648e798b84a50f06b0fea28","unresolved":false,"context_lines":[{"line_number":46,"context_line":"key_buffer_size \u003d \u002764M\u0027"},{"line_number":47,"context_line":"max_heap_table_size \u003d \u002764M\u0027"},{"line_number":48,"context_line":"tmp_table_size \u003d \u002764M\u0027"},{"line_number":49,"context_line":"{% dynamic_pool_size_mb \u003d hostvars[inventory_name][\u0027ansible_memory_mb\u0027][\u0027real\u0027][\u0027total\u0027] * 0.4 | round %}"},{"line_number":50,"context_line":"{% if dynamic_pool_size_mb \u003c 8192 %}"},{"line_number":51,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ dynamic_pool_size_mb }}M\u0027"},{"line_number":52,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa6399be_31eaedac","line":49,"in_reply_to":"fa6399be_811535e6","updated":"2016-10-14 10:25:40.000000000","message":"fixed","commit_id":"d34c4a1db867d79d7c5c47bbe462992ef1ba1e1e"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d6129b41032e49c079c6f75e23ddc7850f69b698","unresolved":false,"context_lines":[{"line_number":50,"context_line":"{% if dynamic_pool_size_mb \u003c 8192 %}"},{"line_number":51,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ dynamic_pool_size_mb }}M\u0027"},{"line_number":52,"context_line":"{% else %}"},{"line_number":53,"context_line":"innodb_buffer_pool_size \u003d \u00278192M\u0027"},{"line_number":54,"context_line":"{% endif %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[server]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa6399be_e4436d40","line":53,"updated":"2016-10-13 18:59:24.000000000","message":"8G might be too high a default, this should be discussed internally to Kolla before being merged.\n\nI like it otherwise.","commit_id":"d34c4a1db867d79d7c5c47bbe462992ef1ba1e1e"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0c8b409b79d7d8557d62e33882e61bd68c766a9e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"{% if dynamic_pool_size_mb \u003c 8192 %}"},{"line_number":51,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ dynamic_pool_size_mb }}M\u0027"},{"line_number":52,"context_line":"{% else %}"},{"line_number":53,"context_line":"innodb_buffer_pool_size \u003d \u00278192M\u0027"},{"line_number":54,"context_line":"{% endif %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[server]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa6399be_a1d4f91f","line":53,"updated":"2016-10-14 02:22:55.000000000","message":"yep. 8G is too high. i perfer to not set this value in default.","commit_id":"d34c4a1db867d79d7c5c47bbe462992ef1ba1e1e"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"774b7de75d17afc76648e798b84a50f06b0fea28","unresolved":false,"context_lines":[{"line_number":50,"context_line":"{% if dynamic_pool_size_mb \u003c 8192 %}"},{"line_number":51,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ dynamic_pool_size_mb }}M\u0027"},{"line_number":52,"context_line":"{% else %}"},{"line_number":53,"context_line":"innodb_buffer_pool_size \u003d \u00278192M\u0027"},{"line_number":54,"context_line":"{% endif %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[server]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa6399be_51b20195","line":53,"in_reply_to":"fa6399be_a1d4f91f","updated":"2016-10-14 10:25:40.000000000","message":"Well, I think we can all agree that the default value of 128 mb is not nearly enough. As described here (https://dev.mysql.com/doc/refman/5.6/en/innodb-parameters.html#sysvar_innodb_buffer_pool_size) the recommended value is 80% of the machines size. In our case, where docker containers share memory, this i probably too much, which is why I decided to go with 40%. Also, 8GB is not the default here but the upper limit. In my opinion, leaving it at 128M is not a good default for us and we should set it properly for the use case.","commit_id":"d34c4a1db867d79d7c5c47bbe462992ef1ba1e1e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"936a9dc7fa3b3b590d4a9f719c3a3f4938e59a1f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"key_buffer_size \u003d \u002764M\u0027"},{"line_number":47,"context_line":"max_heap_table_size \u003d \u002764M\u0027"},{"line_number":48,"context_line":"tmp_table_size \u003d \u002764M\u0027"},{"line_number":49,"context_line":"{% set dynamic_pool_size_mb \u003d hostvars[inventory_name][\u0027ansible_memory_mb\u0027][\u0027real\u0027][\u0027total\u0027] * 0.4 | round %}"},{"line_number":50,"context_line":"{% if dynamic_pool_size_mb \u003c 8192 %}"},{"line_number":51,"context_line":"innodb_buffer_pool_size \u003d \u0027{{ dynamic_pool_size_mb }}M\u0027"},{"line_number":52,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"fa6399be_d959cc36","line":49,"range":{"start_line":49,"start_character":39,"end_line":49,"end_character":53},"updated":"2016-10-14 15:36:35.000000000","message":"inventory_hostname","commit_id":"6d558a2a774b029355301a84ba6d4a35104c94ca"}]}