)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9f2e0750646043ba6ae6ef975137f7f379c8a15c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It is confusing to have different base home location"},{"line_number":10,"context_line":"for different service."},{"line_number":11,"context_line":"This patch make base home directory common through out the services."},{"line_number":12,"context_line":"And it is recomended to create home directory using --home-dir flag while"},{"line_number":13,"context_line":"adding user for a particular service."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0db1b62fbc58288cd75328d74789e02b926a56c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_01bffcd0","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":36},"updated":"2016-10-21 08:53:09.000000000","message":"Why is this recommend?","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3da7d864b9ae1c851224574206274bc4d15fb20e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch make base home directory common through out the services."},{"line_number":12,"context_line":"And it is recomended to create home directory using --home-dir flag while"},{"line_number":13,"context_line":"adding user for a particular service."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0db1b62fbc58288cd75328d74789e02b926a56c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_add323d4","line":14,"updated":"2016-10-20 16:12:32.000000000","message":"Add bug id","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"4f0dc6ab193ded3856be6b586b7d61f320901fb9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch make base home directory common through out the services."},{"line_number":12,"context_line":"And it is recomended to create home directory using --home-dir flag while"},{"line_number":13,"context_line":"adding user for a particular service."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0db1b62fbc58288cd75328d74789e02b926a56c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_1f127657","line":14,"in_reply_to":"fa6399be_add323d4","updated":"2016-10-20 16:16:53.000000000","message":"Agreed.  Can you add bug ID or link to bp here please?","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"}],"docker/aodh/aodh-base/Dockerfile.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9f2e0750646043ba6ae6ef975137f7f379c8a15c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"ADD aodh-base-archive /aodh-base-source"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"RUN ln -s aodh-base-source/* aodh \\"},{"line_number":66,"context_line":"    \u0026\u0026 useradd --user-group --create-home --home-dir /home/aodh aodh \\"},{"line_number":67,"context_line":"    \u0026\u0026 chmod 777 /home/aodh"},{"line_number":68,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt pymongo /aodh \\"},{"line_number":69,"context_line":"    \u0026\u0026 mkdir -p /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6895a0_01d8dc52","line":66,"range":{"start_line":66,"start_character":42,"end_line":66,"end_character":63},"updated":"2016-10-21 08:53:09.000000000","message":"I think this parameter is not required.\n\n\"The default is to append the LOGIN name to BASE_DIR and use that as the login directory name.\" BASE_DIR is /home by default.","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"160666675159deba29d83b35877ebbc8c222e916","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"RUN ln -s aodh-base-source/* aodh \\"},{"line_number":66,"context_line":"    \u0026\u0026 useradd --user-group --create-home --home-dir /home/aodh aodh \\"},{"line_number":67,"context_line":"    \u0026\u0026 chmod 777 /home/aodh"},{"line_number":68,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt pymongo /aodh \\"},{"line_number":69,"context_line":"    \u0026\u0026 mkdir -p /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh \\"},{"line_number":70,"context_line":"    \u0026\u0026 cp -r /aodh/etc/aodh/* /etc/aodh/  \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa6399be_bbae2c96","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":27},"updated":"2016-10-19 15:24:29.000000000","message":"Why 777? Also seems to be a line continuation missing (\\)","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"160666675159deba29d83b35877ebbc8c222e916","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0026\u0026 mkdir -p /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh \\"},{"line_number":70,"context_line":"    \u0026\u0026 cp -r /aodh/etc/aodh/* /etc/aodh/  \\"},{"line_number":71,"context_line":"    \u0026\u0026 cp /aodh/aodh/api/app.wsgi /var/www/cgi-bin/aodh \\"},{"line_number":72,"context_line":"    \u0026\u0026 chown -R aodh: /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh /home/aodh"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"{% endif %}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa6399be_9b996871","line":72,"range":{"start_line":72,"start_character":74,"end_line":72,"end_character":84},"updated":"2016-10-19 15:24:29.000000000","message":"Is this needed now?","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9f2e0750646043ba6ae6ef975137f7f379c8a15c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \u0026\u0026 mkdir -p /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh \\"},{"line_number":70,"context_line":"    \u0026\u0026 cp -r /aodh/etc/aodh/* /etc/aodh/  \\"},{"line_number":71,"context_line":"    \u0026\u0026 cp /aodh/aodh/api/app.wsgi /var/www/cgi-bin/aodh \\"},{"line_number":72,"context_line":"    \u0026\u0026 chown -R aodh: /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh /home/aodh"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"{% endif %}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6895a0_61e7d812","line":72,"range":{"start_line":72,"start_character":74,"end_line":72,"end_character":84},"in_reply_to":"fa6399be_9b996871","updated":"2016-10-21 08:53:09.000000000","message":"I thinks it is safe to remove this now.","commit_id":"cbf1131d898a56166ca2530e061d7eb9254332db"}]}