)]}'
{"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0d7021db00b26ca15d4e0903c659ec6550065d4a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            \u0027libXi\u0027,"},{"line_number":40,"context_line":"            \u0027libxslt\u0027,"},{"line_number":41,"context_line":"            \u0027libyaml\u0027,"},{"line_number":42,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":43,"context_line":"            \u0027Percona-Server-shared-56\u0027,"},{"line_number":44,"context_line":"            \u0027pyOpenSSL\u0027,"},{"line_number":45,"context_line":"            \u0027pyparsing\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_4da7124f","side":"PARENT","line":42,"updated":"2016-10-31 19:48:51.000000000","message":"if removing these deps, we want shared deps in the openstack-base dockerfile (to cut down on image downloads) so PyMySql python package should be somewhere in these lists since they are likely used by every python service.","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d9a1f0fbe90ccc4996a138ad2fafe4cff0b10a54","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            \u0027libXi\u0027,"},{"line_number":40,"context_line":"            \u0027libxslt\u0027,"},{"line_number":41,"context_line":"            \u0027libyaml\u0027,"},{"line_number":42,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":43,"context_line":"            \u0027Percona-Server-shared-56\u0027,"},{"line_number":44,"context_line":"            \u0027pyOpenSSL\u0027,"},{"line_number":45,"context_line":"            \u0027pyparsing\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_fdf871c5","side":"PARENT","line":42,"in_reply_to":"ba5da102_4da7124f","updated":"2016-11-01 18:31:15.000000000","message":"we are already bringing in PyMySQL in all the appropriate sections I think (lines: 73, 133, 183 \u0026 300).","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c6ba20ecebfa7ee182c70855520e1a13aa591c80","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027python2-oslo-concurrency\u0027,"},{"line_number":58,"context_line":"            \u0027python2-oslo-config\u0027,"},{"line_number":59,"context_line":"            \u0027python2-oslo-context\u0027,"},{"line_number":60,"context_line":"            \u0027python2-oslo-db\u0027,"},{"line_number":61,"context_line":"            \u0027python2-oslo-i18n\u0027,"},{"line_number":62,"context_line":"            \u0027python2-oslo-log\u0027,"},{"line_number":63,"context_line":"            \u0027python2-oslo-messaging\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_919a2062","side":"PARENT","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":30},"updated":"2016-10-31 22:05:30.000000000","message":"This package actually lists both MySQL-python and python2-PyMySQL as dependencies, even though only one of them is required making the removal of MySQL-python currently moot for binary builds.","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1320d37659a37ae11d52b59db781cb11e413b73b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027python2-oslo-concurrency\u0027,"},{"line_number":58,"context_line":"            \u0027python2-oslo-config\u0027,"},{"line_number":59,"context_line":"            \u0027python2-oslo-context\u0027,"},{"line_number":60,"context_line":"            \u0027python2-oslo-db\u0027,"},{"line_number":61,"context_line":"            \u0027python2-oslo-i18n\u0027,"},{"line_number":62,"context_line":"            \u0027python2-oslo-log\u0027,"},{"line_number":63,"context_line":"            \u0027python2-oslo-messaging\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_d488e9c7","side":"PARENT","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":30},"in_reply_to":"ba5da102_919a2062","updated":"2016-11-01 17:37:30.000000000","message":"I guess a transitive dependency here is ok, although i\u0027d prefer it listed","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d9a1f0fbe90ccc4996a138ad2fafe4cff0b10a54","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027python2-oslo-concurrency\u0027,"},{"line_number":58,"context_line":"            \u0027python2-oslo-config\u0027,"},{"line_number":59,"context_line":"            \u0027python2-oslo-context\u0027,"},{"line_number":60,"context_line":"            \u0027python2-oslo-db\u0027,"},{"line_number":61,"context_line":"            \u0027python2-oslo-i18n\u0027,"},{"line_number":62,"context_line":"            \u0027python2-oslo-log\u0027,"},{"line_number":63,"context_line":"            \u0027python2-oslo-messaging\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_5a6083a5","side":"PARENT","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":30},"in_reply_to":"ba5da102_d488e9c7","updated":"2016-11-01 18:31:15.000000000","message":"It is currently listed on line 73.","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1320d37659a37ae11d52b59db781cb11e413b73b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027libxslt-devel\u0027,"},{"line_number":201,"context_line":"            \u0027libyaml-devel\u0027,"},{"line_number":202,"context_line":"            \u0027MariaDB-devel\u0027,"},{"line_number":203,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":204,"context_line":"            \u0027openldap-devel\u0027,"},{"line_number":205,"context_line":"            \u0027openssl-devel\u0027,"},{"line_number":206,"context_line":"            \u0027postgresql\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_749d5d09","side":"PARENT","line":203,"updated":"2016-11-01 17:37:30.000000000","message":"The proper package should be installed in source repos here:\nhttps://github.com/openstack/kolla/blob/master/docker/openstack-base/Dockerfile.j2#L239\n\nWe have a general bias towards including transitive deps in this list to keep the openstack-base image larger but other images smaller with the same bits.","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"d9a1f0fbe90ccc4996a138ad2fafe4cff0b10a54","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            \u0027libxslt-devel\u0027,"},{"line_number":201,"context_line":"            \u0027libyaml-devel\u0027,"},{"line_number":202,"context_line":"            \u0027MariaDB-devel\u0027,"},{"line_number":203,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":204,"context_line":"            \u0027openldap-devel\u0027,"},{"line_number":205,"context_line":"            \u0027openssl-devel\u0027,"},{"line_number":206,"context_line":"            \u0027postgresql\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba5da102_dac65399","side":"PARENT","line":203,"in_reply_to":"ba5da102_749d5d09","updated":"2016-11-01 18:31:15.000000000","message":"It is already in the source repos at line 300 in the section you\u0027re referring too, pymysql is pure python so no package is required here for a source build.","commit_id":"a204b62f22027eb1ed9f2e3ac708e4eb43237f29"}]}