)]}'
{"ansible/roles/baremetal/tasks/install.yml":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"27e68943678a2f711ccfc55c5b02aa61b6eaad95","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  ufw: state\u003ddisabled policy\u003dallow"},{"line_number":9,"context_line":"  when: ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: disable firewalld and iptables"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  service:"},{"line_number":14,"context_line":"    name: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_e7916548","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":15},"updated":"2016-11-03 16:48:04.000000000","message":"Disable","commit_id":"5072e5f8598cb83ddc2a1961de78584c842137a9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f6f948760d19bd48ef5c45f2575b0cece4ffc6f8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    state: stopped"},{"line_number":17,"context_line":"  with_items:"},{"line_number":18,"context_line":"    - firewalld"},{"line_number":19,"context_line":"    - iptables-services"},{"line_number":20,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Install apt packages"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5da102_ed33ff5f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":23},"updated":"2016-11-03 20:34:56.000000000","message":"iptables-services is not a service, is the package to install iptables service, but the service name still being iptables.\nAlsom, iptables-services is not always installed by default, in example: centos 7 minimal don\u0027t have iptables-services package installed. In the case of a missing service, will raise an error due not found.","commit_id":"5072e5f8598cb83ddc2a1961de78584c842137a9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b513e9a0650df4e85b24d026e26db42e10fe620","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when: ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install the latest version of firewalld"},{"line_number":12,"context_line":"  yum: name\u003dfirewalld state\u003dlatest"},{"line_number":13,"context_line":"  register: result"},{"line_number":14,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_1e53ed6d","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":34},"updated":"2016-11-04 07:28:04.000000000","message":"Do we want latest or present? I would prefer present because latest will always update yum cache and take longer time to install. Using present in fresh install will use the latest package and re executing the role will keep the package installed. Personally as operator I don\u0027t like change package version without knowledge.","commit_id":"7611f247a2af0f49290a4295637727a2a869a868"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"840fcad57812e0d26db264a382b428bfb2a11bc3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  ufw: state\u003ddisabled policy\u003dallow"},{"line_number":9,"context_line":"  when: ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install the latest version of firewalld"},{"line_number":12,"context_line":"  yum: name\u003dfirewalld state\u003dpresent"},{"line_number":13,"context_line":"  register: result"},{"line_number":14,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Disable firewalld"},{"line_number":17,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_93336bf6","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":37},"updated":"2016-11-04 12:04:43.000000000","message":"This is strange, why install just to disable?","commit_id":"028e91ef93ec4ba9c8a134578b4256706dbe8bbd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b38c12cbc252bca85af1ce7de114591e2e035f10","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Install the latest version of firewalld"},{"line_number":12,"context_line":"  yum: name\u003dfirewalld state\u003dpresent"},{"line_number":13,"context_line":"  register: result"},{"line_number":14,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Disable firewalld"},{"line_number":17,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5da102_6ffdee6d","line":14,"updated":"2016-11-06 06:12:33.000000000","message":"agree. please do not install it explicit.","commit_id":"028e91ef93ec4ba9c8a134578b4256706dbe8bbd"}]}