)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c4bd68d5e8b326bdb114212b07eb0469660ae9ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Add kafka image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6c9b8f8b0cf254c2c3333ca789c5da364c7d5c73"},{"line_number":10,"context_line":"Partially-Implements: monasca-containers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a71b18c_0a615dd3","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":40},"updated":"2016-12-05 12:01:58.000000000","message":"fix bp link","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"169966f284039d0fc1613bdb87449d7ea70066c6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add kafka image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6c9b8f8b0cf254c2c3333ca789c5da364c7d5c73"},{"line_number":10,"context_line":"Partially-Implements: monasca-containers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a71b18c_f4e9421b","line":10,"updated":"2016-12-12 13:35:56.000000000","message":"I know its annoying, but could you put in blueprint monasca-containers so that gerrit links to it properly?  Thanks.","commit_id":"7229e1bb68037a30230d0353f816fa22a46185ec"}],"docker/kafka/Dockerfile.j2":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c4bd68d5e8b326bdb114212b07eb0469660ae9ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block kafka_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_aa7149aa","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":43},"updated":"2016-12-05 12:01:58.000000000","message":"openstack-base","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"427cf483ce4729aa815dd3f1f074e1683f2a8331","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block kafka_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_562ae990","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":43},"in_reply_to":"3a71b18c_aa7149aa","updated":"2016-12-06 11:43:20.000000000","message":"Non openstack image, so base is right","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"427cf483ce4729aa815dd3f1f074e1683f2a8331","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set kafka_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_e916ba4a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":14},"updated":"2016-12-06 11:43:20.000000000","message":"Please, add message in at build time, \nExample: https://github.com/openstack/kolla/blob/master/docker/freezer/freezer-base/Dockerfile.j2#L10","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"217962b29d55297c10ddaac653e810d6488f27eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set kafka_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_2cfc403d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":14},"in_reply_to":"3a71b18c_e916ba4a","updated":"2016-12-06 12:19:09.000000000","message":"Done","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c4bd68d5e8b326bdb114212b07eb0469660ae9ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set kafka_packages \u003d ["},{"line_number":14,"context_line":"        \u0027default-jre\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_8a6c8dd1","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":22},"updated":"2016-12-05 12:01:58.000000000","message":"comma isn\u0027t needed here","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"217962b29d55297c10ddaac653e810d6488f27eb","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set kafka_packages \u003d ["},{"line_number":14,"context_line":"        \u0027default-jre\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_0c014438","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":22},"in_reply_to":"3a71b18c_8a6c8dd1","updated":"2016-12-06 12:19:09.000000000","message":"same comments from zookeeper, but this prevents merge conflicts and messing up git diffs and stuff","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"427cf483ce4729aa815dd3f1f074e1683f2a8331","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0026\u0026 useradd --user-group --home-dir /kafka kafka \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":25,"context_line":"    \u0026\u0026 usermod -a -G kolla kafka \\"},{"line_number":26,"context_line":"    \u0026\u0026 chown -R kafka: /kafka"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block kafka_footer %}{% endblock %}"},{"line_number":29,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_89538616","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":29},"updated":"2016-12-06 11:43:20.000000000","message":"Owning not needed since path is the same as home-dir for kafka user","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"09a379460807df4bbbdb085281281bd489b9f60d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0026\u0026 useradd --user-group --home-dir /kafka kafka \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":25,"context_line":"    \u0026\u0026 usermod -a -G kolla kafka \\"},{"line_number":26,"context_line":"    \u0026\u0026 chown -R kafka: /kafka"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block kafka_footer %}{% endblock %}"},{"line_number":29,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_c6f6275c","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":29},"in_reply_to":"3a71b18c_476cf59b","updated":"2016-12-07 02:45:20.000000000","message":"If you read the above commands you see that /kafka is a symlink that points to /kafka* which was ADD\u0027ed by the Dockerfile. It is owned by root. --home-dir sets the home directory. --create-home creates it [1]. One fails when it exists, the other does not.\n\nEither way /kafka is _not_ owned by kafka at this point in the dockerfile\n\n[1] https://linux.die.net/man/8/useradd","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"217962b29d55297c10ddaac653e810d6488f27eb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0026\u0026 useradd --user-group --home-dir /kafka kafka \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":25,"context_line":"    \u0026\u0026 usermod -a -G kolla kafka \\"},{"line_number":26,"context_line":"    \u0026\u0026 chown -R kafka: /kafka"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block kafka_footer %}{% endblock %}"},{"line_number":29,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_ecdec8db","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":29},"in_reply_to":"3a71b18c_89538616","updated":"2016-12-06 12:19:09.000000000","message":"No, chown is needed here. useradd isn\u0027t creating the home. the files are incorrectly owned by root at this point in dockerfile","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6a6c143f37f4bbaadb205eaf8a0f8c8d25158619","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0026\u0026 useradd --user-group --home-dir /kafka kafka \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":25,"context_line":"    \u0026\u0026 usermod -a -G kolla kafka \\"},{"line_number":26,"context_line":"    \u0026\u0026 chown -R kafka: /kafka"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block kafka_footer %}{% endblock %}"},{"line_number":29,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a71b18c_476cf59b","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":29},"in_reply_to":"3a71b18c_ecdec8db","updated":"2016-12-06 12:29:33.000000000","message":"Really? I though --home-dir in the useradd command creates kafka homedir owned by kafka user. Maybe the same comment at zookeeper is wrong.\nUsing the useradd command i get the following owner for /kafka\nstat -c %U,%G /kafka/\nkafka,kafka\n\nWhat is the permission issue, about recursive permissions or something like that?","commit_id":"b02580eb8ddc004b5345a0ee54d495ef78532981"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"169966f284039d0fc1613bdb87449d7ea70066c6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{ macros.install_packages(kafka_packages | customizable(\"packages\")) }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":22,"context_line":"ADD kafka-archive /"},{"line_number":23,"context_line":"RUN ln -s kafka* kafka \\"},{"line_number":24,"context_line":"    \u0026\u0026 useradd --user-group --home-dir /kafka kafka \\"},{"line_number":25,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3a71b18c_14315e5a","line":22,"updated":"2016-12-12 13:35:56.000000000","message":"kafka not defined in aux:\nhttps://github.com/openstack/kolla/blob/master/kolla/common/config.py#L47\n\nkafka not defined in sources:\nhttps://github.com/openstack/kolla/blob/master/kolla/common/config.py#L148\n\nignore this comment - I see later it is defined.","commit_id":"7229e1bb68037a30230d0353f816fa22a46185ec"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4b62db0e8969cb1e9121ffb28471bcc2a7966e5a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{ macros.install_packages(kafka_packages | customizable(\"packages\")) }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":22,"context_line":"ADD kafka-archive /"},{"line_number":23,"context_line":"RUN ln -s kafka* kafka \\"},{"line_number":24,"context_line":"    \u0026\u0026 useradd --user-group --home-dir /kafka kafka \\"},{"line_number":25,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1a6eadb0_bc0925e0","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":19},"updated":"2016-12-12 15:52:17.000000000","message":"This is only available for source build types. You\u0027ll need to update the if logic to only do this for source","commit_id":"b3c78512761feee35cdd0199034579fcd5ef173d"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2d9811dabca76cf053ebb1f1291236049f8f4993","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":237,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/monasca-ui/\u0027"},{"line_number":238,"context_line":"                     \u0027monasca-ui-1.2.1.tar.gz\u0027)},"},{"line_number":239,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 8dc0165... [WIP] Add monasca build files"},{"line_number":240,"context_line":"    \u0027horizon-plugin-neutron-lbaas-dashboard\u0027: {"},{"line_number":241,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":242,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/neutron-lbaas-dashboard/\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_a53c0594","line":239,"updated":"2016-12-12 09:14:57.000000000","message":"Have merge conflict messages, in master aren\u0027t there. Will come from the monasca dockerfile, guess","commit_id":"02a8df6b8573f022fee518cbe3e983dc526de35f"}]}