)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"484f019ea1ead08cee8e4989f6eb4aa4c477e3b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Author:     Sam Yaple \u003csam@yaple.net\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-12-05 10:24:47 +0000"},{"line_number":4,"context_line":"Commit:     Sam Yaple \u003csam@yaple.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-12 13:16:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add zookeeper image"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a71b18c_c1e1e72b","line":5,"updated":"2016-12-12 14:01:18.000000000","message":"missing from aux images in build:\nhttps://github.com/openstack/kolla/blob/master/kolla/common/config.py#L47","commit_id":"2b04074457cc05788907ddd644d98285553efe07"}],"docker/zookeeper/Dockerfile.j2":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"d87e44ceab1afaccb87066fb73221245fcd074aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block zookeeper_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_4a28b586","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":43},"updated":"2016-12-05 12:00:32.000000000","message":"openstack-base?","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8fb42c339c218a52fa62b9c0720bd3240072143c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block zookeeper_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_d3d36bd3","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":43},"in_reply_to":"3a71b18c_1d95223e","updated":"2016-12-06 11:35:35.000000000","message":"yup, is correct. Zookeeper does nothing to do with openstack","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"4a4a00df71e7e6ae7f3c1e6d6dd77526ad4f6df7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block zookeeper_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_1d95223e","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":43},"in_reply_to":"3a71b18c_4a28b586","updated":"2016-12-05 13:46:39.000000000","message":"no. this is correct","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ad96f024d7312a5619ca3b5b153c3df30e57d3d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_baedf0b8","line":10,"updated":"2016-12-06 05:28:19.000000000","message":"Damn I thought RH finally got around to packaging zookeeper, guess they still haven\u0027t.","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8fb42c339c218a52fa62b9c0720bd3240072143c","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_f698557a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":14},"updated":"2016-12-06 11:35:35.000000000","message":"Please, post a message\nExample: https://github.com/openstack/kolla/blob/master/docker/karbor/karbor-base/Dockerfile.j2#L8","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3ef6d70c8381c6a7aa64090216cbcc8af5584079","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_cd549fcb","line":10,"in_reply_to":"3a71b18c_0c3ea427","updated":"2016-12-06 15:39:55.000000000","message":"Ya, durn, https://apps.fedoraproject.org/packages/zookeeper/overview/ still seems like it\u0027s missing a package into non-fedora... Durn. I gotta bug monty about this...","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"af831e7a0a00f7bfd5c4d51f6744bc7d89ef07ec","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_0c3ea427","line":10,"in_reply_to":"3a71b18c_b6aa5d83","updated":"2016-12-06 12:17:03.000000000","message":"I agree, i dont think a repo should be added for this. Ill leave a message and let other folks that use centos decide on how to proceed here","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9eded1b9536d56259e35c2b088fd8f71173cca24","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_e68ef12c","line":10,"in_reply_to":"3a71b18c_baedf0b8","updated":"2016-12-06 07:48:56.000000000","message":"They might have. I dont know enough about RH stuff to check. If someone else checks I will happily put packages here","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8fb42c339c218a52fa62b9c0720bd3240072143c","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN /bin/false"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_b6aa5d83","line":10,"in_reply_to":"3a71b18c_e68ef12c","updated":"2016-12-06 11:35:35.000000000","message":"Cannot find zookeeper packages in epel, rdo, delorean, there are some other projects that have package zookeeper as Midonet.\nI wouldn\u0027t add Midonet repo.","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"d87e44ceab1afaccb87066fb73221245fcd074aa","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["},{"line_number":14,"context_line":"        \u0027zookeeper\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_6a06511e","line":14,"range":{"start_line":14,"start_character":19,"end_line":14,"end_character":20},"updated":"2016-12-05 12:00:32.000000000","message":"comma isn\u0027t needed here.","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"4a4a00df71e7e6ae7f3c1e6d6dd77526ad4f6df7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["},{"line_number":14,"context_line":"        \u0027zookeeper\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_7d91b646","line":14,"range":{"start_line":14,"start_character":19,"end_line":14,"end_character":20},"in_reply_to":"3a71b18c_6a06511e","updated":"2016-12-05 13:46:39.000000000","message":"comma may not be needed, but it should remain. This means in the future if we need to add another package it only modifies one line, not two (helps with git diffs/rebase/etc)","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8fb42c339c218a52fa62b9c0720bd3240072143c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["},{"line_number":14,"context_line":"        \u0027zookeeper\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_d69b5964","line":14,"range":{"start_line":14,"start_character":19,"end_line":14,"end_character":20},"in_reply_to":"3a71b18c_7d91b646","updated":"2016-12-06 11:35:35.000000000","message":"We don\u0027t have last comma in any other Dockerfile. But Sam\u0027s comment really makes sense for me, specially to avoid unnecessary merge conflicts.","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"af831e7a0a00f7bfd5c4d51f6744bc7d89ef07ec","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set zookeeper_packages \u003d ["},{"line_number":14,"context_line":"        \u0027zookeeper\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_cc0e6c8b","line":14,"range":{"start_line":14,"start_character":19,"end_line":14,"end_character":20},"in_reply_to":"3a71b18c_d69b5964","updated":"2016-12-06 12:17:03.000000000","message":"At one point in the past, I was on top of keeping commas at the end of lines like this. We may not do it now after some refactors, but I can fix that real quick-like","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8fb42c339c218a52fa62b9c0720bd3240072143c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"RUN useradd --user-group --create-home --home-dir /var/lib/zookeeper zookeeper \\"},{"line_number":22,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":23,"context_line":"    \u0026\u0026 usermod -a -G kolla zookeeper \\"},{"line_number":24,"context_line":"    \u0026\u0026 chown -R zookeeper: /var/lib/zookeeper"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block zookeeper_footer %}{% endblock %}"},{"line_number":27,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_56d669f1","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":45},"updated":"2016-12-06 11:35:35.000000000","message":"When this path is used for zookeeper user\u0027s home, applying permissions is not necessary","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"af831e7a0a00f7bfd5c4d51f6744bc7d89ef07ec","unresolved":false,"context_lines":[{"line_number":21,"context_line":"RUN useradd --user-group --create-home --home-dir /var/lib/zookeeper zookeeper \\"},{"line_number":22,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":23,"context_line":"    \u0026\u0026 usermod -a -G kolla zookeeper \\"},{"line_number":24,"context_line":"    \u0026\u0026 chown -R zookeeper: /var/lib/zookeeper"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block zookeeper_footer %}{% endblock %}"},{"line_number":27,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_ec70880d","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":45},"in_reply_to":"3a71b18c_56d669f1","updated":"2016-12-06 12:17:03.000000000","message":"Done","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8fb42c339c218a52fa62b9c0720bd3240072143c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":23,"context_line":"    \u0026\u0026 usermod -a -G kolla zookeeper \\"},{"line_number":24,"context_line":"    \u0026\u0026 chown -R zookeeper: /var/lib/zookeeper"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block zookeeper_footer %}{% endblock %}"},{"line_number":27,"context_line":"{% block footer %}{% endblock %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_d6a19947","line":25,"updated":"2016-12-06 11:35:35.000000000","message":"Zookeeper user don\u0027t need sudoers file?","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"af831e7a0a00f7bfd5c4d51f6744bc7d89ef07ec","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":23,"context_line":"    \u0026\u0026 usermod -a -G kolla zookeeper \\"},{"line_number":24,"context_line":"    \u0026\u0026 chown -R zookeeper: /var/lib/zookeeper"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block zookeeper_footer %}{% endblock %}"},{"line_number":27,"context_line":"{% block footer %}{% endblock %}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a71b18c_2cdb601c","line":25,"in_reply_to":"3a71b18c_d6a19947","updated":"2016-12-06 12:17:03.000000000","message":"No. It doesnt really do much. This is the end of a patchset for monasca containers though, this patch _may_ change slightly. Still unlikely sudoers will ever be needed","commit_id":"d5ab1a2835f83e7adab4cbacf55e74c2aed78bd4"}],"tests/test_build.py":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"db5428a1679c0ed6e85e064fa1c1f92c21f19929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a6eadb0_395b6756","updated":"2016-12-12 15:47:14.000000000","message":"You need to exclude it from centos/oraclelinux source builds also","commit_id":"e3af349f9ff012838d715cc3d910c21817e68889"}]}