)]}'
{"id":"openstack%2Fkolla~410573","triplet_id":"openstack%2Fkolla~master~Ie8134f990e92aff509d3342cbb22567d4c9da209","project":"openstack/kolla","branch":"master","topic":"bug/1649781","hashtags":[],"change_id":"Ie8134f990e92aff509d3342cbb22567d4c9da209","subject":"Fix don\u0027t enter if block forever when do reconfigure","status":"ABANDONED","created":"2016-12-14 07:37:06.000000000","updated":"2017-02-23 00:41:04.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"239bfe530c2e5ce75198b2656d2369f5a8d6ea23","_number":410573,"virtual_id_number":410573,"owner":{"_account_id":21413,"name":"Jack Ning","email":"ningyougang@navercorp.com","username":"jackning"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"value":-1,"date":"2017-01-23 15:58:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"all":[{"value":-1,"date":"2016-12-22 06:31:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-12-16 07:31:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},{"value":-1,"date":"2017-02-22 15:16:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"value":-1,"date":"2016-12-15 16:04:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},{"value":-1,"date":"2016-12-15 13:02:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-15 13:02:27.000000000","updated_by":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"reviewer":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"state":"REVIEWER"},{"updated":"2016-12-15 16:04:25.000000000","updated_by":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"reviewer":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"state":"REVIEWER"},{"updated":"2016-12-16 07:31:49.000000000","updated_by":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"reviewer":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"state":"REVIEWER"},{"updated":"2016-12-22 06:31:38.000000000","updated_by":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"reviewer":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"state":"REVIEWER"},{"updated":"2017-01-23 15:58:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-02-22 15:16:29.000000000","updated_by":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"reviewer":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"state":"REVIEWER"}],"messages":[{"id":"6c5b547d2919a25983240d5288287c2c502eca91","author":{"_account_id":21413,"name":"Jack Ning","email":"ningyougang@navercorp.com","username":"jackning"},"date":"2016-12-14 07:37:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"102a6c553d2a5fd7a3db45af34ad001e7a5146f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-14 08:35:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-kolla-docs-ubuntu-xenial http://docs-draft.openstack.org/73/410573/1/check/gate-kolla-docs-ubuntu-xenial/fdf9a34//doc/build/html/ : SUCCESS in 58s\n- gate-kolla-pep8-ubuntu-xenial http://logs.openstack.org/73/410573/1/check/gate-kolla-pep8-ubuntu-xenial/2636125/ : SUCCESS in 1m 19s\n- gate-kolla-python27-ubuntu-xenial http://logs.openstack.org/73/410573/1/check/gate-kolla-python27-ubuntu-xenial/d123757/ : SUCCESS in 1m 38s\n- gate-kolla-python35-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-python35-nv/99e3602/ : SUCCESS in 2m 06s (non-voting)\n- gate-kolla-dsvm-build-centos-binary-centos-7-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-build-centos-binary-centos-7-nv/3ec59d9/ : SUCCESS in 26m 06s (non-voting)\n- gate-kolla-dsvm-deploy-centos-binary-centos-7-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-deploy-centos-binary-centos-7-nv/7c616a8/ : FAILURE in 41m 02s (non-voting)\n- gate-kolla-dsvm-build-centos-source-centos-7 http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-build-centos-source-centos-7/993c15c/ : SUCCESS in 28m 08s\n- gate-kolla-dsvm-deploy-centos-source-centos-7-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-deploy-centos-source-centos-7-nv/2c74bef/ : SUCCESS in 54m 00s (non-voting)\n- gate-kolla-dsvm-build-ubuntu-binary-ubuntu-xenial-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-build-ubuntu-binary-ubuntu-xenial-nv/b944ae4/ : FAILURE in 17m 39s (non-voting)\n- gate-kolla-dsvm-build-ubuntu-source-ubuntu-xenial http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-build-ubuntu-source-ubuntu-xenial/03ebf37/ : SUCCESS in 30m 02s\n- gate-kolla-dsvm-deploy-ubuntu-binary-ubuntu-xenial-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-deploy-ubuntu-binary-ubuntu-xenial-nv/6d27d7c/ : SUCCESS in 31m 12s (non-voting)\n- gate-kolla-dsvm-deploy-ubuntu-source-ubuntu-xenial-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-deploy-ubuntu-source-ubuntu-xenial-nv/6931d67/ : SUCCESS in 34m 59s (non-voting)\n- gate-kolla-dsvm-build-oraclelinux-binary-centos-7-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-build-oraclelinux-binary-centos-7-nv/bb75dd6/ : SUCCESS in 35m 35s (non-voting)\n- gate-kolla-dsvm-deploy-oraclelinux-binary-centos-7-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-deploy-oraclelinux-binary-centos-7-nv/24d9799/ : SUCCESS in 41m 33s (non-voting)\n- gate-kolla-dsvm-build-oraclelinux-source-centos-7 http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-build-oraclelinux-source-centos-7/b9d8023/ : SUCCESS in 32m 07s\n- gate-kolla-dsvm-deploy-oraclelinux-source-centos-7-nv http://logs.openstack.org/73/410573/1/check/gate-kolla-dsvm-deploy-oraclelinux-source-centos-7-nv/cdc5cb0/ : SUCCESS in 57m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"64b32ba0544b6d4fc4eccbb77d9cf85ae0fb548b","author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"date":"2016-12-15 13:02:27.000000000","message":"Patch Set 1: Code-Review-1\n\nIf I understand correctly, if this conditional was faulty reconfigure would not work at all. Last time I checked it works fine. Can you explain more why the existing conditional is wrong and how your patch fixes it? The before and after look equivalent to me.","accounts_in_message":[],"_revision_number":1},{"id":"2798e24deb94aff8f28600c1e3252ddaebc770c6","author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"date":"2016-12-15 16:04:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f335e8dd41eff97efcd398aa174c9465446bc7fd","author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"date":"2016-12-16 07:31:49.000000000","message":"Patch Set 1: Code-Review-1\n\nI agree. The new variable introduced does not change the condition.","accounts_in_message":[],"_revision_number":1},{"id":"5f0c6a3f027504e930132330a0fb2dad9e1de4f6","author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"date":"2016-12-22 06:31:38.000000000","message":"Patch Set 1: Code-Review-1\n\nthis seems the same. please add more information.","accounts_in_message":[],"_revision_number":1},{"id":"1966f539ba6ca485c33c64e31c21fceb6f698c05","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-23 15:58:06.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"bcec23a63897bc622afae1c6d8740b2c03237808","author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"date":"2017-02-22 15:16:29.000000000","message":"Patch Set 1: Code-Review-1\n\nplease fix the confilict, thanks","accounts_in_message":[],"_revision_number":1},{"id":"d5a1a50f3573b8edbf4476a2dd65796e3038629f","author":{"_account_id":21413,"name":"Jack Ning","email":"ningyougang@navercorp.com","username":"jackning"},"date":"2017-02-23 00:41:04.000000000","message":"Abandoned\n\nBecause these code has been Refactored","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1432b1f261167fba21e261356f215e6a624d5e0c","revisions":{"1432b1f261167fba21e261356f215e6a624d5e0c":{"kind":"REWORK","_number":1,"created":"2016-12-14 07:37:06.000000000","uploader":{"_account_id":21413,"name":"Jack Ning","email":"ningyougang@navercorp.com","username":"jackning"},"ref":"refs/changes/73/410573/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/73/410573/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/73/410573/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/73/410573/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/73/410573/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/73/410573/1"}}},"commit":{"parents":[{"commit":"f4ca32cd7877f7cd1abf7270c4329f99248cbf49","subject":"Merge \"Add kafka image\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/f4ca32cd7877f7cd1abf7270c4329f99248cbf49"}]}],"author":{"name":"jackning","email":"ningyougang@navercorp.com","date":"2016-12-14 07:34:59.000000000","tz":480},"committer":{"name":"jackning","email":"ningyougang@navercorp.com","date":"2016-12-14 07:36:44.000000000","tz":480},"subject":"Fix don\u0027t enter if block forever when do reconfigure","message":"Fix don\u0027t enter if block forever when do reconfigure\n\nChange-Id: Ie8134f990e92aff509d3342cbb22567d4c9da209\nCloses-Bug: #1649781\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1432b1f261167fba21e261356f215e6a624d5e0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1432b1f261167fba21e261356f215e6a624d5e0c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}