)]}'
{"docker/swift/swift-base/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0db9f594429f8532a59f9076b9de9d089a9a443c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(swift_base_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN pip install oslo.rootwrap"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da4df55a_84778b01","line":17,"updated":"2016-12-22 03:19:15.000000000","message":"oslo.rootwrap is certainly packaged in both centos and ubuntu. we can install the pacakged versions in the section above","commit_id":"ae17fdae591d503dfed5dfdde300ffbbc56b6b42"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"011e2298b917573553fe04590a79831e2921c082","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(swift_base_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN pip install oslo.rootwrap"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da4df55a_a42c8fac","line":17,"in_reply_to":"da4df55a_84778b01","updated":"2016-12-22 03:36:47.000000000","message":"The version of oslo.rootwrap in EPEL repo is 1.0.0,\nand 4.1.0 in ubuntu xenial repo, while current version is 5.3.0\nNot sure if they are too old to work fine.","commit_id":"ae17fdae591d503dfed5dfdde300ffbbc56b6b42"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ef422136194b4aa64692f7bb5052cead142e31a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(swift_base_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN pip install oslo.rootwrap"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da4df55a_7fbeb200","line":17,"in_reply_to":"da4df55a_a42c8fac","updated":"2016-12-22 03:39:08.000000000","message":"its fine, this is the binary relase. its the version all other projects would be using.","commit_id":"ae17fdae591d503dfed5dfdde300ffbbc56b6b42"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0db9f594429f8532a59f9076b9de9d089a9a443c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ADD swift-base-archive /swift-base-source"},{"line_number":28,"context_line":"RUN ln -s swift-base-source/* swift \\"},{"line_number":29,"context_line":"    \u0026\u0026 useradd --user-group swift \\"},{"line_number":30,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /swift \\"},{"line_number":31,"context_line":"    \u0026\u0026 mkdir -p /etc/swift /var/cache/swift /var/log/swift /home/swift \\"},{"line_number":32,"context_line":"    \u0026\u0026 cp -r /swift/etc/* /etc/swift/ \\"},{"line_number":33,"context_line":"    \u0026\u0026 chown -R swift: /etc/swift /var/cache/swift /var/log/swift /home/swift"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da4df55a_e47db7e8","line":30,"updated":"2016-12-22 03:19:15.000000000","message":"oslo.rootwrap should be before /swift here (matches other dockerfiles)","commit_id":"ae17fdae591d503dfed5dfdde300ffbbc56b6b42"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"011e2298b917573553fe04590a79831e2921c082","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ADD swift-base-archive /swift-base-source"},{"line_number":28,"context_line":"RUN ln -s swift-base-source/* swift \\"},{"line_number":29,"context_line":"    \u0026\u0026 useradd --user-group swift \\"},{"line_number":30,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /swift \\"},{"line_number":31,"context_line":"    \u0026\u0026 mkdir -p /etc/swift /var/cache/swift /var/log/swift /home/swift \\"},{"line_number":32,"context_line":"    \u0026\u0026 cp -r /swift/etc/* /etc/swift/ \\"},{"line_number":33,"context_line":"    \u0026\u0026 chown -R swift: /etc/swift /var/cache/swift /var/log/swift /home/swift"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da4df55a_df2a3e7e","line":30,"in_reply_to":"da4df55a_e47db7e8","updated":"2016-12-22 03:36:47.000000000","message":"Agree","commit_id":"ae17fdae591d503dfed5dfdde300ffbbc56b6b42"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"4859793d1778426bfa40f864681960dd83314749","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ADD swift-base-archive /swift-base-source"},{"line_number":26,"context_line":"RUN ln -s swift-base-source/* swift \\"},{"line_number":27,"context_line":"    \u0026\u0026 useradd --user-group swift \\"},{"line_number":28,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /swift \\"},{"line_number":29,"context_line":"    \u0026\u0026 mkdir -p /etc/swift /var/cache/swift /var/log/swift /home/swift \\"},{"line_number":30,"context_line":"    \u0026\u0026 cp -r /swift/etc/* /etc/swift/ \\"},{"line_number":31,"context_line":"    \u0026\u0026 chown -R swift: /etc/swift /var/cache/swift /var/log/swift /home/swift"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"da4df55a_1ff846e5","side":"PARENT","line":28,"updated":"2016-12-22 03:38:24.000000000","message":"no. this is wrong. don\u0027t remove this line. This matches all other docker files. add oslo.rootwrap before /swift on this line","commit_id":"2cc9a5ae15cbb0a51964c3366bec98ff6be53ea2"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"4859793d1778426bfa40f864681960dd83314749","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(swift_base_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN pip install oslo.rootwrap"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"da4df55a_7fe79240","line":17,"updated":"2016-12-22 03:38:24.000000000","message":"this should be installed from package, not pip. install in above section","commit_id":"579bb738f23253bcbe95ace77adc7195254276b5"}]}
