)]}'
{"docker/ironic/ironic-inspector/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"90be9072f576542fd322c9ee62df1e7124fefa5f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":"    {% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da4df55a_0a67784d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"updated":"2016-12-28 13:53:05.000000000","message":"This is removing installation of centos binary","commit_id":"419c30ef18e0aa8caa39416d0bfb2119cb82adbf"}],"docker/macros.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"014e44115e2897f2cca889971842cb93bc788fc0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        RUN {{ debian_package_install(packages) }}"},{"line_number":12,"context_line":"    {%- endif %}"},{"line_number":13,"context_line":"{%- else %}"},{"line_number":14,"context_line":"RUN false"},{"line_number":15,"context_line":"{%- endif %}"},{"line_number":16,"context_line":"{%- endmacro %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_6b651ae0","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":9},"updated":"2016-12-29 14:50:46.000000000","message":"Please echo a message to know what the problem is a simple false is weird to debug. Use /bin/false  with a message, the same way as \"binary not yet available for distro...\" instead of standalone false command.","commit_id":"723fad3fdca08b8638676a51539f8f7aa2697e9b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"35cedf49d0edaf58066de4fd17e2879b88703f3c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {%- endif %}"},{"line_number":13,"context_line":"{%- elif packages is undefined %}"},{"line_number":14,"context_line":"RUN echo \u0027Macro install_packages: parameter undefined\u0027 \\"},{"line_number":15,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":16,"context_line":"{%- endif %}"},{"line_number":17,"context_line":"{%- endmacro %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ba5201f7_d1030c75","line":15,"updated":"2016-12-30 06:29:36.000000000","message":"this current solution is not so good. for example [0]\n\nthis won\u0027t catch when the first neutron_openvswitch_agent_packages is correct, but the following one name is bad.\n\n[0] https://review.openstack.org/#/c/414848/9/docker/neutron/neutron-openvswitch-agent/Dockerfile.j2","commit_id":"66aa1d9f4c4f2ff9894c64b905189e16f4277890"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4a9ec8b12ae21c28f30ca378733580c56a0be94c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir \\"},{"line_number":20,"context_line":"    install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":21,"context_line":"    {%- for package in packages %}"},{"line_number":22,"context_line":"    {{ package }}"},{"line_number":23,"context_line":"    {%- if not loop.last %} \\{% endif %}"},{"line_number":24,"context_line":"    {%- endfor %}"},{"line_number":25,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_78023c40","line":22,"updated":"2016-12-30 13:24:44.000000000","message":"if in line 23 should be in line 22, to keep a list as follows:\npackage1 \\\npackage2 \\\npackage3\n\nOtherwise, the list will be:\n\npackage1\n\\\npackage2\n\\\npackage3","commit_id":"9aeb8207c5e85d966a44343b33d0648c7af6e446"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"fa93811d0b3778caa55e3d986de4623f825adb5b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir \\"},{"line_number":20,"context_line":"    install --upgrade -c requirements/upper-constraints.txt \\"},{"line_number":21,"context_line":"    {%- for package in packages %}"},{"line_number":22,"context_line":"    {{ package }}"},{"line_number":23,"context_line":"    {%- if not loop.last %} \\{% endif %}"},{"line_number":24,"context_line":"    {%- endfor %}"},{"line_number":25,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_731244b6","line":22,"in_reply_to":"ba5201f7_78023c40","updated":"2017-01-03 02:06:36.000000000","message":"This is nothing wrong, this is the same code that I used in the base image.\nTested it with template-only, got correct results.","commit_id":"9aeb8207c5e85d966a44343b33d0648c7af6e446"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4a9ec8b12ae21c28f30ca378733580c56a0be94c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {%- if not loop.last %} \\{% endif %}"},{"line_number":24,"context_line":"    {%- endfor %}"},{"line_number":25,"context_line":"{%- endif %}"},{"line_number":26,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_f8bb8c73","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":3},"updated":"2016-12-30 13:24:44.000000000","message":"Remove - in last endmacro.\npep is giving error \"file error: no newline at end of file\"\nhttp://logs.openstack.org/48/414848/10/check/gate-kolla-pep8-ubuntu-xenial/15035ff/console.html#_2016-12-30_09_03_16_459850","commit_id":"9aeb8207c5e85d966a44343b33d0648c7af6e446"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"fa93811d0b3778caa55e3d986de4623f825adb5b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {%- if not loop.last %} \\{% endif %}"},{"line_number":24,"context_line":"    {%- endfor %}"},{"line_number":25,"context_line":"{%- endif %}"},{"line_number":26,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_9317a8a2","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":3},"in_reply_to":"ba5201f7_f8bb8c73","updated":"2017-01-03 02:06:36.000000000","message":"Done.Never expect this will cause a error, it\u0027s the same as the install_packages macro above.","commit_id":"9aeb8207c5e85d966a44343b33d0648c7af6e446"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"b04f6cd22fe219077812af91ad40436fdcc7af1b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {%- if not loop.last %} \\{% endif %}"},{"line_number":24,"context_line":"    {%- endfor %}"},{"line_number":25,"context_line":"{%- endif %}"},{"line_number":26,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_f448d72f","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":3},"in_reply_to":"ba5201f7_f8bb8c73","updated":"2017-01-03 08:40:21.000000000","message":"Oh, one minor mistake, lacking of a empty line at the EOF.","commit_id":"9aeb8207c5e85d966a44343b33d0648c7af6e446"}],"docker/neutron/neutron-metadata-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"90be9072f576542fd322c9ee62df1e7124fefa5f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY neutron_sudoers /etc/sudoers.d/kolla_neutron_metadata_sudoers"},{"line_number":22,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da4df55a_aa1e6cb8","line":19,"updated":"2016-12-28 13:53:05.000000000","message":"I would leave this line where is it now, if someday centos binary install is necessary, this line won\u0027t be duplicated or changed again","commit_id":"419c30ef18e0aa8caa39416d0bfb2119cb82adbf"},{"author":{"_account_id":24013,"name":"jimmygc","email":"guochao@winhong.com","username":"jimmygc"},"change_message_id":"2bdc3133463be5fa48d31ee289615aa026ccdef8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY neutron_sudoers /etc/sudoers.d/kolla_neutron_metadata_sudoers"},{"line_number":22,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"ba5201f7_f3d58ab9","line":19,"in_reply_to":"da4df55a_aa1e6cb8","updated":"2016-12-29 06:13:51.000000000","message":"I want to create a \"Run false\" when the packages parameter is no defined or empty, which will report error when the parameter is wrong or empty.\nThis eliminate the possibility of a mistaken variable name which is silently ignored.\nDo you think it\u0027s better to leave it intact?","commit_id":"419c30ef18e0aa8caa39416d0bfb2119cb82adbf"}],"docker/neutron/neutron-openvswitch-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"90be9072f576542fd322c9ee62df1e7124fefa5f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% block neutron_openvswitch_agent_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da4df55a_ca1bb0c8","line":27,"updated":"2016-12-28 13:53:05.000000000","message":"ditto","commit_id":"419c30ef18e0aa8caa39416d0bfb2119cb82adbf"}],"docker/neutron/neutron-server/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"90be9072f576542fd322c9ee62df1e7124fefa5f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{ macros.install_packages(neutron_server_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ADD plugins-archive /"},{"line_number":32,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_neutron_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da4df55a_ea7a34f0","line":29,"updated":"2016-12-28 13:53:05.000000000","message":"ditto","commit_id":"419c30ef18e0aa8caa39416d0bfb2119cb82adbf"}],"docker/zookeeper/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"90be9072f576542fd322c9ee62df1e7124fefa5f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    ] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{ macros.install_packages(zookeeper_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":22,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"da4df55a_0a8058bf","line":19,"updated":"2016-12-28 13:53:05.000000000","message":"ditto","commit_id":"419c30ef18e0aa8caa39416d0bfb2119cb82adbf"}]}