)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add OpenDaylight Container to kolla"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"blueprint opendaylight-support"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements docker container for OpenDaylight."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_e191cd53","line":9,"updated":"2017-01-04 09:26:02.000000000","message":"Add: Partially-Implements: blueprint opendaylight-support\n\nAnd move it to line 18 after commit description","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"}],"contrib/template-override/opendaylight-template-overrides.j2":[{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"8b606da11c8b9d582acb0f9373c12da80b63ace2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba5201f7_dc9963d2","updated":"2017-01-09 16:58:06.000000000","message":"Sean is there a way to tell the check/gate to use template override? I imagine not, so what is way forward with image relying on template override for source install?","commit_id":"d2fb3a3cadb855b0d3d7c161cf70a23532dca75d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"663b2ec5c28979603a7891ab731536c3c2321c95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba5201f7_770fb02e","in_reply_to":"ba5201f7_dc9963d2","updated":"2017-01-09 17:13:38.000000000","message":"it is intended to not gate on temlate overrides.\nsee comment on patchset 9 for how to disable building this container in gates.","commit_id":"d2fb3a3cadb855b0d3d7c161cf70a23532dca75d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b3d0e60d046e9a8791626841c48ac65f5c238fe","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% block opendaylight_source_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"      {% set opendaylight_packages \u003d [\u0027java-1.8.0-openjdk\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_5144dd19","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":4},"updated":"2017-01-23 15:29:07.000000000","message":"elif and endif not need to be indented","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7e975ab4756eea0fcf1cd4f2d869b3657342db7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% block opendaylight_source_install %}"},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":"      {% set opendaylight_packages \u003d [\u0027java-1.8.0-openjdk\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_fbc2ff83","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":4},"in_reply_to":"5a3905b3_5144dd19","updated":"2017-01-23 17:25:38.000000000","message":"Done","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":19494,"name":"Daniel Farrell","email":"dfarrell07@gmail.com","username":"dfarrell07"},"change_message_id":"4f4a6b0b6513a8c22a1fbf5adf975baee473837f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":18,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":19,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_767954fc","line":17,"updated":"2017-02-20 20:23:54.000000000","message":"Note that with the 5-release repo, you will get SR updates. To pin to an SR, use something like 52-release. Getting SR updates may be good for maintenance, as you typically always want to test latest SR.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":18,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":19,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_8d15814a","line":17,"in_reply_to":"da36d5c6_767954fc","updated":"2017-02-22 19:57:37.000000000","message":"Good to know.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19494,"name":"Daniel Farrell","email":"dfarrell07@gmail.com","username":"dfarrell07"},"change_message_id":"4f4a6b0b6513a8c22a1fbf5adf975baee473837f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":18,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":19,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_9665e846","line":19,"updated":"2017-02-20 20:23:54.000000000","message":"Not so sure about what this is doing, but note that if you install the package, it expects to be able to land in /opt/opendaylight","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":18,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":19,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_a8431341","line":19,"in_reply_to":"da36d5c6_39bfcdfc","updated":"2017-02-22 19:57:37.000000000","message":"Daniel, understood. This is attempting to duplicate location of ODL for \u0027source\u0027 (actually binary build but tar of ODL) installs. So that all installs produce the same path.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f9f5a8cae48f88e341de29c0b68745b1ea3e7520","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":18,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":19,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_39bfcdfc","line":19,"in_reply_to":"da36d5c6_9665e846","updated":"2017-02-20 20:33:23.000000000","message":"The ADD in line 18 copy the odl source package at /opendaylight/\nThen line 19 links /opendaylight/ to the expected odl path.\nIs the way in kolla we install source code.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d64a666c208d67f5b8551a0e70ba659299c4371b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":13,"context_line":"  {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  {% if opendaylight_distro is not defined %}"},{"line_number":18,"context_line":"    {% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"ffe62b97_ce827200","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"updated":"2017-03-29 14:28:27.000000000","message":"this macro call should be aligned to the left, dockerfiles RUN should be at the begining of the line, otherwise is not evaluating as a docker option","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"7e248d1cfb4cd65663305ca0ac4f8d11a028a0ed","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":13,"context_line":"  {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  {% if opendaylight_distro is not defined %}"},{"line_number":18,"context_line":"    {% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"ffe62b97_800f8e86","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"in_reply_to":"ffe62b97_ce827200","updated":"2017-03-29 17:20:00.000000000","message":"Done","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"}],"doc/template-override/.keep":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"207b9027bbfbf9033b4da0b3aa92c09425ace73d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"3a1ff146_75f4d286","side":"PARENT","updated":"2017-03-15 19:29:55.000000000","message":"remove these files please","commit_id":"5397586ae46e59be457259a8bffc1fabb3885b98"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"39d8c446219897122ce211bc81c539434eb7d1af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"1a1ced50_ac164256","side":"PARENT","in_reply_to":"3a1ff146_75f4d286","updated":"2017-03-23 18:13:43.000000000","message":"Done","commit_id":"5397586ae46e59be457259a8bffc1fabb3885b98"}],"doc/template-override/opendaylight-source.rst":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24bc7852c107c63b3377eca8b346040324bc9e0d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  (for \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":25,"context_line":"  used in kolla-build.conf"},{"line_number":26,"context_line":"- To build the container execute the follow command:"},{"line_number":27,"context_line":"    tools/build.py --template-override \\"},{"line_number":28,"context_line":"    contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Deploy Opendaylight"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_1c46af7a","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":4},"updated":"2017-01-24 15:30:17.000000000","message":"Extra indent","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"cfdb31478b19c85694c20475bd33832e2ff76e95","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  (for \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":25,"context_line":"  used in kolla-build.conf"},{"line_number":26,"context_line":"- To build the container execute the follow command:"},{"line_number":27,"context_line":"    tools/build.py --template-override \\"},{"line_number":28,"context_line":"    contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Deploy Opendaylight"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_21088828","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":4},"in_reply_to":"5a3905b3_1c46af7a","updated":"2017-01-24 23:45:57.000000000","message":"Without the spaces these looked weird when rendered, but happy to take them out.","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24bc7852c107c63b3377eca8b346040324bc9e0d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  used in kolla-build.conf"},{"line_number":26,"context_line":"- To build the container execute the follow command:"},{"line_number":27,"context_line":"    tools/build.py --template-override \\"},{"line_number":28,"context_line":"    contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Deploy Opendaylight"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_9c529f33","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":4},"updated":"2017-01-24 15:30:17.000000000","message":"ditto","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"cfdb31478b19c85694c20475bd33832e2ff76e95","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  used in kolla-build.conf"},{"line_number":26,"context_line":"- To build the container execute the follow command:"},{"line_number":27,"context_line":"    tools/build.py --template-override \\"},{"line_number":28,"context_line":"    contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Deploy Opendaylight"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_6139b0d8","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":4},"in_reply_to":"5a3905b3_9c529f33","updated":"2017-01-24 23:45:57.000000000","message":"Done","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24bc7852c107c63b3377eca8b346040324bc9e0d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To deploy \u0027Opendaylight + OpenvSwitch\u0027 instead of \u0027OpenvSwitch + Neutron Agent\u0027"},{"line_number":34,"context_line":"configure /etc/kollaglobal.yml as follows."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"kollaglobal.yml"},{"line_number":37,"context_line":"_______________"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_5c23d7bc","line":34,"updated":"2017-01-24 15:30:17.000000000","message":"missing slash and wrong name, is globals.yml","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"cfdb31478b19c85694c20475bd33832e2ff76e95","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To deploy \u0027Opendaylight + OpenvSwitch\u0027 instead of \u0027OpenvSwitch + Neutron Agent\u0027"},{"line_number":34,"context_line":"configure /etc/kollaglobal.yml as follows."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"kollaglobal.yml"},{"line_number":37,"context_line":"_______________"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_4124b4ae","line":34,"in_reply_to":"5a3905b3_5c23d7bc","updated":"2017-01-24 23:45:57.000000000","message":"Done","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24bc7852c107c63b3377eca8b346040324bc9e0d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"To deploy \u0027Opendaylight + OpenvSwitch\u0027 instead of \u0027OpenvSwitch + Neutron Agent\u0027"},{"line_number":34,"context_line":"configure /etc/kollaglobal.yml as follows."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"kollaglobal.yml"},{"line_number":37,"context_line":"_______________"},{"line_number":38,"context_line":"::"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_d0040b16","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":15},"updated":"2017-01-24 15:30:17.000000000","message":"with globals.yml is enough for me","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"cfdb31478b19c85694c20475bd33832e2ff76e95","unresolved":false,"context_lines":[{"line_number":33,"context_line":"To deploy \u0027Opendaylight + OpenvSwitch\u0027 instead of \u0027OpenvSwitch + Neutron Agent\u0027"},{"line_number":34,"context_line":"configure /etc/kollaglobal.yml as follows."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"kollaglobal.yml"},{"line_number":37,"context_line":"_______________"},{"line_number":38,"context_line":"::"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_81369ce5","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":15},"in_reply_to":"5a3905b3_d0040b16","updated":"2017-01-24 23:45:57.000000000","message":"Done","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"883c1ce6a080ed5d0de49b4603a859f3f03a665a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenDaylight Source build"},{"line_number":2,"context_line":"-------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ubuntu Linux does not provide packages for OpenDaylight."}],"source_content_type":"text/x-rst","patch_set":18,"id":"3a461143_cd034975","line":1,"range":{"start_line":1,"start_character":13,"end_line":1,"end_character":25},"updated":"2017-02-02 20:31:37.000000000","message":"Change all mentions of source build to all builds, to encompass any use of ODL deployed by kolla. Template override use is needed in binary and source case to accommodate changes needed to neutron server (installation of networking-odl for example) for both cases.","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"fbd468e875aa1e4f5fe149e0ddc9916cce3974dd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  (for \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":25,"context_line":"  used in kolla-build.conf"},{"line_number":26,"context_line":"- To build the container execute the follow command:"},{"line_number":27,"context_line":"  tools/build.py --template-override \\"},{"line_number":28,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Deploy Opendaylight"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3a461143_3273214f","line":27,"range":{"start_line":27,"start_character":1,"end_line":27,"end_character":16},"updated":"2017-01-27 11:44:09.000000000","message":"Also use kolla-build command instead of the develop version. Contrib path will be somewhere in /usr/share, tho","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"dbef86d9321e81baafcb694b3d3ec53e99d038a6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  (for \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":25,"context_line":"  used in kolla-build.conf"},{"line_number":26,"context_line":"- To build the container execute the follow command:"},{"line_number":27,"context_line":"  tools/build.py --template-override \\"},{"line_number":28,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Deploy Opendaylight"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3a461143_2432f110","line":27,"range":{"start_line":27,"start_character":1,"end_line":27,"end_character":16},"in_reply_to":"3a461143_3273214f","updated":"2017-01-27 18:09:08.000000000","message":"Agreed. Will update.","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":19494,"name":"Daniel Farrell","email":"dfarrell07@gmail.com","username":"dfarrell07"},"change_message_id":"4f4a6b0b6513a8c22a1fbf5adf975baee473837f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenDaylight Source build"},{"line_number":2,"context_line":"-------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ubuntu Linux does not provide packages for OpenDaylight."},{"line_number":5,"context_line":"To install OpenDaylight on Ubuntu or with a different"},{"line_number":6,"context_line":"version then is currently packaged, a source build"},{"line_number":7,"context_line":"(technically using a prebuilt binary package) is required."}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_564c50c7","line":4,"updated":"2017-02-20 20:23:54.000000000","message":"We do have Debian packages FYI https://wiki.opendaylight.org/view/Deployment#Deb","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenDaylight Source build"},{"line_number":2,"context_line":"-------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ubuntu Linux does not provide packages for OpenDaylight."},{"line_number":5,"context_line":"To install OpenDaylight on Ubuntu or with a different"},{"line_number":6,"context_line":"version then is currently packaged, a source build"},{"line_number":7,"context_line":"(technically using a prebuilt binary package) is required."}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_8871efaa","line":4,"in_reply_to":"da36d5c6_3956edd2","updated":"2017-02-22 19:57:37.000000000","message":"Ditto. Didn\u0027t know about these.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f9f5a8cae48f88e341de29c0b68745b1ea3e7520","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenDaylight Source build"},{"line_number":2,"context_line":"-------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ubuntu Linux does not provide packages for OpenDaylight."},{"line_number":5,"context_line":"To install OpenDaylight on Ubuntu or with a different"},{"line_number":6,"context_line":"version then is currently packaged, a source build"},{"line_number":7,"context_line":"(technically using a prebuilt binary package) is required."}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_3956edd2","line":4,"in_reply_to":"da36d5c6_564c50c7","updated":"2017-02-20 20:33:23.000000000","message":"Awesome, didn\u0027t know about deb packages. Thanks","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"c7bc164a7b004e4dcf9b007f342f4512fa5f1a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenDaylight Source build"},{"line_number":2,"context_line":"-------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ubuntu Linux does not provide packages for OpenDaylight."},{"line_number":5,"context_line":"To install OpenDaylight on Ubuntu or with a different"},{"line_number":6,"context_line":"version then is currently packaged, a source build"},{"line_number":7,"context_line":"(technically using a prebuilt binary package) is required."}],"source_content_type":"text/x-rst","patch_set":23,"id":"3a1ff146_152593aa","line":4,"in_reply_to":"da36d5c6_8871efaa","updated":"2017-03-14 18:38:50.000000000","message":"Done","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"47ffa42ad9dee21c57f7ec70a29fff1efab89710","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenDaylight Build"},{"line_number":2,"context_line":"-------------------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"To build OpenDaylight, use of a template override"},{"line_number":5,"context_line":"\"opendaylight-template-overrides.j2\" is needed."}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a1ced50_2add2ee0","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":25},"updated":"2017-03-22 02:10:17.000000000","message":"Please delete\nAlso, undeline should be using \u003d\u003d and not --\nPlease refer https://docs.openstack.org/contributor-guide/rst-conv/titles.html","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"47ffa42ad9dee21c57f7ec70a29fff1efab89710","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a source build (technically uses a prebuilt binary package) is required."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Building OpenDaylight Containers"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a1ced50_4ada6ae9","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":44},"updated":"2017-03-22 02:10:17.000000000","message":"delete","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"39d8c446219897122ce211bc81c539434eb7d1af","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a source build (technically uses a prebuilt binary package) is required."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Building OpenDaylight Containers"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a1ced50_cc661e29","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":44},"in_reply_to":"1a1ced50_4ada6ae9","updated":"2017-03-23 18:13:43.000000000","message":"Done","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"47ffa42ad9dee21c57f7ec70a29fff1efab89710","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  kolla-build --template-override \\"},{"line_number":35,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Deploy Opendaylight"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"To deploy \u0027Opendaylight + OpenvSwitch\u0027 instead of \u0027OpenvSwitch + Neutron Agent\u0027"},{"line_number":41,"context_line":"configure /etc/kolla/globals.yml as follows."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"globals.yml"},{"line_number":44,"context_line":"___________"},{"line_number":45,"context_line":"::"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    ###############################"},{"line_number":48,"context_line":"    # Neutron - Networking Options"},{"line_number":49,"context_line":"    ###############################"},{"line_number":50,"context_line":"    neutron_plugin_agent: \"opendaylight\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    ###############################"},{"line_number":53,"context_line":"    #  OpenDaylight"},{"line_number":54,"context_line":"    ###############################"},{"line_number":55,"context_line":"    opendaylight_mechanism_driver: \"opendaylight_v2\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    ####################"},{"line_number":58,"context_line":"    # OpenStack options"},{"line_number":59,"context_line":"    ####################"},{"line_number":60,"context_line":"    enable_opendaylight: \"yes\""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a1ced50_cac2dae8","line":60,"range":{"start_line":37,"start_character":0,"end_line":60,"end_character":30},"updated":"2017-03-22 02:10:17.000000000","message":"Please move this to a separate doc under kolla-ansible/doc","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"39d8c446219897122ce211bc81c539434eb7d1af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  kolla-build --template-override \\"},{"line_number":35,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Deploy Opendaylight"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"To deploy \u0027Opendaylight + OpenvSwitch\u0027 instead of \u0027OpenvSwitch + Neutron Agent\u0027"},{"line_number":41,"context_line":"configure /etc/kolla/globals.yml as follows."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"globals.yml"},{"line_number":44,"context_line":"___________"},{"line_number":45,"context_line":"::"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    ###############################"},{"line_number":48,"context_line":"    # Neutron - Networking Options"},{"line_number":49,"context_line":"    ###############################"},{"line_number":50,"context_line":"    neutron_plugin_agent: \"opendaylight\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    ###############################"},{"line_number":53,"context_line":"    #  OpenDaylight"},{"line_number":54,"context_line":"    ###############################"},{"line_number":55,"context_line":"    opendaylight_mechanism_driver: \"opendaylight_v2\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    ####################"},{"line_number":58,"context_line":"    # OpenStack options"},{"line_number":59,"context_line":"    ####################"},{"line_number":60,"context_line":"    enable_opendaylight: \"yes\""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a1ced50_ec6bdaef","line":60,"range":{"start_line":37,"start_character":0,"end_line":60,"end_character":30},"in_reply_to":"1a1ced50_cac2dae8","updated":"2017-03-23 18:13:43.000000000","message":"Done","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"To build OpenDaylight, use of a template override"},{"line_number":6,"context_line":"\"opendaylight-template-overrides.j2\" is needed."},{"line_number":7,"context_line":"The template override enables OpenDaylight use"},{"line_number":8,"context_line":"with OpenStack by installing required networking-odl"},{"line_number":9,"context_line":"plugin in neutron-server container."}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_a2bacb6f","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":1},"updated":"2017-03-23 19:01:55.000000000","message":"single colon `","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"To build OpenDaylight, use of a template override"},{"line_number":6,"context_line":"\"opendaylight-template-overrides.j2\" is needed."},{"line_number":7,"context_line":"The template override enables OpenDaylight use"},{"line_number":8,"context_line":"with OpenStack by installing required networking-odl"},{"line_number":9,"context_line":"plugin in neutron-server container."}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_251fc50a","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":1},"in_reply_to":"1a1ced50_a2bacb6f","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"fc665932c63a5713b22a60aeb7d1cad6cf121f0a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"with OpenStack by installing required networking-odl"},{"line_number":9,"context_line":"plugin in neutron-server container."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"To install a different version of OpenDaylight then packages provide"},{"line_number":12,"context_line":"a source build (technically uses a prebuilt binary package) is required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Building OpenDaylight Containers"}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_dcefa5e7","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":60},"updated":"2017-03-23 22:28:31.000000000","message":"This is a little unclear? Can we rephrase the sentence?","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":8,"context_line":"with OpenStack by installing required networking-odl"},{"line_number":9,"context_line":"plugin in neutron-server container."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"To install a different version of OpenDaylight then packages provide"},{"line_number":12,"context_line":"a source build (technically uses a prebuilt binary package) is required."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Building OpenDaylight Containers"}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_9c2a3de5","line":11,"range":{"start_line":11,"start_character":47,"end_line":11,"end_character":60},"in_reply_to":"ffe62b97_dcefa5e7","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":15,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_a261eb13","line":18,"range":{"start_line":18,"start_character":44,"end_line":18,"end_character":71},"updated":"2017-03-23 19:01:55.000000000","message":"add `to show paths`","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":15,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_c56191aa","line":18,"range":{"start_line":18,"start_character":44,"end_line":18,"end_character":71},"in_reply_to":"1a1ced50_a261eb13","updated":"2017-03-23 22:40:52.000000000","message":"Not sure I understand this.","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"fc665932c63a5713b22a60aeb7d1cad6cf121f0a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_bcc5015e","line":20,"updated":"2017-03-23 22:28:31.000000000","message":"Can we have a line gap between two bullet points?","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"fc665932c63a5713b22a60aeb7d1cad6cf121f0a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_3cafb195","line":20,"range":{"start_line":20,"start_character":9,"end_line":20,"end_character":28},"updated":"2017-03-23 22:28:31.000000000","message":"Please use single ` here","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_5c0dd58e","line":20,"range":{"start_line":20,"start_character":9,"end_line":20,"end_character":28},"in_reply_to":"ffe62b97_3cafb195","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_3c1211b3","line":20,"in_reply_to":"ffe62b97_bcc5015e","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"fc665932c63a5713b22a60aeb7d1cad6cf121f0a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_fc902951","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":14},"updated":"2017-03-23 22:28:31.000000000","message":"OpenDaylight","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- For source builds append the following to /etc/kolla/kolla-build.conf,"},{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_7c1899d2","line":21,"range":{"start_line":21,"start_character":2,"end_line":21,"end_character":14},"in_reply_to":"ffe62b97_fc902951","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_c24d079b","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":3},"updated":"2017-03-23 19:01:55.000000000","message":"single colon `","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_65545dca","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":3},"in_reply_to":"1a1ced50_c24d079b","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_0248ff86","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":3},"updated":"2017-03-23 19:01:55.000000000","message":"ditto","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- Change opendaylight_distro to match the folder where"},{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_4547611d","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":3},"in_reply_to":"1a1ced50_0248ff86","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_c2f1876c","line":24,"updated":"2017-03-23 19:01:55.000000000","message":"please add a new line before","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  opendaylight build resides. For example, if using prebuilt archive from OpenDaylight downloads,"},{"line_number":22,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2.tar.gz\" use"},{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_05456916","line":24,"in_reply_to":"1a1ced50_c2f1876c","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    opendaylight_distro \u003d distribution-karaf-0.5.2-Boron-SR2"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_22889bc6","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":2},"updated":"2017-03-23 19:01:55.000000000","message":"for declaring code in docs use \n.. code-block:: console","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  \"distribution-karaf-0.5.2-Boron-SR2\""},{"line_number":24,"context_line":"kolla-build.conf"},{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    opendaylight_distro \u003d distribution-karaf-0.5.2-Boron-SR2"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_e53f6d85","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":2},"in_reply_to":"1a1ced50_22889bc6","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    opendaylight_distro \u003d distribution-karaf-0.5.2-Boron-SR2"},{"line_number":30,"context_line":"    [opendaylight]"},{"line_number":31,"context_line":"    type \u003d url"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_c215079c","line":28,"updated":"2017-03-23 19:01:55.000000000","message":"please, remove empty line","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":25,"context_line":"________________"},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    opendaylight_distro \u003d distribution-karaf-0.5.2-Boron-SR2"},{"line_number":30,"context_line":"    [opendaylight]"},{"line_number":31,"context_line":"    type \u003d url"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_c53a7198","line":28,"in_reply_to":"1a1ced50_c215079c","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    location \u003d https://nexus.opendaylight.org/content/repositories/opendaylight.release/org/opendaylight/integration/distribution-karaf/0.5.2-Boron-SR2/distribution-karaf-0.5.2-Boron-SR2.tar.gz"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- To build the container (source or binary) execute the follow command:"},{"line_number":35,"context_line":"  kolla-build --template-override \\"},{"line_number":36,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_629293f8","line":35,"updated":"2017-03-23 19:01:55.000000000","message":"use command format","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"fc665932c63a5713b22a60aeb7d1cad6cf121f0a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    location \u003d https://nexus.opendaylight.org/content/repositories/opendaylight.release/org/opendaylight/integration/distribution-karaf/0.5.2-Boron-SR2/distribution-karaf-0.5.2-Boron-SR2.tar.gz"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- To build the container (source or binary) execute the follow command:"},{"line_number":35,"context_line":"  kolla-build --template-override \\"},{"line_number":36,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"}],"source_content_type":"text/x-rst","patch_set":32,"id":"ffe62b97_9c891d28","line":35,"in_reply_to":"1a1ced50_629293f8","updated":"2017-03-23 22:28:31.000000000","message":"+1","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    location \u003d https://nexus.opendaylight.org/content/repositories/opendaylight.release/org/opendaylight/integration/distribution-karaf/0.5.2-Boron-SR2/distribution-karaf-0.5.2-Boron-SR2.tar.gz"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- To build the container (source or binary) execute the follow command:"},{"line_number":35,"context_line":"  kolla-build --template-override \\"},{"line_number":36,"context_line":"  contrib/template-override/opendaylight-template-overrides.j2 opendaylight"}],"source_content_type":"text/x-rst","patch_set":32,"id":"1a1ced50_e5568dcd","line":35,"in_reply_to":"1a1ced50_629293f8","updated":"2017-03-23 22:40:52.000000000","message":"I changed this to match other rst docs, hopefully that\u0027s what you meant.","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"f6b2eb546d9a049540aa396c49d0527598bf595c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- For source builds append the following to kolla-build.conf,"},{"line_number":20,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- Change \u0027opendaylight_distro\u0027 to match the folder where OpenDaylight"},{"line_number":23,"context_line":"  build resides. For example, if using prebuilt archive from OpenDaylight"},{"line_number":24,"context_line":"  downloads \u0027distribution-karaf-0.5.2-Boron-SR2.tar.gz\u0027 becomes"},{"line_number":25,"context_line":"  \u0027distribution-karaf-0.5.2-Boron-SR2\u0027."}],"source_content_type":"text/x-rst","patch_set":35,"id":"ffe62b97_1a6f632b","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":30},"updated":"2017-03-29 22:31:51.000000000","message":"it must be ` and not \u0027 . Please change all instances of the same","commit_id":"369dcb68803e253a2bbabe4ed59079b18b084ce0"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"a4e917e6f5058e96245677fb7a2d3ce4dfe1f3d9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- For source builds append the following to kolla-build.conf,"},{"line_number":20,"context_line":"  selecting the version of OpenDaylight to use for your source build."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- Change \u0027opendaylight_distro\u0027 to match the folder where OpenDaylight"},{"line_number":23,"context_line":"  build resides. For example, if using prebuilt archive from OpenDaylight"},{"line_number":24,"context_line":"  downloads \u0027distribution-karaf-0.5.2-Boron-SR2.tar.gz\u0027 becomes"},{"line_number":25,"context_line":"  \u0027distribution-karaf-0.5.2-Boron-SR2\u0027."}],"source_content_type":"text/x-rst","patch_set":35,"id":"ffe62b97_83330a14","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":30},"in_reply_to":"ffe62b97_1a6f632b","updated":"2017-03-30 01:15:28.000000000","message":"Done. It was really hard to figure out what you meant, kept focusing on \u0027and not\u0027 rather than punctuation. But think I cracked it.","commit_id":"369dcb68803e253a2bbabe4ed59079b18b084ce0"},{"author":{"_account_id":24164,"name":"Sayantani Goswami","email":"sayantani.goswami@intel.com","username":"sayantani.goswami"},"change_message_id":"f6b2eb546d9a049540aa396c49d0527598bf595c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Build the container (source or binary) by executing the following command::"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    kolla-build --template-override contrib/template-override/opendaylight-template-overrides.j2 opendaylight"}],"source_content_type":"text/x-rst","patch_set":35,"id":"ffe62b97_da4d7bc4","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":109},"updated":"2017-03-29 22:31:51.000000000","message":"please put it under\n\n::","commit_id":"369dcb68803e253a2bbabe4ed59079b18b084ce0"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"a4e917e6f5058e96245677fb7a2d3ce4dfe1f3d9","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Build the container (source or binary) by executing the following command::"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    kolla-build --template-override contrib/template-override/opendaylight-template-overrides.j2 opendaylight"}],"source_content_type":"text/x-rst","patch_set":35,"id":"ffe62b97_6336c605","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":109},"in_reply_to":"ffe62b97_da4d7bc4","updated":"2017-03-30 01:15:28.000000000","message":"Done","commit_id":"369dcb68803e253a2bbabe4ed59079b18b084ce0"}],"docker/neutron/neutron-openvswitch-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set neutron_openvswitch_agent_packages \u003d ["},{"line_number":12,"context_line":"            \u0027openstack-neutron-openvswitch\u0027,"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_210035aa","line":13,"updated":"2017-01-04 09:26:02.000000000","message":"Why remove openvswitch?","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f031e2f7befb6b50aa9c7b8dd8c2dafd6317b4ff","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"        {% set neutron_openvswitch_agent_packages \u003d ["},{"line_number":12,"context_line":"            \u0027openstack-neutron-openvswitch\u0027,"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_625ce9ed","line":13,"in_reply_to":"ba5201f7_210035aa","updated":"2017-01-04 17:49:05.000000000","message":"openvswitch is required in this contianer to provide the ovs commandline clients so this change will break kolla when ovs is used without odl.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"}],"docker/opendaylight/Dockerfile.j2":[{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"448887f64208f612f03a067d316f80c466dd68f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":10,"context_line":"            \u0027java-1.7.0-openjdk\u0027,"},{"line_number":11,"context_line":"            \u0027wget\u0027,"},{"line_number":12,"context_line":"            \u0027git\u0027"},{"line_number":13,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_15a37950","line":10,"updated":"2017-01-04 00:43:16.000000000","message":"Should java 1.7 be used here or java 1.8? Will check with OpenDaylight Packaging PTL","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":10,"context_line":"            \u0027java-1.7.0-openjdk\u0027,"},{"line_number":11,"context_line":"            \u0027wget\u0027,"},{"line_number":12,"context_line":"            \u0027git\u0027"},{"line_number":13,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_8142c10e","line":10,"in_reply_to":"ba5201f7_15a37950","updated":"2017-01-04 09:26:02.000000000","message":"As part of opendaylight binary dependency, java-1.8.0-openjdk is installed in centos.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f031e2f7befb6b50aa9c7b8dd8c2dafd6317b4ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set opendaylight_packages \u003d ["},{"line_number":10,"context_line":"            \u0027java-1.7.0-openjdk\u0027,"},{"line_number":11,"context_line":"            \u0027wget\u0027,"},{"line_number":12,"context_line":"            \u0027git\u0027"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_02bb1de6","line":12,"range":{"start_line":11,"start_character":11,"end_line":12,"end_character":17},"updated":"2017-01-04 17:49:05.000000000","message":"why are you installing git and wget.\nfor source installs the plugin fuctionality should be used so that kolla build pulls down the artifact and includes it it the image build.\n\nhttps://github.com/openstack/kolla/blob/master/doc/image-building.rst#plugin-functionality\n\nfor binary builds the odl package provied by the os should pull in the required dependencies.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"448887f64208f612f03a067d316f80c466dd68f7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":26,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-1.7.0-openjdk"},{"line_number":27,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":28,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-1.7.0-openjdk-amd64"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ENV JAVA_MIN_MEM {{ odl_java_min_mem }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_75e685b5","line":28,"updated":"2017-01-04 00:43:16.000000000","message":"Both JAVA_HOME values should probably be configurable using jinja2 template language to maintain deploy configurability.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f031e2f7befb6b50aa9c7b8dd8c2dafd6317b4ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":26,"context_line":"ENV JAVA_HOME /usr/lib/jvm/jre-1.7.0-openjdk"},{"line_number":27,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":28,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-1.7.0-openjdk-amd64"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ENV JAVA_MIN_MEM {{ odl_java_min_mem }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_82a46da6","line":28,"in_reply_to":"ba5201f7_75e685b5","updated":"2017-01-04 17:49:05.000000000","message":"im not sure you need to configur this at all. if you set the path correctly in the contianer or use the absulte path to java when specifying the contianer boot command.\nbut yes this should not be here","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-1.7.0-openjdk-amd64"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ENV JAVA_MIN_MEM {{ odl_java_min_mem }}"},{"line_number":32,"context_line":"ENV JAVA_MAX_MEM {{ odl_java_max_mem }}"},{"line_number":33,"context_line":"ENV JAVA_MAX_PERM_MEM {{ odl_java_max_perm_mem }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN mkdir /opt/odl \u0026\u0026 cd /opt/odl \u0026\u0026 \\"},{"line_number":36,"context_line":"    wget {{ odl_url_prefix }}/{{ odl_url_release_repository_path }}/org/opendaylight/integration/distribution-karaf/{{ odl_release }}/{{ odl_release }}.tar.gz \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_2152f5dd","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":49},"updated":"2017-01-04 09:26:02.000000000","message":"This values cannot be evaluated in Dockerfiles, should be added in ansible start.yml playbook during startup.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f031e2f7befb6b50aa9c7b8dd8c2dafd6317b4ff","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV JAVA_HOME /usr/lib/jvm/java-1.7.0-openjdk-amd64"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ENV JAVA_MIN_MEM {{ odl_java_min_mem }}"},{"line_number":32,"context_line":"ENV JAVA_MAX_MEM {{ odl_java_max_mem }}"},{"line_number":33,"context_line":"ENV JAVA_MAX_PERM_MEM {{ odl_java_max_perm_mem }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN mkdir /opt/odl \u0026\u0026 cd /opt/odl \u0026\u0026 \\"},{"line_number":36,"context_line":"    wget {{ odl_url_prefix }}/{{ odl_url_release_repository_path }}/org/opendaylight/integration/distribution-karaf/{{ odl_release }}/{{ odl_release }}.tar.gz \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_0205dd78","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":49},"in_reply_to":"ba5201f7_2152f5dd","updated":"2017-01-04 17:49:05.000000000","message":"+1","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"ENV JAVA_MAX_MEM {{ odl_java_max_mem }}"},{"line_number":33,"context_line":"ENV JAVA_MAX_PERM_MEM {{ odl_java_max_perm_mem }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN mkdir /opt/odl \u0026\u0026 cd /opt/odl \u0026\u0026 \\"},{"line_number":36,"context_line":"    wget {{ odl_url_prefix }}/{{ odl_url_release_repository_path }}/org/opendaylight/integration/distribution-karaf/{{ odl_release }}/{{ odl_release }}.tar.gz \u0026\u0026 \\"},{"line_number":37,"context_line":"    sleep 3 \u0026\u0026 \\"},{"line_number":38,"context_line":"    tar -xvzf {{ odl_release }}.tar.gz"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_410619cf","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":38},"updated":"2017-01-04 09:26:02.000000000","message":"This should be part of a source installation.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f031e2f7befb6b50aa9c7b8dd8c2dafd6317b4ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"ENV JAVA_MAX_MEM {{ odl_java_max_mem }}"},{"line_number":33,"context_line":"ENV JAVA_MAX_PERM_MEM {{ odl_java_max_perm_mem }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN mkdir /opt/odl \u0026\u0026 cd /opt/odl \u0026\u0026 \\"},{"line_number":36,"context_line":"    wget {{ odl_url_prefix }}/{{ odl_url_release_repository_path }}/org/opendaylight/integration/distribution-karaf/{{ odl_release }}/{{ odl_release }}.tar.gz \u0026\u0026 \\"},{"line_number":37,"context_line":"    sleep 3 \u0026\u0026 \\"},{"line_number":38,"context_line":"    tar -xvzf {{ odl_release }}.tar.gz"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_222f41f7","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":38},"in_reply_to":"ba5201f7_410619cf","updated":"2017-01-04 17:49:05.000000000","message":"this should be done using the plugin fuctionality and a template override.\nhttps://github.com/openstack/kolla/blob/master/doc/image-building.rst#plugin-functionality","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% block opendaylight_footer %}{% endblock %}"},{"line_number":46,"context_line":"{% block footer %}{% endblock %}"},{"line_number":47,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_a113450c","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":20},"updated":"2017-01-04 09:26:02.000000000","message":"Deprecated footers","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"06f2855f6a0bb31a28fec3b518eefb5b62b6e08a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"COPY opendaylight-5-release.repo /etc/yum.repos.d/"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN yum clean all"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      {% set opendaylight_packages \u003d ["},{"line_number":16,"context_line":"        \u0027opendaylight\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_f6bcf4bc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":17},"updated":"2017-01-05 15:31:54.000000000","message":"Not needed, after every installation a clean all is made, this dockerfile is children of base image and clean repos has been made in that image.\nWhen install packages will update repo info.","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"ce50ec7d0e117b832f114961474f035586680f25","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"COPY opendaylight-5-release.repo /etc/yum.repos.d/"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN yum clean all"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      {% set opendaylight_packages \u003d ["},{"line_number":16,"context_line":"        \u0027opendaylight\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_37890c76","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":17},"in_reply_to":"ba5201f7_f6bcf4bc","updated":"2017-01-05 21:36:20.000000000","message":"Done","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"06f2855f6a0bb31a28fec3b518eefb5b62b6e08a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN echo \"Package unavailable for {{ base_distro }}\" | /bin/false"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_b6bfcca8","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":4},"updated":"2017-01-05 15:31:54.000000000","message":"Remove indent","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"ce50ec7d0e117b832f114961474f035586680f25","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN echo \"Package unavailable for {{ base_distro }}\" | /bin/false"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_577a1078","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":4},"in_reply_to":"ba5201f7_b6bfcca8","updated":"2017-01-05 21:36:20.000000000","message":"Done","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"06f2855f6a0bb31a28fec3b518eefb5b62b6e08a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ADD opendaylight-archive /opt/opendaylight"},{"line_number":34,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_b6d6ecee","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":4},"updated":"2017-01-05 15:31:54.000000000","message":"ditto","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"ce50ec7d0e117b832f114961474f035586680f25","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ADD opendaylight-archive /opt/opendaylight"},{"line_number":34,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_777f1466","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":4},"in_reply_to":"ba5201f7_b6d6ecee","updated":"2017-01-05 21:36:20.000000000","message":"Done","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a187178043097cea39277bac58dd6acdfdde96f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":26,"context_line":"      {% set opendaylight_packages \u003d [\u0027java-1.8.0-openjdk\u0027] %}"},{"line_number":27,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":28,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    {{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ADD opendaylight-archive /opt/opendaylight"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":37,"context_line":"   \u0027odl-neutron-service\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_55011305","line":34,"range":{"start_line":24,"start_character":0,"end_line":34,"end_character":11},"updated":"2017-01-06 12:27:28.000000000","message":"odl is an infra component and currently we are not allowed to support source installs of infra components natively in the dockerfiles.\n\ni would not mind changing that personally but for now you should replace this with a block and provide a template overide example contrib.\n\ni will be submitting a patch to create the new directory for template files soon for dpdk so we should both rebase on that patch.","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"06f2855f6a0bb31a28fec3b518eefb5b62b6e08a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"RUN /opt/opendaylight/bin/start clean \\"},{"line_number":46,"context_line":"    \u0026\u0026 sleep 15 \\"},{"line_number":47,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/client \"feature:install -v {% for feature in opendaylight_features %}{{ feature }}{{ \u0027 \u0027 if not loop.last else \u0027\u0027 }}{% endfor %}\" \\"},{"line_number":48,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":51,"context_line":"RUN touch /usr/local/bin/kolla_opendaylight_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_160a5879","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":33},"updated":"2017-01-05 15:31:54.000000000","message":"Don\u0027t know why I need to stop opendaylight before finish the layer, if not stopped, features didn\u0027t work. weird :/","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"ce50ec7d0e117b832f114961474f035586680f25","unresolved":false,"context_lines":[{"line_number":45,"context_line":"RUN /opt/opendaylight/bin/start clean \\"},{"line_number":46,"context_line":"    \u0026\u0026 sleep 15 \\"},{"line_number":47,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/client \"feature:install -v {% for feature in opendaylight_features %}{{ feature }}{{ \u0027 \u0027 if not loop.last else \u0027\u0027 }}{% endfor %}\" \\"},{"line_number":48,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":51,"context_line":"RUN touch /usr/local/bin/kolla_opendaylight_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_974d5840","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":33},"in_reply_to":"ba5201f7_160a5879","updated":"2017-01-05 21:36:20.000000000","message":"I\u0027m not exactly sure but it might have something to do with graceful shutdown and ability to store config of the install.","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74d2ca5ccf413b156f2a039b7e63f6c2ccbd2cd8","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":24,"context_line":"      {% set opendaylight_packages \u003d [\u0027java-1.8.0-openjdk\u0027] %}"},{"line_number":25,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":26,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":32,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":33,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":37,"context_line":"   \u0027odl-neutron-service\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba5201f7_d811ba05","line":34,"range":{"start_line":22,"start_character":0,"end_line":34,"end_character":11},"updated":"2017-01-06 12:42:54.000000000","message":"this need to be refactored into a template override.\n\nI would replace this with a named block to make it simpler\n\n{% import \"macros.j2\" as macros with context %}\n\n{% elif install_type \u003d\u003d \u0027source\u0027 %}\n{% block opendaylight_source_install %}{% endblock %}\n{% endif %}\n\nin the template override just add\n\n{% block opendaylight_source_install %}\n\n{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}\n      {% set opendaylight_packages \u003d [\u0027java-1.8.0-openjdk\u0027] %}\n    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}\n      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}\n    {% endif %}\n\n{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}\n\n{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}\nADD opendaylight-archive /opendaylight\nRUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight\n\n{% endblock %}","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"0de08b5a0e26956ad7666c14453d3ef2943e3db5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":24,"context_line":"      {% set opendaylight_packages \u003d [\u0027java-1.8.0-openjdk\u0027] %}"},{"line_number":25,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":26,"context_line":"      {% set opendaylight_packages \u003d [\u0027openjdk-8-jre\u0027] %}"},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% set opendaylight_distro \u003d \u0027distribution-karaf-0.5.2-Boron-SR2\u0027 %}"},{"line_number":32,"context_line":"ADD opendaylight-archive /opendaylight"},{"line_number":33,"context_line":"RUN ln -s /opendaylight/{{ opendaylight_distro }} /opt/opendaylight"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":37,"context_line":"   \u0027odl-neutron-service\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba5201f7_1fca3d1b","line":34,"range":{"start_line":22,"start_character":0,"end_line":34,"end_character":11},"in_reply_to":"ba5201f7_d811ba05","updated":"2017-01-06 18:39:22.000000000","message":"Done","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74d2ca5ccf413b156f2a039b7e63f6c2ccbd2cd8","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RUN /opt/opendaylight/bin/start clean \\"},{"line_number":46,"context_line":"    \u0026\u0026 sleep 15 \\"},{"line_number":47,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/client \"feature:install -v {% for feature in opendaylight_features %}{{ feature }}{{ \u0027 \u0027 if not loop.last else \u0027\u0027 }}{% endfor %}\" \\"},{"line_number":48,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba5201f7_98a732bc","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":24},"updated":"2017-01-06 12:42:54.000000000","message":"is this path the same on centos and ubuntu?","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"0de08b5a0e26956ad7666c14453d3ef2943e3db5","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"RUN /opt/opendaylight/bin/start clean \\"},{"line_number":46,"context_line":"    \u0026\u0026 sleep 15 \\"},{"line_number":47,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/client \"feature:install -v {% for feature in opendaylight_features %}{{ feature }}{{ \u0027 \u0027 if not loop.last else \u0027\u0027 }}{% endfor %}\" \\"},{"line_number":48,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba5201f7_3fc2a1e9","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":24},"in_reply_to":"ba5201f7_98a732bc","updated":"2017-01-06 18:39:22.000000000","message":"AFAIK no official package for Ubuntu as yet. Standard practice for ODL Packaging is to place into /opt/ (.RPMs, puppet and ansible)","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87235036478fc4bcd4f49f62daa9f09106fdf443","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":"{% block opendaylight_source_install %}{% endblock %}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% set opendaylight_features \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ba5201f7_0508f690","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":53},"updated":"2017-01-09 17:08:19.000000000","message":"hi i should have mentioned this in my last review but can you update this to\n\n{% block opendaylight_source_install %}\nRUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\\n\u0026\u0026 /bin/false\n{% endblock %}\n\nif you try to do a source build of opendaylight without using a template-override it should fail as that is not supported.\n\nwith this change you will also need to excluded the odl container from being built in the source build jobs similar to https://review.openstack.org/#/c/342354/10/tests/test_build.py","commit_id":"65fa2d12473c55e91a03b6e906d703b0ee9c7cb5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87235036478fc4bcd4f49f62daa9f09106fdf443","unresolved":false,"context_lines":[{"line_number":33,"context_line":"] %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN /opt/opendaylight/bin/start clean \\"},{"line_number":36,"context_line":"    \u0026\u0026 sleep 15 \\"},{"line_number":37,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/client \"feature:install -v {% for feature in opendaylight_features %}{{ feature }}{{ \u0027 \u0027 if not loop.last else \u0027\u0027 }}{% endfor %}\" \\"},{"line_number":38,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ba5201f7_053556f6","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":15},"updated":"2017-01-09 17:08:19.000000000","message":"nit: while this probably ok it would be more robust to grep so an initialization complete message or somting similar in the log output if available to ensure you dont have odd behavior on SSDs vs HDDs VSs in vms with distribute storage that said 15 seconds should be ok even for slow systems.","commit_id":"65fa2d12473c55e91a03b6e906d703b0ee9c7cb5"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"5a43439bc0ca19a4aea194ae150172711c190382","unresolved":false,"context_lines":[{"line_number":33,"context_line":"] %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN /opt/opendaylight/bin/start clean \\"},{"line_number":36,"context_line":"    \u0026\u0026 sleep 15 \\"},{"line_number":37,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/client \"feature:install -v {% for feature in opendaylight_features %}{{ feature }}{{ \u0027 \u0027 if not loop.last else \u0027\u0027 }}{% endfor %}\" \\"},{"line_number":38,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ba5201f7_b354c5ca","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":15},"in_reply_to":"ba5201f7_053556f6","updated":"2017-01-09 20:06:49.000000000","message":"I don\u0027t like having a sleep here either. I don\u0027t have a better way to do this ATM. But I\u0027ll check with ODL community and check on a better method.","commit_id":"65fa2d12473c55e91a03b6e906d703b0ee9c7cb5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b3d0e60d046e9a8791626841c48ac65f5c238fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        \u0027opendaylight\u0027"},{"line_number":15,"context_line":"      ] %}"},{"line_number":16,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":17,"context_line":"RUN echo \"Package unavailable for {{ base_distro }}\" | /bin/false"},{"line_number":18,"context_line":"    {% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_318031f7","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":65},"updated":"2017-01-23 15:29:07.000000000","message":"For unify with the rest of Dockerfiles use:\nRUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\\n    \u0026\u0026 /bin/false","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7e975ab4756eea0fcf1cd4f2d869b3657342db7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        \u0027opendaylight\u0027"},{"line_number":15,"context_line":"      ] %}"},{"line_number":16,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":17,"context_line":"RUN echo \"Package unavailable for {{ base_distro }}\" | /bin/false"},{"line_number":18,"context_line":"    {% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_3be2c72f","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":65},"in_reply_to":"5a3905b3_318031f7","updated":"2017-01-23 17:25:38.000000000","message":"Done","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b3d0e60d046e9a8791626841c48ac65f5c238fe","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":"RUN touch /usr/local/bin/kolla_opendaylight_extend_start \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_opendaylight_extend_start"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"{% block opendaylight_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_51869ddb","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":56},"updated":"2017-01-23 15:29:07.000000000","message":"Does not exist, odl only use kolla_extend_start as far I can see","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7e975ab4756eea0fcf1cd4f2d869b3657342db7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":"RUN touch /usr/local/bin/kolla_opendaylight_extend_start \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_opendaylight_extend_start"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"{% block opendaylight_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_5bd31360","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":56},"in_reply_to":"5a3905b3_51869ddb","updated":"2017-01-23 17:25:38.000000000","message":"Done","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b3d0e60d046e9a8791626841c48ac65f5c238fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":"RUN touch /usr/local/bin/kolla_opendaylight_extend_start \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_opendaylight_extend_start"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"{% block opendaylight_footer %}{% endblock %}"},{"line_number":48,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_1167b54d","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":97},"updated":"2017-01-23 15:29:07.000000000","message":"ditto","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7e975ab4756eea0fcf1cd4f2d869b3657342db7","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":44,"context_line":"RUN touch /usr/local/bin/kolla_opendaylight_extend_start \\"},{"line_number":45,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_opendaylight_extend_start"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"{% block opendaylight_footer %}{% endblock %}"},{"line_number":48,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5a3905b3_7bd60f50","line":45,"range":{"start_line":45,"start_character":51,"end_line":45,"end_character":97},"in_reply_to":"5a3905b3_1167b54d","updated":"2017-01-23 17:25:38.000000000","message":"Done","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24bc7852c107c63b3377eca8b346040324bc9e0d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":45,"context_line":"RUN touch /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_extend_start"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block opendaylight_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5a3905b3_d0524b12","line":45,"range":{"start_line":45,"start_character":9,"end_line":45,"end_character":43},"updated":"2017-01-24 15:30:17.000000000","message":"not need to touch since the file is already copied there.","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"cfdb31478b19c85694c20475bd33832e2ff76e95","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \u0026\u0026 /opt/opendaylight/bin/stop"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":45,"context_line":"RUN touch /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_extend_start"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block opendaylight_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5a3905b3_41803447","line":45,"range":{"start_line":45,"start_character":9,"end_line":45,"end_character":43},"in_reply_to":"5a3905b3_d0524b12","updated":"2017-01-24 23:45:57.000000000","message":"Done","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"24bc7852c107c63b3377eca8b346040324bc9e0d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":45,"context_line":"RUN touch /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_extend_start"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block opendaylight_footer %}{% endblock %}"},{"line_number":49,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5a3905b3_704a7756","line":46,"range":{"start_line":46,"start_character":51,"end_line":46,"end_character":84},"updated":"2017-01-24 15:30:17.000000000","message":"duplicated","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"cfdb31478b19c85694c20475bd33832e2ff76e95","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":45,"context_line":"RUN touch /usr/local/bin/kolla_extend_start \\"},{"line_number":46,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_extend_start"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block opendaylight_footer %}{% endblock %}"},{"line_number":49,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5a3905b3_61953087","line":46,"range":{"start_line":46,"start_character":51,"end_line":46,"end_character":84},"in_reply_to":"5a3905b3_704a7756","updated":"2017-01-24 23:45:57.000000000","message":"Done","commit_id":"357c8443af9f51c83d8245504c0b77e35824832f"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"3f3f073b62b0368337887f8675a2f09d12d63004","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY opendaylight-5-release.repo /etc/yum.repos.d/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      {% set opendaylight_packages \u003d ["},{"line_number":16,"context_line":"        \u0027opendaylight\u0027"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_795ad72b","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":32},"updated":"2017-02-22 18:50:42.000000000","message":"shouldn\u0027t this be variablized and we can have container images for every ODL release?","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"c7bc164a7b004e4dcf9b007f342f4512fa5f1a09","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY opendaylight-5-release.repo /etc/yum.repos.d/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      {% set opendaylight_packages \u003d ["},{"line_number":16,"context_line":"        \u0027opendaylight\u0027"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"3a1ff146_35136f5e","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":32},"in_reply_to":"da36d5c6_1fa37bb3","updated":"2017-03-14 18:38:50.000000000","message":"Done","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY opendaylight-5-release.repo /etc/yum.repos.d/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      {% set opendaylight_packages \u003d ["},{"line_number":16,"context_line":"        \u0027opendaylight\u0027"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_1fa37bb3","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":32},"in_reply_to":"da36d5c6_795ad72b","updated":"2017-02-22 19:57:37.000000000","message":"Yes, this is probably a good idea.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19494,"name":"Daniel Farrell","email":"dfarrell07@gmail.com","username":"dfarrell07"},"change_message_id":"4f4a6b0b6513a8c22a1fbf5adf975baee473837f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027opendaylight\u0027"},{"line_number":17,"context_line":"      ] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_36e6fcb4","line":19,"updated":"2017-02-20 20:23:54.000000000","message":"Same \"there are now deb packages\" feedback https://wiki.opendaylight.org/view/Deployment#Deb","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027opendaylight\u0027"},{"line_number":17,"context_line":"      ] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_8d474176","line":19,"in_reply_to":"da36d5c6_36e6fcb4","updated":"2017-02-22 19:57:37.000000000","message":"Thanks, Didn\u0027t know that at the time. Will update here.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"c7bc164a7b004e4dcf9b007f342f4512fa5f1a09","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027opendaylight\u0027"},{"line_number":17,"context_line":"      ] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":20,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"3a1ff146_150e7334","line":19,"in_reply_to":"da36d5c6_8d474176","updated":"2017-03-14 18:38:50.000000000","message":"Done","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19494,"name":"Daniel Farrell","email":"dfarrell07@gmail.com","username":"dfarrell07"},"change_message_id":"4f4a6b0b6513a8c22a1fbf5adf975baee473837f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_d6404059","line":32,"updated":"2017-02-20 20:23:54.000000000","message":"I think you likely just want to install `odl-netvirt-openstack`. That should pull in all of these and new-NetVirt. `odl-ovsdb-openstack` is the old NetVirt\u0027s way of pulling in everything FYI.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"c7bc164a7b004e4dcf9b007f342f4512fa5f1a09","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"3a1ff146_751de765","line":32,"in_reply_to":"da36d5c6_0da888da","updated":"2017-03-14 18:38:50.000000000","message":"Done","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"fe22acf6ed9c0da1341db332e1a6e988328ada0f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_cfef4d85","line":32,"in_reply_to":"da36d5c6_2d65751d","updated":"2017-02-23 16:06:11.000000000","message":"But you are building from this RPM which already contains features built into it, right?  When we deploy ODL using this RPM today with OOO, there is no internet connectivity and it brings up these features.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_2d65751d","line":32,"in_reply_to":"da36d5c6_5c56e1ce","updated":"2017-02-22 19:57:37.000000000","message":"Actually, I believe when you install a feature in ODL from \u0027release distribution\u0027 it pulls it down from external repo and installs. If you are installing from a specific projects builds it\u0027s likely that the features needed are present at start of ODL and then only need to be \u0027enabled\u0027 by running feature:install. There might be a way to have packages built into release distro. But then we run into issue of deciding what to include. \n\nSo for Kolla deploy model I think Eduardo is correct, to have the needed features available to start at container/odl start they need to be installed at build unless there is an expectation of connection to internet or local repo in the environment. I think in general kolla assumes this is not a reasonable expectation.\n\nHowever since all of this is editable before build of container (thus the template/variables) this can all be overridden. To both Daniel and Tim\u0027s points, what would a sane default be?\n\nWe can make this part explicitly able to be overridden in a template override.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0167f412b3c96b9b022b0984622e0aed2aacc94a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_79b9f778","line":32,"in_reply_to":"da36d5c6_7971f7a7","updated":"2017-02-22 19:03:19.000000000","message":"In kolla we create images consumables by deployment tools, an image must contain all necessary packages installed on it.\nWe do not install stuff during deployment as some nodes will likely have different versions that others breaking consistency in the environment as well as the hosts need internet connection to retrieve packages.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"b900bb0a1729244ccd8a0560215f96cf57f563bd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_5c56e1ce","line":32,"in_reply_to":"da36d5c6_79b9f778","updated":"2017-02-22 19:09:50.000000000","message":"I\u0027m not really referring to installing any missing packages here.  The feature install function for ODL will install already existing package into the karaf shell.  This is more like enabling a feature in ODL, rather than \"installing\" it.  I think we don\u0027t need to start ODL and enable each feature.  If we need it ready out of the box preloaded with netvirt, then write the features to the correct conf file imo.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"15247fe6160f5d9133b455f5b31030e14d578494","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_0da888da","line":32,"in_reply_to":"da36d5c6_cfef4d85","updated":"2017-02-23 18:41:37.000000000","message":"If we were only building with RPM that is correct, if the OSGI bundles/karaf features that we want are part of RPM. This template is meant to satisfy building from source (an ODL build in this case) or binary (packaging RPM etc.) covering centos, oraclelinux, rhel, ubuntu and debian.\n\nThe source option defaults to pulling the latest build from https://nexus.opendaylight.org/content/repositories/opendaylight.release/org/opendaylight/integration/distribution-karaf/ which is the same thing you will get from https://www.opendaylight.org/downloads. But the idea is you can override that version or you could build a custom version of ODL and give the path in kolla-build.conf and it would install that at container build.\n\nIn all cases we want the container behavior to be the same when we start it whether you use binary or \u0027source\u0027. Unless something has changed about karaf features (they are all stored with build and thus your point about enabling is correct) we would need to install these features at build where an internet connection is expected.\n\nNone of this changes the fact that we can accommodate exactly what you are asking for in a template override. See https://docs.openstack.org/developer/kolla/image-building.html#generic-customisation \n\nWe could include a specific template override for triple-O use, add this section as overridable and change whatever is needed. Take a look at current override used https://review.openstack.org/#/c/416369/23/contrib/template-override/opendaylight-template-overrides.j2","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"3f3f073b62b0368337887f8675a2f09d12d63004","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endblock %}"},{"line_number":30,"context_line":"{% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% set opendaylight_features \u003d ["},{"line_number":33,"context_line":"   \u0027odl-neutron-service\u0027,"},{"line_number":34,"context_line":"   \u0027odl-restconf-all\u0027,"},{"line_number":35,"context_line":"   \u0027odl-aaa-authn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"da36d5c6_7971f7a7","line":32,"in_reply_to":"da36d5c6_d6404059","updated":"2017-02-22 18:50:42.000000000","message":"I don\u0027t think we should set any features to install here.  This should be done by a configuration tool or user.  For example with OOO, we will run puppet-opendaylight to create the configuration file which will indicate which features to load during ODL start.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"82461c0d9b7043fb3538a92bf58bd9a4fa4be1ec","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set opendaylight_packages \u003d [\u0027opendaylight\u0027] %}"},{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    {% if opendaylight_repo is not defined %}{% set opendaylight_repo \u003d \u0027opendaylight.repo\u0027 %}{% endif %}"},{"line_number":15,"context_line":"COPY {{ opendaylight_repo }} /etc/yum.repos.d/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1a1ced50_eb1d9373","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":4},"updated":"2017-03-23 12:13:55.000000000","message":"add indent and move set to a new line","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"39d8c446219897122ce211bc81c539434eb7d1af","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    {% set opendaylight_packages \u003d [\u0027opendaylight\u0027] %}"},{"line_number":12,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    {% if opendaylight_repo is not defined %}{% set opendaylight_repo \u003d \u0027opendaylight.repo\u0027 %}{% endif %}"},{"line_number":15,"context_line":"COPY {{ opendaylight_repo }} /etc/yum.repos.d/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1a1ced50_4c5a2e52","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":4},"in_reply_to":"1a1ced50_eb1d9373","updated":"2017-03-23 18:13:43.000000000","message":"Done","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"82461c0d9b7043fb3538a92bf58bd9a4fa4be1ec","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      {% endif %}"},{"line_number":25,"context_line":"RUN sh -c \"echo \u0027deb {{ odl_release_deb_url }} /\u0027 \u003e /etc/apt/sources.list.d/opendaylight.list\" \\"},{"line_number":26,"context_line":"    \u0026\u0026 apt-get update"},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1a1ced50_2b3debdc","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":4},"updated":"2017-03-23 12:13:55.000000000","message":"remove indent","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"39d8c446219897122ce211bc81c539434eb7d1af","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      {% endif %}"},{"line_number":25,"context_line":"RUN sh -c \"echo \u0027deb {{ odl_release_deb_url }} /\u0027 \u003e /etc/apt/sources.list.d/opendaylight.list\" \\"},{"line_number":26,"context_line":"    \u0026\u0026 apt-get update"},{"line_number":27,"context_line":"    {% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1a1ced50_6c57ea26","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":4},"in_reply_to":"1a1ced50_2b3debdc","updated":"2017-03-23 18:13:43.000000000","message":"Done","commit_id":"4708417d249a107b2e4cb321fd13018b33b71feb"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d64a666c208d67f5b8551a0e70ba659299c4371b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        {% endif %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"RUN sh -c \"echo \u0027deb {{ odl_release_deb_url }} /\u0027 \u003e /etc/apt/sources.list.d/opendaylight.list\" \\"},{"line_number":28,"context_line":"    \u0026\u0026 apt-get update"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"ffe62b97_8e6fca29","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":21},"updated":"2017-03-29 14:28:27.000000000","message":"this last update is not needed.\nAfter each macro.install is cleaned up local cache and in the next call will update local cache.","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"7e248d1cfb4cd65663305ca0ac4f8d11a028a0ed","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        {% endif %}"},{"line_number":26,"context_line":"{% endif %}"},{"line_number":27,"context_line":"RUN sh -c \"echo \u0027deb {{ odl_release_deb_url }} /\u0027 \u003e /etc/apt/sources.list.d/opendaylight.list\" \\"},{"line_number":28,"context_line":"    \u0026\u0026 apt-get update"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"ffe62b97_602a4adb","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":21},"in_reply_to":"ffe62b97_8e6fca29","updated":"2017-03-29 17:20:00.000000000","message":"Done","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b0143638c28bd7f9012dccfd745d03a643601521","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        {% endif %}"},{"line_number":26,"context_line":"      {% endif %}"},{"line_number":27,"context_line":"RUN sh -c \"echo \u0027deb {{ odl_release_deb_url }} /\u0027 \u003e /etc/apt/sources.list.d/opendaylight.list\""},{"line_number":28,"context_line":"RUN apt-get update"},{"line_number":29,"context_line":"    {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ macros.install_packages(opendaylight_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":38,"id":"7ffa3b31_7ad6002a","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":18},"updated":"2017-04-18 15:26:20.000000000","message":"yes, this was what I mean, but can you merge with previous RUN to reduce image layers?\n\nRUN sh -c \"echo \u0027deb {{ odl_release_deb_url }} /\u0027 \u003e /etc/apt/sources.list.d/opendaylight.list\" \\\n\u0026\u0026 apt-get update","commit_id":"ea7a4c847c6352ca3a959402dd6ec39534ef60eb"}],"docker/opendaylight/extend_start.sh":[{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"448887f64208f612f03a067d316f80c466dd68f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/opendaylight"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":". /usr/local/bin/kolla_opendaylight_extend_start"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba5201f7_9554c921","line":10,"updated":"2017-01-04 00:43:16.000000000","message":"Need to add kolla_opendaylight_extend_start file to patch","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/opendaylight"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":". /usr/local/bin/kolla_opendaylight_extend_start"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba5201f7_c121294f","line":10,"in_reply_to":"ba5201f7_9554c921","updated":"2017-01-04 09:26:02.000000000","message":"If there is only one Dockerfile, not need to add other extend_start than the base one. Use BOOTSTRAP variables if needed.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba5201f7_01f331d7","line":11,"updated":"2017-01-04 09:26:02.000000000","message":"http://logs.openstack.org/69/416369/4/check/gate-kolla-pep8-ubuntu-xenial/7c45248/console.html#_2017-01-04_00_21_20_795408","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"06f2855f6a0bb31a28fec3b518eefb5b62b6e08a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":11,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":12,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":13,"context_line":"    #ODL do something here"},{"line_number":14,"context_line":"    exit 0"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba5201f7_56ddc0de","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":26},"updated":"2017-01-05 15:31:54.000000000","message":"Think there is no bootstrap process of odl, since features are installed in docker image. Leave this here until we ensure is not needed","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"8c80cbfdfb736ee3f478b5e8393ced6bcb459757","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/opendaylight\" ]]; then"},{"line_number":4,"context_line":"    mkdir -p /var/log/kolla/opendaylight"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/opendaylight) !\u003d \"755\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":12,"id":"7a3c09a3_e382cd51","line":3,"range":{"start_line":3,"start_character":12,"end_line":3,"end_character":39},"updated":"2017-01-15 03:45:31.000000000","message":"Please use variable\n\nExample：\nhttps://github.com/openstack/kolla/blob/master/docker/ceilometer/ceilometer-base/extend_start.sh#L3","commit_id":"efe2c54fb5914c6aa861ad9fc5d38f5f149e0dea"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"94d6a5d7a928c90877bca7b81a08468cbf11dc94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/opendaylight\" ]]; then"},{"line_number":4,"context_line":"    mkdir -p /var/log/kolla/opendaylight"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/opendaylight) !\u003d \"755\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":12,"id":"7a3c09a3_f7969dee","line":3,"range":{"start_line":3,"start_character":12,"end_line":3,"end_character":39},"in_reply_to":"7a3c09a3_e382cd51","updated":"2017-01-17 17:37:13.000000000","message":"Done","commit_id":"efe2c54fb5914c6aa861ad9fc5d38f5f149e0dea"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b3d0e60d046e9a8791626841c48ac65f5c238fe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":13,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":14,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":15,"context_line":"    #ODL do something here"},{"line_number":16,"context_line":"    exit 0"},{"line_number":17,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"5a3905b3_319d910a","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":26},"updated":"2017-01-23 15:29:07.000000000","message":"Probably is not needed a bootstrap process, guess this will be removed once verified in ansible role","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7e975ab4756eea0fcf1cd4f2d869b3657342db7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":13,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":14,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":15,"context_line":"    #ODL do something here"},{"line_number":16,"context_line":"    exit 0"},{"line_number":17,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"5a3905b3_fbf75fd0","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":26},"in_reply_to":"5a3905b3_319d910a","updated":"2017-01-23 17:25:38.000000000","message":"That\u0027s the plan. :)","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cbea775b93b0b2275ca8ffa56b7831556fb34e91","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    chmod 755 \"${OPENDAYLIGHT_LOG_DIR}\""},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":13,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":14,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":15,"context_line":"    #ODL do something here"},{"line_number":16,"context_line":"    exit 0"},{"line_number":17,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3a461143_92277563","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":2},"updated":"2017-01-27 11:42:34.000000000","message":"I think is ready to merge, can you please remove this part as is not used.","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"dbef86d9321e81baafcb694b3d3ec53e99d038a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    chmod 755 \"${OPENDAYLIGHT_LOG_DIR}\""},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":13,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":14,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":15,"context_line":"    #ODL do something here"},{"line_number":16,"context_line":"    exit 0"},{"line_number":17,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3a461143_a45fc13f","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":2},"in_reply_to":"3a461143_92277563","updated":"2017-01-27 18:09:08.000000000","message":"Agreed.","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":19494,"name":"Daniel Farrell","email":"dfarrell07@gmail.com","username":"dfarrell07"},"change_message_id":"4f4a6b0b6513a8c22a1fbf5adf975baee473837f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"OPENDAYLIGHT_LOG_DIR\u003d/var/log/kolla/opendaylight"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ ! -d \"${OPENDAYLIGHT_LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p \"${OPENDAYLIGHT_LOG_DIR}\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"da36d5c6_992b5982","line":3,"updated":"2017-02-20 20:23:54.000000000","message":"Is this for the purpose of publishing logs? If so, maybe should also publish /opt/opendaylight/data/log/karaf.log, the main ODL log. Anyone debugging ODL will need this.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"c7bc164a7b004e4dcf9b007f342f4512fa5f1a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"OPENDAYLIGHT_LOG_DIR\u003d/var/log/kolla/opendaylight"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ ! -d \"${OPENDAYLIGHT_LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p \"${OPENDAYLIGHT_LOG_DIR}\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3a1ff146_d503fb0b","line":3,"in_reply_to":"da36d5c6_687afb78","updated":"2017-03-14 18:38:50.000000000","message":"Daniel, I believe this is to collate logs for fluentd. I just need to make sure fluent is pulling log from /opt/opendaylight/data/log/karaf.log","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b064c49b93cca74ceaed347aa98faec0c8bc828c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"OPENDAYLIGHT_LOG_DIR\u003d/var/log/kolla/opendaylight"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ ! -d \"${OPENDAYLIGHT_LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p \"${OPENDAYLIGHT_LOG_DIR}\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"da36d5c6_687afb78","line":3,"in_reply_to":"da36d5c6_992b5982","updated":"2017-02-22 19:57:37.000000000","message":"Good catch.","commit_id":"0e058057f479eb7be964f222ed48b8f62e2c3e4d"}],"docker/opendaylight/neutron-server-template-overrides.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a187178043097cea39277bac58dd6acdfdde96f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN git clone https://git.openstack.org/openstack/networking-odl \\"},{"line_number":5,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-odl"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_5846aa4f","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":48},"updated":"2017-01-06 12:27:28.000000000","message":"the git clone should not be done via the template override.\nit should use the kolla-build plugin method.","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"06f2855f6a0bb31a28fec3b518eefb5b62b6e08a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN git clone https://git.openstack.org/openstack/networking-odl \\"},{"line_number":5,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-odl"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba5201f7_9691e8f3","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":14},"updated":"2017-01-05 15:31:54.000000000","message":"As this will install odl plugin into neutron-server image, we can\u0027t rely on template-overrides to ensure odl plugin does not break neutron-server.\nI would add the url at https://github.com/openstack/kolla/blob/master/kolla/common/config.py#L270\nAnd install as a regular plugin into neutron-server.","commit_id":"e2180af635841a9f7d302bc619064bf6827da443"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74d2ca5ccf413b156f2a039b7e63f6c2ccbd2cd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba5201f7_58e22a30","updated":"2017-01-06 12:42:54.000000000","message":"all template overrides should be moved to a dedicated folder not stored with the docker images.\n\nim creating a directory for storing them currently under the contrib dir.\n\nill post back with the link to the patch.\nonce the patch is up to create the template dir you should rebase this on top and move this into that directory.\n\ncurrently only one template override can be used at a time. that is being changed.\nas such you should also add the template overide for installing odl from source to the template override you are introducing.","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"0de08b5a0e26956ad7666c14453d3ef2943e3db5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba5201f7_7f3d09dc","in_reply_to":"ba5201f7_58e22a30","updated":"2017-01-06 18:39:22.000000000","message":"Done","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8481370f367779ae17efb59344d79ae0d3f37564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba5201f7_93a70c0a","in_reply_to":"ba5201f7_58e22a30","updated":"2017-01-06 16:09:55.000000000","message":"can you rebase this on top of https://review.openstack.org/#/c/417429/\nand move this template override to the contrib/template-override folder","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"0de08b5a0e26956ad7666c14453d3ef2943e3db5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba5201f7_9f28ed9b","in_reply_to":"ba5201f7_93a70c0a","updated":"2017-01-06 18:39:22.000000000","message":"Done","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74d2ca5ccf413b156f2a039b7e63f6c2ccbd2cd8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN git clone https://git.openstack.org/openstack/networking-odl \\"},{"line_number":5,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-odl"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba5201f7_98a1f2fa","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":48},"updated":"2017-01-06 12:42:54.000000000","message":"only the pip install should be done in the template.\nthe git clone should be done via the kolla-build plugin mechanism\nalso im not sure if this will install networking-odl from pip or install the version from  the git repo you just cloned so you might what to use a relative \"./\" or absolute path instead.","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"0de08b5a0e26956ad7666c14453d3ef2943e3db5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% block neutron_server_footer %}"},{"line_number":4,"context_line":"RUN git clone https://git.openstack.org/openstack/networking-odl \\"},{"line_number":5,"context_line":"    \u0026\u0026 pip --no-cache-dir install networking-odl"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"ba5201f7_94aa8f83","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":48},"in_reply_to":"ba5201f7_98a1f2fa","updated":"2017-01-06 18:39:22.000000000","message":"Done","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"}],"docker/opendaylight/opendaylight-5-release.repo":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"74d2ca5ccf413b156f2a039b7e63f6c2ccbd2cd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba5201f7_f8cd9e66","updated":"2017-01-06 12:42:54.000000000","message":"do we need to enable a similar repo on ubuntu or is it packaged in the ubuntu cloud archive/main repos?","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"0de08b5a0e26956ad7666c14453d3ef2943e3db5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba5201f7_b4e953b9","in_reply_to":"ba5201f7_f8cd9e66","updated":"2017-01-06 18:39:22.000000000","message":"AFAIK there isn\u0027t a packaged version of ODL for ubuntu. Did a cursory search and only found networking-odl http://packages.ubuntu.com/search?keywords\u003dopendaylight\u0026searchon\u003dall\u0026suite\u003dall\u0026section\u003dall and this seemed the same in cloud archive.","commit_id":"c829d72948a42cde21dd335b9639fff90e31c8af"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0b3d0e60d046e9a8791626841c48ac65f5c238fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[opendaylight-5-release]"},{"line_number":2,"context_line":"name\u003dCentOS CBS OpenDaylight Boron Release Repository"},{"line_number":3,"context_line":"baseurl\u003dhttp://cbs.centos.org/repos/nfv7-opendaylight-5-release/$basearch/os/"},{"line_number":4,"context_line":"enabled\u003d1"},{"line_number":5,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"5a3905b3_ec4ecc6d","line":3,"range":{"start_line":3,"start_character":54,"end_line":3,"end_character":55},"updated":"2017-01-23 15:29:07.000000000","message":"release 6 is ready to be released (no packages in repo yet) just to know.\nhttp://cbs.centos.org/repos/nfv7-opendaylight-6-release/","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7e975ab4756eea0fcf1cd4f2d869b3657342db7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[opendaylight-5-release]"},{"line_number":2,"context_line":"name\u003dCentOS CBS OpenDaylight Boron Release Repository"},{"line_number":3,"context_line":"baseurl\u003dhttp://cbs.centos.org/repos/nfv7-opendaylight-5-release/$basearch/os/"},{"line_number":4,"context_line":"enabled\u003d1"},{"line_number":5,"context_line":"gpgcheck\u003d0"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"5a3905b3_5b66b32a","line":3,"range":{"start_line":3,"start_character":54,"end_line":3,"end_character":55},"in_reply_to":"5a3905b3_ec4ecc6d","updated":"2017-01-23 17:25:38.000000000","message":"Roger that. Unless packaging is using another number scheme, Release 6 (Carbon) is set for 5/11/2017. So we have some time. :) We are currently on Boron (release 5 stability release 2). I\u0027ll double check with Daniel (ODL Packaging PTL) on ODL packaging numbering.","commit_id":"e31fc28ab5bcc069002db34ca3fefb61f725d657"}],"docker/openvswitch/openvswitch-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch\u0027,"},{"line_number":10,"context_line":"    \u0027python-openvswitch\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch-switch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_e11c6d15","line":10,"range":{"start_line":9,"start_character":53,"end_line":10,"end_character":25},"updated":"2017-01-04 09:26:02.000000000","message":"Please, split in multilines","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"448887f64208f612f03a067d316f80c466dd68f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch\u0027,"},{"line_number":10,"context_line":"    \u0027python-openvswitch\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch-switch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_b518ed85","line":10,"updated":"2017-01-04 00:43:16.000000000","message":"Why do I need to add python-openvswitch here? Investigate.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f031e2f7befb6b50aa9c7b8dd8c2dafd6317b4ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch\u0027,"},{"line_number":10,"context_line":"    \u0027python-openvswitch\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch-switch\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_e2737913","line":10,"range":{"start_line":9,"start_character":53,"end_line":10,"end_character":25},"in_reply_to":"ba5201f7_e11c6d15","updated":"2017-01-04 17:49:05.000000000","message":"i dont belive it is required in this container.\n\nthe ansible code uses the commanline client to configure ovs currently.\n\nit is required for the ovs agent container so that the native python client can be used instead of the command line client but that should not require it to be installed here.","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18ce3c2449edfcd934f1e622a855d07a572ee2c4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set openvswitch_base_packages \u003d [\u0027openvswitch-switch\u0027,"},{"line_number":14,"context_line":"    \u0027python-openvswitch\u0027] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(openvswitch_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba5201f7_211755ee","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":28},"updated":"2017-01-04 09:26:02.000000000","message":"ditto","commit_id":"27a00878ee30fcfdf82e1245f9d0b5a09e03e7e5"}],"kolla/common/config.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cbea775b93b0b2275ca8ffa56b7831556fb34e91","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":451,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/octavia/\u0027"},{"line_number":452,"context_line":"                     \u0027octavia-master.tar.gz\u0027)},"},{"line_number":453,"context_line":"    \u0027opendaylight\u0027: {"},{"line_number":454,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":455,"context_line":"        \u0027location\u0027: (\u0027https://nexus.opendaylight.org/content/\u0027"},{"line_number":456,"context_line":"                     \u0027repositories/opendaylight.release/org/opendaylight/\u0027"},{"line_number":457,"context_line":"                     \u0027integration/distribution-karaf/0.5.2-Boron-SR2/\u0027"},{"line_number":458,"context_line":"                     \u0027distribution-karaf-0.5.2-Boron-SR2.tar.gz\u0027)},"},{"line_number":459,"context_line":"    \u0027panko-base\u0027: {"},{"line_number":460,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":461,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a461143_b2b8f1e6","line":458,"range":{"start_line":453,"start_character":0,"end_line":458,"end_character":67},"updated":"2017-01-27 11:42:34.000000000","message":"This part is not used, this is appended in kolla-build.conf as per the doc","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"dbef86d9321e81baafcb694b3d3ec53e99d038a6","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":451,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/octavia/\u0027"},{"line_number":452,"context_line":"                     \u0027octavia-master.tar.gz\u0027)},"},{"line_number":453,"context_line":"    \u0027opendaylight\u0027: {"},{"line_number":454,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":455,"context_line":"        \u0027location\u0027: (\u0027https://nexus.opendaylight.org/content/\u0027"},{"line_number":456,"context_line":"                     \u0027repositories/opendaylight.release/org/opendaylight/\u0027"},{"line_number":457,"context_line":"                     \u0027integration/distribution-karaf/0.5.2-Boron-SR2/\u0027"},{"line_number":458,"context_line":"                     \u0027distribution-karaf-0.5.2-Boron-SR2.tar.gz\u0027)},"},{"line_number":459,"context_line":"    \u0027panko-base\u0027: {"},{"line_number":460,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":461,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/panko/\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a461143_8471e5e2","line":458,"range":{"start_line":453,"start_character":0,"end_line":458,"end_character":67},"in_reply_to":"3a461143_b2b8f1e6","updated":"2017-01-27 18:09:08.000000000","message":"My intention here is to have this show up as default source for ODL in kolla-build.conf. Are you saying that is undesirable and it should be mentioned in docs and added by the person using template override manually?","commit_id":"af439f27388441d5aafb0fcd73e4410c4da11a20"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        \u0027uid\u0027: 42437,"},{"line_number":697,"context_line":"        \u0027gid\u0027: 42437,"},{"line_number":698,"context_line":"    },"},{"line_number":699,"context_line":"    \u0027opendaylight-user\u0027: {"},{"line_number":700,"context_line":"        \u0027uid\u0027: 42438,"},{"line_number":701,"context_line":"        \u0027gid\u0027: 42438,"},{"line_number":702,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a1ced50_025e3f76","line":699,"range":{"start_line":699,"start_character":5,"end_line":699,"end_character":17},"updated":"2017-03-23 19:01:55.000000000","message":"user/group uid cannot be changed, please add opendaylight user at the end of the list with the next free uid","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        \u0027uid\u0027: 42437,"},{"line_number":697,"context_line":"        \u0027gid\u0027: 42437,"},{"line_number":698,"context_line":"    },"},{"line_number":699,"context_line":"    \u0027opendaylight-user\u0027: {"},{"line_number":700,"context_line":"        \u0027uid\u0027: 42438,"},{"line_number":701,"context_line":"        \u0027gid\u0027: 42438,"},{"line_number":702,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a1ced50_65f1bd95","line":699,"range":{"start_line":699,"start_character":5,"end_line":699,"end_character":17},"in_reply_to":"1a1ced50_025e3f76","updated":"2017-03-23 22:40:52.000000000","message":"Done","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d64a666c208d67f5b8551a0e70ba659299c4371b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                    \u0027monasca\u0027,"},{"line_number":89,"context_line":"                    \u0027murano\u0027,"},{"line_number":90,"context_line":"                    \u0027octavia\u0027,"},{"line_number":91,"context_line":"                    \u0027opendaylight\u0027,"},{"line_number":92,"context_line":"                    \u0027panko\u0027,"},{"line_number":93,"context_line":"                    \u0027rally\u0027,"},{"line_number":94,"context_line":"                    \u0027redis\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"ffe62b97_ae6e0efd","line":91,"range":{"start_line":91,"start_character":20,"end_line":91,"end_character":35},"updated":"2017-03-29 14:28:27.000000000","message":"i think odl is more of infra profile than aux","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"7e248d1cfb4cd65663305ca0ac4f8d11a028a0ed","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                    \u0027monasca\u0027,"},{"line_number":89,"context_line":"                    \u0027murano\u0027,"},{"line_number":90,"context_line":"                    \u0027octavia\u0027,"},{"line_number":91,"context_line":"                    \u0027opendaylight\u0027,"},{"line_number":92,"context_line":"                    \u0027panko\u0027,"},{"line_number":93,"context_line":"                    \u0027rally\u0027,"},{"line_number":94,"context_line":"                    \u0027redis\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"ffe62b97_80842ed4","line":91,"range":{"start_line":91,"start_character":20,"end_line":91,"end_character":35},"in_reply_to":"ffe62b97_ae6e0efd","updated":"2017-03-29 17:20:00.000000000","message":"Changed. :) I don\u0027t have a good sense of what these categories mean.","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d64a666c208d67f5b8551a0e70ba659299c4371b","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":473,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-vpnaas/\u0027"},{"line_number":474,"context_line":"                     \u0027neutron-vpnaas-master.tar.gz\u0027)},"},{"line_number":475,"context_line":"    \u0027neutron-server-plugin-networking-odl\u0027: {"},{"line_number":476,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":477,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-odl/\u0027"},{"line_number":478,"context_line":"                     \u0027networking-odl-master.tar.gz\u0027)},"},{"line_number":479,"context_line":"    \u0027nova-base\u0027: {"},{"line_number":480,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":481,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/nova/\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"ffe62b97_ee365603","line":478,"range":{"start_line":475,"start_character":0,"end_line":478,"end_character":54},"updated":"2017-03-29 14:28:27.000000000","message":"please, alphabetize it.","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"7e248d1cfb4cd65663305ca0ac4f8d11a028a0ed","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":473,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-vpnaas/\u0027"},{"line_number":474,"context_line":"                     \u0027neutron-vpnaas-master.tar.gz\u0027)},"},{"line_number":475,"context_line":"    \u0027neutron-server-plugin-networking-odl\u0027: {"},{"line_number":476,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":477,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/networking-odl/\u0027"},{"line_number":478,"context_line":"                     \u0027networking-odl-master.tar.gz\u0027)},"},{"line_number":479,"context_line":"    \u0027nova-base\u0027: {"},{"line_number":480,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":481,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/nova/\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"ffe62b97_e0641a4c","line":478,"range":{"start_line":475,"start_character":0,"end_line":478,"end_character":54},"in_reply_to":"ffe62b97_ee365603","updated":"2017-03-29 17:20:00.000000000","message":"Done","commit_id":"e89e9c16d8537b09a4f5b2b0201238e75d8f302f"}],"releasenotes/notes/add-opendaylight-fee2807442ce3c6d.yaml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cf34052ec8058e2c535e9cb3fa4c778926d42c08","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    During the pike cycle support for networking with"},{"line_number":4,"context_line":"    OpenDaylight was added to kolla."},{"line_number":5,"context_line":"    OpenDaylight is an open source software defined networking"},{"line_number":6,"context_line":"    controller platform with features that include network"},{"line_number":7,"context_line":"    virtualization, service function chanining and many others."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"   - Add OpenDaylight docker template and supporting files."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1a1ced50_02d55fb8","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":63},"updated":"2017-03-23 19:01:55.000000000","message":"not sure if a prelude is needed in release notes","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"e7a84d08da0e2304c8327bfc1a86ca9563048dee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    During the pike cycle support for networking with"},{"line_number":4,"context_line":"    OpenDaylight was added to kolla."},{"line_number":5,"context_line":"    OpenDaylight is an open source software defined networking"},{"line_number":6,"context_line":"    controller platform with features that include network"},{"line_number":7,"context_line":"    virtualization, service function chanining and many others."},{"line_number":8,"context_line":"features:"},{"line_number":9,"context_line":"   - Add OpenDaylight docker template and supporting files."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1a1ced50_256c2536","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":63},"in_reply_to":"1a1ced50_02d55fb8","updated":"2017-03-23 22:40:52.000000000","message":"Removed.","commit_id":"be0e4bb400c5fc2517a640508a6a45c0855e5f15"}]}