)]}'
{"docker/gnocchi/gnocchi-base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"76b3ce765649b5b553699e210a02480e53590ad3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \u0026\u0026 useradd --user-group gnocchi \\"},{"line_number":65,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt gnocchiclient /gnocchi[keystone,mysql,file,ceph] \\"},{"line_number":66,"context_line":"    \u0026\u0026 mkdir -p /etc/gnocchi /var/log/kolla/gnocchi /home/gnocchi \\"},{"line_number":67,"context_line":"    \u0026\u0026 gnocchi-config-generator \u003e /etc/gnocchi/gnocchi.conf \\"},{"line_number":68,"context_line":"    \u0026\u0026 chown -R gnocchi: /etc/gnocchi /var/log/kolla/gnocchi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a3c09a3_79031474","line":67,"updated":"2017-01-13 15:29:24.000000000","message":"1. lots of openstack project are using oslo-config-generator feature. and there is not \u003cservice\u003e.conf file in most of the projects. we do not generate \u003cservice\u003e.conf for them. so i do not treat gnocchi as especially. if u want to add this, please add in all projects.\n\n2. gnocchi won\u0027t work with the defautl gnocchi.conf file. and i do not think any openstack work with the default settings. we need configure the database url and keystone middle, at least. so I do not think it is useful and work to add the default gnocchi.conf file in dockerfiles.","commit_id":"8d65cfcef71d7a37b62a99d71addea97b0cde04f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"00b328052b6fb024d1e1c14e609c7f1b393c08f8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \u0026\u0026 useradd --user-group gnocchi \\"},{"line_number":65,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt gnocchiclient /gnocchi[keystone,mysql,file,ceph] \\"},{"line_number":66,"context_line":"    \u0026\u0026 mkdir -p /etc/gnocchi /var/log/kolla/gnocchi /home/gnocchi \\"},{"line_number":67,"context_line":"    \u0026\u0026 gnocchi-config-generator \u003e /etc/gnocchi/gnocchi.conf \\"},{"line_number":68,"context_line":"    \u0026\u0026 chown -R gnocchi: /etc/gnocchi /var/log/kolla/gnocchi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a3c09a3_d8c16982","line":67,"updated":"2017-01-13 13:28:16.000000000","message":"gnocchi.conf is mapping by ansible or k8s. then no need to generate the file in Dockerfile.\n\nso this line should be removed now.","commit_id":"8d65cfcef71d7a37b62a99d71addea97b0cde04f"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"835d8d4c98f05ed53c24c3cf24c852b069c572c6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \u0026\u0026 useradd --user-group gnocchi \\"},{"line_number":65,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt gnocchiclient /gnocchi[keystone,mysql,file,ceph] \\"},{"line_number":66,"context_line":"    \u0026\u0026 mkdir -p /etc/gnocchi /var/log/kolla/gnocchi /home/gnocchi \\"},{"line_number":67,"context_line":"    \u0026\u0026 gnocchi-config-generator \u003e /etc/gnocchi/gnocchi.conf \\"},{"line_number":68,"context_line":"    \u0026\u0026 chown -R gnocchi: /etc/gnocchi /var/log/kolla/gnocchi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a3c09a3_7cb062f5","line":67,"in_reply_to":"7a3c09a3_79031474","updated":"2017-01-13 15:41:06.000000000","message":"Fair enough.","commit_id":"8d65cfcef71d7a37b62a99d71addea97b0cde04f"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c5af7c473f8604c9fd86f14f6259ac628e455567","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \u0026\u0026 useradd --user-group gnocchi \\"},{"line_number":65,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt gnocchiclient /gnocchi[keystone,mysql,file,ceph] \\"},{"line_number":66,"context_line":"    \u0026\u0026 mkdir -p /etc/gnocchi /var/log/kolla/gnocchi /home/gnocchi \\"},{"line_number":67,"context_line":"    \u0026\u0026 gnocchi-config-generator \u003e /etc/gnocchi/gnocchi.conf \\"},{"line_number":68,"context_line":"    \u0026\u0026 chown -R gnocchi: /etc/gnocchi /var/log/kolla/gnocchi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a3c09a3_1bc20b34","line":67,"in_reply_to":"7a3c09a3_d8c16982","updated":"2017-01-13 13:55:32.000000000","message":"Hmmm, kolla-ansible and kolla-kubernetes are not the only consumers of kolla images. Will the gnocchi container work without providing an external configuration file? If not then we absolutely need to generate the default config file with gnocchi-config-generator like Eduardo did in PS1.","commit_id":"8d65cfcef71d7a37b62a99d71addea97b0cde04f"}]}
