)]}'
{"kolla/image/build.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0830bd0e3714e22d40265e52345b5a2857befa6d","unresolved":false,"context_lines":[{"line_number":542,"context_line":"                os.path.join(sys.prefix, \u0027share/kolla\u0027),"},{"line_number":543,"context_line":"                os.path.join(sys.prefix, \u0027local/share/kolla\u0027),"},{"line_number":544,"context_line":"                os.path.join(os.environ[\u0027SNAP\u0027], \u0027share/kolla\u0027))"},{"line_number":545,"context_line":"        except KeyError:"},{"line_number":546,"context_line":"            possible_paths \u003d ("},{"line_number":547,"context_line":"                PROJECT_ROOT,"},{"line_number":548,"context_line":"                os.path.join(sys.prefix, \u0027share/kolla\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_81a8dc8e","line":545,"updated":"2017-02-07 14:10:07.000000000","message":"KeyError is wired. \ncould u use:\n\nif os.environ.get(\u0027SNAP\u0027):\n   xxx\nelse:\n   xxx","commit_id":"706e10157028749b1045a9f72e61880cc813638d"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"5d0571174ac95580382ea07a11a0b9f6ac25b012","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        self.maintainer \u003d conf.maintainer"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def _get_images_dir(self):"},{"line_number":539,"context_line":"        if os.environ.get(\u0027SNAP\u0027):"},{"line_number":540,"context_line":"            possible_paths \u003d ("},{"line_number":541,"context_line":"                PROJECT_ROOT,"},{"line_number":542,"context_line":"                os.path.join(sys.prefix, \u0027share/kolla\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_3ee6e816","line":539,"updated":"2017-02-09 19:10:11.000000000","message":"you can just use os.environ.get(\u0027SNAP\u0027, \u0027\u0027) instead of this full if statement. os.path.join(\u0027\u0027) won\u0027t break anything","commit_id":"c0dc532b800c081e4b06463ca8c64b326736156e"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"385979773711ce726bb06c3609f65005bcae5ea3","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            PROJECT_ROOT,"},{"line_number":541,"context_line":"            os.path.join(sys.prefix, \u0027share/kolla\u0027),"},{"line_number":542,"context_line":"            os.path.join(sys.prefix, \u0027local/share/kolla\u0027),"},{"line_number":543,"context_line":"            os.path.join(os.environ.get(\u0027SNAP\u0027, \u0027\u0027), \u0027share/kolla\u0027))"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        for path in possible_paths:"},{"line_number":546,"context_line":"            image_path \u003d os.path.join(path, \u0027docker\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_bea66351","line":543,"updated":"2017-02-16 14:59:27.000000000","message":"could u add some NOTE to explain what SNAP is and why add it here? otherwise newcomer will be confused. and wanna remove it.","commit_id":"3224802df12bd153a74dd1e4a30aed8a340a495a"}]}