)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"f5ffbac85046614f2f186102d92a8700042548fa","unresolved":false,"context_lines":[{"line_number":74,"context_line":"V2:"},{"line_number":75,"context_line":"- fix check for !x86-64 to get it working at all"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Partially-Implements: multiarch-and-arm64-containers"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Change-Id: If0ccc58d436b2468cd477c222ebc2fe0073206e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"3a1ff146_820cd295","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":52},"updated":"2017-03-15 09:17:47.000000000","message":"please enable the blueprint hyperlink.\nPlease follow https://wiki.openstack.org/wiki/GitCommitMessages.","commit_id":"f5b460f1de9e85b67e26c5920f2e07e1a7b0f165"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6d8b956a299e153eb4c8458116db474080320fa8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"V2:"},{"line_number":75,"context_line":"- fix check for !x86-64 to get it working at all"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Partially-Implements: multiarch-and-arm64-containers"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Change-Id: If0ccc58d436b2468cd477c222ebc2fe0073206e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"3a1ff146_4f576202","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":52},"in_reply_to":"3a1ff146_820cd295","updated":"2017-03-15 09:50:11.000000000","message":"this patch is already linked on blueprint","commit_id":"f5b460f1de9e85b67e26c5920f2e07e1a7b0f165"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4b6c174c1615a36d460ab3fabea7912ada8f82f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":2,"context_line":"FROM {{ base_arch }}/{{ base_image }}:{{ base_distro_tag }}"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"FROM {{ base_image }}:{{ base_distro_tag }}"},{"line_number":5,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1a430d35_19a421b8","line":2,"updated":"2017-02-08 17:01:20.000000000","message":"normally, how can we get ppc docker base images?\nis there any standard image name provided by docker official?","commit_id":"ebabcfdbc0fdeb53fe6d39277f6ad2b9c8bf6f66"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"bcd59c7def14c239596618b1c09a7261a7335113","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":2,"context_line":"FROM {{ base_arch }}/{{ base_image }}:{{ base_distro_tag }}"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"FROM {{ base_image }}:{{ base_distro_tag }}"},{"line_number":5,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1a430d35_191b4182","line":2,"in_reply_to":"1a430d35_19a421b8","updated":"2017-02-08 17:09:51.000000000","message":"{{ base_arch }}/{{ base_image }}:{{ base_distro_tag }} is not good. it do not work at all.\n\ntry to use this[0]\n\nif not conf.base_image:\n    if self.base_arch \u003d\u003d \"ppc64le\":\n        conf.base_image \u003d \"ppc64le/ubuntu\"\n    elif self.base_arch \u003d\u003d \"arm\"\n         conf.base_image \u003d \"arm\"\n    else:\n         conf.base_image \u003d conf.base\n\n[0] https://github.com/openstack/kolla/blob/master/kolla/common/config.py#L827","commit_id":"ebabcfdbc0fdeb53fe6d39277f6ad2b9c8bf6f66"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7d01ddeb22bbfac05d9f5bb8ba28c8bc01281762","unresolved":false,"context_lines":[{"line_number":320,"context_line":"{% if base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"   {% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":323,"context_line":"RUN apt-get -y install  --no-install-recommends build-essential  gcc"},{"line_number":324,"context_line":"   {% elif base_distro \u003d\u003d \u0027centos\u0027 %}"},{"line_number":325,"context_line":"RUN yum -y install gcc"},{"line_number":326,"context_line":"   {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa31d9ce_497204e7","line":323,"range":{"start_line":323,"start_character":48,"end_line":323,"end_character":68},"updated":"2017-02-10 11:46:05.000000000","message":"can you use macros.install to install packages, make customizations easier for users.","commit_id":"b3e932dd739d3a969cea62659abec76b9d524ac9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7d01ddeb22bbfac05d9f5bb8ba28c8bc01281762","unresolved":false,"context_lines":[{"line_number":322,"context_line":"   {% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":323,"context_line":"RUN apt-get -y install  --no-install-recommends build-essential  gcc"},{"line_number":324,"context_line":"   {% elif base_distro \u003d\u003d \u0027centos\u0027 %}"},{"line_number":325,"context_line":"RUN yum -y install gcc"},{"line_number":326,"context_line":"   {% endif %}"},{"line_number":327,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":328,"context_line":"    \u0026\u0026 python get-pip.py \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa31d9ce_e949f88f","line":325,"range":{"start_line":325,"start_character":19,"end_line":325,"end_character":22},"updated":"2017-02-10 11:46:05.000000000","message":"ditto","commit_id":"b3e932dd739d3a969cea62659abec76b9d524ac9"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"c5dfaa59fc6a8ad97233ab0a62a577ac9f8a90fd","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    {% if install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"{% set base_compiler_packages \u003d ["},{"line_number":189,"context_line":"    \u0027gcc\u0027,"},{"line_number":190,"context_line":"] %}"},{"line_number":191,"context_line":"{% set base_centos_source_packages \u003d ["},{"line_number":192,"context_line":"    \u0027curl\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"da36d5c6_ce940ae4","line":189,"range":{"start_line":189,"start_character":9,"end_line":189,"end_character":10},"updated":"2017-02-21 14:38:05.000000000","message":"ditto","commit_id":"2c66a027573e9e9d17c6120ab90f0a5511cdd8d2"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"88c163baa67b2ce1b682fb3040e2f193cb16db8b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"] %}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"{% set base_centos_yum_repo_packages \u003d ["},{"line_number":121,"context_line":"    \u0027epel-release \u0027,"},{"line_number":122,"context_line":"    \u0027yum-plugin-priorities\u0027,"},{"line_number":123,"context_line":"] %}"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"bff0334d_10f5d057","line":121,"range":{"start_line":121,"start_character":17,"end_line":121,"end_character":18},"updated":"2017-04-06 07:32:48.000000000","message":"please remove this whitespace","commit_id":"c5ffcdffe7dc95cdb0f504f0602c06f9e81cde86"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"bd211e3d821c3ca650c2de3ba1077c5f0ffb14cf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 /etc/yum.conf"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#### BEGIN REPO ENABLEMENT"},{"line_number":44,"context_line":"{% set base_yum_repo_files \u003d ["},{"line_number":45,"context_line":" ] %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"{% set base_yum_url_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_832bb4e9","line":44,"updated":"2017-04-25 17:27:01.000000000","message":"do we need to keep these empty definitions here if we redefine it later based on arch?","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8b9419af7b69823ca8618194985abe248f85fbb1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 /etc/yum.conf"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#### BEGIN REPO ENABLEMENT"},{"line_number":44,"context_line":"{% set base_yum_repo_files \u003d ["},{"line_number":45,"context_line":" ] %}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"{% set base_yum_url_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_4c6dd902","line":44,"in_reply_to":"5ff73747_832bb4e9","updated":"2017-04-25 19:09:10.000000000","message":"ppc64le does not have own list\n\nI also thought about moving all *.repo to centos-{{base_arch}}.repo file to have it similar to how Debian/Ubuntu  sources.list is handled.","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"bd211e3d821c3ca650c2de3ba1077c5f0ffb14cf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"{#"},{"line_number":91,"context_line":" # this is comment to fix build issues - without it \u0027install_packages\u0027 gets merged"},{"line_number":92,"context_line":" # with for loop below. No idea why."},{"line_number":93,"context_line":"#}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{%- for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":96,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_632e68fb","line":93,"updated":"2017-04-25 17:27:01.000000000","message":"lol...","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8b9419af7b69823ca8618194985abe248f85fbb1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"{#"},{"line_number":91,"context_line":" # this is comment to fix build issues - without it \u0027install_packages\u0027 gets merged"},{"line_number":92,"context_line":" # with for loop below. No idea why."},{"line_number":93,"context_line":"#}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{%- for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":96,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_2c496d8a","line":93,"in_reply_to":"5ff73747_632e68fb","updated":"2017-04-25 19:09:10.000000000","message":"trust me - took a while to find out ;(","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"bd211e3d821c3ca650c2de3ba1077c5f0ffb14cf","unresolved":false,"context_lines":[{"line_number":132,"context_line":"] %}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":135,"context_line":"    {% set base_centos_yum_repo_keys \u003d base_centos_yum_repo_keys + ["},{"line_number":136,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage\u0027,"},{"line_number":137,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization\u0027"},{"line_number":138,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_4335ac45","line":135,"updated":"2017-04-25 17:27:01.000000000","message":"since we install packages from this var above, why do we change var here? I don\u0027t think it\u0027ll be used","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5e0ca67c10249070d5c01fdbf531873a25845a1a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"] %}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":135,"context_line":"    {% set base_centos_yum_repo_keys \u003d base_centos_yum_repo_keys + ["},{"line_number":136,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage\u0027,"},{"line_number":137,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization\u0027"},{"line_number":138,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_17b91ee8","line":135,"in_reply_to":"5ff73747_4335ac45","updated":"2017-04-25 19:21:09.000000000","message":"Older version installed those keys always. On x86 we have those centos-release-* packages so we do have keys for repositories added by them.\n\nOn aarch64 we have those repos added from buildlogs.centos.org in aarch64-cbs.repo file with \"gpgcheck\u003d0\" option set so packages are not checked are they signed (they are not).\n\nThere is a work going on moving aarch64 repos from buildlogs.centos.org to mirrors.centos.org/altarch/7/ place.","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8b9419af7b69823ca8618194985abe248f85fbb1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"] %}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":135,"context_line":"    {% set base_centos_yum_repo_keys \u003d base_centos_yum_repo_keys + ["},{"line_number":136,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage\u0027,"},{"line_number":137,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization\u0027"},{"line_number":138,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5ff73747_8c1ac17a","line":135,"in_reply_to":"5ff73747_4335ac45","updated":"2017-04-25 19:09:10.000000000","message":"have to check - long time since it was written","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"66ff38a66435a272d8d256df03d9d58e3ca02e55","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    {% set base_yum_repo_keys \u003d ["},{"line_number":74,"context_line":"        \u0027http://yum.mariadb.org/RPM-GPG-KEY-MariaDB\u0027,"},{"line_number":75,"context_line":"        \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-Percona \u0027,"},{"line_number":76,"context_line":"        \u0027https://packages.elastic.co/GPG-KEY-elasticsearch\u0027,"},{"line_number":77,"context_line":"        \u0027https://repos.influxdata.com/influxdb.key\u0027,"},{"line_number":78,"context_line":"        \u0027https://packagecloud.io/gpg.key\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":46,"id":"3f044301_2221b8b5","line":75,"range":{"start_line":75,"start_character":45,"end_line":75,"end_character":46},"updated":"2017-05-04 11:28:23.000000000","message":"just a nit, empty space in here","commit_id":"df2d1125d31f0dae22d8bef332d7805a136fb9db"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"66ff38a66435a272d8d256df03d9d58e3ca02e55","unresolved":false,"context_lines":[{"line_number":92,"context_line":" # with for loop below. No idea why."},{"line_number":93,"context_line":"#}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"{%- for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}"},{"line_number":96,"context_line":"{%- if loop.first %}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":97,"context_line":"    rpm --import {{ key }}"},{"line_number":98,"context_line":"{%- if not loop.last %} \\{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":46,"id":"3f044301_bd9a89c2","line":95,"range":{"start_line":95,"start_character":2,"end_line":95,"end_character":3},"updated":"2017-05-04 11:28:23.000000000","message":"previous comment is likely due this that remove trailing new lines.\n\nhttp://jinja.pocoo.org/docs/dev/templates/#whitespace-control","commit_id":"df2d1125d31f0dae22d8bef332d7805a136fb9db"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91bbd5f66325942399e76a8f3211b2a9a6553a2c","unresolved":false,"context_lines":[{"line_number":261,"context_line":"{% endblock %}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":264,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":265,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":266,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":267,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":49,"id":"3f044301_72570e28","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":57},"updated":"2017-05-10 19:46:54.000000000","message":"sources.list.ubuntu  will be copied  to all base_arch, then be replaced by the sources.list  at  line 266","commit_id":"57c055a40b717eb5a0888d4dc61d19a8b96a95e4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb793d962a59f911f45e61ef6f1d71ff09af0c1a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"{% endblock %}"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":264,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":265,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":266,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":267,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":49,"id":"3f044301_ed6d83cc","line":264,"range":{"start_line":264,"start_character":0,"end_line":264,"end_character":57},"in_reply_to":"3f044301_72570e28","updated":"2017-05-10 19:54:19.000000000","message":"yes, it will be.\n\ndoing it otherwise would require bunch of nested if/else/endif to get same effect.","commit_id":"57c055a40b717eb5a0888d4dc61d19a8b96a95e4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91bbd5f66325942399e76a8f3211b2a9a6553a2c","unresolved":false,"context_lines":[{"line_number":263,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":264,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":265,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":266,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":267,"context_line":"{% endif %}"},{"line_number":268,"context_line":"{% endblock %}"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":49,"id":"3f044301_12532a41","line":266,"updated":"2017-05-10 19:46:54.000000000","message":"isnt missing  {{ base_arch }} here?","commit_id":"57c055a40b717eb5a0888d4dc61d19a8b96a95e4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb793d962a59f911f45e61ef6f1d71ff09af0c1a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"{% block base_ubuntu_package_sources_list %}"},{"line_number":264,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":265,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" and base_arch !\u003d \u0027x86_64\u0027 %}"},{"line_number":266,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list"},{"line_number":267,"context_line":"{% endif %}"},{"line_number":268,"context_line":"{% endblock %}"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":49,"id":"3f044301_6d48535b","line":266,"in_reply_to":"3f044301_12532a41","updated":"2017-05-10 19:54:19.000000000","message":"Done","commit_id":"57c055a40b717eb5a0888d4dc61d19a8b96a95e4"}],"docker/base/aarch64-cbs.repo":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"66ff38a66435a272d8d256df03d9d58e3ca02e55","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[delorean-pike-testing]"},{"line_number":17,"context_line":"name\u003ddlrn-pike-testing"},{"line_number":18,"context_line":"baseurl\u003dhttps://buildlogs.centos.org/centos/7/cloud/$basearch/openstack-pike/"},{"line_number":19,"context_line":"enabled\u003d1"},{"line_number":20,"context_line":"gpgcheck\u003d0"},{"line_number":21,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":46,"id":"3f044301_48ae25e8","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":77},"updated":"2017-05-04 11:28:23.000000000","message":"please, add a note or todo at \nhttps://github.com/openstack/kolla/blob/master/kolla/common/config.py#L37\n\nI don\u0027t want to forget change repo version to next release or remove delorean once pike is released (as happen with ubuntu ocata)","commit_id":"df2d1125d31f0dae22d8bef332d7805a136fb9db"}],"docker/base/sources.list.ubuntu":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"bd211e3d821c3ca650c2de3ba1077c5f0ffb14cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# repos are defined in arch specific files"}],"source_content_type":"application/octet-stream","patch_set":42,"id":"5ff73747_2338603b","line":1,"updated":"2017-04-25 17:27:01.000000000","message":"That\u0027s going to need a release note. We support custom sources list so people might need to rename them","commit_id":"f3df9c83e73c632559653c31723c22f7b90e5c59"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"acf7101945a257d93d470a2a4b121e0745306669","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# repos are defined in arch specific files"}],"source_content_type":"application/octet-stream","patch_set":48,"id":"3f044301_e10c7ca6","line":1,"updated":"2017-05-10 10:35:13.000000000","message":"so can this file be removed?","commit_id":"3835fdb42425c31eadf1e22fc9f49eb2e726fc0c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91bbd5f66325942399e76a8f3211b2a9a6553a2c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Fluentd repo"},{"line_number":37,"context_line":"deb http://packages.treasuredata.com/2/ubuntu/xenial/ xenial contrib"},{"line_number":38,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":49,"id":"3f044301_f238beee","line":38,"updated":"2017-05-10 19:46:54.000000000","message":"if need  other change, please remove this empty line","commit_id":"57c055a40b717eb5a0888d4dc61d19a8b96a95e4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"eb793d962a59f911f45e61ef6f1d71ff09af0c1a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# Fluentd repo"},{"line_number":37,"context_line":"deb http://packages.treasuredata.com/2/ubuntu/xenial/ xenial contrib"},{"line_number":38,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":49,"id":"3f044301_cd72c7ad","line":38,"in_reply_to":"3f044301_f238beee","updated":"2017-05-10 19:54:19.000000000","message":"Done","commit_id":"57c055a40b717eb5a0888d4dc61d19a8b96a95e4"}],"kolla/common/config.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1c16e3f51881daae8431f73ee188d55c50ac7a9e","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    conf.set_default(\u0027base_tag\u0027, DISTRO_RELEASE.get(conf.base))"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    if not conf.base_image:"},{"line_number":832,"context_line":"        conf.base_image \u003d conf.base"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_3f0a9d8a","line":832,"updated":"2017-02-08 17:37:15.000000000","message":"if not conf.base_image:\n    if self.base_arch \u003d\u003d \"ppc64le\":\n        conf.base_image \u003d \"ppc64le/ubuntu\"\n    elif self.base_arch \u003d\u003d \"arm\"\n         conf.base_image \u003d \"...\"\n    else:\n         conf.base_image \u003d conf.base","commit_id":"875c5e4e7ffc570822fccdcceec80c957f4d835a"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"711cbc02c17643331eb2c1210c396da29539bc92","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    cfg.StrOpt(\u0027maintainer\u0027,"},{"line_number":244,"context_line":"               default\u003d\u0027Kolla Project (https://launchpad.net/kolla)\u0027,"},{"line_number":245,"context_line":"               help\u003d\u0027The MAINTAINER field\u0027),"},{"line_number":246,"context_line":"    cfg.ListOpt(\u0027rpm_setup_config\u0027, default\u003d[DELOREAN[hostarch], DELOREAN_DEPS[hostarch]],"},{"line_number":247,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":248,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":249,"context_line":"    cfg.StrOpt(\u0027apt_sources_list\u0027, help\u003d(\u0027Path to custom sources.list\u0027)),"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a1ff146_79524bdf","line":246,"updated":"2017-03-14 16:11:58.000000000","message":"pep8 will complain, line is too long \"line too long (90 \u003e 79 characters)\"","commit_id":"ba546b682d51220be8f38ad195b43d74bc841ef4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"66ff38a66435a272d8d256df03d9d58e3ca02e55","unresolved":false,"context_lines":[{"line_number":42,"context_line":"DELOREAN_DEPS \u003d {"},{"line_number":43,"context_line":"    \u0027x86_64\u0027: \"https://trunk.rdoproject.org/centos7/delorean-deps.repo\","},{"line_number":44,"context_line":"    \u0027aarch64\u0027: None,"},{"line_number":45,"context_line":"    \u0027ppc64le\u0027: None"},{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"INSTALL_TYPE_CHOICES \u003d [\u0027binary\u0027, \u0027source\u0027, \u0027rdo\u0027, \u0027rhos\u0027]"}],"source_content_type":"text/x-python","patch_set":46,"id":"3f044301_e869718b","line":45,"updated":"2017-05-04 11:28:23.000000000","message":"missing comma","commit_id":"df2d1125d31f0dae22d8bef332d7805a136fb9db"}],"kolla/image/build.py":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"acf7101945a257d93d470a2a4b121e0745306669","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                else:"},{"line_number":623,"context_line":"                    # Copy .repo file from filesystem"},{"line_number":624,"context_line":"                    cmd \u003d \"COPY {} /etc/yum.repos.d/\".format(config)"},{"line_number":625,"context_line":"            elif config \u003d\u003d \u0027None\u0027:"},{"line_number":626,"context_line":"                cmd \u003d \u0027\u0027"},{"line_number":627,"context_line":"            else:"},{"line_number":628,"context_line":"                raise exception.KollaRpmSetupUnknownConfig("}],"source_content_type":"text/x-python","patch_set":48,"id":"3f044301_e11a3cca","line":625,"range":{"start_line":625,"start_character":28,"end_line":625,"end_character":33},"updated":"2017-05-10 10:35:13.000000000","message":"Is this meant to be a string?","commit_id":"3835fdb42425c31eadf1e22fc9f49eb2e726fc0c"}],"releasenotes/notes/ubuntu-sources.list-change-65bb0f936b0ec95b.yaml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"acf7101945a257d93d470a2a4b121e0745306669","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Ubuntu sources.list got split into two files: \"sources.list.ubuntu\" and"},{"line_number":5,"context_line":"    \"sources.list.ubuntu.ARCHNAME\" (where ARCHNAME is \"x86_64\", \"aarch64\" or"},{"line_number":6,"context_line":"    \"ppc64le\") due to non-x86 support changes."}],"source_content_type":"text/x-yaml","patch_set":48,"id":"3f044301_411fb0b6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":75},"updated":"2017-05-10 10:35:13.000000000","message":"We should either remove sources.list.ubuntu or use that for the default x86_64 and then have two more for the other architectures","commit_id":"3835fdb42425c31eadf1e22fc9f49eb2e726fc0c"}]}