)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"1b001adca391c800b4c58f9ffbe5b86ef6ed0acf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In old implementation, version-check always get the latest versions"},{"line_number":10,"context_line":"rather than latest versions for certain release. it is useless for"},{"line_number":11,"context_line":"stable brtanch. And it also parse from tarballs.openstack.org site,"},{"line_number":12,"context_line":"which is very slow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this new implementation, version-check gets latest versions from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ffe62b97_6927b666","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":14},"updated":"2017-03-24 00:16:51.000000000","message":"typo\ns/brtanch/branch","commit_id":"1cc9ff35065ef0e4c3f9f0e10a39e00c388deb63"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"1b001adca391c800b4c58f9ffbe5b86ef6ed0acf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"stable brtanch. And it also parse from tarballs.openstack.org site,"},{"line_number":12,"context_line":"which is very slow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this new implementation, version-check gets latest versions from"},{"line_number":15,"context_line":"openstack/releases repo, which is faster and get also the latest"},{"line_number":16,"context_line":"versions for certain openstack release."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1554337"},{"line_number":19,"context_line":"Change-Id: Ie8951625817d82f38cf820cf9bd44ae447e2eb75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ffe62b97_09694a24","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":39},"updated":"2017-03-24 00:16:51.000000000","message":"what about keeping latest release version as well as latest version from openstack release. Supose if any operator wants to find the latest version of kolla rather than version of the latest version from openstack release, then i think it would be better to keep old one too and add the new implementation as enhancement.\n\n\nPlease correct if I am on wrong track. Thanks !!","commit_id":"1cc9ff35065ef0e4c3f9f0e10a39e00c388deb63"}],"tools/version-check.py":[{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"d61d09a05b2e0e4726ee3f5eb40a5dc06f4ab199","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def get_default_branch():"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    with open(os.path.join(PROJECT_ROOT, \u0027.gitreview\u0027), \u0027r\u0027) as gitreview:"},{"line_number":61,"context_line":"        for line in gitreview:"},{"line_number":62,"context_line":"            branches \u003d RE_DEFAULT_BRANCH.findall(line)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_59465824","line":59,"updated":"2017-02-20 08:05:05.000000000","message":"remove blank line","commit_id":"2f7ba5458c7ff8ae730d5f38081dfcd62f8a2f92"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"0ab364a31727654fd8315cbce6915b5acb237f9e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"RELEASE_REPO \u003d \u0027https://github.com/openstack/releases\u0027"},{"line_number":33,"context_line":"TARGET \u003d \u0027/tmp/releases\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"SKIP_PRJECTS \u003d {"},{"line_number":36,"context_line":"    \u0027rally\u0027: \u0027Rally is not managed by openstack/releases project\u0027,"},{"line_number":37,"context_line":"    \u0027nova-novncproxy\u0027: (\u0027nova-novncproxy is not managed by\u0027"},{"line_number":38,"context_line":"                        \u0027 openstack/releases project\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_53463924","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":12},"updated":"2017-03-15 03:37:09.000000000","message":"I think. We can update the variable name to SKIP_PROJECTS. SKIP_PRJECTS seems little bit weird.","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7922cb693f596364fdf702dae847581faf743a03","unresolved":false,"context_lines":[{"line_number":32,"context_line":"RELEASE_REPO \u003d \u0027https://github.com/openstack/releases\u0027"},{"line_number":33,"context_line":"TARGET \u003d \u0027/tmp/releases\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"SKIP_PRJECTS \u003d {"},{"line_number":36,"context_line":"    \u0027rally\u0027: \u0027Rally is not managed by openstack/releases project\u0027,"},{"line_number":37,"context_line":"    \u0027nova-novncproxy\u0027: (\u0027nova-novncproxy is not managed by\u0027"},{"line_number":38,"context_line":"                        \u0027 openstack/releases project\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a1ced50_433fb086","line":35,"updated":"2017-03-22 07:19:37.000000000","message":"yes, this is a typo actually.","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"0ab364a31727654fd8315cbce6915b5acb237f9e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"SKIP_PRJECTS \u003d {"},{"line_number":36,"context_line":"    \u0027rally\u0027: \u0027Rally is not managed by openstack/releases project\u0027,"},{"line_number":37,"context_line":"    \u0027nova-novncproxy\u0027: (\u0027nova-novncproxy is not managed by\u0027"},{"line_number":38,"context_line":"                        \u0027 openstack/releases project\u0027),"},{"line_number":39,"context_line":"    \u0027nova-spicehtml5proxy\u0027: (\u0027nova-spicehtml5proxy is not managed\u0027"},{"line_number":40,"context_line":"                             \u0027 by openstack/releases project\u0027),"},{"line_number":41,"context_line":"    \u0027openstack-base\u0027: \u0027There is no tag for requirements project\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_f1047dc7","line":38,"range":{"start_line":37,"start_character":4,"end_line":38,"end_character":55},"updated":"2017-03-15 03:37:09.000000000","message":"Why this has been addeed. Is this not part of openstack/release ?\n https://github.com/openstack/nova/blob/master/nova/cmd/novncproxy.py","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7922cb693f596364fdf702dae847581faf743a03","unresolved":false,"context_lines":[{"line_number":35,"context_line":"SKIP_PRJECTS \u003d {"},{"line_number":36,"context_line":"    \u0027rally\u0027: \u0027Rally is not managed by openstack/releases project\u0027,"},{"line_number":37,"context_line":"    \u0027nova-novncproxy\u0027: (\u0027nova-novncproxy is not managed by\u0027"},{"line_number":38,"context_line":"                        \u0027 openstack/releases project\u0027),"},{"line_number":39,"context_line":"    \u0027nova-spicehtml5proxy\u0027: (\u0027nova-spicehtml5proxy is not managed\u0027"},{"line_number":40,"context_line":"                             \u0027 by openstack/releases project\u0027),"},{"line_number":41,"context_line":"    \u0027openstack-base\u0027: \u0027There is no tag for requirements project\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a1ced50_6344ac1a","line":38,"updated":"2017-03-22 07:19:37.000000000","message":"this is a historical issue. \nin newton and mitaka branch, there are nova-novncproxy in config.py.\nbut since ocata, it is not managed by config.py and comes from linux distro repo.","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"0ab364a31727654fd8315cbce6915b5acb237f9e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027rally\u0027: \u0027Rally is not managed by openstack/releases project\u0027,"},{"line_number":37,"context_line":"    \u0027nova-novncproxy\u0027: (\u0027nova-novncproxy is not managed by\u0027"},{"line_number":38,"context_line":"                        \u0027 openstack/releases project\u0027),"},{"line_number":39,"context_line":"    \u0027nova-spicehtml5proxy\u0027: (\u0027nova-spicehtml5proxy is not managed\u0027"},{"line_number":40,"context_line":"                             \u0027 by openstack/releases project\u0027),"},{"line_number":41,"context_line":"    \u0027openstack-base\u0027: \u0027There is no tag for requirements project\u0027,"},{"line_number":42,"context_line":"    \u0027tempest\u0027: \u0027tempest is not managed by openstack/releases project\u0027"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_b11a0516","line":40,"range":{"start_line":39,"start_character":4,"end_line":40,"end_character":63},"updated":"2017-03-15 03:37:09.000000000","message":"ditto.\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/cmd/spicehtml5proxy.py\n\nAlso follow the below path where these services gets start.\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/console/websocketproxy.py\n\nSo I think these are part of openstack/release, Please check.","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7922cb693f596364fdf702dae847581faf743a03","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \u0027nova-novncproxy\u0027: (\u0027nova-novncproxy is not managed by\u0027"},{"line_number":38,"context_line":"                        \u0027 openstack/releases project\u0027),"},{"line_number":39,"context_line":"    \u0027nova-spicehtml5proxy\u0027: (\u0027nova-spicehtml5proxy is not managed\u0027"},{"line_number":40,"context_line":"                             \u0027 by openstack/releases project\u0027),"},{"line_number":41,"context_line":"    \u0027openstack-base\u0027: \u0027There is no tag for requirements project\u0027,"},{"line_number":42,"context_line":"    \u0027tempest\u0027: \u0027tempest is not managed by openstack/releases project\u0027"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a1ced50_834d2840","line":40,"updated":"2017-03-22 07:19:37.000000000","message":"nova-spicehtml5proxy is a nova command.\n\nbut what we want here is novnc and spicehtml5 package.","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"0ab364a31727654fd8315cbce6915b5acb237f9e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    for key in sorted(config.SOURCES):"},{"line_number":123,"context_line":"        independent_project \u003d False"},{"line_number":124,"context_line":"        value \u003d config.SOURCES[key]"},{"line_number":125,"context_line":"        if key in SKIP_PRJECTS:"},{"line_number":126,"context_line":"            LOG.info(\u0027%s is skiped: %s\u0027, key, SKIP_PRJECTS[key])"},{"line_number":127,"context_line":"            continue"},{"line_number":128,"context_line":"        # get project name from location"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_936fd191","line":125,"range":{"start_line":125,"start_character":18,"end_line":125,"end_character":30},"updated":"2017-03-15 03:37:09.000000000","message":"ditto line no. 35","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"0ab364a31727654fd8315cbce6915b5acb237f9e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        independent_project \u003d False"},{"line_number":124,"context_line":"        value \u003d config.SOURCES[key]"},{"line_number":125,"context_line":"        if key in SKIP_PRJECTS:"},{"line_number":126,"context_line":"            LOG.info(\u0027%s is skiped: %s\u0027, key, SKIP_PRJECTS[key])"},{"line_number":127,"context_line":"            continue"},{"line_number":128,"context_line":"        # get project name from location"},{"line_number":129,"context_line":"        location \u003d value[\u0027location\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_d369498d","line":126,"range":{"start_line":126,"start_character":46,"end_line":126,"end_character":58},"updated":"2017-03-15 03:37:09.000000000","message":"ditto line no. 35","commit_id":"9628878571fa00f8c15e244d7e72b31668cd564a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67740915071f08e85f81c437f6408dd7f51fa6d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# NOTE(SamYaple): Update the search path to prefer PROJECT_ROOT as the source"},{"line_number":28,"context_line":"#                 of packages to import if we are using local tools instead of"},{"line_number":29,"context_line":"#                 pip installed kolla tools"},{"line_number":30,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("},{"line_number":31,"context_line":"    os.path.dirname(os.path.realpath(__file__)), \u0027..\u0027))"},{"line_number":32,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":33,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from kolla.common import config as common_config"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_599f1450","side":"PARENT","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":36},"updated":"2017-05-15 09:31:36.000000000","message":"cannot test without this under GIT_REPO/tools/\n\n[egonzalez90@controller tools]$ python version-check.py \nTraceback (most recent call last):\n  File \"version-check.py\", line 24, in \u003cmodule\u003e\n    from kolla.common import config","commit_id":"eaec95b14e21ad51f32097f00b10f3092dff4e09"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67740915071f08e85f81c437f6408dd7f51fa6d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from kolla.common import config"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"logging.basicConfig(level\u003dlogging.INFO)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_b9ff3866","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":31},"updated":"2017-05-15 09:31:36.000000000","message":"kolla.common should be imported after PROJECT_ROOT path is defined to make it work under local path instead of PYTHON_PATH","commit_id":"1facac7aca021652a1388a9aba2ce985517165c3"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67740915071f08e85f81c437f6408dd7f51fa6d1","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def get_default_branch():"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    with open(os.path.join(PROJECT_ROOT, \u0027.gitreview\u0027), \u0027r\u0027) as gitreview:"},{"line_number":61,"context_line":"        for line in gitreview:"},{"line_number":62,"context_line":"            branches \u003d RE_DEFAULT_BRANCH.findall(line)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_16ff1bab","line":59,"updated":"2017-05-15 09:31:36.000000000","message":"to maintain consistency with other functions, please remove this empty line","commit_id":"1facac7aca021652a1388a9aba2ce985517165c3"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"c58a49160bd08e343934e1913a2698532f407c49","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def get_default_branch():"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    with open(os.path.join(PROJECT_ROOT, \u0027.gitreview\u0027), \u0027r\u0027) as gitreview:"},{"line_number":61,"context_line":"        for line in gitreview:"},{"line_number":62,"context_line":"            branches \u003d RE_DEFAULT_BRANCH.findall(line)"},{"line_number":63,"context_line":"            if branches:"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f013ff3_6eb8bb29","line":60,"updated":"2017-05-15 16:17:32.000000000","message":"did you test it if you don\u0027t run kolla from git? I think if you do just pip install kolla it might not have .gitreview","commit_id":"1facac7aca021652a1388a9aba2ce985517165c3"}]}