)]}'
{"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f27ebe7a761b23268fe6f42334f660efedaea47b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027pyudev\u0027,"},{"line_number":54,"context_line":"    \u0027shade\u003d\u003d1.5.0\u0027"},{"line_number":55,"context_line":"] %}"},{"line_number":56,"context_line":"{{ macros.install_pip(kolla_toolbox_base_packages | customizable(\"pip_packages\"), use_requirements\u003dFalse) }}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"RUN mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":59,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal\u0027 \u003e /etc/ansible/hosts \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa31d9ce_62028571","line":56,"updated":"2017-02-16 17:19:01.000000000","message":"then how to install other python package? w/ or w/o user_requirments?\n\nos-client-config exist in requirments. with version 1.26. should we use requirements to install it?","commit_id":"a9fc548dcad19e8c4f6cfe83e5c89f77ac668d96"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"90d7a51a993f7df3a9eea7b440192d5e4b9411d6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027pyudev\u0027,"},{"line_number":54,"context_line":"    \u0027shade\u003d\u003d1.5.0\u0027"},{"line_number":55,"context_line":"] %}"},{"line_number":56,"context_line":"{{ macros.install_pip(kolla_toolbox_base_packages | customizable(\"pip_packages\"), use_requirements\u003dFalse) }}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"RUN mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":59,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal\u0027 \u003e /etc/ansible/hosts \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa31d9ce_0249c98e","line":56,"in_reply_to":"fa31d9ce_62028571","updated":"2017-02-16 17:23:37.000000000","message":"Other packages can be installed using the macro as normal, as the venv exists now in both source/binary. I use requirements\u003dFalse here to preserve the pins for ansible etc.\n\nI will see if we can move os-client-config and maybe one or two others into a requirements controlled block.","commit_id":"a9fc548dcad19e8c4f6cfe83e5c89f77ac668d96"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4fa119cd8d5c336c244800143908970be55537ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# NOTE(pbourke): enable the virtualenv regardless of source/binary so ansible"},{"line_number":11,"context_line":"# can be used consistently from the playbooks"},{"line_number":12,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"    {% set kolla_toolbox_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_999e5eb7","line":12,"updated":"2017-02-24 15:39:35.000000000","message":"in this way, we do not need full path in kolla-ansible.","commit_id":"110179f78d762c1f16504f557f33566d0a88c68d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"eb28a6325bfe9a562fd35cd926b3448241c3ffe5","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# NOTE(pbourke): enable the virtualenv regardless of source/binary so ansible"},{"line_number":11,"context_line":"# can be used consistently from the playbooks"},{"line_number":12,"context_line":"ENV PATH /var/lib/kolla/venv/bin:$PATH"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":15,"context_line":"    {% set kolla_toolbox_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_f4b84177","line":12,"in_reply_to":"da36d5c6_999e5eb7","updated":"2017-02-24 16:16:09.000000000","message":"Currently they\u0027re hard coded to /usr/bin so they need to be updated. The question is whether we keep the full path or just go with \u0027ansible\u0027. From a security standpoint the full path tends to be preferred I think.","commit_id":"110179f78d762c1f16504f557f33566d0a88c68d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c508d3e8ea1c08254fc29f4e7b98e5a39e54dc42","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":52,"context_line":"        \u0027os-client-config\u003d\u003d1.16.0\u0027,"},{"line_number":53,"context_line":"        \u0027pyudev\u0027,"},{"line_number":54,"context_line":"        \u0027shade\u003d\u003d1.5.0\u0027"},{"line_number":55,"context_line":"    ] %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_5e812c8e","line":54,"updated":"2017-02-24 15:32:02.000000000","message":"we need upper-constraint.txt file to restrict the os-client-config, mysql-python, shade and pytz version.\n\nsince upper-constraint.txt file do not exist in binary case, we may need download it manually.","commit_id":"110179f78d762c1f16504f557f33566d0a88c68d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"eb28a6325bfe9a562fd35cd926b3448241c3ffe5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027MySQL-python\u0027,"},{"line_number":52,"context_line":"        \u0027os-client-config\u003d\u003d1.16.0\u0027,"},{"line_number":53,"context_line":"        \u0027pyudev\u0027,"},{"line_number":54,"context_line":"        \u0027shade\u003d\u003d1.5.0\u0027"},{"line_number":55,"context_line":"    ] %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_1429559e","line":54,"in_reply_to":"da36d5c6_5e812c8e","updated":"2017-02-24 16:16:09.000000000","message":"As discussed I can\u0027t think of a clean way to do this right now. Hopefully we can improve it in the future.","commit_id":"110179f78d762c1f16504f557f33566d0a88c68d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4fa119cd8d5c336c244800143908970be55537ae","unresolved":false,"context_lines":[{"line_number":57,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":60,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":61,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 \\"},{"line_number":62,"context_line":"        /var/lib/kolla/venv/lib/python2.7/site-packages/os_client_config/defaults.json"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_79e28a30","line":60,"updated":"2017-02-24 15:39:35.000000000","message":"ah, please use \n\necho \u0027localhost ansible_connection\u003dlocal ansible_python_intepreter\u003d/var/lib/kolla/venv/bin/python \u003e /etc/ansible/hosts\n\n\nin this way, we can change nothing in kolla-ansible.","commit_id":"110179f78d762c1f16504f557f33566d0a88c68d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"eb28a6325bfe9a562fd35cd926b3448241c3ffe5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints \u003d false) }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":60,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":61,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 \\"},{"line_number":62,"context_line":"        /var/lib/kolla/venv/lib/python2.7/site-packages/os_client_config/defaults.json"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_af7af085","line":60,"in_reply_to":"da36d5c6_79e28a30","updated":"2017-02-24 16:16:09.000000000","message":"We have to remove the references to /usr/bin/ansible in kolla-ansible but I can make this change anyway.","commit_id":"110179f78d762c1f16504f557f33566d0a88c68d"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"cf4c946d48d4c3803798a1f61e2a5402f733b953","unresolved":false,"context_lines":[{"line_number":14,"context_line":"{% set kolla_toolbox_packages \u003d ["},{"line_number":15,"context_line":"    \u0027crudini\u0027,"},{"line_number":16,"context_line":"    \u0027gdisk\u0027,"},{"line_number":17,"context_line":"    \u0027jq\u0027,"},{"line_number":18,"context_line":"] %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{ macros.install_packages(kolla_toolbox_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a30ddce_a882f7c5","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":9},"updated":"2017-03-10 16:59:48.000000000","message":"remove this comma please if you push next patch","commit_id":"5bdcd7be998f463482bd3d7c7c18e53cabaa574d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"17e8f44c32fcfde9a477b75fafad8d67c5b9faa8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0027crudini\u0027,"},{"line_number":16,"context_line":"    \u0027gdisk\u0027,"},{"line_number":17,"context_line":"    \u0027jq\u0027,"},{"line_number":18,"context_line":"] %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{ macros.install_packages(kolla_toolbox_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba2be162_55c02450","line":18,"updated":"2017-03-04 04:13:12.000000000","message":"add intent if you push next patch.","commit_id":"5bdcd7be998f463482bd3d7c7c18e53cabaa574d"}]}