)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"9d90d29a8a87716a63a11a8e38977546b434f360","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-02-22 11:46:23 +0100"},{"line_number":4,"context_line":"Commit:     Javier Castillo Alcíbar \u003cjavier.castillo.alcibar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-22 11:50:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sahara needs to run ssh-keygen in order to generate keypair and"},{"line_number":8,"context_line":"access to cluster instances. We need sahara-base container to"},{"line_number":9,"context_line":"include this binary, even when we deploy based on source type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_1bef21b1","line":6,"updated":"2017-02-22 12:27:49.000000000","message":"Please add a title separated from commit description.","commit_id":"3907a3e08d530d76604e4c58dce0456f42c24529"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"a08ce7d59205f62fe6f95a3b5ed5e77ea4755b4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Javier Castillo Alcíbar \u003cjavier.castillo.alcibar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-22 15:48:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sahara needs to run ssh-keygen in order to generate keypair and"},{"line_number":8,"context_line":"access to cluster instances. We need sahara-base container to"},{"line_number":9,"context_line":"include this binary, even when we deploy based on source type."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_f51b3619","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":59},"updated":"2017-02-22 14:59:33.000000000","message":"the title shoud not too long, keep it brief word","commit_id":"719d3fa4bbbd73cc918b345ad30706fc10f41a5f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"6dd9f05702fbe5fa3e422246acfeeb9c9d312f97","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Javier Castillo Alcíbar \u003cjavier.castillo.alcibar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-22 15:48:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sahara needs to run ssh-keygen in order to generate keypair and"},{"line_number":8,"context_line":"access to cluster instances. We need sahara-base container to"},{"line_number":9,"context_line":"include this binary, even when we deploy based on source type."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_50d41046","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":59},"in_reply_to":"da36d5c6_f51b3619","updated":"2017-02-22 15:11:42.000000000","message":"per openstack doc, there is one empty line between title and content. \n\nhttps://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"719d3fa4bbbd73cc918b345ad30706fc10f41a5f"}],"docker/sahara/sahara-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"9d90d29a8a87716a63a11a8e38977546b434f360","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"RUN yum -y install openssh"},{"line_number":23,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"RUN apt-get -y install openssh-client"},{"line_number":25,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da36d5c6_7be81db5","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":18},"updated":"2017-02-22 12:27:49.000000000","message":"Please, use macros.install to install packages in docker images.","commit_id":"3907a3e08d530d76604e4c58dce0456f42c24529"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"9d90d29a8a87716a63a11a8e38977546b434f360","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"RUN yum -y install openssh"},{"line_number":23,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"RUN apt-get -y install openssh-client"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ADD sahara-base-archive /sahara-base-source"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da36d5c6_bbd295fe","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":37},"updated":"2017-02-22 12:27:49.000000000","message":"ditto","commit_id":"3907a3e08d530d76604e4c58dce0456f42c24529"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"63d12a7bec1b5de420fdd6e0629d8a6730233a11","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"    {% set sahara_base_aux_packages \u003d [\u0027openssh\u0027] %}"},{"line_number":23,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"    {% set sahara_base_aux_packages \u003d [\u0027openssh-client\u0027] %}"},{"line_number":25,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"da36d5c6_50641048","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":26},"updated":"2017-02-22 15:18:17.000000000","message":"Just use sahara_base_packages to maintain consistency, this is only applied to source installs and not need another custom name.","commit_id":"3655f2e9146b48121d8d5e8a5c5fb381b85ae2d6"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"162db6ce1018a257173fb5ab473df84b75ba2f58","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"    {% set sahara_base_packages \u003d [\u0027openssh\u0027] %}"},{"line_number":23,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"    {% set sahara_base_packages \u003d [\u0027openssh-client\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a30ddce_4328b986","line":21,"range":{"start_line":21,"start_character":32,"end_line":21,"end_character":40},"updated":"2017-03-09 15:20:35.000000000","message":"fedora support is deprecated and no longer maintained","commit_id":"15d61e6a80dd7adfe88bf50d78435e649f1e2185"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f0f7892ab79e69876e7c41019cb446f1a1773c44","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"    {% set sahara_base_packages \u003d [\u0027openssh\u0027] %}"},{"line_number":23,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"    {% set sahara_base_packages \u003d [\u0027openssh-client\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a30ddce_2870e3db","line":21,"updated":"2017-03-10 05:01:12.000000000","message":"remove fedora","commit_id":"15d61e6a80dd7adfe88bf50d78435e649f1e2185"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"6891bab2e79ea58f951676c5a810c646c454ab1b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":22,"context_line":"    {% set sahara_base_packages \u003d [\u0027openssh\u0027] %}"},{"line_number":23,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"    {% set sahara_base_packages \u003d [\u0027openssh-client\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a30ddce_b94b4b86","line":21,"range":{"start_line":21,"start_character":32,"end_line":21,"end_character":40},"in_reply_to":"9a30ddce_4328b986","updated":"2017-03-10 01:26:36.000000000","message":"agree","commit_id":"15d61e6a80dd7adfe88bf50d78435e649f1e2185"}]}
