)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"417ee00daffd2bfc95cc78710273e453534bd894","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I8ecd0b658b8df8f38ddf717fa9443d4dc2896984"},{"line_number":28,"context_line":"Closes-Bug: #1624457"},{"line_number":29,"context_line":"(cherry picked from commit 5752c7eb0b1f9c5978dd4e9271ded346cea231e0)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba2be162_a85adeef","line":29,"updated":"2017-03-05 14:51:41.000000000","message":"Reference:\nhttps://docs.openstack.org/project-team-guide/stable-branches.html\n  \"Please keep Conflicts lines in the commit message to help reviewers!\"\n\nOpenStack typically leaves the conflict information in place to help others in the future detect backports that were done incorrectly.  The backport test I ran for sbezverk has this in the commit message when done manually at the end:\n\n    Conflicts:\n        docker/ironic/ironic-inspector/Dockerfile.j2","commit_id":"31681a8227a8330a18af5cdcc66abc7530f9b7ba"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e12f2ee3a36736888c976379beda8e9d51c8e12d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I8ecd0b658b8df8f38ddf717fa9443d4dc2896984"},{"line_number":28,"context_line":"Closes-Bug: #1624457"},{"line_number":29,"context_line":"(cherry picked from commit 5752c7eb0b1f9c5978dd4e9271ded346cea231e0)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba2be162_688e262f","line":29,"in_reply_to":"ba2be162_a85adeef","updated":"2017-03-05 15:12:25.000000000","message":"That\u0027s odd, it applies cleanly for me. Perhaps that\u0027s because this review is dependent upon https://review.openstack.org/#/c/439913, so that the history lines up correctly?\n\ngit cherry-pick 5752c7eb0b1f9c5978dd4e9271ded346cea231e0\n[stable/newton 9dddef3] Fix binary ironic-inspector rootwrap configuration\n 3 files changed, 5 insertions(+), 1 deletion(-)\n create mode 100644 docker/ironic/ironic-inspector/ironic_sudoers_binary\n rename docker/ironic/ironic-inspector/{ironic_sudoers \u003d\u003e ironic_sudoers_source} (100%)","commit_id":"31681a8227a8330a18af5cdcc66abc7530f9b7ba"}],"docker/ironic/ironic-inspector/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd71de3472f5e56853c8def22b84a85e9e0e3f96","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ironic_extend_start"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":44,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_ironic_inspector_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ba2be162_bc770e39","line":41,"updated":"2017-03-01 23:12:20.000000000","message":"Looks like extend_start.sh didn\u0027t exist in Newton. It was added as part of this commit: https://github.com/openstack/kolla/commit/040ff6ea037357a84a6450c944648b83eb833454.\n\nI don\u0027t know whether that commit will work for Newton.","commit_id":"97fd14ac41c9519ce6330c5b6755883e0e0e0d51"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"417ee00daffd2bfc95cc78710273e453534bd894","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"COPY ironic_sudoers /etc/sudoers.d/kolla_ironic_inspector_sudoers"},{"line_number":38,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ironic_extend_start"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba2be162_a811fe05","side":"PARENT","line":37,"updated":"2017-03-05 14:51:41.000000000","message":"lgtm","commit_id":"608769bf99ef60be18c1dc9f6fd04578c9bcdf51"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"417ee00daffd2bfc95cc78710273e453534bd894","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"COPY ironic_sudoers_binary /etc/sudoers.d/kolla_ironic_inspector_sudoers"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":23,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":24,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027iptables\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba2be162_2867ceb7","line":21,"updated":"2017-03-05 14:51:41.000000000","message":"lgtm","commit_id":"31681a8227a8330a18af5cdcc66abc7530f9b7ba"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"417ee00daffd2bfc95cc78710273e453534bd894","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/ironic-inspector/rootwrap.conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"COPY ironic_sudoers_source /etc/sudoers.d/kolla_ironic_inspector_sudoers"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ironic_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba2be162_480882da","line":38,"updated":"2017-03-05 14:51:41.000000000","message":"lgtm","commit_id":"31681a8227a8330a18af5cdcc66abc7530f9b7ba"}],"docker/ironic/ironic-inspector/ironic_sudoers_binary":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"417ee00daffd2bfc95cc78710273e453534bd894","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ironic ALL\u003d(root) NOPASSWD: /usr/bin/ironic-inspector-rootwrap /etc/ironic-inspector/rootwrap.conf *"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba2be162_0803eab8","line":1,"updated":"2017-03-05 14:51:41.000000000","message":"lgtm","commit_id":"31681a8227a8330a18af5cdcc66abc7530f9b7ba"}],"docker/ironic/ironic-inspector/ironic_sudoers_source":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"417ee00daffd2bfc95cc78710273e453534bd894","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ironic ALL\u003d(root) NOPASSWD: /var/lib/kolla/venv/bin/ironic-inspector-rootwrap /etc/ironic-inspector/rootwrap.conf *"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba2be162_482fa23e","line":1,"updated":"2017-03-05 14:51:41.000000000","message":"lgtm","commit_id":"31681a8227a8330a18af5cdcc66abc7530f9b7ba"}]}