)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c184affe87e0bb1a6f4297df3ea87ac5b27c0444","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add neutron-bgp-dragent service."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint neutron-bgp-dragent"},{"line_number":10,"context_line":"Added neutron-bgp-dragent Dockerfile."},{"line_number":11,"context_line":"Updated kolla/common/config.py with necessary sources."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_f4d081f8","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":41},"updated":"2017-03-09 16:19:08.000000000","message":"Nit, usually Implements go after commit description with an empty line between","commit_id":"edba7b99130a380ae4299930c4042847919bdd1c"}],"docker/neutron/neutron-bgp-dragent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c184affe87e0bb1a6f4297df3ea87ac5b27c0444","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":"        {% set neutron_bgp_dragent_packages \u003d ["},{"line_number":12,"context_line":"            \u0027neutron-bgp-dragent\u0027"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% elif base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027]  %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9a30ddce_54606da5","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":12},"updated":"2017-03-09 16:19:08.000000000","message":"Just really a nit, almost all dockerfiles start first declaring rpm based distros and then declare deb distros.\nIs nothing important by i would like maintain style consistency between dockerfiles.","commit_id":"edba7b99130a380ae4299930c4042847919bdd1c"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"33aa2d719b8fc48aadb71d00738e0625a323c6b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027]  %}"},{"line_number":11,"context_line":"        RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":14,"context_line":"        {% set neutron_bgp_dragent_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a30ddce_81a52548","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":8},"updated":"2017-03-10 09:41:13.000000000","message":"RUNs are not indented.","commit_id":"d1c393d2da28bf07f161a76b0c5099c6dd0c5481"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bb703797950cfe004d064e411aeffc0c64c130a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"        {% set neutron_bgp_dragent_packages \u003d ["},{"line_number":13,"context_line":"            \u0027neutron-dynamic-routing\u0027"},{"line_number":14,"context_line":"        ] %}"},{"line_number":15,"context_line":"    {% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a30ddce_9ac3c388","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":37},"updated":"2017-03-10 12:46:23.000000000","message":"seems there is not binary for ubuntu too\nhttp://logs.openstack.org/32/443732/7/check/gate-kolla-dsvm-build-ubuntu-binary-ubuntu-xenial-nv/833173a/console.html#_2017-03-10_10_41_06_414555","commit_id":"622594d3c4f4c4c3d1123421b8de89ce33f1672f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4410f20973f2246e08de8c84b3119c372d4c5ca7","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027]  %}"},{"line_number":10,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"        {% set neutron_bgp_dragent_packages \u003d ["},{"line_number":13,"context_line":"            \u0027neutron-bgp-dragent\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9a30ddce_d52ec0a3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":69},"updated":"2017-03-13 09:06:04.000000000","message":"hrm, missing /bin/false at the end.\n\nRUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\\n    \u0026\u0026 /bin/false","commit_id":"96c1b6959233da4a8117c1a205f24c8ad9d01471"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"a80418b00564dc0517a74901304367f90ef4fc81","unresolved":false,"context_lines":[{"line_number":22,"context_line":"ADD neutron-bgp-dragent-archive /neutron-bgp-dragent-source"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% set neutron_bgp_dragent_pip_packages \u003d ["},{"line_number":25,"context_line":"        \u0027/neutron_dynamic_routing\u0027"},{"line_number":26,"context_line":"    ] %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"RUN ln -s neutron-bgp-dragent-source/* neutron_dynamic_routing \\"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5a22e58a_7abb1d0f","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":33},"updated":"2017-03-14 09:11:45.000000000","message":"i think \u0027neutron-bgp-dragent\u0027 to better","commit_id":"3c565264c48ebeb11189153ab88c03cf742cfa6d"}],"docker/neutron/neutron-bgp-dragent/neutron_sudoers":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"000ba5a08d4119fa7a958ff5162e867114489d23","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown neutron\\: /var/lib/neutron/kolla, /usr/bin/chown neutron\\: /var/lib/neutron/kolla"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5a22e58a_54f2ba9b","line":1,"updated":"2017-03-14 08:25:30.000000000","message":"this file is used in neutron-metata-agent. Seem bgp-dragent does not depend on this.","commit_id":"48f36011463bf839ffc717051d42a6896cac454a"}],"kolla/common/config.py":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"8664b4b103e9109516391d7a184cecb43f9e19b8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                     \u0027neutron-vpnaas-master.tar.gz\u0027)},"},{"line_number":470,"context_line":"    \u0027neutron-bgp-dragent\u0027: {"},{"line_number":471,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":472,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-dynamic-routing/\u0027"},{"line_number":473,"context_line":"                     \u0027neutron-dynamic-routing-master.tar.gz\u0027)},"},{"line_number":474,"context_line":"    \u0027nova-base\u0027: {"},{"line_number":475,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":476,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/nova/\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_920659cc","line":473,"range":{"start_line":472,"start_character":2,"end_line":473,"end_character":61},"updated":"2017-03-10 06:39:47.000000000","message":"seems this link is duplicate with line 457, it ok?","commit_id":"598f7572c2157b92c3855e5eb94c9f21ee02665b"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"ee1e19ba3619f1dc7bc994918d38a0d258729c89","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":468,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-vpnaas/\u0027"},{"line_number":469,"context_line":"                     \u0027neutron-vpnaas-master.tar.gz\u0027)},"},{"line_number":470,"context_line":"    \u0027neutron-bgp-dragent\u0027: {"},{"line_number":471,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":472,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-dynamic-routing/\u0027"},{"line_number":473,"context_line":"                     \u0027neutron-dynamic-routing-master.tar.gz\u0027)},"},{"line_number":474,"context_line":"    \u0027nova-base\u0027: {"},{"line_number":475,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":476,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/nova/\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a22e58a_d35dd6ed","line":473,"range":{"start_line":470,"start_character":0,"end_line":473,"end_character":63},"updated":"2017-03-14 12:22:15.000000000","message":"shift it to line no. 446 for better code readability.","commit_id":"2c5b42597f3d2a8a037da93e4c34d874a6ec9d4a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"96d13348eee5749e062f150d44841794cf65777a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":456,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-lbaas/\u0027"},{"line_number":457,"context_line":"                     \u0027neutron-lbaas-master.tar.gz\u0027)},"},{"line_number":458,"context_line":"    \u0027neutron-server-plugin-neutron-dynamic-routing\u0027: {"},{"line_number":459,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":460,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-dynamic-routing/\u0027"},{"line_number":461,"context_line":"                     \u0027neutron-dynamic-routing-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a1ff146_ee98306d","line":458,"updated":"2017-03-14 16:56:59.000000000","message":"Please, alphabetize this. dynamic routing plugin have to go just before lbaas plugin at line 454","commit_id":"de9bdc7235b96b202b733390c3d0c18309da4d8e"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"1dfc6ff36884762d61e2b4e8df7cc93690b78c3f","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":456,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-lbaas/\u0027"},{"line_number":457,"context_line":"                     \u0027neutron-lbaas-master.tar.gz\u0027)},"},{"line_number":458,"context_line":"    \u0027neutron-server-plugin-neutron-dynamic-routing\u0027: {"},{"line_number":459,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":460,"context_line":"        \u0027location\u0027: (\u0027$tarballs_base/neutron-dynamic-routing/\u0027"},{"line_number":461,"context_line":"                     \u0027neutron-dynamic-routing-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a1ff146_d0c6a215","line":458,"in_reply_to":"3a1ff146_ee98306d","updated":"2017-03-15 00:33:13.000000000","message":"@thomas_oneill agree with @egonzalez. last time I missed.","commit_id":"de9bdc7235b96b202b733390c3d0c18309da4d8e"}],"releasenotes/notes/add-neutron-bgp-dragent-c831d5ec9a130937.yaml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1caa96d32d0701f8d6650b7fb15161ed0ee25ab7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a30ddce_1c444519","updated":"2017-03-10 01:36:40.000000000","message":"you need re-write this file. like\n\nhttps://github.com/openstack/kolla/blob/master/releasenotes/notes/add-zun-dockerfile-fb604877dc9c15fe.yaml","commit_id":"598f7572c2157b92c3855e5eb94c9f21ee02665b"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"8664b4b103e9109516391d7a184cecb43f9e19b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a30ddce_72e2c530","in_reply_to":"9a30ddce_1c444519","updated":"2017-03-10 06:39:47.000000000","message":"agree , note should be brief","commit_id":"598f7572c2157b92c3855e5eb94c9f21ee02665b"}],"tests/test_build.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"bb703797950cfe004d064e411aeffc0c64c130a9","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"manila-data\","},{"line_number":153,"context_line":"        \"monasca-base\","},{"line_number":154,"context_line":"        \"neutron-sfc-agent\","},{"line_number":155,"context_line":"        \"searchlight-base\","},{"line_number":156,"context_line":"        \"senlin-base\","},{"line_number":157,"context_line":"        \"solum-base\","},{"line_number":158,"context_line":"        \"tacker\","}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_9a958388","line":155,"updated":"2017-03-10 12:46:23.000000000","message":"also here","commit_id":"622594d3c4f4c4c3d1123421b8de89ce33f1672f"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"ee1e19ba3619f1dc7bc994918d38a0d258729c89","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"manila-data\","},{"line_number":76,"context_line":"        \"monasca-base\","},{"line_number":77,"context_line":"        \"neutron-sfc-agent\","},{"line_number":78,"context_line":"        \"neutron-bgp-dragent\","},{"line_number":79,"context_line":"        \"searchlight-base\","},{"line_number":80,"context_line":"        \"senlin-base\","},{"line_number":81,"context_line":"        \"solum-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5a22e58a_53f9e6c7","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":30},"updated":"2017-03-14 12:22:15.000000000","message":"shift it to line no. 77","commit_id":"2c5b42597f3d2a8a037da93e4c34d874a6ec9d4a"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"ee1e19ba3619f1dc7bc994918d38a0d258729c89","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        \"karbor-base\","},{"line_number":114,"context_line":"        \"kuryr-base\","},{"line_number":115,"context_line":"        \"monasca-base\","},{"line_number":116,"context_line":"        \"neutron-sfc-agent\","},{"line_number":117,"context_line":"        \"octavia-base\","},{"line_number":118,"context_line":"        \"panko-base\","},{"line_number":119,"context_line":"        \"searchlight-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5a22e58a_d3b5d6d0","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":28},"updated":"2017-03-14 12:22:15.000000000","message":"I think, \"neutron-bgp-dragent\" should also be added here. i.e for ubuntu binary part too.","commit_id":"2c5b42597f3d2a8a037da93e4c34d874a6ec9d4a"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"ee1e19ba3619f1dc7bc994918d38a0d258729c89","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        \"manila-data\","},{"line_number":153,"context_line":"        \"monasca-base\","},{"line_number":154,"context_line":"        \"neutron-sfc-agent\","},{"line_number":155,"context_line":"        \"neutron-bgp-dragent\","},{"line_number":156,"context_line":"        \"searchlight-base\","},{"line_number":157,"context_line":"        \"senlin-base\","},{"line_number":158,"context_line":"        \"solum-base\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5a22e58a_931a7e16","line":155,"range":{"start_line":155,"start_character":8,"end_line":155,"end_character":30},"updated":"2017-03-14 12:22:15.000000000","message":"shift it to line no. 154.","commit_id":"2c5b42597f3d2a8a037da93e4c34d874a6ec9d4a"}]}
