)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"44eecbbd41a4d262ab38af45f33f6ae2bc3aba5b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This apache module is necessary for when one wants to use TLS for the"},{"line_number":10,"context_line":"services running over httpd."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This only addressed RHEL based systems at the moment, since there is no"},{"line_number":13,"context_line":"such package available for Ubuntu. This requires apache2.2-common which"},{"line_number":14,"context_line":"will carry a lot more dependencies; So I think this should be handled"},{"line_number":15,"context_line":"and decided in a separate patch."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"when installing mod_ssl in RHEL-based distributions, an ssl.conf file is"},{"line_number":18,"context_line":"installed in the /etc/httpd/conf.d directory. This file tells httpd to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_e065b244","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":32},"updated":"2017-03-23 11:43:50.000000000","message":"Could you please create a bug for it to track it better? \nThen, please add a line Related-Bug to the bottom of the commit message.","commit_id":"4f94c17a988d0faf57ef2529ac08f43e485bc7fb"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"44eecbbd41a4d262ab38af45f33f6ae2bc3aba5b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will carry a lot more dependencies; So I think this should be handled"},{"line_number":15,"context_line":"and decided in a separate patch."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"when installing mod_ssl in RHEL-based distributions, an ssl.conf file is"},{"line_number":18,"context_line":"installed in the /etc/httpd/conf.d directory. This file tells httpd to"},{"line_number":19,"context_line":"listen on port 443; however, we don\u0027t want to do this by default, since"},{"line_number":20,"context_line":"this should be explicitly enabled by the container\u0027s configuration. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_00348e47","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"updated":"2017-03-23 11:43:50.000000000","message":"s/when/When","commit_id":"4f94c17a988d0faf57ef2529ac08f43e485bc7fb"}],"docker/aodh/aodh-base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"09c9e541f2b9cc58bb0fd341265726f33f693f73","unresolved":false,"context_lines":[{"line_number":22,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":23,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/site-packages/aodh/api/app.wsgi /var/www/cgi-bin/aodh/ \\"},{"line_number":24,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf \\"},{"line_number":25,"context_line":"    \u0026\u0026 sed -i \u0027/Listen 443 https/d\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":26,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"       {% set aodh_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a1ced50_9e1f08b6","line":25,"updated":"2017-03-23 08:02:38.000000000","message":"If you happen to submit a new patch, can you comment out the line instead of deleting it to be more consistent with the change made to httpd.conf for port 80?","commit_id":"bbca7313f5e1563b9dfd7411894e680ce0ab0b7b"}],"docker/cinder/cinder-api/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"09c9e541f2b9cc58bb0fd341265726f33f693f73","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                \u0027mod_ssl\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":"{{ macros.install_packages(cinder_api_packages | customizable(\"packages\")) }}"},{"line_number":17,"context_line":"RUN sed -i \u0027/Listen 443 https/d\u0027 /etc/httpd/conf.d/ssl.conf"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"        {% set cinder_api_packages \u003d ["},{"line_number":20,"context_line":"                \u0027cinder-api\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a1ced50_1ee798ac","line":17,"updated":"2017-03-23 08:02:38.000000000","message":"Interesting, we don\u0027t prevent cinder-api from listening on port 80? I see this has been forgotten in recent patches to add apache to cinder-api, heat-base, ironic-pxe and nova-api.\n\nI\u0027m going to fix it.","commit_id":"bbca7313f5e1563b9dfd7411894e680ce0ab0b7b"}]}