)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"d4f7004ab5058c759da7467b2d2df990436b014a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Margin \u003cjhu_com@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-23 16:02:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix ironic-donductor failed when build with binary"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add ironic sudoer with binary and source in ironic-base"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a1ced50_9c49d033","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":20},"updated":"2017-03-23 08:21:49.000000000","message":"s/donductor/conductor/","commit_id":"5a882b4cb0d2be6b594556f1db7f6b4b6f8e7e5c"}],"docker/ironic/ironic-base/ironic_sudoers_binary":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"119c8ba1e69711c046cf8ae9547db7ec3ef5b037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ironic ALL\u003d(root) NOPASSWD: /usr/bin/ironic-rootwrap /etc/ironic/rootwrap.conf *,/usr/sbin/modprobe iscsi_tcp, /sbin/modprobe iscsi_tcp"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ffe62b97_cd527f13","line":1,"updated":"2017-03-29 12:21:31.000000000","message":"The binary file shouldn\u0027t need the rootwrap entry - this should be provided by the package\u0027s sudoer file. We just need to add iscsi_tcp. I\u0027d recommend that we break this out into a separate file that is shared between source and binary builds, containing:\n\nironic ALL\u003d(root) NOPASSWD: /usr/sbin/modprobe iscsi_tcp, /sbin/modprobe iscsi_tcp","commit_id":"5a882b4cb0d2be6b594556f1db7f6b4b6f8e7e5c"}],"docker/ironic/ironic-base/ironic_sudoers_source":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"119c8ba1e69711c046cf8ae9547db7ec3ef5b037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ironic ALL \u003d (root) NOPASSWD: /var/lib/kolla/venv/bin/ironic-rootwrap /etc/ironic/rootwrap.conf *, /usr/sbin/modprobe iscsi_tcp, /sbin/modprobe iscsi_tcp"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ffe62b97_4d954f86","line":1,"updated":"2017-03-29 12:21:31.000000000","message":"Actually, we shouldn\u0027t need the source rootwrap entry in here either - it will be provided by the ironic-conductor and ironic-api image layers.","commit_id":"5a882b4cb0d2be6b594556f1db7f6b4b6f8e7e5c"}]}