)]}'
{"docker/heat/heat-base/Dockerfile.j2":[{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"cc208f5ab0a43d378e476766e4710bb50f4c4e2f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        \u0027httpd\u0027,"},{"line_number":16,"context_line":"        \u0027mod_wsgi\u0027"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":"{{ macros.install_packages(heat_base_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":"RUN sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":20,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":21,"context_line":"    {% set heat_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1a1ced50_b7706241","line":18,"updated":"2017-03-23 10:31:46.000000000","message":"What about Ubuntu?","commit_id":"578174f4efb1fb110322628077cd188fbe8e1534"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"24fb23ede4b7b027d87f252867490a0d3e004295","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ] %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{{ macros.install_packages(heat_base_packages | customizable(\"packages\")) }}"},{"line_number":50,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":51,"context_line":"{% endif %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ADD heat-base-archive /heat-base-source"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_914d3874","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":34},"updated":"2017-03-27 01:58:03.000000000","message":"I see sometime we \"truncate -s\", sometime we \"echo \u003e\", I think we also have \"touch \", given this context, is it different?","commit_id":"93e2b94ff9119f3a3e7cb8469f09e88947c6d694"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"a27dbf219d64d394f241f8750a96c50a2c8f6eb9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ] %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{{ macros.install_packages(heat_base_packages | customizable(\"packages\")) }}"},{"line_number":50,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":51,"context_line":"{% endif %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ADD heat-base-archive /heat-base-source"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_428b431e","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":34},"in_reply_to":"ffe62b97_3213075f","updated":"2017-03-28 11:36:16.000000000","message":"@Duong: I am fully agree with you, I really prefer a new openstack-http-base image","commit_id":"93e2b94ff9119f3a3e7cb8469f09e88947c6d694"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"5372c98dc0d2fd8e32bc0afbe5de85813bd3390d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ] %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{{ macros.install_packages(heat_base_packages | customizable(\"packages\")) }}"},{"line_number":50,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":51,"context_line":"{% endif %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ADD heat-base-archive /heat-base-source"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_3213075f","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":34},"in_reply_to":"ffe62b97_4fcf04b0","updated":"2017-03-27 07:03:19.000000000","message":"Thanks for explanation, openstack-http-base wfm, but it\u0027s quite tremendous change, I\u0027m not sure how many people like this.","commit_id":"93e2b94ff9119f3a3e7cb8469f09e88947c6d694"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c8d734b750aef56f7825f0a65ce0a667c48f3179","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ] %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{{ macros.install_packages(heat_base_packages | customizable(\"packages\")) }}"},{"line_number":50,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":51,"context_line":"{% endif %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ADD heat-base-archive /heat-base-source"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ffe62b97_4fcf04b0","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":34},"in_reply_to":"ffe62b97_914d3874","updated":"2017-03-27 06:51:36.000000000","message":"\u0027truncate -s 0\u0027 and \u0027echo \u003e\u0027 are two ways of deleting the content of a file, they\u0027re equivalent.\n\n\u0027touch\u0027 is different, it either creates a file or changes the timestamp if the file already exists.\n\nI agree there is a bit a refactoring needed to normalize how we clean up the ports.conf file but this should be done in another commit. One way to do it would be to write a jinja2 macro that we would call in images with httpd. We\u0027ve also talked about a openstack-http-base image that services that can run under httpd would inherit from but this is a much more invasive change that requires more discussion.","commit_id":"93e2b94ff9119f3a3e7cb8469f09e88947c6d694"}]}