)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"859f5a4b8cc4c2fb21142eef76730881f9b22497","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":11,"context_line":"{%- endfor %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LABEL kolla_version\u003d\"{{ kolla_version }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_bd629815","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":20},"updated":"2017-03-24 03:14:54.000000000","message":"keep single space before and after for better coding style as followed in all module.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9f1cbde544225527ac585102381dcf8856d0dd08","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":11,"context_line":"{%- endfor %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LABEL kolla_version\u003d\"{{ kolla_version }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_1294b836","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":20},"in_reply_to":"ffe62b97_bad050cb","updated":"2017-03-24 14:13:51.000000000","message":"Agreed as I have explained above.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9f1cbde544225527ac585102381dcf8856d0dd08","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":11,"context_line":"{%- endfor %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LABEL kolla_version\u003d\"{{ kolla_version }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_52748035","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":20},"in_reply_to":"ffe62b97_bd629815","updated":"2017-03-24 14:13:51.000000000","message":"https://docs.docker.com/engine/reference/builder/#env\n\nIn the examples listed here, there is no spacing.  Also, I\u0027m not touching this label as part of this (and with no need to honestly).  This is trying to reduce a few layers here and there.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"78eae1523ab004e2b742e8c89602445b97206223","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {%- if not loop.last %} \\{% endif -%}"},{"line_number":11,"context_line":"{%- endfor %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LABEL kolla_version\u003d\"{{ kolla_version }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_bad050cb","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":20},"in_reply_to":"ffe62b97_bd629815","updated":"2017-03-24 09:59:01.000000000","message":"not sure if adding spaces will work as expected, i always saw ENV without spaces in multi environment declaration","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"6beeea95d8481ffa5a37d6b1af7bfaecd934ffef","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_42ba87de","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":22},"updated":"2017-03-24 02:13:04.000000000","message":"I think it is not necessary,\nif you insist, please modify this\nhttps://github.com/openstack/kolla/blob/master/docker/helm-repository/Dockerfile.j2#L5-L7","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"859f5a4b8cc4c2fb21142eef76730881f9b22497","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_5d714ce0","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":22},"updated":"2017-03-24 03:14:54.000000000","message":"ditto","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9f1cbde544225527ac585102381dcf8856d0dd08","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_d2b650da","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":22},"in_reply_to":"ffe62b97_42ba87de","updated":"2017-03-24 14:13:51.000000000","message":"I\u0027ll push a new change with those modified as well.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"859f5a4b8cc4c2fb21142eef76730881f9b22497","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#### Customize PS1 to be used with bash shell"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_1d73c4e9","line":19,"range":{"start_line":19,"start_character":22,"end_line":19,"end_character":23},"updated":"2017-03-24 03:14:54.000000000","message":"ditto","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9f1cbde544225527ac585102381dcf8856d0dd08","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% block base_header %}{% endblock %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#### Customize PS1 to be used with bash shell"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_32dd7c14","line":19,"range":{"start_line":19,"start_character":22,"end_line":19,"end_character":23},"in_reply_to":"ffe62b97_1d73c4e9","updated":"2017-03-24 14:13:51.000000000","message":"Answered above.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"859f5a4b8cc4c2fb21142eef76730881f9b22497","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#### Customize PS1 to be used with bash shell"},{"line_number":23,"context_line":"COPY kolla_bashrc /tmp/"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_dd7c3cb7","line":20,"range":{"start_line":20,"start_character":26,"end_line":20,"end_character":27},"updated":"2017-03-24 03:14:54.000000000","message":"ditto","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9f1cbde544225527ac585102381dcf8856d0dd08","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"ENV KOLLA_BASE_DISTRO\u003d{{ base_distro }} \\"},{"line_number":19,"context_line":"    KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":20,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#### Customize PS1 to be used with bash shell"},{"line_number":23,"context_line":"COPY kolla_bashrc /tmp/"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_12e278d6","line":20,"range":{"start_line":20,"start_character":26,"end_line":20,"end_character":27},"in_reply_to":"ffe62b97_dd7c3cb7","updated":"2017-03-24 14:13:51.000000000","message":"Answered above.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f8b2de4374f89dc3f925a81637e591ad914749cd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /root/.bashrc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# PS1 var when used /bin/sh shell"},{"line_number":28,"context_line":"ENV PS1\u003d\"$(tput bold)($(printenv KOLLA_SERVICE_NAME))$(tput sgr0)[$(id -un)@$(hostname -s) $(pwd)]$ \""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":31,"context_line":"# For RPM Variants, enable the correct repositories - this should all be done"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_addc9846","line":28,"updated":"2017-03-24 10:11:29.000000000","message":"You could possibly merge this one as well","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"9f1cbde544225527ac585102381dcf8856d0dd08","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /root/.bashrc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# PS1 var when used /bin/sh shell"},{"line_number":28,"context_line":"ENV PS1\u003d\"$(tput bold)($(printenv KOLLA_SERVICE_NAME))$(tput sgr0)[$(id -un)@$(hostname -s) $(pwd)]$ \""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":31,"context_line":"# For RPM Variants, enable the correct repositories - this should all be done"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffe62b97_92f6888f","line":28,"in_reply_to":"ffe62b97_addc9846","updated":"2017-03-24 14:13:51.000000000","message":"The reason I did not want to merge this was because I felt that it depended on the PS1 customization command run above, and so the order of things would end up a bit weird.\n\nI am looking to refactor that PS1 customization part later to reduce the layers, but that\u0027s work to be done in another patch.","commit_id":"34fb99cade4cfda2a78e0380b8c09b44265f3416"}]}